August 2005 - Development - lists.drupal.org

[drupal-devel] [feature] URL rewrite hook
by chx 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/29030 Post a follow up: http://drupal.org/project/comments/add/29030 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch (code needs review) Attachment: http://drupal.org/files/issues/url_rewrite.patch (1.35 KB) I need a URL rewrite hook sometimes, here is an implementation, with ample comments. I looked into arg() to see whether it needs a reset parameter, and it does not, but it contained a minor bug, which is also fixed. chx

12 55

[drupal-devel] [task] New drupal forms api.
by adrian 21 Sep '05

21 Sep '05

Issue status update for http://drupal.org/node/29465 Post a follow up: http://drupal.org/project/comments/add/29465 Project: Drupal Version: cvs Component: base system Category: tasks Priority: critical Assigned to: adrian Reported by: adrian Updated by: adrian Status: patch (code needs work) Attachment: http://drupal.org/files/issues/form.inc (20.53 KB) This is the first check in of the new forms api code. The system has been designed to co-exist with the current forms api, and is contained in a new include file (includes/form.inc). Forms are now defined in their component arrays, similar to how menu items are defined. example : <?php $form['body'] = array(type => 'textarea', default_value => $node->body, cols => 60, rows => 60); ?> Elements can also be nested, and the $edit follows this definition. For instance : <?php $form['author'] = array(type => 'fieldset', title => t('Authoring information'), collapsible => TRUE, collapsed => TRUE, weight => -1); $form['author']['name'] = array(type => 'textfield', title => t('Authored by'), maxlength => 60, autocomplete_path => 'user/autocomplete', default_value => $node->name, weight => -1); ?> All the properties used are defined as constants, and are documented for each of the elements, and individually. adrian

32 138

[drupal-devel] [feature] menu.module feature: visible in breadcrumb, but not visible in tree
by DFG 20 Sep '05

20 Sep '05

Issue status update for http://drupal.org/node/29621 Post a follow up: http://drupal.org/project/comments/add/29621 Project: Drupal Version: cvs Component: menu system Category: feature requests Priority: normal Assigned to: DFG Reported by: DFG Updated by: DFG Status: patch (code needs review) Attachment: http://drupal.org/files/issues/menu.module_0.patch (3.9 KB) I wonder that it isn't (until now) possible to add menu items, that are visible in the breadcrumb but not in the menu tree. You need this e.g. if you don't want to overbloat the menu, while have pages with subpages that have also subpages and so on. The menu system is already capable of this feature, but I am speaking about menu.module, that is missing a way to configure this. I added checkboxes, so that you have e.g. (the following is the default): [x] Visible in tree [ ] Expanded [x] Visible in breadcrumb You now have these checkboxes when editing an item in admin/menu, but also in the new menu (on-the-fly) group when adding/editing a node. I have a technical description of the changes that my patch will commit, but also many screenshots, that show what is possible and how the changes look. I start with the screenshots: (1) http://d-f-g.net/drupal/menu-module-patch/node-view.png Here you can see a very long breadcrumb, that was configured using the menu module. The menu tree on the left is expanded until the last menu item with the MENU_VISIBLE_IN_TREE flag. (2) http://d-f-g.net/drupal/menu-module-patch/phpmyadmin-menu-table.png This is the interesting part of the menu table, viewed with phpmyadmin. (3) http://d-f-g.net/drupal/menu-module-patch/node-add.png (4) http://d-f-g.net/drupal/menu-module-patch/node-edit.png (5) http://d-f-g.net/drupal/menu-module-patch/admin-menu.png (6) http://d-f-g.net/drupal/menu-module-patch/admin-menu-edit.png ------------------------------------------------------------------ Technical description, all changes in menu.module ------------------------------------------------------------------ - added 2 checkboxes in menu_edit_item_form(): - checkbox "Expanded" was already there - checkboxes: added "Visible in tree" and "Visible in breadcrumb" - used the same coding style as for "Expanded" - added handling of the 2 new checkboxes in menu_edit_item_save(): - used the same handling style as for "Expanded" - menu_overview_tree_rows(): - the t('edit') button is no longer bound to MENU_VISIBLE_IN_TREE - instead to (MENU_VISIBLE_IN_TREE | MENU_VISIBLE_IN_BREADCRUMB) - added the 3 checkboxes in menu_node_form(): - this is the menu otf section (some call it so). the checkboxes should not be missed there. - menu_parent_options() and menu_overview_tree_rows(): - t('disabled') no longer bound to !& MENU_VISIBLE_IN_TREE (see the code...) - instead to !& (MENU_VISIBLE_IN_TREE | MENU_VISIBLE_IN_BREADCRUMB) ------------------------------------------------------------------ Best regards, DFG DFG

2 3

[drupal-devel] [feature] Unique roles feature patch
by kubaZygmunt 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27958 Post a follow up: http://drupal.org/project/comments/add/27958 Project: Drupal Version: cvs Component: user.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: kubaZygmunt Updated by: kubaZygmunt Status: patch (code needs review) Attachment: http://drupal.org/files/issues/unique.roles.patch.txt (1.61 KB) I've added code which prevents user from submiting 2 roles with the same name. kubaZygmunt

4 4

[drupal-devel] [task] Enhanced upload administration
by Junyor 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/25756 Project: Drupal Version: cvs Component: upload.module Category: tasks Priority: normal Assigned to: Junyor Reported by: Junyor Updated by: Junyor Status: patch Attachment: http://drupal.org/files/issues/drupal-4-6.upload.junyor.patch (4.84 KB) I've found the need to have some administration for file attachments. Here's a demo patch of some of the proposed added functionality. This functionality should easily allow users to get a list of the files they've uploaded, so they can get rid of old files if they reach their size limit. Changes: - Added an 'administer uploaded files' permission - Added admin/uploads and 'my uploads', which list uploaded files Planned changes: - statistics for the 'my uploads' and admin/uploads pages with total size of uploaded files and size limit - functionality to delete/rename files (using checkboxes to select multiple files) Please comment on code quality, current functionality, and planned functionality. Thanks. Patch applies to 4.6 and HEAD. Junyor

9 42

[drupal-devel] [task] introduce node autofill
by Bèr Kessels 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27530 Post a follow up: http://drupal.org/project/comments/add/27530 Project: Drupal Version: cvs Component: node system Category: tasks Priority: normal Assigned to: Bèr Kessels Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/node_autocomplete.patch (1.25 KB) This patch introduces an autofill for node titles. It is not yet used anywhere, but at least we have the node/autofill url available where contribs &c can query for node titles. Bèr Kessels

5 9

[drupal-devel] [bug] hook_delete_confirm -- custom controls for modules during delete cycle
by thehunmonkgroup 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/26649 Post a follow up: http://drupal.org/project/comments/add/26649 Project: Drupal Version: 4.6.2 Component: base system Category: bug reports Priority: normal Assigned to: thehunmonkgroup Reported by: thehunmonkgroup Updated by: thehunmonkgroup Status: patch Attachment: http://drupal.org/files/issues/node_module_hook_delete_confirm.patch (547 bytes) the proposed patch creates a hook_delete_confirm, which is called from node_delete during the confirmation cycle. this hook allows modules to inject custom control structures into the deletion process, as they don't currently have this ability. this is needed, for example, in the eventrepeat.module that i'm creating, which handles repeating/recurring events for event.module. without a solution such as this, there is no way for the module to put in options for different kinds of deletions--ex. 'this occurance only', 'this and all future occurances', 'all occurances'. click here [1] for a screenshot of what this hook looks like in action... i've tested this patch and it works great, even when multiple modules are calling hook_delete_confirm. i'd also be happy to write the documentation for hook_delete_confirm if this patch gets accepted. [1] http://www.apartmentlines.com/hook_delete_confirm_screenshot.PNG thehunmonkgroup

14 40

[drupal-devel] [feature] Dependency system to solve forum without comment problem
by chx 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/18447 Project: Drupal Version: cvs Component: system.module Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/depend.patch (3.22 KB) As discussed on the developer list. This was surprisingly easy. There is still an issue: t('The configuration options have been saved.') is displayed more than once if there is a dependency forced module switch on. I have tried something (you'll see) for some reason it does not work. Number of page reloads can be decreased if Drupal could be reinitialized after system_listing_save instead of redirecting but I doubt this would be feasible. Although I marked this is feature request, this is more a usability issue (for the forum-comment dependency) and as a side effect it is a useful feature, too (for any other module "bundles"). I want criticism! I'd like to get torn apart by wild animals. Heavy! Eaten by some squirrels. chx

14 45

[drupal-devel] [task] Admin help in core modules
by Robin Monks 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/26139 Project: Drupal Version: 4.6.2 Component: other Category: tasks Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/4-6-2-helptext.patch (126.02 KB) This patch adds help text to all core modules per the information at http://drupal.org/node/24768. This patch should be applied to 4.6.x and CVS HEAD. Robin Robin Monks

9 23

[drupal-devel] [bug] Queue module does not count the last submitted vote correctly
by leongtd 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27303 Post a follow up: http://drupal.org/project/comments/add/27303 Project: Drupal Version: 4.6.2 Component: queue.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: leongtd Updated by: leongtd Status: patch Attachment: http://drupal.org/files/issues/drupal-4.6.2-queue-vote-fix.patch (438 bytes) Queue module does not count the last submitted vote correctly. After the user has submitted a vote, it wouldn't count as the vaild vote until another user vote in. Steps of reproduce: - If the promotion threshold is set as 1. - First user press +1 vote Actual results: - The vote just submitted won't get counted and the post won't be promoted until second user vote +1 again. Expected results: - The vote should count and the promotion should be immediate. Attached is the code to fix the problem. leongtd

2 1