August 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Improved styling of autocomplete matches
by Thox 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/24932 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Thox Updated by: Thox Status: patch Attachment: http://drupal.org/files/issues/autocomplete_8.patch (1.39 KB) I'd like the autocomplete matches to be underlined (or styled in some way) so that users can see which part of the strings returned was actually matched. See Screenshot [1]. [1] http://photos14.flickr.com/19139302_0acb27f00d_o.png Thox

6 10

[drupal-devel] [feature] Speed up Drupal and improve scalability: On demand module loading
by Jose A Reyero 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27901 Post a follow up: http://drupal.org/project/comments/add/27901 Project: Drupal Version: cvs Component: module system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch (code needs review) Attachment: http://drupal.org/files/issues/on_demand_module_loading.patch (7.8 KB) As Drupal grows bigger, there is too much code not really needed parsed for each request. Also, installing more and more modules presents serious scalability issues, as all the enabled modules are included always for each non cached page. This is a first attempt to keep track of *all* module hooks, and only load modules when they're really needed. I guess it may need some polishing but the idea is simple enough. Currently, as the hook_menu is implemented by most of the modules, and it is called most of the times, the potential performance improvement introduced by this mechanism may be small. But the thing is, once he have some system for on demand module loading, hooks can be reworked in the future, to have some real performance boost. I.e. hook_menu could be easily split in two 'hook_menu' and 'hook_menu_dynamic', thus really reducing acually loaded modules. As I said, this is a first step. If there's some interest in this kind of features, I have some other things in the works aimed at performance and scalability, like: - (Simple) Rework of menu system to take real advantage of on demand module loading - Expand menu items to be able to include some file where the callback is in - Extend module loading for 'loading on path', and maybe 'loading split modules' - Some API loader, kind of api_invoke.... Jose A Reyero

6 10

[drupal-devel] [feature] Add Referrer Banning
by Robin Monks 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/27787 Post a follow up: http://drupal.org/project/comments/add/27787 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/referring_banning_with_stat_fix.patch (7.9 KB) The attached patch adds the following features to Drupal HEAD: - Setting Access Permissions by referrer. The attached patch fixes the following bugs: - Port numbers on same domain cause Drupal to mark an external referrer This patch changes the following modules, by function: - user.module -- user_admin_access_check Now allows checking based on referrer. -- _user_admin_access_form Now has options for banning based on referrer. -- user_admin_access Now lists referrer bans. -- user_help Show referrer banning in documentation. - bootstrap.inc -- _drupal_bootstrap Checks to ensure user is not banned by referrer. - statistics.module -- statistics_top_referrers Has "quick-links" for banning referring domain. Fixes port issue. I have tested this module and it works correctly on Drupal HEAD. Robin Robin Monks

11 16

[drupal-devel] [feature] Book Menu Navigation needs Theming
by merlinofchaos 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/28198 Post a follow up: http://drupal.org/project/comments/add/28198 Project: Drupal Version: 4.6.2 Component: book.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: merlinofchaos Updated by: merlinofchaos Status: patch (code needs review) Attachment: http://drupal.org/files/issues/book-theme-menu.patch (1.88 KB) In one of my Drupal sites I re-themed a minor issue in the menus, and discovered that the book navigation system just uses code that looks similar to the menu themes, but isn't actually themed. This very small patch adds a function theme_book_menu_item modeled closely on theme_menu_item from the menu system, and lets me theme this output as necessary; I believe it's incompatible with the other book menu patch floating around (and hopefully not necessary, but I haven't looked too closely at what that patch actually does). Hopefully I didn't break anything with it! merlinofchaos

2 2

[drupal-devel] [task] Integrate primary links with menu navigation
by adrian 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/22215 Project: Drupal Version: 4.6.0 Component: theme system Category: tasks Priority: critical Assigned to: Anonymous Reported by: adrian Updated by: adrian Status: patch Attachment: http://drupal.org/files/issues/menu_patch.diff (7.58 KB) Here is the first version of the patch that uses the menu system to generate the primary and secondary navigational links. The navigation menu should by default be used as the source for the primary / secondary navigation (currently only in bluemarine, templates need to be modified to use this functionality). Furthermore, the css used sucks .. and we will need someone to write proper default css for us to make it at least presentable in the absence of theme css. The navlinks aren't really useful if there are more than 5 links in a menu, so admin/ looks utterly horrible. This code is copied and adjusted from Bér's primary links module, and Adrian Simmons cleaned up the CSS a bit. Bér didn't have any css with the module, so I had to rip it from his webschuur.com site. adrian

7 12

[drupal-devel] [bug] PostgreSQL Socket Connection
by iamtheari 19 Sep '05

19 Sep '05

Issue status update for http://drupal.org/node/26836 Post a follow up: http://drupal.org/project/comments/add/26836 Project: Drupal Version: 4.6.2 Component: postgresql database Category: bug reports Priority: normal Assigned to: Anonymous Reported by: iamtheari Updated by: iamtheari Status: patch Attachment: http://drupal.org/files/issues/drupal-pgsql-socket.patch (917 bytes) Drupal does not allow for PostgreSQL connections via unix socket. I have written a patch that allows it to do so. The effect of this patch is that a hostname of 'localhost' in a pgsql:// $db_url will use Unix sockets unless a port it set in the URL. A hostname of '127.0.0.1' will use TCP/IP as before. Examples: Unix socket: pgsql://user:pass@localhost/db TCP/IP: pgsql://user:pass@localhost:4444/db TCP/IP: pgsql://user:pass@127.0.0.1/db TCP/IP: pgsql://user:pass@127.0.0.1:4444/db The patch is attached to this bug report. From a top-level Drupal directory, type 'patch -p0 < /path/to/drupal-pgsql-socket.patch' to apply it (omit the single-quotes). iamtheari

5 13

[drupal-devel] [feature] Hooks for comment enhancements
by Eaton 18 Sep '05

18 Sep '05

Issue status update for http://drupal.org/node/28255 Post a follow up: http://drupal.org/project/comments/add/28255 Project: Drupal Version: cvs Component: comment.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Eaton Updated by: Eaton Status: patch (code needs review) Attachment: http://drupal.org/files/issues/comment.module_10.patch (2.05 KB) I've been working on a couple modules that modify and enhance the commenting system (file attachments in comments, and custom comment validation for specific nodetypes). Another patch (http://drupal.org/node/14708) would add limited form and validation customizatoin, but this one adds nodeapi-style form_pre, form_post, validate, and view hooks. It's my first patch offered to the Drupal core, hope it's useful. Eaton

11 34

[drupal-devel] [task] Introduce theme wrapper, as discussed on the Sprint
by Bèr Kessels 18 Sep '05

18 Sep '05

Issue status update for http://drupal.org/node/23584 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: Bèr Kessels Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/theme_wrapper.patch (1.23 KB) I finally got around this. On the useability sprint inAntwerp we agreed that theme_box is: 1) not flexible, 2) underused 3) very powerfull for themers, consistancy and developers if it has enough information. This patch introduces such a function, called theme_wrapper. Theme('wrapper') should be called EVERYWHERE where we now have hardcoded spans and divs, only to be able to add a class or ID to a (part of -) a page. >From the notes: " ** HTML themed wrapper ** Currently, we use a theme_box to wrap parts of pages in HTML. This should be extended, but most of, all, get better CSS support. Thus a wrapper should be introduced, one that should replace theme_box. This theme_wrapper can and/or will get an ID and a class. * Both class and ID should be passed as elements, so that it is up to the developers to pqss correct classes and Ids; * Both the ID and class are required. (?) * Discuss whether or not they are required. **List of classes.** When passing a class, the developer should be encourqged to choose an existing class, instead of inventing new ones for every wrapper. This will be achieved by a list of standard classes, that will be available in drupal.css. Think of classes such as “3-col-left”, “3-col-center” and “3-col-right”, for wrappers that will make content in a 3 columned way. This could be used, for example in a directory.module to present three directories next to one another. TODO: Create a standard set of classes, that can, and should be, (re-) used by developers. ** Ids** Ids should be unique on a page, thus the developer must make sure, he or she does not use an ID that is already existing on the page where his or her HTML will be rendered. But just like with the classees, we should avoid a wildgrowth of ids. Thus, good guidelines, including lists of examples, lust be written. TODO: Create guidelines for ID-ing elements in Drupal. " Bèr Kessels

8 40

[drupal-devel] [bug] Make node_save() recursion-aware
by jvandyk 18 Sep '05

18 Sep '05

Issue status update for http://drupal.org/node/27007 Post a follow up: http://drupal.org/project/comments/add/27007 Project: Drupal Version: cvs Component: node system Category: bug reports Priority: normal Assigned to: jvandyk Reported by: jvandyk Updated by: jvandyk Status: patch Attachment: http://drupal.org/files/issues/node_serialized2x.patch (664 bytes) node_save() saves a node, then calls insert or update hooks. These hooks may run functions that, in turn, call node_save(). This all works fine except that if a revision is being created, the revision gets serialized twice -- once on the original node_save() call and once on the callback's node_save() call. The attached two-line patch simply inserts a boolean variable called rev_serialized to keep track of whether the serialization has already been done. I'd like to see cvs and 4.6 patched. This patch is necessary so I can release actions and workflow for 4.6. Background: http://drupal.org/node/24326 jvandyk

15 26

[drupal-devel] [feature] Ajax Tablesorting
by Steven 18 Sep '05

18 Sep '05

Issue status update for http://drupal.org/node/30150 Post a follow up: http://drupal.org/project/comments/add/30150 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Steven Reported by: Steven Updated by: Steven Status: patch (code needs review) Attachment: http://drupal.org/files/issues/jstablesort.patch (12.93 KB) This patch adds Ajax-based tablesorting to tablesort.inc. Note that this is /not/ client-side sorting, which isn't that useful in Drupal as most sortable tables are paged. Of course, given that it still requires a round-trip to the server, the biggest advantage is in visual usability, as only the table itself changes and not the entire page. The way this is accomplished will probably strike you as very elegant, or very dirty ;). In order to avoid patching up every instance of a sortable table and providing a custom Ajax menu callback for each, I made it so that inside theme('table'), the tablesort can cause the table to be printed immediately and PHP to quit. This is triggered by the GET variable 'tablesort', when set to the table's id. So, the Ajax HTTP request visits the exact same page as the original page, it only adds something to the URL which triggers this special behaviour. It works really well. In fact, the id-per-table wouldn't be necessary if we restricted ourselves to one sortable table per page. Steven

6 13