August 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Deleting Users & validate role name
by kubaZygmunt 11 Sep '05

11 Sep '05

Issue status update for http://drupal.org/node/27951 Post a follow up: http://drupal.org/project/comments/add/27951 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: kubaZygmunt Updated by: kubaZygmunt Status: patch (code needs review) Attachment: http://drupal.org/files/issues/user.module.patch.txt (914 bytes) I've found two bugs in user.module 1. Deleting button in admin section doesn't work ( deleting works only by url user/$id/delete ), I've upadated condition 2. If you change role name to 0 then system deletes role. (I've added isset($edit['name') ) kubaZygmunt

2 2

[drupal-devel] [feature] Enable override and extension of core module functions
by nedjo 11 Sep '05

11 Sep '05

Issue status update for http://drupal.org/node/29428 Post a follow up: http://drupal.org/project/comments/add/29428 Project: Drupal Version: cvs Component: module system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: nedjo Updated by: nedjo Status: patch (code needs review) Attachment: http://drupal.org/files/issues/module-extension-and-override.patch (1.38 KB) A frequently requested functionality is the ability to override or extend core module functions. This small patch is an initial take on how to enable function extension and overriding. It takes the existing module_invoke() function and adds tests for override and extension functions, in the forms modulename_originalfunction_override() and modulename_originalfunction_extension(). So, for example, an override function for the core taxonomy_node_form() function as defined by a module named testmodule would be called testmodule_taxonomy_node_form_override(), and would be run instead of taxonomy_node_form(). And testmodule_taxonomy_node_form_extension() would be run every time taxonomy_node_form() was called, hence "extending" it. Of course, this approach would only be useful if we converted most - or all! - of our current module function calls to use module_invoke()... nedjo

8 15

[drupal-devel] [feature] New themable function theme_search_form to unify search form and put logic at the correct level
by robertDouglass 11 Sep '05

11 Sep '05

Issue status update for http://drupal.org/node/27843 Post a follow up: http://drupal.org/project/comments/add/27843 Project: Drupal Version: cvs Component: search.module Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: robertDouglass Status: patch Attachment: http://drupal.org/files/issues/make_search_themable.txt (3.99 KB) The search form should be themable, but it shouldn't be left to the theme('page') function to do this, as is the current implementation. This patch adds a theme_search_form function to theme.inc (not search module because that would cause a dependency) and removes the then unneeded variables from the phptemplate.engine. Pushbutton and Bluemarine are updated to take advantage of the new function. In the current implementation, several variables are created needlessly in phptemplate.engine (like the text for the button) and then pushed to the template. This seems messy and this patch fixes that. Remaining questions: should the function accept any parameters? I think not, but other opinions are welcome. robertDouglass

3 2

[drupal-devel] [feature] Multiple simple nodes
by chx 11 Sep '05

11 Sep '05

Issue status update for http://drupal.org/node/29794 Post a follow up: http://drupal.org/project/comments/add/29794 Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch (code needs review) Attachment: http://drupal.org/files/issues/simplenode.module (9.09 KB) Instead of page, story etc let's have a module with which you can add simple body only nodes. At least moshe and I frequently copy story.module to have a new simple module. For example, event needs this. For permissions it's great to have multiple node types. So I downloaded a copy of content.module from CCK, pressed delete a lot, copied hook_form from story and then rename the stuff to simplenode.module. Then I reviewed the thing but it was really not much, so credit goes to JonBob and jvandyk. MySQL is: CREATE TABLE node_type ( type_name varchar(31) NOT NULL default '', label varchar(255) NOT NULL default '', description mediumtext NOT NULL, help mediumtext NOT NULL, PRIMARY KEY (type_name) ) TYPE=MyISAM; chx

7 20

[drupal-devel] [feature] Add create_child grant type in node_access system
by clydefrog 11 Sep '05

11 Sep '05

Issue status update for http://drupal.org/node/20890 Project: Drupal Version: cvs Component: node system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: clydefrog Updated by: clydefrog Status: patch Attachment: http://drupal.org/files/issues/access_child_page.patch (3.26 KB) This patch makes it possible to restrict which nodes can be used as parents when editing child book pages. Here's a quick summary of the changes: Add grant_create_child column to node_access page. Set grant_create_child to 1 in the default nid = 0 row. Pass array('op' => 'create_child') to db_rewrite_sql() in book_toc(). Modify node_db_rewrite_sql() so that the "$op" argument is used in _node_access_where_sql() Generalize node_access_view_all_nodes() to node_access_all_nodes($op) I'm not sure I've covered all the bases. In particular, the "add child page" link still appears on all book pages. Also, there is nothing stopping a clueful user from passing an arbitrary parent nid when submitting. But shouldn't those be the responsibility of the particular node_access module? Thanks for considering this patch. An aside: The attached patch was made with "diff -ru". Is it acceptable to use "cvs diff -u" as well? clydefrog

3 5

[drupal-devel] [feature] OPML Import for Aggregator
by arnabdotorg 10 Sep '05

10 Sep '05

Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: arnabdotorg Reported by: arnabdotorg Updated by: arnabdotorg Status: patch Attachment: http://drupal.org/files/issues/import_opml.patch (3.96 KB) The aggregator supports OPML export for all feeds, but not import. This patch enables import of OPML lists, allowing people to import lists of RSS feeds they've already assembled in another RSS app. Demo: http://arnab.drupaldevs.org/aggregator Patch: http://arnab.drupaldevs.org/tmp/import_opml.patch arnabdotorg -- View: http://drupal.org/node/16282 Edit: http://drupal.org/project/comments/add/16282

5 6

[drupal-devel] [feature] MySQLi support
by nsk 09 Sep '05

09 Sep '05

Issue status update for http://drupal.org/node/29910 Post a follow up: http://drupal.org/project/comments/add/29910 Project: Drupal Version: cvs Component: database system Category: feature requests Priority: critical Assigned to: Anonymous Reported by: nsk Updated by: nsk Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/nskpatch.tar.bz2 (4.14 KB) I added MySQLi support to Drupal by adding a database.mysqli.inc file. After chx's suggestion I also removed $row from db_result from both mysqli and mysql files. Users are supposed to connect to Drupal with a mysqli "URL" in their settings.php. Just adding an "i" in the mysql entry in settings.php would work. MySQLi is the new MySQL client in PHP which connects to MySQL 4.1, 5.0 and beyond. MySQLi replaces the older MySQL library which was popular with MySQL 3.23 and 4.0. http://gr.php.net/manual/en/ref.mysqli.php The older MySQL client does not support full functionality with MySQL 4.1, that's why MySQLi is important. MySQLi works in PHP 4.1.3 or above, and is more popular in PHP 5. MySQLi means MySQL Improved. This patch should be included in core. nsk

14 67

[drupal-devel] [task] Remove a php notice in common.inc
by drumm 09 Sep '05

09 Sep '05

Issue status update for http://drupal.org/node/28948 Post a follow up: http://drupal.org/project/comments/add/28948 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch (code needs review) Attachment: http://drupal.org/files/issues/common.inc_7.diff (619 bytes) I turned on notices for update.php with PHP 4. This turned up in common.inc. drumm

2 1

[drupal-devel] [feature] Database Table Creation Script
by danielc 09 Sep '05

09 Sep '05

Issue status update for http://drupal.org/node/20530 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: danielc Updated by: danielc Status: patch Attachment: http://drupal.org/files/issues/create.php.v1.txt (11.43 KB) Attached is a PHP script that creates all of the database tables for all sites in /drupal/sites/*. It works with CVS checkouts of either HEAD or the DRUPAL-4-6 branch as of 2005-04-14 19:00 UTC. Until it gets added to CVS, you can use it by saving the latest version of the file from this page, rename it "create.php" and put it in the "/drupal/database" directory. Then either execute it from the command line or point your web browser to it. For exact usage instructions, read the documentation inside the script. danielc

7 9

[drupal-devel] [bug] "Only variables can be passed by reference" to file_check_directory()
by danielc 09 Sep '05

09 Sep '05

Issue status update for http://drupal.org/node/26033 Project: Drupal Version: 4.6.2 Component: base system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: danielc Updated by: danielc Status: patch Attachment: http://drupal.org/files/issues/file_create_path.diff (2.4 KB) A client of mine just upgraded to the latest snapshot of PHP 5.0.5-dev and started getting errors when file_check_directory() is called: Fatal error: Only variables can be passed by reference in c:\drupal\modules\system.module on line 653 This patch fixes the problem by assigning the values to variables before passing them to file_check_directory(). Thanks. (BTW: I'm no longer on on drupal-devel due to time constraints.) danielc

4 7