August 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Session system - fix for NULL uid
by Cvbge 03 Sep '05

03 Sep '05

Issue status update for http://drupal.org/node/29143 Post a follow up: http://drupal.org/project/comments/add/29143 Project: Drupal Version: 4.5.5 Component: other Category: bug reports Priority: critical Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge Status: patch (code needs review) Attachment: http://drupal.org/files/issues/session-uid.inc (955 bytes) On fresh install session table is empty and session.inc tries to insert a row. But it ommits uid field which is NOT NULL and inserting fails. Attached patch makes it to have the same behaviour as 4.6 Cvbge

3 5

[drupal-devel] [bug] Remove code containing user access controls from profile theme functions
by robertDouglass 03 Sep '05

03 Sep '05

Issue status update for http://drupal.org/node/27949 Post a follow up: http://drupal.org/project/comments/add/27949 Project: Drupal Version: cvs Component: profile.module Category: bug reports Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: robertDouglass Status: patch (code needs review) Attachment: http://drupal.org/files/issues/profile_fix_acces_control_in_theme.txt (2.36 KB) The two theme functions in profile.module both violate good theming practice by running user control logic in the middle of them. Worse yet, this isn't immediately visible since it happens in yet another function. Thus themers overriding these functions to style profile pages[1] inadvertently break access control, thus leading to the misperception that overriding theme functions is inherently dangerous[2]. [1] http://drupal.org/node/16011 [2] http://drupal.org/node/16821 robertDouglass

6 11

[drupal-devel] [feature] introduce filapi hook
by Bèr Kessels 02 Sep '05

02 Sep '05

Issue status update for http://drupal.org/node/18934 Project: Drupal Version: 4.5.2 Component: file system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch This simple patch by Robert Douglas introduces a fileapi hook. Nothing fancy, nothing difficult and most of all harldy any performance overhead. It simply allows modules to hook into the data of the file on: insert delete update load The reason why this should be here, and not in nodeapi, is because, for example media.module wants to "do stuff" with the file, like get id3 data and put that into a table on upload of a file. Another valid use case would be to be able to track and count downloads. Yet another case would be some file renaming, or organising in directories. Bèr Bèr Kessels

12 20

[drupal-devel] [feature] Patch to add 'wide' to class of wide form items. (Solves theme problems with wide fields.)
by jjeff 02 Sep '05

02 Sep '05

Issue status update for http://drupal.org/node/28044 Post a follow up: http://drupal.org/project/comments/add/28044 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: jjeff Reported by: jjeff Updated by: jjeff Status: patch (code needs review) Attachment: http://drupal.org/files/issues/common.wide.patch (5.33 KB) We've all seen wide Drupal forms break a fixed width theme by "blowing out" the right side of the theme. Here's a solution to the problem. This patch adds a "wide" class tag to any textfield, password, textarea, or autocomplete form item with a width (size) of more than 40 characters. By also adding a css rule in drupal.css that sets any "wide" form-items to width:100%, we keep these form items under control. Of course the assumption is that any form items with a width greater than 40 are intended to be full width. Opposing viewpoints are welcome. Here's the css rule: .form-item .wide { width: 100%; } patch for common.inc is attached. jjeff

8 10

[drupal-devel] [feature] show online/offline status in theme('username')
by moshe weitzman 02 Sep '05

02 Sep '05

Issue status update for http://drupal.org/node/29281 Post a follow up: http://drupal.org/project/comments/add/29281 Project: Drupal Version: cvs Component: theme system Category: feature requests Priority: normal Assigned to: moshe weitzman Reported by: moshe weitzman Updated by: moshe weitzman Status: patch (code needs review) Attachment: http://drupal.org/files/issues/online.patch (9.41 KB) add css class such that a theme can put nice online/offline indicators when showing a username link. i made sure the relevant queries in node, user, and tracker modules were passing the $user->access parameter which triggers the addition of this css class. no added quries or JOINS needed.much of this patch is just moving the 'inactivity timer' pref from the Who's Online block config page to the main admin/settings/user page. would be nice if someone contributed small graphics for online offline and added these to drupal.css. this would enhance our default presentation. i'd like for this patch not to wait on that, if possible. moshe weitzman

11 29

[drupal-devel] [task] More improvements to help text for admin/access pages
by nysus 01 Sep '05

01 Sep '05

Issue status update for http://drupal.org/node/28278 Post a follow up: http://drupal.org/project/comments/add/28278 Project: Drupal Version: cvs Component: user.module Category: tasks Priority: normal Assigned to: nysus Reported by: nysus Updated by: nysus Status: patch (code needs review) Attachment: http://drupal.org/files/issues/user_1.module (87.58 KB) Here's some more improvements to the help text found on the following pages: admin/access admin/access/roles admin/access/rules admin/access/rules/add nysus

1 1

[drupal-devel] [bug] Menu.inc error when running on php5
by iraszl 01 Sep '05

01 Sep '05

Issue status update for http://drupal.org/node/27582 Post a follow up: http://drupal.org/project/comments/add/27582 Project: Drupal Version: 4.6.2 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: iraszl Updated by: iraszl Status: patch In *menu.inc*, function menu_execute_active_handler() I changed: if (strlen($arg)) { To: if (strlen($arg) && is_array($arguments)) { That did the trick to get rid of the annoying error messages in the log. iraszl

3 2

[drupal-devel] [feature] Advanced search features
by Steven 01 Sep '05

01 Sep '05

Issue status update for http://drupal.org/node/28159 Post a follow up: http://drupal.org/project/comments/add/28159 Project: Drupal Version: cvs Component: search.module Category: feature requests Priority: normal Assigned to: Steven Reported by: Steven Updated by: Steven Status: patch (code needs review) Attachment: http://drupal.org/files/issues/search_2.patch (37.05 KB) Here's my promised search patch. It's not 100% commit ready yet, but it's time to sollicit some feedback and get this tested ;). Note that this patch requires a db update, which will wipe the search index. You will then need to call cron.php enough times for the site to be indexed completely again. This could take a while for large databases, but you can control the throttle and see the progress at admin/settings/search. *Features* * AND keyword matching by default ('all of the words'), instead of OR ('any of the words'). * OR support through keyword1 OR keyword2 OR ... * Phrase searching through "quoted strings". * Negative matching through -"minus prefix" -word. * Restrict search by taxonomy or node type(s) using taxonomy:1,2 and type:blog,page. The options are built-into the keyword string through a google like syntax, but there is an expandable "advanced settings" form below the search box which acts as a 'query builder': This example will result in the following search string (of course not a practical example): test type:forum,story category:1 "tinky winky" OR "dipsy" -"uh oh" "teletubby bye bye" On a different note, I removed the wildcard matching. An important reason is that there were significant performance problems with leading wildcards. Such queries were not be able to use any indices, and the resulting full-table scan took a long time. Even Google does have intra-word wildcards, they can only be used as placeholders for entire words in phrases. Trailing wildcards on the other hand are usually used to accomodate grammatical variations on a word. But, wildcards are not really the best tool for this as this puts a burden on the user. If you need this feature, you should instead tie in an algorithm like the Porter Stemmer through the search_preprocess hook. That way you can reduce related words to a single common root (e.g. "walker" "walking" "walked" to "walk"). The search system will then index and search on the reduced words. You will even benefit from a reduced database size because there are less unique words. Because such algorithms are very language specific, I didn't build in any. But it should be trivial to make a Porter Stemmer module for Drupal search, which can be used on english sites. *Database* To implement the above searches, I added a 'search_dataset' table that is independent of the keyword index. Each dataset row contains the entire contents of the indexed item, but filtered, cleaned up and reduced to space-sparated tokens (words, numbers, dates, ...). This table is used to resolve the exact conditions, which means the keyword index is not as essential anymore. Because searches are AND by default, the OR method of search_index acts as an initial filter to eliminate the majority of items immediately. That subset is then further reduced through the search_dataset table. All of this means that the search_index table can now be indexed at a much higher minimum word lenght (e.g. 5), which means a reduced database size. Even with the new dataset table, the net database size shrinks slightly. I also implemented the searching as two selects into temporary tables. This allows me to avoid doing a costly counting query for the pager and a range-limited query for the actual results. I added support for temporary tables to database.(my|pg)sql. The db api itself takes a normal SELECT and a table name, and turns it into an appropriate platform specific temporary table query (CREATE TABLE ... AS, CREATE TABLE ... SELECT). I still need to do detailed benchmarking, but at least for the same queries as before, this patch should be faster. Of course, pre-patch, all searches were OR, not AND, so a direct comparison needs to take this into account (the pre-patch query "drupal theme development" is now "drupal OR theme OR development"). One feature request that I did not do is date based searching (before X/X/X, after X/X/X), mostly because we don't have a good date widget yet. I've been toying with making a simple in-page JS data picker, but it's not done yet and I think the patch is good enough already. Date restrictions can be added on later without any problems. Steven

16 29

[drupal-devel] [feature] Paging support for long page nodes
by scutari 01 Sep '05

01 Sep '05

Issue status update for http://drupal.org/node/30089 Post a follow up: http://drupal.org/project/comments/add/30089 Project: Drupal Version: 4.6.3 Component: page.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: scutari Updated by: scutari Status: patch (code needs review) Attachment: http://drupal.org/files/issues/submitted_page_0.patch (1.84 KB) This is a *beta* support for paging (splitting long page nodes into smaller chunks) using a  tag. Even in this beta stage it works flawlessly in my drupal 4.6.3. Preview of splitted nodes is broken without some other hacks; I'll provide them as patches if this feature request is deemed interesting. scutari

10 18

[drupal-devel] [bug] Css fix: highlighted block regions on top
by fajerstarter 01 Sep '05

01 Sep '05

Issue status update for http://drupal.org/node/30094 Post a follow up: http://drupal.org/project/comments/add/30094 Project: Drupal Version: 4.6.0 Component: block.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: fajerstarter Updated by: fajerstarter Status: patch (code needs review) Attachment: http://drupal.org/files/issues/drupal_css_svn.diff (397 bytes) The highlighted block regions on the block configuration page appears below some objects on custom themes. This two rows fixes that. Hopefully a z-index of 99 is enough for most themes... fajerstarter

2 2