August 2005 - Development - lists.drupal.org

[drupal-devel] Re: More profiling code - the server this time
by Mike Gifford 11 Aug '05

11 Aug '05

Hi Robert, Robert Douglass <rob(a)robshouse.net> wrote: > I'd be pretty interested in seeing this code and would love to help > you > port it to Drupal. If you don't want to wait for CVS access we > could put > it in my sandbox. It's not a lot of code so I've just pasted it in here. No problems with you putting it up in your sandbox. I'm still new to drupal so hints on locations for a temp directory where this could be written, the cache table is probably be used. Also, is there is an existing script timer tool built in. I can send along the class that this script uses if there isn't one built in. Also, the values I put in for the base number of cycles were designed so that they would take about a second on an old machine. A shorter number of cycles made it harder to judge the relative speed and more cycles caused the problems on really slow servers. /* Do some really simple math a bunch of times */ function profileProcessorSpeed($max = 1000) { // for ($i=0 ; $i < $max ; ++$i) { $bigArray[] = 3 * $i; } foreach($bigArray AS $bigItem) { $value = $bigItem / 2; } // echo "$value end"; } /* Read/Write a bunch of files to a temp directory */ function profileDiskSpeed($max = 400) { global $_PSL, $scriptTimer; $contents = $handle = null; $dir = $_PSL['basedir'] . '/updir/fileCache/'; $scriptTimer->start('diskSpeed'); for ($i=0 ; $i < $max ; ++$i) { if ($scriptTimer->get_current('diskSpeed') > 30) { echo "Script Interrupted, $i disk cycles completed"; return $i; break; } $filename = $dir . 'testFile_' . $i . '.txt'; $somecontent = "Add this to the file $i \n"; // Let's make sure the directory is writable first. if (is_writable($dir)) { // Open file if (!$handle = fopen($filename, 'a')) { echo "Cannot open file ($filename)"; exit; } // Write $somecontent to our opened file. if (fwrite($handle, $somecontent) === FALSE) { echo "Cannot write to file ($filename)"; exit; } fclose($handle); // Read contents $handle = fopen($filename, 'r'); $contents .= fread($handle, filesize($filename)); fclose($handle); unlink($filename); } else { echo "The directory $dir is not writable"; } } return null; } /* Insert/Update/Delete a bunch of files into a cache table */ function profileDBaccess($max = 400) { global $_PSL, $scriptTimer; $contents = null; $db = pslNew('BEDB'); $scriptTimer->start('dbSpeed'); for ($i=0 ; $i < $max ; ++$i) { if ($scriptTimer->get_current('dbSpeed') > 30) { echo "Script Interrupted, $i database cycles completed"; return $i; break; } $j = $i + 30000; $query = "SELECT value FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); while ($db->next_record()) { if ($db->Record['value']) { $query = "DELETE FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); } } $query = "INSERT INTO psl_variable (variable_id, value, variable_name) VALUES ('$j', 'Inserted Value $j', 'Test$j')"; $db->query($query); $query = "UPDATE psl_variable SET value = 'Updated Value $j' WHERE variable_id = '$j'"; $db->query($query); $query = "SELECT value FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); if ($db->next_record()) { $contents .= $db->Record['value']; } $query = "DELETE FROM psl_variable WHERE variable_id = '$j'"; $db->query($query); } return null; } // Start log content $content = '<p>' . date("D M j G:i:s T Y") . ' - '; $scriptTimer->start('profile'); $processorCycles = 10000; profileProcessorSpeed($processorCycles); $processorSpeed = $scriptTimer->get_current('profile'); $content .= "Processor Speed ($processorCycles Cycles): $processorSpeed - "; $fileCycles = 400; $diskCycleResults = profileDiskSpeed($fileCycles); $diskCycleResults = (!empty($diskCycleResults)) ? $diskCycleResults : $fileCycles; $diskSpeed = $scriptTimer->get_current('profile') - $processorSpeed; $content .= "Disk Speed ($diskCycleResults Cycles): $diskSpeed - "; $dbCycles = 250; $dbCycleResults = profileDBaccess($dbCycles); $dbCycleResults = (!empty($dbCycleResults)) ? $dbCycleResults : $dbCycles; $dbSpeed = $scriptTimer->get_current('profile') - $processorSpeed - $diskSpeed; $content .= "DB Speed ($dbCycleResults Cycles): $dbSpeed </p>\n"; $dir = $_PSL['basedir'] . '/updir/fileCache'; $filenameLog = $dir . '/profileLog.txt'; $filenameAverage = $dir . '/profileAverage.txt'; // Read contents of log if (is_readable($filenameLog)) { $handle = fopen($filenameLog, 'r'); $contents .= fread($handle, filesize($filenameLog)); fclose($handle); } // Write log if (!$handle = fopen($filenameLog, 'a')) { echo "Cannot open file ($filenameLog)"; exit; } if (fwrite($handle, $content) === FALSE) { echo "Cannot write to file ($filenameLog)"; exit; } fclose($handle); // Read contents of log if (is_readable($filenameAverage)) { $handle = fopen($filenameAverage, 'r'); $values = unserialize(fread($handle, filesize ($filenameAverage))); fclose($handle); $count = $values['count'] + 1; $processor = (($values['processor'] * $values['count']) + $processorSpeed) / $count; $disk = (($values['disk'] * $values['count']) + $diskSpeed) / $count; $database = (($values['database'] * $values['count']) + $dbSpeed) / $count; } else { $count = 1; $processor = $processorSpeed; $disk = $diskSpeed; $database = $dbSpeed; } $average = "<p>Count $count - Processor Speed (100000 Cycles): $processor - Disk Speed (400 Cycles): $disk - DB Speed (250 Cycles): $database </p>"; // Write log $value = serialize(array('count' => $count, 'processor' => $processor, 'disk' => $disk, 'database' => $database)); if (!$handle = fopen($filenameAverage, 'w')) { echo "Cannot open file ($filenameAverage)"; exit; } if (fwrite($handle, $value) === FALSE) { echo "Cannot write to file ($filenameAverage)"; exit; } fclose($handle); echo "<h1>Last Results</h1> $content <h1>Average Results</h1> $average <h1>All Results</h1> $contents "; Feel free to enhance any of this. Would be neat to see it as a drupal module. Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Latest launch Canadian Labour Congress / Congrès du travail du Canada http://canadianlabour.ca / http://congresdutravail.ca

2 2

[drupal-devel] [feature] Parse atom feeds
by Prometheus6 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/13941 Post a follow up: http://drupal.org/project/comments/add/13941 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: Prometheus6 Reported by: Capnj Updated by: Prometheus6 Status: patch (code needs review) Okay. Just to let you know, I added the blog it link because of this conversation. http://drupal.org/node/10752 I'll make a patch tonight just for the blog it feature, so this item can be closed if you like. Prometheus6 Previous comments: ------------------------------------------------------------------------ Sun, 05 Dec 2004 23:26:00 +0000 : Capnj I've seen mention elsewhere on drupal.org but don't see a feature request, so here goes. The news aggregator is a great piece of Drupal as far as I'm concerned and I'd sure like to see it read all the sources out there, have the 'blog this' function, and also have a tool for browsers to generate a blog entry from a web page (like MT had). Is that a big enough request? LOL Thanks for all that everyone does here. Great stuff! gil ------------------------------------------------------------------------ Tue, 07 Dec 2004 17:38:31 +0000 : drumm RSS 2.0 feeds should work in 4.5.0 and earlier. ------------------------------------------------------------------------ Mon, 14 Feb 2005 16:04:32 +0000 : georgehotelling I've hacked Magpie [1] support into the Drupal aggregator, so it can support Atom. If you have a Drupal site and want the code, you can get it from http://george.hotelling.net/projects/magpie-aggregator-4.5.2.tgz [2] I'm not sure if I'm supposed to create a patch or what, but I needed this for ArborBlogs.com [3] and figured some other people would benefit from it. [1] http://magpierss.sourceforge.net/ [2] http://george.hotelling.net/projects/magpie-aggregator-4.5.2.tgz [3] http://www.arborblogs.com/ ------------------------------------------------------------------------ Tue, 15 Mar 2005 04:04:42 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD.txt (5.46 KB) Very nice. I hacked aggregator.module for 4.6 using your module as a guide...well, frankly by ripping out great chunks of code for my use. ------------------------------------------------------------------------ Thu, 28 Jul 2005 22:21:11 +0000 : Boris Mann Can someone roll a patch for this? Would be a good addition for 4.7 now that Atom is at 1.0. ------------------------------------------------------------------------ Fri, 29 Jul 2005 01:49:42 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/magpie_aggregator.zip (7.87 KB) A patch would require the Magpie include files and wholly restructures the way the feeds are parsed...the Magpie code would handle all the feeds, not just Atom. That said, the attached zip file has the necessary includes and a patch to CVS. ------------------------------------------------------------------------ Fri, 29 Jul 2005 03:36:59 +0000 : Steven Magpie RSS duplicates a lot of functionality that is already in Drupal. We decided a long time ago that we would not use it. Porting Atom parsing into the current aggregator can't be that hard. ------------------------------------------------------------------------ Mon, 01 Aug 2005 16:38:53 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD_0.txt (1.93 KB) Since I'm messing around with the aggregator module anyway... I developed this around Atom 0.3 feeds this weekend, but I don't see anything in Atom 1.0 that should break it. ------------------------------------------------------------------------ Tue, 02 Aug 2005 15:00:50 +0000 : Eaton +1 on that patch. Running it now on my test site and everything looks great. ------------------------------------------------------------------------ Tue, 02 Aug 2005 16:24:54 +0000 : Bèr Kessels a small issue, whe do not use if ($data) $items[$item][$tag] .= $data; please just use if ($data) { $items[$item][$tag] .= $data; } ------------------------------------------------------------------------ Wed, 03 Aug 2005 02:18:54 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD_1.txt (1.99 KB) Not a problem. Here's the corrections. ------------------------------------------------------------------------ Wed, 03 Aug 2005 16:14:14 +0000 : Dries If this is all it takes to parse Atom feeds (to some extend), I'm all for it. Code looks OK. Set to 'ready to be committed' after some testing. ------------------------------------------------------------------------ Wed, 03 Aug 2005 18:59:20 +0000 : kika anybody up for a testing suite tests? http://intertwingly.net/wiki/pie/FormatTests ------------------------------------------------------------------------ Wed, 03 Aug 2005 20:07:37 +0000 : Prometheus6 That would be for the Atom module. ------------------------------------------------------------------------ Wed, 03 Aug 2005 23:36:04 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_CVS.txt (2.35 KB) Because the aggregator would always gather enough information todownload an Atom feed, the previous patch focused on parsing items/entries correctly. This patch adds more complete parsing of the feed's channel data (site link, subtitle/description, logo). Now all the feed and item fields will be properly updated. ------------------------------------------------------------------------ Mon, 08 Aug 2005 16:00:22 +0000 : Prometheus6 The content of the Atom feed's id and info tags were being displayed as part of the feed's description on the aggregator pages. With this patch those tags are recognized and discarded. The "blog it" link is also added to the aggregator page items in addition to the block. ------------------------------------------------------------------------ Mon, 08 Aug 2005 16:01:55 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_CVS_0.txt (3.69 KB) Let's try that with the patch this time... ------------------------------------------------------------------------ Thu, 11 Aug 2005 13:13:34 +0000 : Dries Committed a partial patch. Left out the 'blog it' stuff for now but committed the parsing part. The 'blog it' stuff needs more review and testing.

1 0

[drupal-devel] [bug] _db_query() does not return FALSE in case of errors, as stated in documentation
by Cvbge 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/25522 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge Status: patch Attachment: http://drupal.org/files/issues/database.mysql.inc.diff (318 bytes) According to documentation db_query() should return FALSE "if the query was not executed correctly". This function calls _db_query() which returns nothing in such cases (for example when the sql syntax is wrong). Attached one-liner fixes this by adding return FALSE to _db_query(). It's from 4.6.1 but should apply to cvs without problems. Please apply this patch also to 4.6 branch. But there seems to be a problem with db_error(). It calls mysql_errno() but it seems that errors are cleared after mysql_error() call. So db_error() does not indicate any errors even if they occur. Cvbge

2 5

[drupal-devel] [bug] Duplicate entry 'locale:pl' for key 1 query: INSERT INTO cache
by katin 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/21568 Post a follow up: http://drupal.org/project/comments/add/21568 Project: Drupal Version: 4.5.2 Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Cvbge Updated by: katin Status: patch (code needs review) It's going to require more logic changes than that... since things error out on the REPLACE if the record *isn't* in the cache yet. Something like: If (REPLACE fails) then INSERT I'll test some code on my sites and post updates. katin Previous comments: ------------------------------------------------------------------------ Fri, 29 Apr 2005 07:01:29 +0000 : Cvbge Sometimes I'm getting following errors: (I'm not sure what triggers it, or what's the cause - I suppose it's localization or image module, maybe albums...) Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Duplicate entry 'locale:pl' for key 1 query: INSERT INTO cache (cid, data, created, expire, headers) VALUES ('locale:pl', 'a:1652:{s:15:\"Download method\";b:1;s:49:\"Public - files are available using http directly.\";b:1;s:42:\"Private - files are transferred by Drupal.\";b:1;s:20:\"File system settings\";b:1;s:34:\"Select an image processing toolkit\";b:1;s:14:\"Image handling\";b:1;s:23:\"Configurable time zones\";b:1;s:17:\"Short date format\";b:1;s:33:\"The short format of date display.\";b:1;s:18:\"Medium date format\";b:1;s:30:\"The medium sized date display.\";b:1;s:16:\"Long date format\";b:1;s:45:\"Longer date format used for detailed display.\";b:1;s:45:\"The first day of the week for calendar views.\";b:1;s:62:\"Only JPEG, PNG and GIF images are allowed to be used as logos.\";b:1;s:66:\"Check here if you want the theme to use the logo supplied in /home/www-data/izoo/includes/database.mysql.inc on line 66. Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Duplicate entry 'locale:en' for key 1 query: INSERT INTO cache (cid, data, created, expire, headers) VALUES ('locale:en', 'a:1652:{s:15:\"Download method\";b:1;s:49:\"Public - files are available using http directly.\";b:1;s:42:\"Private - files are transferred by Drupal.\";b:1;s:20:\"File system settings\";b:1;s:34:\"Select an image processing toolkit\";b:1;s:14:\"Image handling\";b:1;s:23:\"Configurable time zones\";b:1;s:17:\"Short date format\";b:1;s:33:\"The short format of date display.\";b:1;s:18:\"Medium date format\";b:1;s:30:\"The medium sized date display.\";b:1;s:16:\"Long date format\";b:1;s:45:\"Longer date format used for detailed display.\";b:1;s:45:\"The first day of the week for calendar views.\";b:1;s:62:\"Only JPEG, PNG and GIF images are allowed to be used as logos.\";b:1;s:66:\"Check here if you want the theme to use the logo supplied in /home/www-data/izoo/includes/database.mysql.inc on line 66. Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Cannot modify header information - headers already sent by (output started at /home/www-data/izoo/includes/common.inc:384) in /home/www-data/izoo/includes/file.inc on line 437. Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Cannot modify header information - headers already sent by (output started at /home/www-data/izoo/includes/common.inc:384) in /home/www-data/izoo/includes/file.inc on line 437. ------------------------------------------------------------------------ Sun, 05 Jun 2005 06:34:59 +0000 : chx This is fixed in HEAD. If you want, you may change the mysql_connect line by adding ,2 after TRUE. ------------------------------------------------------------------------ Fri, 29 Jul 2005 05:42:57 +0000 : bslade Could this related to the issue (bug) "improved cache api - race conditions"? ( http://drupal.org/node/1811 [1] ) Ben in DC PublicMailbox at benslade dot com [1] http://drupal.org/node/1811 ------------------------------------------------------------------------ Thu, 11 Aug 2005 12:25:01 +0000 : katin I fixed it by changing some logic in bootstrap.inc. The function is cache_set(): (I tried to post the actual code here inside <code> tags, but kept getting 'Terminated request because of suspicious input data.' and all my text would be lost. After a dozen tries moving code tags, trimming lines, etc., I give up. You'll have to go look at the code yourself.) The logic in this function is: UPDATE record if (!db_affected_rows()) then INSERT the record I found a clue to why this logic would fail in the PHP manual, mysql_affected_rows page: (http://us2.php.net/manual/en/function.mysql-affected-rows.php) " When using UPDATE, MySQL will not update columns where the new value is the same as the old value. This creates the possibility that mysql_affected_rows() may not actually equal the number of rows matched, only the number of rows that were literally affected by the query. The REPLACE statement first deletes the record with the same primary key and then inserts the new record. This function returns the number of deleted records plus the number of inserted records. " That would mean that if the record specified in the UPDATE line is already in the db exactly as so, mysql_affected_rows() would return zero, and the logic then tries to INSERT the record - which will throw the error because it already exists. Therefore, change the INSERT to a REPLACE and the logic will work fine for duplicate as well as changed cache entries. The error messages stop. (Again, tried to post code samples here for the fixed line... couldn't get past the 'suspicious data' errors... I had no disallowed tags... really annoying.) Background: MySQL ver 4.1.11 PHP ver 4.3.11 Drupal version 4.6.2 Linux platform I suspect the exact behaviour of mysql_affected_rows() in relation to the UPDATE function may differ in different versions of mysql (3.23 to 4.1, for example).

1 0

[drupal-devel] More profiling code - the server this time
by Mike Gifford 11 Aug '05

11 Aug '05

Hi folks, I'm curious to know if there is any code within drupal to help test server performance. I went looking for some generic stuff a while back but couldn't find it (does it exist anywhere else that folks are aware of). I ended up writing some code for another CMS to test hard drive (read/write), cpu (simple math) and database (insert/update/ select) operations so that I could conclusively prove that it was a client's server that was the problem (and not the CMS itself). Before writing the code I had assumed that because the mysql server was hosted elsewhere that the problem was most likely due to poor bandwidth between those two servers. Now there was a security problem with how this was configured (as the mysql server could be accessed directly from anywhere and wasn't tied to any IP), I was surprised to find out that the problem was more with disk speed in peak periods than anything. At very slow periods the script could only go through five cycles of a simple script to write, read and update a file before timing out. This code is set up to log previous queries and provide an average speed. It is also set up to time out after a certain period of time and count cycles completed rather than number of seconds. Web hosting is an odd business with folks offering the moon for next to nothing. Often hosts have to cut a lot of corners to try to meet the bottom line. Just nice to have some way to analyze the ways that this can affect the performance of a drupal site. If there's interest I could port it over to Drupal.. Would need some advice though about where it should go though? I haven't got a sandbox yet. Expect it could just be a stand alone module.. Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Latest launch Canadian Labour Congress / Congrès du travail du Canada http://canadianlabour.ca / http://congresdutravail.ca -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://www.openconcept.ca Latest launch Canadian Labour Congress / Congrès du travail du Canada http://canadianlabour.ca / http://congresdutravail.ca

3 2

[drupal-devel] [feature] Parse atom feeds
by Dries 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/13941 Post a follow up: http://drupal.org/project/comments/add/13941 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: Prometheus6 Reported by: Capnj Updated by: Dries Status: patch (code needs review) Committed a partial patch. Left out the 'blog it' stuff for now but committed the parsing part. The 'blog it' stuff needs more review and testing. Dries Previous comments: ------------------------------------------------------------------------ Sun, 05 Dec 2004 23:26:00 +0000 : Capnj I've seen mention elsewhere on drupal.org but don't see a feature request, so here goes. The news aggregator is a great piece of Drupal as far as I'm concerned and I'd sure like to see it read all the sources out there, have the 'blog this' function, and also have a tool for browsers to generate a blog entry from a web page (like MT had). Is that a big enough request? LOL Thanks for all that everyone does here. Great stuff! gil ------------------------------------------------------------------------ Tue, 07 Dec 2004 17:38:31 +0000 : drumm RSS 2.0 feeds should work in 4.5.0 and earlier. ------------------------------------------------------------------------ Mon, 14 Feb 2005 16:04:32 +0000 : georgehotelling I've hacked Magpie [1] support into the Drupal aggregator, so it can support Atom. If you have a Drupal site and want the code, you can get it from http://george.hotelling.net/projects/magpie-aggregator-4.5.2.tgz [2] I'm not sure if I'm supposed to create a patch or what, but I needed this for ArborBlogs.com [3] and figured some other people would benefit from it. [1] http://magpierss.sourceforge.net/ [2] http://george.hotelling.net/projects/magpie-aggregator-4.5.2.tgz [3] http://www.arborblogs.com/ ------------------------------------------------------------------------ Tue, 15 Mar 2005 04:04:42 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD.txt (5.46 KB) Very nice. I hacked aggregator.module for 4.6 using your module as a guide...well, frankly by ripping out great chunks of code for my use. ------------------------------------------------------------------------ Thu, 28 Jul 2005 22:21:11 +0000 : Boris Mann Can someone roll a patch for this? Would be a good addition for 4.7 now that Atom is at 1.0. ------------------------------------------------------------------------ Fri, 29 Jul 2005 01:49:42 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/magpie_aggregator.zip (7.87 KB) A patch would require the Magpie include files and wholly restructures the way the feeds are parsed...the Magpie code would handle all the feeds, not just Atom. That said, the attached zip file has the necessary includes and a patch to CVS. ------------------------------------------------------------------------ Fri, 29 Jul 2005 03:36:59 +0000 : Steven Magpie RSS duplicates a lot of functionality that is already in Drupal. We decided a long time ago that we would not use it. Porting Atom parsing into the current aggregator can't be that hard. ------------------------------------------------------------------------ Mon, 01 Aug 2005 16:38:53 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD_0.txt (1.93 KB) Since I'm messing around with the aggregator module anyway... I developed this around Atom 0.3 feeds this weekend, but I don't see anything in Atom 1.0 that should break it. ------------------------------------------------------------------------ Tue, 02 Aug 2005 15:00:50 +0000 : Eaton +1 on that patch. Running it now on my test site and everything looks great. ------------------------------------------------------------------------ Tue, 02 Aug 2005 16:24:54 +0000 : Bèr Kessels a small issue, whe do not use if ($data) $items[$item][$tag] .= $data; please just use if ($data) { $items[$item][$tag] .= $data; } ------------------------------------------------------------------------ Wed, 03 Aug 2005 02:18:54 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_HEAD_1.txt (1.99 KB) Not a problem. Here's the corrections. ------------------------------------------------------------------------ Wed, 03 Aug 2005 16:14:14 +0000 : Dries If this is all it takes to parse Atom feeds (to some extend), I'm all for it. Code looks OK. Set to 'ready to be committed' after some testing. ------------------------------------------------------------------------ Wed, 03 Aug 2005 18:59:20 +0000 : kika anybody up for a testing suite tests? http://intertwingly.net/wiki/pie/FormatTests ------------------------------------------------------------------------ Wed, 03 Aug 2005 20:07:37 +0000 : Prometheus6 That would be for the Atom module. ------------------------------------------------------------------------ Wed, 03 Aug 2005 23:36:04 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_CVS.txt (2.35 KB) Because the aggregator would always gather enough information todownload an Atom feed, the previous patch focused on parsing items/entries correctly. This patch adds more complete parsing of the feed's channel data (site link, subtitle/description, logo). Now all the feed and item fields will be properly updated. ------------------------------------------------------------------------ Mon, 08 Aug 2005 16:00:22 +0000 : Prometheus6 The content of the Atom feed's id and info tags were being displayed as part of the feed's description on the aggregator pages. With this patch those tags are recognized and discarded. The "blog it" link is also added to the aggregator page items in addition to the block. ------------------------------------------------------------------------ Mon, 08 Aug 2005 16:01:55 +0000 : Prometheus6 Attachment: http://drupal.org/files/issues/AGGREGATOR_ATOM_CVS_0.txt (3.69 KB) Let's try that with the patch this time...

1 0

[drupal-devel] [bug] RSS feed should use created date, not updated date
by Dries 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/23750 Post a follow up: http://drupal.org/project/comments/add/23750 Project: Drupal Version: 4.6.0 Component: node.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: jerakeen Updated by: Dries Status: patch (code needs review) Committed to HEAD and DRUPAL-4-6. Dries Previous comments: ------------------------------------------------------------------------ Fri, 27 May 2005 16:53:50 +0000 : jerakeen Attachment: http://drupal.org/files/issues/created_date_not_updated_date.patch (592 bytes) The pubDate in the RSS feed should use the node creation timestamp to set the pubDate, not the node updated timestamp. This might be the same as http://drupal.org/node/20368, but that issue isn't in the node component, and I don't want to jump to conclusions. Trivial patch attached. ------------------------------------------------------------------------ Tue, 09 Aug 2005 19:04:17 +0000 : killes(a)www.drop.org It's a patch.

1 0

[drupal-devel] [bug] Duplicate entry 'locale:pl' for key 1 query: INSERT INTO cache
by katin 11 Aug '05

11 Aug '05

Issue status update for http://drupal.org/node/21568 Post a follow up: http://drupal.org/project/comments/add/21568 Project: Drupal -Version: 4.6.0 +Version: 4.5.2 Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Cvbge Updated by: katin -Status: closed +Status: patch (code needs review) I fixed it by changing some logic in bootstrap.inc. The function is cache_set(): (I tried to post the actual code here inside <code> tags, but kept getting 'Terminated request because of suspicious input data.' and all my text would be lost. After a dozen tries moving code tags, trimming lines, etc., I give up. You'll have to go look at the code yourself.) The logic in this function is: UPDATE record if (!db_affected_rows()) then INSERT the record I found a clue to why this logic would fail in the PHP manual, mysql_affected_rows page: (http://us2.php.net/manual/en/function.mysql-affected-rows.php) " When using UPDATE, MySQL will not update columns where the new value is the same as the old value. This creates the possibility that mysql_affected_rows() may not actually equal the number of rows matched, only the number of rows that were literally affected by the query. The REPLACE statement first deletes the record with the same primary key and then inserts the new record. This function returns the number of deleted records plus the number of inserted records. " That would mean that if the record specified in the UPDATE line is already in the db exactly as so, mysql_affected_rows() would return zero, and the logic then tries to INSERT the record - which will throw the error because it already exists. Therefore, change the INSERT to a REPLACE and the logic will work fine for duplicate as well as changed cache entries. The error messages stop. (Again, tried to post code samples here for the fixed line... couldn't get past the 'suspicious data' errors... I had no disallowed tags... really annoying.) Background: MySQL ver 4.1.11 PHP ver 4.3.11 Drupal version 4.6.2 Linux platform I suspect the exact behaviour of mysql_affected_rows() in relation to the UPDATE function may differ in different versions of mysql (3.23 to 4.1, for example). katin Previous comments: ------------------------------------------------------------------------ Fri, 29 Apr 2005 07:01:29 +0000 : Cvbge Sometimes I'm getting following errors: (I'm not sure what triggers it, or what's the cause - I suppose it's localization or image module, maybe albums...) Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Duplicate entry 'locale:pl' for key 1 query: INSERT INTO cache (cid, data, created, expire, headers) VALUES ('locale:pl', 'a:1652:{s:15:\"Download method\";b:1;s:49:\"Public - files are available using http directly.\";b:1;s:42:\"Private - files are transferred by Drupal.\";b:1;s:20:\"File system settings\";b:1;s:34:\"Select an image processing toolkit\";b:1;s:14:\"Image handling\";b:1;s:23:\"Configurable time zones\";b:1;s:17:\"Short date format\";b:1;s:33:\"The short format of date display.\";b:1;s:18:\"Medium date format\";b:1;s:30:\"The medium sized date display.\";b:1;s:16:\"Long date format\";b:1;s:45:\"Longer date format used for detailed display.\";b:1;s:45:\"The first day of the week for calendar views.\";b:1;s:62:\"Only JPEG, PNG and GIF images are allowed to be used as logos.\";b:1;s:66:\"Check here if you want the theme to use the logo supplied in /home/www-data/izoo/includes/database.mysql.inc on line 66. Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Duplicate entry 'locale:en' for key 1 query: INSERT INTO cache (cid, data, created, expire, headers) VALUES ('locale:en', 'a:1652:{s:15:\"Download method\";b:1;s:49:\"Public - files are available using http directly.\";b:1;s:42:\"Private - files are transferred by Drupal.\";b:1;s:20:\"File system settings\";b:1;s:34:\"Select an image processing toolkit\";b:1;s:14:\"Image handling\";b:1;s:23:\"Configurable time zones\";b:1;s:17:\"Short date format\";b:1;s:33:\"The short format of date display.\";b:1;s:18:\"Medium date format\";b:1;s:30:\"The medium sized date display.\";b:1;s:16:\"Long date format\";b:1;s:45:\"Longer date format used for detailed display.\";b:1;s:45:\"The first day of the week for calendar views.\";b:1;s:62:\"Only JPEG, PNG and GIF images are allowed to be used as logos.\";b:1;s:66:\"Check here if you want the theme to use the logo supplied in /home/www-data/izoo/includes/database.mysql.inc on line 66. Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Cannot modify header information - headers already sent by (output started at /home/www-data/izoo/includes/common.inc:384) in /home/www-data/izoo/includes/file.inc on line 437. Location /system/files?file=images/zaulek_onanistow.thumbnail.jpg Wiadomość Cannot modify header information - headers already sent by (output started at /home/www-data/izoo/includes/common.inc:384) in /home/www-data/izoo/includes/file.inc on line 437. ------------------------------------------------------------------------ Sun, 05 Jun 2005 06:34:59 +0000 : chx This is fixed in HEAD. If you want, you may change the mysql_connect line by adding ,2 after TRUE. ------------------------------------------------------------------------ Fri, 29 Jul 2005 05:42:57 +0000 : bslade Could this related to the issue (bug) "improved cache api - race conditions"? ( http://drupal.org/node/1811 [1] ) Ben in DC PublicMailbox at benslade dot com [1] http://drupal.org/node/1811

1 0

[drupal-devel] Release critical bugs for August 11, 2005
by drupal-devel＠drupal.org 11 Aug '05

11 Aug '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 29 weeks 4 days url: http://drupal.org/node/15654 / feature requests Site Slogan Margin age: 4 days 2 hours url: http://drupal.org/node/28382 / bug reports Free Tagging broken on forums age: 18 hours 25 min url: http://drupal.org/node/28607 Installation error: Call to undefined function age: 3 days 9 hours url: http://drupal.org/node/28414 404 sites shown twice age: 1 week 2 days url: http://drupal.org/node/27990 js addLoadEvent not working. age: 1 week 4 days url: http://drupal.org/node/27884 Forum bug with drupal 462 age: 1 week 6 days url: http://drupal.org/node/27663 enable MySQL client side for UTF8 age: 3 weeks 2 days url: http://drupal.org/node/26990 Drupal 4.6.2 Doesn't allow login (IIS 5.1, PHP 5.0.4) assigned: bigeye age: 3 weeks 5 days url: http://drupal.org/node/26780 Problem in the 4.6.2 upgrade - node.module age: 5 weeks 2 days url: http://drupal.org/node/26342 postgresql autocomplete code age: 6 weeks 9 hours url: http://drupal.org/node/26027 Accidentally Deleting Forums Vocabulary in Categories Breaks Forums? age: 9 weeks 5 days url: http://drupal.org/node/24274 Taxonomy Multiple Hierarchy doesn't display children for all its parent age: 10 weeks 1 day url: http://drupal.org/node/24023 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 12 weeks 3 days url: http://drupal.org/node/22911 database table "term_node" not updated when removing a term from a node under editing and submitting age: 17 weeks 2 days url: http://drupal.org/node/20315 Reassigning a node to a different term does not work properly age: 17 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 18 weeks 4 days url: http://drupal.org/node/19874 New submit error, non-admin user, postgresql database assigned: adrian age: 22 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 25 weeks 14 hours url: http://drupal.org/node/17428 Change to sesssion.inc violates UID database constraint age: 29 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 30 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 30 weeks 2 days url: http://drupal.org/node/15399 Argument NOT must be type boolean age: 38 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 42 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 43 weeks 6 days url: http://drupal.org/node/11366 Fatal error: Call to undefined function: drupal_set_html_head() age: 50 weeks 1 day url: http://drupal.org/node/10317 user error: Duplicate entry assigned: Kjartan age: 1 year 35 weeks url: http://drupal.org/node/4428 / feature requests Filter the title to allow HTML comments age: 2 weeks 6 days url: http://drupal.org/node/27205 Novel Module Creation Request age: 8 weeks 3 days url: http://drupal.org/node/24856 moving pages en masse age: 18 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 22 weeks 13 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 24 weeks 2 days url: http://drupal.org/node/17663 Allow named anchors to work without specifying full path to node age: 1 year 37 weeks url: http://drupal.org/node/4213 / support requests blocks age: 7 weeks 2 days url: http://drupal.org/node/25378 Problem with Forums age: 30 weeks 5 days url: http://drupal.org/node/15299 / bug reports search over fields.inc fields conceptual error age: 40 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 40 weeks 6 days url: http://drupal.org/node/12257 / feature requests event.module support of repeating/recurring events? assigned: thehunmonkgroup age: 1 year 38 weeks url: http://drupal.org/node/4122 / bug reports Menu item not showing age: 44 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 45 weeks url: http://drupal.org/node/3001 / bug reports file size bug age: 8 weeks 5 days url: http://drupal.org/node/24728 / bug reports gallery bug - not integrated in drupal assigned: vidy age: 21 hours 54 min url: http://drupal.org/node/28598 gallery.module doesn't synch passwords when they're changed age: 1 week 6 days url: http://drupal.org/node/27702 Full screen slideshow in Gallery module is not working (erroring out on the wrong URL) age: 5 weeks 9 hours url: http://drupal.org/node/26479 Drupal session being logged out each time gallery module is called age: 6 weeks 6 days url: http://drupal.org/node/25614 Gallery error age: 15 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 20 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 20 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 21 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 24 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 23 weeks 4 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 21 weeks url: http://drupal.org/node/6392 / bug reports image module fails on dual site configuration age: 4 weeks 5 hours url: http://drupal.org/node/26657 Editing a previously uploaded and thumnailed image loses the thumbnail. age: 7 weeks 1 day url: http://drupal.org/node/25465 Cannot upload .jpgs age: 23 weeks 3 days url: http://drupal.org/node/18076 Image.Module does not know the correct filename age: 38 weeks 1 day url: http://drupal.org/node/13032 / feature requests Can't Upload a Whole Directory in 4.6.0 age: 1 day 11 hours url: http://drupal.org/node/28542 / support requests Images are there but not showing assigned: Stepfordtwit age: 2 weeks 13 hours url: http://drupal.org/node/27615 Image Module Permissions age: 5 weeks 3 days url: http://drupal.org/node/26280 path problems on upgrading... age: 14 weeks 3 days url: http://drupal.org/node/21725 / bug reports RSS "no element found at line 1" age: 5 weeks 5 days url: http://drupal.org/node/26185 Outdated help texts age: 1 year 1 week url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 1 year 10 weeks url: http://drupal.org/node/8128 / tasks move XML-parser into an inclde file. age: 7 weeks 1 day url: http://drupal.org/node/25439 / feature requests Notify.module ignores the true submission queue age: 1 year 41 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 19 weeks url: http://drupal.org/node/6795 / bug reports Reminder email links don't work age: 6 weeks 5 days url: http://drupal.org/node/25677 / bug reports access control problems age: 2 weeks 5 days url: http://drupal.org/node/27273 Download link is wrong age: 7 weeks 2 days url: http://drupal.org/node/25363 Projects not listed and page not complete age: 10 weeks 2 days url: http://drupal.org/node/23956 Date for latest is incorrect age: 17 weeks 49 min url: http://drupal.org/node/20485 Invalid link to release files age: 24 weeks 3 days url: http://drupal.org/node/17625 Node body not complete w/o releases age: 26 weeks 6 days url: http://drupal.org/node/16733 blank page after install age: 27 weeks 1 day url: http://drupal.org/node/16575 / support requests Help with everything - nothing seems to work in the latest build age: 37 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 13 weeks 1 day url: http://drupal.org/node/22520 / feature requests Request to generate email for all content changes/additions, including comments age: 3 weeks 4 days url: http://drupal.org/node/26824 / bug reports javascrip downloads square.gif for every category age: 25 weeks 1 day url: http://drupal.org/node/17366

1 0

[drupal-devel] Release critical bugs for August 11, 2005
by drupal-devel＠drupal.org 11 Aug '05

11 Aug '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 29 weeks 4 days url: http://drupal.org/node/15654 / feature requests Site Slogan Margin age: 4 days 2 hours url: http://drupal.org/node/28382 / bug reports Free Tagging broken on forums age: 18 hours 25 min url: http://drupal.org/node/28607 Installation error: Call to undefined function age: 3 days 9 hours url: http://drupal.org/node/28414 404 sites shown twice age: 1 week 2 days url: http://drupal.org/node/27990 js addLoadEvent not working. age: 1 week 4 days url: http://drupal.org/node/27884 Forum bug with drupal 462 age: 1 week 6 days url: http://drupal.org/node/27663 enable MySQL client side for UTF8 age: 3 weeks 2 days url: http://drupal.org/node/26990 Drupal 4.6.2 Doesn't allow login (IIS 5.1, PHP 5.0.4) assigned: bigeye age: 3 weeks 5 days url: http://drupal.org/node/26780 Problem in the 4.6.2 upgrade - node.module age: 5 weeks 2 days url: http://drupal.org/node/26342 postgresql autocomplete code age: 6 weeks 9 hours url: http://drupal.org/node/26027 Accidentally Deleting Forums Vocabulary in Categories Breaks Forums? age: 9 weeks 5 days url: http://drupal.org/node/24274 Taxonomy Multiple Hierarchy doesn't display children for all its parent age: 10 weeks 1 day url: http://drupal.org/node/24023 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 12 weeks 3 days url: http://drupal.org/node/22911 database table "term_node" not updated when removing a term from a node under editing and submitting age: 17 weeks 2 days url: http://drupal.org/node/20315 Reassigning a node to a different term does not work properly age: 17 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 18 weeks 4 days url: http://drupal.org/node/19874 New submit error, non-admin user, postgresql database assigned: adrian age: 22 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 25 weeks 14 hours url: http://drupal.org/node/17428 Change to sesssion.inc violates UID database constraint age: 29 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 30 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 30 weeks 2 days url: http://drupal.org/node/15399 Argument NOT must be type boolean age: 38 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 42 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 43 weeks 6 days url: http://drupal.org/node/11366 Fatal error: Call to undefined function: drupal_set_html_head() age: 50 weeks 1 day url: http://drupal.org/node/10317 user error: Duplicate entry assigned: Kjartan age: 1 year 35 weeks url: http://drupal.org/node/4428 / feature requests Filter the title to allow HTML comments age: 2 weeks 6 days url: http://drupal.org/node/27205 Novel Module Creation Request age: 8 weeks 3 days url: http://drupal.org/node/24856 moving pages en masse age: 18 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 22 weeks 13 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 24 weeks 2 days url: http://drupal.org/node/17663 Allow named anchors to work without specifying full path to node age: 1 year 37 weeks url: http://drupal.org/node/4213 / support requests blocks age: 7 weeks 2 days url: http://drupal.org/node/25378 Problem with Forums age: 30 weeks 5 days url: http://drupal.org/node/15299 / bug reports search over fields.inc fields conceptual error age: 40 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 40 weeks 6 days url: http://drupal.org/node/12257 / feature requests event.module support of repeating/recurring events? assigned: thehunmonkgroup age: 1 year 38 weeks url: http://drupal.org/node/4122 / bug reports Menu item not showing age: 44 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 45 weeks url: http://drupal.org/node/3001 / bug reports file size bug age: 8 weeks 5 days url: http://drupal.org/node/24728 / bug reports gallery bug - not integrated in drupal assigned: vidy age: 21 hours 54 min url: http://drupal.org/node/28598 gallery.module doesn't synch passwords when they're changed age: 1 week 6 days url: http://drupal.org/node/27702 Full screen slideshow in Gallery module is not working (erroring out on the wrong URL) age: 5 weeks 9 hours url: http://drupal.org/node/26479 Drupal session being logged out each time gallery module is called age: 6 weeks 6 days url: http://drupal.org/node/25614 Gallery error age: 15 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 20 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 20 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 21 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 24 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 23 weeks 4 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 21 weeks url: http://drupal.org/node/6392 / bug reports image module fails on dual site configuration age: 4 weeks 5 hours url: http://drupal.org/node/26657 Editing a previously uploaded and thumnailed image loses the thumbnail. age: 7 weeks 1 day url: http://drupal.org/node/25465 Cannot upload .jpgs age: 23 weeks 3 days url: http://drupal.org/node/18076 Image.Module does not know the correct filename age: 38 weeks 1 day url: http://drupal.org/node/13032 / feature requests Can't Upload a Whole Directory in 4.6.0 age: 1 day 11 hours url: http://drupal.org/node/28542 / support requests Images are there but not showing assigned: Stepfordtwit age: 2 weeks 13 hours url: http://drupal.org/node/27615 Image Module Permissions age: 5 weeks 3 days url: http://drupal.org/node/26280 path problems on upgrading... age: 14 weeks 3 days url: http://drupal.org/node/21725 / bug reports RSS "no element found at line 1" age: 5 weeks 5 days url: http://drupal.org/node/26185 Outdated help texts age: 1 year 1 week url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 1 year 10 weeks url: http://drupal.org/node/8128 / tasks move XML-parser into an inclde file. age: 7 weeks 1 day url: http://drupal.org/node/25439 / feature requests Notify.module ignores the true submission queue age: 1 year 41 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 19 weeks url: http://drupal.org/node/6795 / bug reports Reminder email links don't work age: 6 weeks 5 days url: http://drupal.org/node/25677 / bug reports access control problems age: 2 weeks 5 days url: http://drupal.org/node/27273 Download link is wrong age: 7 weeks 2 days url: http://drupal.org/node/25363 Projects not listed and page not complete age: 10 weeks 2 days url: http://drupal.org/node/23956 Date for latest is incorrect age: 17 weeks 49 min url: http://drupal.org/node/20485 Invalid link to release files age: 24 weeks 3 days url: http://drupal.org/node/17625 Node body not complete w/o releases age: 26 weeks 6 days url: http://drupal.org/node/16733 blank page after install age: 27 weeks 1 day url: http://drupal.org/node/16575 / support requests Help with everything - nothing seems to work in the latest build age: 37 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 13 weeks 1 day url: http://drupal.org/node/22520 / feature requests Request to generate email for all content changes/additions, including comments age: 3 weeks 4 days url: http://drupal.org/node/26824 / bug reports javascrip downloads square.gif for every category age: 25 weeks 1 day url: http://drupal.org/node/17366

1 0