September 2005 - Development - lists.drupal.org

[drupal-devel] [bug] cannot connect to DB
by beginner 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: beginner -Status: patch (ready to be committed) +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.3.patch (560 bytes) grrr.... Did I say I was a beginner? I was diffing against the already modified file. This patch should be the good one (either that or expect to have a flood of support request when drupal 4.7 comes out!). beginner Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:22:23 +0000 : Prometheus6 Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?> ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:52:41 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.patch (562 bytes) Thanks Prometheus6. here's a proper patch on includes/database.mysql.inc tested on local (php 4.3.x) and remote (php 4.2.x). ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:56:09 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.2.patch (560 bytes) Am I doing things the wrong way round?? (I am beginner, and new to this diff thing!) here's the negative of the previous one...

1 0

[drupal-devel] [bug] cannot connect to DB
by beginner 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: beginner Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.2.patch (560 bytes) Am I doing things the wrong way round?? (I am beginner, and new to this diff thing!) here's the negative of the previous one... beginner Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:22:23 +0000 : Prometheus6 Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?> ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:52:41 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.patch (562 bytes) Thanks Prometheus6. here's a proper patch on includes/database.mysql.inc tested on local (php 4.3.x) and remote (php 4.2.x).

1 0

[drupal-devel] [bug] cannot connect to DB
by beginner 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: beginner -Status: patch (code needs work) +Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.patch (562 bytes) Thanks Prometheus6. here's a proper patch on includes/database.mysql.inc tested on local (php 4.3.x) and remote (php 4.2.x). beginner Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:22:23 +0000 : Prometheus6 Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?>

1 0

[drupal-devel] [bug] cannot connect to DB
by Prometheus6 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: Prometheus6 Status: patch (code needs work) Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?> Prometheus6 Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B.

1 0

[drupal-devel] [bug] cannot connect to DB
by beginner 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: beginner -Status: active +Status: patch (code needs work) I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. beginner Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3.

1 0

[drupal-devel] [bug] function format_date uses gmdate() incorrectly
by killes 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/29681 Post a follow up: http://drupal.org/project/comments/add/29681 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: thehunmonkgroup Reported by: thehunmonkgroup Updated by: killes(a)www.drop.org -Status: patch (code needs review) +Status: patch (ready to be committed) I think it is obvious that the display function is overcorrecting. At the top of the function we correct for Drupal server time or user tz and then wwe later again shift the zone. print date('D, M jS, G:i', time()-date('Z')); print gmdate('D, M jS, G:i', time()); this code gives the same for me and shows that the timestmap is further modified. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Thu, 25 Aug 2005 22:04:51 +0000 : thehunmonkgroup Attachment: http://drupal.org/files/issues/format_date.patch (817 bytes) function format_date in common.inc is using gmdate() incorrectly. the function is trying to format a local timestamp, and GMT conversion is incorrect in this case. date() should be used instead. bug also exists in 4.6, and this patch should apply there, too. haven't checked the earlier versions of drupal... ------------------------------------------------------------------------ Sat, 27 Aug 2005 04:47:39 +0000 : thehunmonkgroup switching to patch status ------------------------------------------------------------------------ Sat, 03 Sep 2005 23:05:37 +0000 : clydefrog Are you sure about the logic here? I've tried to fix timezone issues before, and I always get confused. My reading of the documentation makes me think your patch is wrong: If the timestamp has already been converted to a localized time, then gmdate() should be used because gmdate() does no timezone adjustments (it does not care what PHP's timezone settings are). Using date() is incorrect because it does care what PHP's timezone settings are. ------------------------------------------------------------------------ Sun, 04 Sep 2005 04:21:12 +0000 : thehunmonkgroup i'm fairly certain that my logic is correct here. the php doc on gmdate() is not totally clear, but i think that if you read it over closely, you'll see that it's the other way around--gmdate() is actually the one that adjusts the timestamp passed. i would recommend writing some short scripts to test out how gmdate() and date() actually operate(that's what i had to do!)--i think you'll see that what happens is gmdate() takes the timestamp passed, applies the server timezone offset, and returns the (formatted) result as GMT. that's what my tests have shown, and for the format_date function, this operation is incorrect--the goal of the function is to simply make the timestamp passed into a human-readable date. no adjustment is necessary.

1 0

[drupal-devel] Stop Anonymous users from even reaching a page and generating warnings
by Peter Atkins 10 Sep '05

10 Sep '05

My site requires that all user are Authenticated and I'm looking for a way to stop Anonymous users from even reaching a page and generating the following error. access denied 2005-09-09 15:39 node/755 denied access. Anonymous Is there a build method for doing this with Drupal or do I need to create something custom? Thanks for you help! Access Manager: This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Dissemination, distribution or copying of this e-mail or the information herein by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is prohibited. If you have received this e-mail in error, please immediately notify us by calling the Help Desk at (310) 482-4200.

2 1

[drupal-devel] Permission Denied Errors
by Peter Atkins 10 Sep '05

10 Sep '05

I'm getting "permission denied "from drupal on pages that I refresh multiple times. Sometimes it works sometimes it doesn't. Anyone have any thoughts? -p

1 0

[drupal-devel] [feature] MySQLi support
by nsk 09 Sep '05

09 Sep '05

Issue status update for http://drupal.org/node/29910 Post a follow up: http://drupal.org/project/comments/add/29910 Project: Drupal Version: cvs Component: database system Category: feature requests Priority: critical Assigned to: Anonymous Reported by: nsk Updated by: nsk Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/nskpatch.tar.bz2 (4.14 KB) I added MySQLi support to Drupal by adding a database.mysqli.inc file. After chx's suggestion I also removed $row from db_result from both mysqli and mysql files. Users are supposed to connect to Drupal with a mysqli "URL" in their settings.php. Just adding an "i" in the mysql entry in settings.php would work. MySQLi is the new MySQL client in PHP which connects to MySQL 4.1, 5.0 and beyond. MySQLi replaces the older MySQL library which was popular with MySQL 3.23 and 4.0. http://gr.php.net/manual/en/ref.mysqli.php The older MySQL client does not support full functionality with MySQL 4.1, that's why MySQLi is important. MySQLi works in PHP 4.1.3 or above, and is more popular in PHP 5. MySQLi means MySQL Improved. This patch should be included in core. nsk

14 67

[drupal-devel] [bug] Can't delete subjects with '&' in title
by Souvent22 09 Sep '05

09 Sep '05

Issue status update for http://drupal.org/node/27140 Post a follow up: http://drupal.org/project/comments/add/27140 Project: Drupal Version: cvs Component: contact.module Category: bug reports Priority: normal Assigned to: Souvent22 Reported by: m3avrck Updated by: Souvent22 Status: patch (code needs review) Attachment: http://drupal.org/files/issues/contact_full_1.patch (6.23 KB) Got the postgres correct this time. No temp table needed. Souvent22 Previous comments: ------------------------------------------------------------------------ Wed, 20 Jul 2005 14:57:03 +0000 : m3avrck Using the site-wide contact forms, any subjects with an '&' cannot be deleted. Clicking delete for these subjects brings up the expected action flow, however, confirming the delete does nothing. Subject still exists. ------------------------------------------------------------------------ Mon, 25 Jul 2005 13:45:38 +0000 : m3avrck It appears this issue might be linked with this one: http://drupal.org/node/23685 A problem with mod_rewrite and not the actual contact module. ------------------------------------------------------------------------ Wed, 31 Aug 2005 16:51:56 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/contact.module_6.patch (4.7 KB) Redid how contacts work. It now references contacts by ID instead of their category as the unique identifier. It also allows for contacts to have weights, so that one may control where the contact will appear in the listing. ------------------------------------------------------------------------ Wed, 31 Aug 2005 16:53:01 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/updates.inc (27.23 KB) This is the update.inc for the database cahnges that goes along with this patch. ------------------------------------------------------------------------ Wed, 31 Aug 2005 18:31:37 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/contact.module_7.patch (4.5 KB) Updated patch. ------------------------------------------------------------------------ Wed, 31 Aug 2005 18:31:55 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/updates.inc_4.patch (1.29 KB) Updated database patch. ------------------------------------------------------------------------ Sat, 03 Sep 2005 16:17:21 +0000 : Cvbge Hi, 0. You should keep all changes in one file, i.e. pake one patch, not patch for every file 1. You should include changes for database/database.{mysql,pgsql} 2. IIRC auto_increment was depreciated, you should use db_next_id() (but I see auto_increment in cvs...) 3. You use "WHERE cid = '%s'", but cid is integer so this should probably be %d (although this probably would not break anything..) ------------------------------------------------------------------------ Wed, 07 Sep 2005 17:31:21 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/contact_full.patch (6.38 KB) Ok, I've taken your suggestions in, and i think I have it this time. Let me know if this is a correct format for a patch. This only fixes the bug of not being able to delete special characters. ------------------------------------------------------------------------ Wed, 07 Sep 2005 17:37:30 +0000 : m3avrck Check your database updates, the UNIQUE fields don't look right syntactically. ------------------------------------------------------------------------ Wed, 07 Sep 2005 18:23:07 +0000 : Souvent22 Attachment: http://drupal.org/files/issues/contact_full_0.patch (6.25 KB) Ok, i apologize for the last upload. Pleasle ignore. I send the wrong file. :-[. Anyway, here's a tested, tried, and correct patch. ------------------------------------------------------------------------ Wed, 07 Sep 2005 18:26:33 +0000 : m3avrck +1 patch works great! Latest HEAD version applied with update.php works great, modifies database correctly for MySQL (and PostgreSQL looks correct as well) and contacts can now be deleted if they have '&' in the subject. Also, dumped entire database and created from modified database.mysql and everything works great. I'd say this patch is ready to be committed! ------------------------------------------------------------------------ Wed, 07 Sep 2005 21:44:47 +0000 : Cvbge Hi, patch does not applies to currect cvs anymore. For the database.pgsql you need to remove (11) from int(11) and also first "category" from UNIQUE line, so it looks like this: CREATE TABLE contact ( cid int NOT NULL, category varchar(255) NOT NULL default '', recipients text NOT NULL default '', reply text NOT NULL default '', UNIQUE (category), PRIMARY KEY (cid) ); The updates are also not compatibile with postgres, but postgres upgrade path is completly broken in cvs and I'll fix it later, so do not pay attention to it. ------------------------------------------------------------------------ Thu, 08 Sep 2005 13:05:54 +0000 : Souvent22 Hello. Thanks for the feedback. I'm in the middle of fixing it, but i have a question. You'll have to excuse my ignorance with PostGres, I'm not as familiar with it as I am MySQL. With that said, I have a question..... I am trying to make my update where one does not lose data. However, in PostGres, I have to make a seperate "temp" table before hand and then copy the date over the the new table (cause i don't know the exact name of the constraint to drop e.g. the primary key). Basically I'm asking if there is a better suggestion in which I doint have to use a temp table, and i could just manipulate the original table? Thanks. ------------------------------------------------------------------------ Thu, 08 Sep 2005 13:12:35 +0000 : Souvent22 Also, I created a temp name for my temp table. However, for prefix purposes, should I enclose it? Example: $temp_name = rand(); $res = db_query("SELECT * FROM $temp_name"); or $temp_name = rand(); $res = db_query("SELECT * FROM {$temp_name}"); Thanks. ------------------------------------------------------------------------ Thu, 08 Sep 2005 13:55:40 +0000 : Souvent22 Clarification: $temp_name = rand(); db_query("CREATE TABLE $temp_name AS SELECT * FROM {contact}"); $res = db_query("SELECT * FROM $temp_name"); or $temp_name = rand(); db_query("CREATE TABLE {$temp_name} AS SELECT * FROM {contact}"); $res = db_query("SELECT * FROM {$temp_name}"); ------------------------------------------------------------------------ Thu, 08 Sep 2005 17:52:06 +0000 : Cvbge "cause i don't know the exact name of the constraint to drop e.g. the primary key " Yes, you know it, it's tablename_pkey. In this case it's contact_pkey. You can drop it by dropping index with it's name (you could drop constraint with it's name but it was not available in 7.2) Adding a column and adding unique attribute is also doable without temp table. You can look at (some) previous updates. But some of them are incorrect ;) By saying that I'll fix it later I meant that I want to introduce function to modify tables and don't want to make temporary fixes now. ------------------------------------------------------------------------ Thu, 08 Sep 2005 19:47:08 +0000 : Souvent22 Thanks. yes, you're right. didn't know if that was universal across the board though since that'st he default, but someone could give their primary key constraint a diff. name. But, with your comment, I'll wait and let you take care of fixing my pgsql portion of my patch. Thanks for your comments though, really helpful...and not confusing. :).

1 0