September 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Extend access control options
by timcn 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30711 Post a follow up: http://drupal.org/project/comments/add/30711 Project: Drupal Version: 4.6.3 Component: node.module Category: feature requests Priority: normal Assigned to: timcn Reported by: timcn Updated by: timcn Status: patch (code needs review) Attachment: http://drupal.org/files/issues/node_33.patch (8.24 KB) Unfortunately you can only give a role permission to "access content" and/or "administer nodes". But often, this does not suffice. You want editors to be able to browse the nodes in the "content" section and for example allow them to make a node sticky. But you don't want them to delete a node or change it's visibility. My patch offers the following permissions: * access content * administer nodes * change revision setting * delete nodes * make nodes sticky * moderate nodes * promote nodes It does also really check if the user is allowed to perform a certain action and deny it if that is not the case. It does also hide the specified checkboxes and options from the dropdown box. The patch is for 4.6.3 but should also work with HEAD. timcn

6 7

[drupal-devel] [feature] OPML Import for Aggregator
by arnabdotorg 10 Sep '05

10 Sep '05

Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: arnabdotorg Reported by: arnabdotorg Updated by: arnabdotorg Status: patch Attachment: http://drupal.org/files/issues/import_opml.patch (3.96 KB) The aggregator supports OPML export for all feeds, but not import. This patch enables import of OPML lists, allowing people to import lists of RSS feeds they've already assembled in another RSS app. Demo: http://arnab.drupaldevs.org/aggregator Patch: http://arnab.drupaldevs.org/tmp/import_opml.patch arnabdotorg -- View: http://drupal.org/node/16282 Edit: http://drupal.org/project/comments/add/16282

5 6

Re: [drupal-devel] Stop Anonymous users from even reaching a page and generating warnings
by Kobus Myburgh 10 Sep '05

10 Sep '05

Please post these questions to the support list. Post your query to the support list and I will help you with this. Kobus >>> patkins(a)directpartners.com 9/10/2005 12:46:19 AM >>> My site requires that all user are Authenticated and I'm looking for a way to stop Anonymous users from even reaching a page and generating the following error. access denied 2005-09-09 15:39 node/755 denied access. Anonymous Is there a build method for doing this with Drupal or do I need to create something custom? Thanks for you help! Access Manager: This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Dissemination, distribution or copying of this e-mail or the information herein by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is prohibited. If you have received this e-mail in error, please immediately notify us by calling the Help Desk at (310) 482-4200.

1 0

Re: [drupal-devel] Permission Denied Errors
by Kobus Myburgh 10 Sep '05

10 Sep '05

Hi, I remember that you are using Windows, like me. I had to remove .htaccess file to fix this problem. These reports belong to the support list. Please post them there in the future. Kobus >>> patkins(a)directpartners.com 9/10/2005 12:12:25 AM >>> I'm getting "permission denied "from drupal on pages that I refresh multiple times. Sometimes it works sometimes it doesn't. Anyone have any thoughts? -p

1 0

Re: [drupal-devel] Drupal on Windows...having issues
by Kobus Myburgh 10 Sep '05

10 Sep '05

Hi, I have no benchmarks, but I am running several Drupal sites on Windows and several on Linux. The only issue I had was that I had to remove the .htaccess file that comes with Drupal, but otherwise none. Speed also okay. Regards, Kobus >>> patkins(a)directpartners.com 9/9/2005 6:48:46 PM >>> I'm a Linux guy trying to run Drupal on Windows 2k Server. Not a choice I have control over. I'm having some serious performance issues and need some help. Are there benchmarks for Drupal on various platforms? If so where would I find that information. Anyone know if Drupal can run on windows with decent performance? Anything will help. Cheers!

1 0

[drupal-devel] [bug] comment preview "Required" is easily bypassed
by Zed Pobre 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/28420 Post a follow up: http://drupal.org/project/comments/add/28420 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Jeremy(a)kerneltrap.org Reported by: Jeremy(a)kerneltrap.org Updated by: Zed Pobre Status: patch (code needs review) This patch is against HEAD? It doesn't want to apply to my 2.6.3 comment.module. Zed Pobre Previous comments: ------------------------------------------------------------------------ Mon, 08 Aug 2005 01:55:34 +0000 : Jeremy(a)kerneltrap.org Setting "Preview comment" to "Required" does not strictly require that the comment be previewed first. This is being abused by spammers to quickly and efficiently post spam comments. I discovered this after I added a new feature to my new spam module [1] to auto-blacklist spammer IP addresses, allowing me to block comment spammers when they preview a comment and thus preventing them from ever inserting their spam into my database. I configured my comment module to "require" comment previews, and yet found that the comments were slipping past my filter. I finally realized what the spammer is doing is setting $_POST['op'] to 'Post comment', effectively bypassing the preview phase. I'm currently looking for a clean solution to this. At the moment the only idea I have is to generate a token at the preview phase, and validate the token at the post phase. Unfortunately the token would have to be stored in the databse between the preview and the post, which adds overhead. Alternatively, I've considered using a time-based hash which would constantly update depending on the time of day. This could easily be validated without storing anything in the database. If too long has gone between the preview and the post, an additional preview step would be required... The down side here is that the time-based hash would be publically available, and thus the spammer could easily duplicate it in their script. A private key could solve for that, but increases the complexity as it adds a configuration step. I have the feeling I'm missing a simpler, cleaner solution. Suggestions? [1] http://kerneltrap.org/jeremy/drupal/spam/ ------------------------------------------------------------------------ Mon, 08 Aug 2005 02:26:21 +0000 : moshe weitzman even if you get this fixed, won't these bots just add a preview step? this 'preview required' feature is designed to maintain high quality submissions by forcing users to proof read. it isn;t designed for security. i think you want to hook into comment_validate(). just add a hook here - there is already a hook_comment() waiting for you to add an operation. ------------------------------------------------------------------------ Mon, 08 Aug 2005 08:49:30 +0000 : Eaton I posted a patch a few days ago (http://drupal.org/node/28255) that adds validation and form construction hooks for comments. It's similar to the one that the captcha module uses, though it adds comment form_pre and form_post hooks instead of a single comment form hook. ------------------------------------------------------------------------ Mon, 08 Aug 2005 13:30:34 +0000 : Jeremy(a)kerneltrap.org Attachment: http://drupal.org/files/issues/comment.module_11.patch (2.5 KB) > even if you get this fixed, won't these bots just add a preview step? Eventually, yes, but it drastically changes their ability to fling spam at a site. As is, they simply have a script that shoots data out at high speed without having to wait for messages to return from the server. It is the server that is doing all the work, thus making it simple for a spammer to DoS a site. If "preview required" really meant "preview required", they would be forced to first automate clicking "preview", and then wait for a response before clicking "submit". This requires more resources on their side, and allows us to add delays after clicking "preview" (if we detect that they are a spammer) further using their resources. > this 'preview required' feature is designed to maintain high quality > submissions by forcing users to proof read. it isn;t designed for security. Regardless of the intention, I was misled to believe that configuring my site to require previews would require that all comments were first previewed. As a site administrator, I would prefer to know that "required" really means "required". > i think you want to hook into comment_validate(). just add a hook here - > there is already a hook_comment() waiting for you to add an operation. Yes and no. Ultimately yes that will work and will allow my spam module to prevent the spam from ever being posted. But it still leaves the greatest burden on the web server, instead of on the spammer. The spammer can still use a very simple script that only pushes data, and thus can generate spam at an unbelievable rapid rate. Here is an example patch to enforce "preview required". It's one idea, I'm sure there are better ones. ------------------------------------------------------------------------ Mon, 08 Aug 2005 14:01:38 +0000 : Jeremy(a)kerneltrap.org Attachment: http://drupal.org/files/issues/comment.module_12.patch (1.4 KB) Here's a second version of the patch that doesn't require any manual configuration. ------------------------------------------------------------------------ Mon, 08 Aug 2005 16:27:27 +0000 : Jose A Reyero I like this idea, and the patch looks good Still, I think it misses something, like some timestamp related hash, because once you get the hash code you can post multiple comments with that. Another problem I can think of is, what happens when a cron run happens between the preview and the post?? I'm afraid comments would get lost For this second problem, I think a key generated only once after module activation could do. About the first one....mmm... I'll sit down for a while and think..... ------------------------------------------------------------------------ Tue, 09 Aug 2005 12:27:20 +0000 : Jeremy(a)kerneltrap.org Attachment: http://drupal.org/files/issues/comment.module_13.patch (1.33 KB) > I think it misses something, like some timestamp related hash, because > once you get the hash code you can post multiple comments with that. Using a timestamp will mean that the comment form "expires". That is, if you wait too long to preview your comment, it will generate an error when you try to post. Yes, technically a spammer could post one real comment, then based on what was in the session from that they could post the same identical comment over and over, so long as it was attached to the same node. But this is not what they do, they try and spread their spam throughout your webpage. Furthermore, the spam module is perfectly capable of detecting and preventing this. > Another problem I can think of is, what happens when a cron run happens > between the preview and the post?? I'm afraid comments would get lost The key is only generated once, that's what the first test is about. In any case, in the unlikely event that the key were to change between preview and post they would simply have to post a second time. My earlier patch wasn't quite right, I was testing the token in the wrong place. This patch fixes that. BTW: This is beneficial for maintaining high quality submissions too, as prior to this change someone could: 1) enter a comment 2) press preview 3) completely change their comment (introducing a mistake) 4) press submit and the comment (mistake and all) would go into the database unpreviewed After this change: 1) enter a comment 2) press preview 3) completely change their comment (introducing a mistake) 4) press submit and they get an error because they didn't preview their changes - forcing them to preview once after any change ------------------------------------------------------------------------ Wed, 10 Aug 2005 03:50:33 +0000 : Jeremy(a)kerneltrap.org FWIW: I've been getting slammed by spam attacks this whole week. Installing this patch has made a huge difference. Well over 100 spam attempts per minute (sometimes two and three times that) and I hardly notice the spammer, whereas before it was choking my database. (Granted, the spammer has not yet upgraded his script to first preview, then submit. But even if he did it wouldn't help him as testing has verified that the new spam module would prevent the comments from ever getting to the database.) Additionally, user and anonymous (nonspam) comments continue to show up at a normal rate. ------------------------------------------------------------------------ Tue, 16 Aug 2005 14:08:04 +0000 : Jeremy(a)kerneltrap.org I would love to see _any_ discussion on this. Drupal is currently too easy to spam, with little effort on the spammer's side, and lots of resources wasted on the Drupal side. A patch like this will greatly increase the spammer's burden, and make it possible to effectively block even the most aggressive spammer attacks. ------------------------------------------------------------------------ Wed, 17 Aug 2005 16:24:04 +0000 : Jose A Reyero Well, this patch is definitely better than what we have, and would save some spam for sure. But maybe keeping track, at the session level, of generated hashes for a user, and then removing them when the comment is sent, could do the work. This way we can forget about previewing comments or not, and also the "permission" to post the comment would expire when the session expires. Any randomly generated value could do for this, no need for complex hashes, but having nid and pid in the hash would add some extra security. ------------------------------------------------------------------------ Wed, 17 Aug 2005 19:58:02 +0000 : breyten Jeremy, a big +1 on the idea, but why not generate the private key when it is actually needed (Ie, when displaying the comment form), instead of wasting a _cron() hook on it? ------------------------------------------------------------------------ Thu, 18 Aug 2005 03:20:02 +0000 : Jeremy(a)kerneltrap.org > Well, this patch is definitely better than what we have, and would save some spam for sure. It is continuing to work very well on my site, which seems to be under nearly perpetual spam attacks from multiple sources. > But maybe keeping track, at the session level, of generated hashes for a user, and then > removing them when the comment is sent, could do the work. The catch is: the key has to be something unique to the server, not guessable or learnable from the outside Simply storing the hash data in the session alone is not enough, as then the spammer could create any random data and store it in the session. That said, the hash could be generated off something other than the text of the comment as it is now, so that a preview is not required. I'll look at doing something like that and submit another patch. > This way we can forget about previewing comments or not, and also the "permission" to > post the comment would expire when the session expires. Any randomly generated value > could do for this, no need for complex hashes, but having nid and pid in the hash would > add some extra security. nid and pid alone are worthless, as they are easy to learn. The pid can always be 0 (spam is rarely attached to a pre-existing comment). The nid is obtained in the path of where the spam is being posted. The solution is a "private-key", which is what my patch adds. Then sure, hash the private key plus the nid and the pid, and you've got enough protection to prevent most spammers. To make it even more secure, automatic rey-keying could be easily accomplished. ------------------------------------------------------------------------ Thu, 18 Aug 2005 04:09:10 +0000 : Jeremy(a)kerneltrap.org Attachment: http://drupal.org/files/issues/comment.module_15.patch (1.18 KB) The attached patch: 1) gets rid of the _cron() hook 2) no longer requires that comments be previewed Prior to this patch, comment spammers were able to send data to a Drupal server acting as though they'd filled out a comment form and pressed submit. As they didn't actually use the form, they could submit spam comments at an obscene rate. With this patch, comment spammers will have to actually load the form, enter text, and press submit. Yes, that can still be automated, but it takes much more work and slows them down, as they have to wait for the entry form to load each time. Unfortunately a spammer could manually submit one comment, then re-use that same session info over and over to attach repeated spam comments to the same node. Such an attempt would be detected and blocked by the spam module if enabled, but again such a session re-use attack could be done without loading the form each time. Fortunately there is much less gain for a spammer to submit 100 spam comments on the same page, versus submitting 100 spam comments each on a different page as they do now. Ideas to improve upon this concept include: - re-key every day or week, changing the private key regularly to be sure it couldn't ever be permanently cracked - add a key table, and generate a unique key for every comment form. essentially, upon comment form creation generate a random key which is stored both in a database table and in the session. when a comment is submited, look for the key from the session in the database table, if a match is found delete it from the database table and post the comment. this would prevent session re-use, but adds overhead. i don't know if it's worth it, perhaps as an external module if the hooks were available. ------------------------------------------------------------------------ Fri, 19 Aug 2005 18:55:11 +0000 : drumm <?php form_set_error('error', t('Validation error, please be sure cookies are enabled on your browser.')); ?> form_set_error [2]()'s fist argument should be the name of a form field, not 'error.' Using (..., 'error') would be better in this case. And the actual message needs work. Since this is a hidden field I don't think it has anything to do with cookies. [2] http://drupaldocs.org/api/head/function/form_set_error ------------------------------------------------------------------------ Fri, 19 Aug 2005 18:56:41 +0000 : drumm The unclosed link in my last update was supposed to say drupal_set_message(..., 'error') ------------------------------------------------------------------------ Sat, 20 Aug 2005 16:00:15 +0000 : Jeremy(a)kerneltrap.org Attachment: http://drupal.org/files/issues/comment.module_16.patch (1.11 KB) drupal_set_message(..., 'error') isn't sufficient to prevent the comment from being posted. I have instead updated the patch to set the error on the hidden 'token' form field. I have updated the message to read: "Unable to validate your comment, please try again. If this error persists, please contact the site administrator." If you don't like the error message, better suggestions are welcome. ------------------------------------------------------------------------ Fri, 09 Sep 2005 03:16:06 +0000 : Jeremy(a)kerneltrap.org Any feedback on this patch? I have been running it on my website for a couple of weeks, and it has completely stopped the most persistent auto-spam scripts that had been posting poker type comments constantly to my site.

1 0

[drupal-devel] [bug] cannot connect to DB
by Goba 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: Goba Status: patch (code needs review) Well, you can actually vote with your money, and go to a different hosting provider. There are plenty already supporting PHP 4.3+ and PHP 5. Note that the latest stable PHP version in the 4.x family is already 4.4.0! 4.3.0 was released on 27th December 2002, so it is becoming three years old software in no time. Goba Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:22:23 +0000 : Prometheus6 Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?> ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:52:41 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.patch (562 bytes) Thanks Prometheus6. here's a proper patch on includes/database.mysql.inc tested on local (php 4.3.x) and remote (php 4.2.x). ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:56:09 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.2.patch (560 bytes) Am I doing things the wrong way round?? (I am beginner, and new to this diff thing!) here's the negative of the previous one... ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:01:13 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.3.patch (560 bytes) grrr.... Did I say I was a beginner? I was diffing against the already modified file. This patch should be the good one (either that or expect to have a flood of support request when drupal 4.7 comes out!). ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:16:47 +0000 : Goba Well, other parts of Drupal also expect PHP 4.3+ (the search indexing code is one example if I remember well), so if you give the impression at this point that it is fine to run with PHP 4.3-, then other things will probably break. I am not certain though :) ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:30:28 +0000 : Prometheus6 "Thanks Prometheus6. " I decided to play patch bingo. ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:52:24 +0000 : beginner Playing bingo is good! :-D "Well, other parts of Drupal also expect PHP 4.3+ (the search indexing code is one example if I remember well), so if you give the impression at this point that it is fine to run with PHP 4.3-, then other things will probably break. " Goba, Precisely, that's why I said earlier to write a warning in admin/settings about the sub-requirements php version used and let them have a quick idea of what may not work. Currently, I am running http://www.wechange.org/ on drupal cvs (two days ago) and php 4.2.3. Drupal can still work, even if some features can be expected to be broken. I haven't tried search indexing yet, but now I shall know that I cannot use it until I manage to persuade my host to upgrade php (unlikely in the short term!). So, I'd rather use a slightly broken Drupal than no drupal at all! The site admin just needs to be warned (so that they don't flood the forum with support requests). Just let them know in admin/settings what is likely to be broken. OR, if the drupal core developpers are purists and only care about self-hosting drupal users and ignore the mass of users who don't really have a choice, they should at least put a proper warning when failing to connect: <ul> <li>Are you sure you have the correct username and password?</li> <li>Are you sure that you have typed the correct hostname?</li> <li>Are you sure that the database server is running?</li> <li>Are you sure the php version in use is >= 4.3.0? If not, either upgrade php, or if you can't, piss off: Drupal is not for you.</li> </ul> (shall I create a patch for this one? Now I know how to do one!) as I said earlier: it's either that (my patch, or the piss-off message) or expect to have a flood of support request when drupal 4.7 comes out!

1 0

[drupal-devel] [bug] cannot connect to DB
by beginner 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: beginner Status: patch (code needs review) Playing bingo is good! :-D "Well, other parts of Drupal also expect PHP 4.3+ (the search indexing code is one example if I remember well), so if you give the impression at this point that it is fine to run with PHP 4.3-, then other things will probably break. " Goba, Precisely, that's why I said earlier to write a warning in admin/settings about the sub-requirements php version used and let them have a quick idea of what may not work. Currently, I am running http://www.wechange.org/ on drupal cvs (two days ago) and php 4.2.3. Drupal can still work, even if some features can be expected to be broken. I haven't tried search indexing yet, but now I shall know that I cannot use it until I manage to persuade my host to upgrade php (unlikely in the short term!). So, I'd rather use a slightly broken Drupal than no drupal at all! The site admin just needs to be warned (so that they don't flood the forum with support requests). Just let them know in admin/settings what is likely to be broken. OR, if the drupal core developpers are purists and only care about self-hosting drupal users and ignore the mass of users who don't really have a choice, they should at least put a proper warning when failing to connect: <ul> <li>Are you sure you have the correct username and password?</li> <li>Are you sure that you have typed the correct hostname?</li> <li>Are you sure that the database server is running?</li> <li>Are you sure the php version in use is >= 4.3.0? If not, either upgrade php, or if you can't, piss off: Drupal is not for you.</li> </ul> (shall I create a patch for this one? Now I know how to do one!) as I said earlier: it's either that (my patch, or the piss-off message) or expect to have a flood of support request when drupal 4.7 comes out! beginner Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:22:23 +0000 : Prometheus6 Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?> ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:52:41 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.patch (562 bytes) Thanks Prometheus6. here's a proper patch on includes/database.mysql.inc tested on local (php 4.3.x) and remote (php 4.2.x). ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:56:09 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.2.patch (560 bytes) Am I doing things the wrong way round?? (I am beginner, and new to this diff thing!) here's the negative of the previous one... ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:01:13 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.3.patch (560 bytes) grrr.... Did I say I was a beginner? I was diffing against the already modified file. This patch should be the good one (either that or expect to have a flood of support request when drupal 4.7 comes out!). ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:16:47 +0000 : Goba Well, other parts of Drupal also expect PHP 4.3+ (the search indexing code is one example if I remember well), so if you give the impression at this point that it is fine to run with PHP 4.3-, then other things will probably break. I am not certain though :) ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:30:28 +0000 : Prometheus6 "Thanks Prometheus6. " I decided to play patch bingo.

1 0

[drupal-devel] [bug] cannot connect to DB
by Prometheus6 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: Prometheus6 Status: patch (code needs review) "Thanks Prometheus6. " I decided to play patch bingo. Prometheus6 Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:22:23 +0000 : Prometheus6 Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?> ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:52:41 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.patch (562 bytes) Thanks Prometheus6. here's a proper patch on includes/database.mysql.inc tested on local (php 4.3.x) and remote (php 4.2.x). ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:56:09 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.2.patch (560 bytes) Am I doing things the wrong way round?? (I am beginner, and new to this diff thing!) here's the negative of the previous one... ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:01:13 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.3.patch (560 bytes) grrr.... Did I say I was a beginner? I was diffing against the already modified file. This patch should be the good one (either that or expect to have a flood of support request when drupal 4.7 comes out!). ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:16:47 +0000 : Goba Well, other parts of Drupal also expect PHP 4.3+ (the search indexing code is one example if I remember well), so if you give the impression at this point that it is fine to run with PHP 4.3-, then other things will probably break. I am not certain though :)

1 0

[drupal-devel] [bug] cannot connect to DB
by Goba 10 Sep '05

10 Sep '05

Issue status update for http://drupal.org/node/30761 Post a follow up: http://drupal.org/project/comments/add/30761 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: beginner Updated by: Goba Status: patch (code needs review) Well, other parts of Drupal also expect PHP 4.3+ (the search indexing code is one example if I remember well), so if you give the impression at this point that it is fine to run with PHP 4.3-, then other things will probably break. I am not certain though :) Goba Previous comments: ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:11:51 +0000 : beginner Hello, I just downloaded and installed the cvs version. It works on my local system, but it doesn't on the remote host. I checked dozens of time the settings.php password, db, etc... Drupal 4.6 works perfectly at the same host, using the same data base, same user, same password (different prefix only, and different url/domain). I get an empty string as sql error message: The MySQL error was: . "Are you sure you have the correct username and password? " Yes. the same as existing drupal 4.6 install. "Are you sure that you have typed the correct hostname? " Yes. idem. "Are you sure that the database server is running? " Yes. working for other installation. To check that the settings.php was properly uploaded, I changed the username in settings.php and uploaded again: the name changed in the mention at the bottom of the new error page, but the mysql error is still an empty string. I do have a mysql error message if I change the username on my localhost: The MySQL error was: Access denied for user: 'testerror@localhost' (Using password: YES). Currently, the username is testerror and the database server is localhost. ???? ------------------------------------------------------------------------ Fri, 09 Sep 2005 09:58:29 +0000 : beginner If I suppress the @ I have the following error message: Warning: Wrong parameter count for mysql_connect() in .../includes/database.mysql.inc on line 37 which seems strange in this context. I have a - in the database host: out-data.org. Would that affect the parsing of the variable in settings.php? ------------------------------------------------------------------------ Fri, 09 Sep 2005 11:26:00 +0000 : beginner It's definitely a php problem, not mysql settings: we use PHP Version 4.2.3 by replacing the line: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> by its values: <?php $connection = mysql_connect('data.out-data.org', 'user', 'pass', TRUE, 2); ?> I still get the Wrong parameter count for mysql_connect() message... ??? 4.6 works fine on the same host. ------------------------------------------------------------------------ Fri, 09 Sep 2005 13:45:29 +0000 : beginner Drupal 4.6: <?php $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); ?> Drupal cvs: <?php $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); ?> One more parameter has been added. php.net/mysql_connect : php 4.3.0 Added the client_flags parameter. i.e. cvs Drupal and the coming 4.7 version will not work for php versions < 4.3.0. My hosts unfortunately uses 4.2.3. ------------------------------------------------------------------------ Sat, 10 Sep 2005 07:17:54 +0000 : beginner I've seen that the list of requirements states php > 4.3.0, but I guess I won't be the only one to be surprised to see that drupal doesn't work AT ALL (no DB connection) when they upgrade. Yet, by modifying the line above, to make it look like version 4.6, I am able to use drupal cvs on my server with an older php version (I'm on the lookout for other similar bugs). I was trying to add a if loop, checking on the php version used, so that we have: <?php if ($php_version >= 4.3.0){ $connection = @mysql_connect($url['host'], $url['user'], $url['pass'], TRUE, 2); }else{ $connection = mysql_connect($url['host'], $url['user'], $url['pass'], TRUE) or die(mysql_error()); } ?> but I cannot find in the documentation how this variable can be tested. Also, once connected to the data base, a warning in admin/settings can be added about the php version used. Or do you really mean to shut out all the people who depend on the (lack of) will of their host to upgrade php? If so, at the very least, add a list item in the error message to remind people to check for the php version. B. ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:22:23 +0000 : Prometheus6 Here's your test. <?php if (version_compare(phpversion(), '5', '<')) { require_once('amazon.php4.inc'); } else { require_once('amazon.php5.inc'); } ?> ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:52:41 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.patch (562 bytes) Thanks Prometheus6. here's a proper patch on includes/database.mysql.inc tested on local (php 4.3.x) and remote (php 4.2.x). ------------------------------------------------------------------------ Sat, 10 Sep 2005 08:56:09 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.2.patch (560 bytes) Am I doing things the wrong way round?? (I am beginner, and new to this diff thing!) here's the negative of the previous one... ------------------------------------------------------------------------ Sat, 10 Sep 2005 09:01:13 +0000 : beginner Attachment: http://drupal.org/files/issues/db-connect.database.mysql.inc.3.patch (560 bytes) grrr.... Did I say I was a beginner? I was diffing against the already modified file. This patch should be the good one (either that or expect to have a flood of support request when drupal 4.7 comes out!).

1 0