May 2006 - Development - lists.drupal.org

more consistency in theme functions and output concepts.
by Bèr Kessels 12 May '06

12 May '06

Hi there, For my helpers module I am trying to be ACAP (as consistent as possible). And some things I have (not yet) decided on, but which IMO could be very usefull for the codyng guidelines and core: * I filter ONLY in the theme function. That way you can be assured that theme functions get the raw data. Having ONE place, and one way where/how we filter makes it easier to look for sec. issues. 'My rule' is: As soon as we make an HTML string from something, we filter it. Anything that gets HTML programatically is therefore filtered. * t(): on the same level. Only in the theme level do we output t()ed strings. This makes it a lot simpler, because you know that functions and methods pass the original strings along, and that they are only translated in the VERY END. This should also make testing against strings a lot easier. I even found a critical sec. issue that opened the "access control open to the world" because I translated two string similar. * whenever a (theme) function can receive HTML as optional string, that string is NOT translated. eg theme_emtpy_placeholder($message = NULL) will return t('not available'), if no param is passed. But the doxygen states: @param $message: Optional. Provide a translated message string. * Theme functions can call other theme functions. They should do so, at all times if there is a function that formats what they want to output (ie call theme_item_list() instead of internally building up LI strings!). These are merely ideas, and I think we can and should make something simpler or maybe even this as guideline. We can then make sure that all changes to core at least follow these guidelines.

5 11

hook_link - proposal
by Just Justin 11 May '06

11 May '06

Greetings! I'm a fairly new drupal hacker and I must say that for the most part it's been a great experience working with drupal. However, I think hook_link() could really be improved. The problem: Any and all modules can add to $links, which is great. The issue I have is twofold: 1). The links that are added are generally HTML (presentation) rather than straight data. 2). All links are folded into a non-keyed array, so the themes have no idea which links came from which modules. It would be great if instead of this: $links[] = l(t('read more'), "node/$node->nid", array('title' => t('Read the rest of this posting.'), 'class' => 'read-more')); Modules were doing something like this: $links['mymodule'] = array('title' => t('Read the rest of this posting.'), 'url' => "node/$node->nid", 'class' => 'read-more'); And relying on the themes to actually display the link. I'd be happy to help code/patch this up, but I wanted to bounce the idea off of some of you first to get things rolling. It looks like I'm going to need something like this sooner rather than later, but I'd like to at least be hacking the core in such a way that my changes could eventually make it into a release, if this is deemed to be a good path to take. Regards, Justin aka {datura} on irc.

6 6

Re: [consulting] CMS comparison
by Bèr Kessels 11 May '06

11 May '06

This is getting Deve. RElated. We should continue this thread on devel. ML. Op woensdag 10 mei 2006 21:37, schreef Kieran Lal: > Ber, let's make sure we are in sync on a Drupal installer, Drupal > install profiles, and per module configuration forms injection into > the installer. We have completed this work as shown in this video > here: > > http://www.youtube.com/watch?v=COg-orloxlY > > We are just looking for some funding to help cover some of the costs > so we can break it up and work to get these pieces into Drupal 4.8 core. I am getting stuff ready for more attention now :) BZR Check in in launchpad soon to come. Central site/hub w. info and trackers soon to come too. Central (BZR synced) SVN and downloadable tarballs soon to come too. (i need to sort out server stuff/infrastructure for that) First post on where I am and what it is here: http://webschuur.com/node/626 My comment is important too http://webschuur.com/node/626#comment-714 Does CS have a spec or RFC for the install profiles files? Kieran,

1 0

hook_fileapi (file products and download permission)
by Dave Cohen 11 May '06

11 May '06

I'm starting work on an ecommerce module to sell MP3 files. To accomplish this, I'd like to introduce some hooks which the audio.module would invoke, and my ecommerce module would implement. I think the hooks could be applied in other contexts, maybe eventually becoming part of Drupal core. That's why I'm sending this to a large audience. I hope all interested parties will let me know if the direction sounds right. I'd like to start solving my problem immediately, making changes to audio.module and an ecommerce module. But I'm open to other approaches if consensus is that the following ideas need work. SPECIFIC PROBLEM ---------------- I'm creating an ecommerce product to sell access to files, specifically MP3 audio files. While there exists a generic file product in the ecommerce module, the audio module is superior when it comes to MP3s. So, I want to use audio module nodes as my products. The difficulty lies in download permissions. I want only users who have purchased an MP3 to be able to download it. But audio.module controls its own downloads. So how to make audio.module obey my product permissions? GENERAL PROBLEM --------------- In Drupal today there are a handful of modules which deal with the uploading and downloading of files. Examples include upload.module, audio.module and the ecommerce file product. Each of these modules contains it's own functions to handle saving and downloading of files. Each of these modules has overlapping functionality because there is no file management piece of Drupal that meets the needs of all of them. While people are working towards better file management in core, in the 4.7 timeframe we have to accept that many modules will be doing some facet of file management. This is a problem for anyone wishing to develop modules that customize file upload/download behavior. PROPOSAL -------- To solve the problem I propose the following APIs. Any file management module (ie upload.module, audio.module) would have to invoke these hooks to be considered "well behaved". Third-party modules implement the hooks in order to have influence over the file managing modules. The APIs fall into two categories: 1) Notification of file events (uploads, downloads) 2) Grant permission to allow file events. In the APIs, files are identified by a numerical $fid and a string $realm. Together, these combine to form a unique file identifier. In the case of upload.module, each file has an $fid from the files table, and the realm could be 'upload'. In the case of audio.module, each node has one file so the $nid is also the $fid, and the realm would be 'audio'. The file management modules would have to implement logic like this when performing file operations: if (user does not have explicit permission to perform operation) { $result = module_invoke hook_file_access for the operation; if ($result contains TRUE) { perform the operation; module_invoke hook_fileapi; // notify that operation has occurred else do not perform; // (access denied) } else { // user has explicit permission to perform op perform the operation; module_invoke hook_fileapi; // notify that operation has occurred } Here are function signatures for the hooks as I imagine them: /** * hook_fileapi * * This hook is invoked when file events occur. * * @param $fid * A numeric file id * @param $realm * A string, combined with $fid ensures a unique file identification * @param $node * The node, if any, with which the file is associated. * @param $op * The type of event ('upload', 'download', 'update', 'delete') * @param $info * Associative array of file details ('filesize', 'filepath', 'filemime',...) * * @return * Nothing */ function hook_fileapi($fid, $realm, $node, $op, $info) { // third party module code goes here. } /** * hook_file_access * * This hook gives us a chance to allow file operations which would * otherwise not be permitted. * * @param $fid * A numeric file id or NULL if $op is 'upload' * @param $realm * A string, combined with $fid ensures unique file identification * @param $node * The node, if any with which the file is assiciated * @param $op * The type of event ('upload', 'download', 'update', 'delete') * @param $info * Associative array of file details ('filesize', 'filepath', 'filemime',...) * @param $account * The user who may or may not have permission to perform the operation * * @return * TRUE, if and only if the user is allowed to perform the operation */ function hook_file_access($fid, $realm, $node, $op, $info, $account) { // third-party logic here if ($is_allowed) return TRUE; } RELATED READING --------------- http://drupal.org/node/33708 (permissions and audio module) http://groups.drupal.org/file-api (file api discussion on groups.drupal.org) http://dave-cohen.com/node/1045 (my own ideas about Drupal file management) http://dave-cohen.com/node/1050 (creating ecommerce products out of nodes) I realize this is a long post. Thanks for reading.

10 13

new LoginToboggan maintainer
by Chad Phillips -- Apartment Lines 11 May '06

11 May '06

just a quick note to let everyone know that i'll be taking over maintainership of LoginToboggan from jjeff. Apologies to all those folks who have submitted issues recently--my intention is to get completely through the issue queue for the module in the next two weeks! chad (hunmonk)

1 0

hook_foo() vs. nodeapi
by Khalid B 11 May '06

11 May '06

One thing that bothered me for a while is that we almost moved from hook_foo() to foo_nodeapi(), but never completely did so. In some cases we use foo_view(), in others we have a foo_nodeapi() with a switch/case for $op 'view'. I find this to be often inconsistent and confusing. Are there any plans to totally eliminate foo_hook() in favor of nodeapi as we have discussed at one point?

10 19

Themes needing maintainers
by Adrian Rossouw 10 May '06

10 May '06

Over a year ago , I committed some themes that were ported from Wordpress , as a favor to a bunch of designers who Bryght was involved with. Unfortunately I haven't been able to get ahold of the designers, and these themes are now sitting in cvs unmaintained. Could someone please take them off my hands and possibly upgrade them to 4.7. They are pretty basic. They are : Leaf Blix rdc* Green Marinée Gespaa -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com

3 3

new inactive_user.module maintainer
by Dries Knapen 10 May '06

10 May '06

Inactive_user.module (http://drupal.org/node/10435) had been unmaintained since Drupal 4.4 (4.5 and 4.6 branches were never created). After communication with, and permission from the original author (jeremy(a)kerneltrap.org) I took over maintainership of this small but nice to have module. I committed the 4.7 version of the module yesterday. This message is only to let you know that this module is working and maintained again. FYI: The inactive_user module provides Drupal administrators with a way to automatically manage inactive user accounts. This module has two goals: to help keep users coming back to a site by reminding them when they've been away for a configurable period of time, and to cleanup unused accounts. cheers, Dries Knapen

1 0

Egressive Drupal Hosting
by Dave Lane 10 May '06

10 May '06

Hello, I was hoping to have our company, Egressive Limited (http://egressive.com) added to the list of Drupal hosting providers. Blurb: Egressive is a hosting provider based in Christchurch, New Zealand, and specialises in the implementation, customisation, and hosting of Drupal sites - on servers with Apache2/PHP5/MySQL5/PostgreSQL8.1. Egressive offers customised hosting solutions and peerless technical support at a reasonable cost. If you need any further information, please let me know! Kind regards, Dave -- = Dave Lane = Egressive Ltd = dave(a)egressive.com == +64 3 963 3733 = = Linux: it just tastes better == egressive.com == +64 21 229 8147 = = Effusion Group Member = effusiongroup.com = gmail dangerdavelane = = skype me: dangerpossum == Please use open standards: www.w3c.org =

2 1

UNSUBSCRIBE
by fritZ 09 May '06

09 May '06

1 0