August 2006 - Development - lists.drupal.org

Re: [development] Splitting up patches
by Michelle Cox 25 Aug '06

25 Aug '06

On 8/25/2006 10:33:09 AM, Dries Buytaert (dries.buytaert(a)gmail.com) wrote: > I support Neil's case. Recently, there has been a trend to bundle > bug fixes with feature requests (to help the features get in). I see no good coming from devs emulating US congressmen. ;) Michelle

1 0

Re: the hekyr
by Lluc Fitzhenry 25 Aug '06

25 Aug '06

Best s j eIIi t ng w x atch j es at our site R e OL w EX C p ART k IER BRE i ITLIN u G BV m LGAR m I and ma h ny other at n http://www.flowkerpowerfive.com , n , r , g , q Never! I called out, to disguise the fact that a little flicker of sentence to Liokukae. case it were needed. It was.

1 0

Timing for an autocomplete patch ?
by Yves CHEDEMOIS 25 Aug '06

25 Aug '06

Hi, I'd like some advice on a dilemma I'm facing : I'm working on a patch for cck's nodereference that requires adding a feature to core's autocomplete widget (I won't delve into technical context here, my question is about patch submitting strategy - see http://drupal.org/node/62498, more specifically comment 10, for details) I therefore have another patch for core, that is (i think...) ready and functionnal, and I'm not sure what would be the best timing to submit it : - wait until the jQuery migration patch hits core, and submit it against the new jQuery version ? - submit it and have it reviewed now, against current HEAD (old style js libs), and maybe update it along the way if the jQuery thing gets commited ? It fixes what i think is a serious usability issue in cck's nodereference, so ideally I wish it would be added to the 4.7 as well, but that might be against all rules ? Any advice from the guys active on js / jQuery stuff ? Thanks yched

2 2

Re: [development] Timing for an autocomplete patch ?
by Yves CHEDEMOIS 25 Aug '06

25 Aug '06

On 24/08/2006 14:46:00, Moshe Weitzman (weitzman(a)tejasa.com) wrote: > > - submit it and have it reviewed now, against current HEAD (old > > style js libs), and maybe update it along the way if the jQuery thing > > gets commited ? > > this one > > > > > It fixes what i think is a serious usability issue in cck's nodereference, > > so ideally I wish it would be added to the 4.7 as well, but that might be > > against all rules ? > > > > "serious usabilility" is probably OK for 4.7. really, it depends on how well > you can convince other developers, and the maintainer of that branch.

1 0

RE: [development] access control APIs
by Metzler, David 25 Aug '06

25 Aug '06

>Once a node is marked 'faculty only', can the student who marked it still read it? If >so, will faculty realize that at least one student can read it, despite the 'faculty >only' mark? Yes, that's exactly the behaviour I'm looking for. The student and the faculty can read it. I don't think the faculty would have a problem with it, given the context of the site. The beauty of simple_access is that I can rename the access group "faculty and author", and the UI problem is solved. :) I had looked at the node you sent, but I can't quite figure out how to leverage that function to "override" the "owner has priveliges" part of the equation. Maybe I'm just being dense, but it sounds like I can either, implement a node specific interface, or implement a role/group specific interface. Do I store the user ID in the GID field in the node_access table? Or is it safe to fake the group membership just for that node access call? Thanks, Dave

1 0

options in update.php?
by Peter Wolanin 24 Aug '06

24 Aug '06

Is it currently possible to present a form and take user input when they run update.php? Here's the scenario I'm thinking of: For the book module patch I posted about, it would be nice to give users the option to convert the top-level pages in their existing book hierarchy to the new "book" type so that they can immediatediatly ue some of the new features. However, to avoid altering (breaking) site data by default, it seems best that this not be the only or the default option. -Peter

2 1

access control APIs
by Metzler, David 24 Aug '06

24 Aug '06

I've been working up a patch to submit for simple_access. Basically, I'm trying to achieve the concept of letting a student say "only share this node with the faculty ", but of course the students aren't and shouuldn't in the faculty role. I'm sort of stuck. I had no problem modifying simple_access to display all the groups, but reading the API documentation, I'm unclear as to whether there's a hook that will let me override the permissions behavior defined in the node_access table. If I read correctly hook_access only applies to nodes that I define in my module, but I was looking for site wide behavior. Can hook_node_grants be leveraged to do this? It's a little unclear to me from the docs. Is there a different recommended strategy? Dave

2 1

jquery 1.0 release imminent
by Adrian Rossouw 24 Aug '06

24 Aug '06

http://drupal.org/comment/reply/79481/147094#comment-147094 John Ressig commented on Drupal.org about the release being this friday, AND it being dual licensed (GPL+MIT). if this gets in, i might never want to touch 4.7 ever again.

10 16

book module patch
by Peter Wolanin 24 Aug '06

24 Aug '06

I have been working with Augustin (beginner) on a substantial patch for the book module: http://drupal.org/node/65319 Your review of this patch and comments would be highly appreciated, as well as your support for getting this RTBC within the next week.

1 0

Request attention to 4.6 issues
by Fernando Silva 24 Aug '06

24 Aug '06

Hi everyone, I would like to request some attention to the 4.6 issues. Because this queue is almost clear, we only need a small effort to close it. Please everyone, take a look at it and review 1 or 2 patches, marking them as RTBC or else say something. We really need special attention from senior developers also to review CRITICAL patches and commit them. Just one review/commit per day... Thanks, Fernando Silva

1 0