June 2008 - Development - lists.drupal.org

RFC: Drupal pluggable systems
by Larry Garfield 17 Jun '08

17 Jun '08

Recently I've been talking up various ideas for pluggable subsystems in Drupal in IRC and the other usual haunts. Ideas have been percolating in my head, but so far I have been remiss in actually writing them down. Yesterday, however, I had an epiphany to solve the primary issue I was trying to work out, so I present a hopefully workable RFC (for real, not IETF version) for pluggable subsystems in Drupal. For the full write-up, please see: http://www.garfieldtech.com/blog/drupal-handler-rfc In the interests of simplicity, *please* don't reply on the list. Reply on the post above. Thanks. -- Larry Garfield AIM: LOLG42 larry(a)garfieldtech.com ICQ: 6817012 "If nature has made any one thing less susceptible than all others of exclusive property, it is the action of the thinking power called an idea, which an individual may exclusively possess as long as he keeps it to himself; but the moment it is divulged, it forces itself into the possession of every one, and the receiver cannot dispossess himself of it." -- Thomas Jefferson

2 2

Drupal 6.2 theme system standalone
by Bob Pepin 14 Jun '08

14 Jun '08

Hello, I've extracted a couple of functions from drupal 6.2 so I can use drupal themes in my own CMS without using the rest of drupal. It's only been a couple of hours since I started work on this, so this is still all very rough. So far it runs the themes included with drupal (bluemarine, chameleon, garland and pushbutton) and the internet_services theme from the drupal themes site. To play with it, you need to extract the attached file into a directory and copy the include/theme.inc file and the themes/ folder from the drupal distribution into that directory. Bob

15 34

Re: [development] Drupal 6.2 theme system standalone
by Larry Garfield 13 Jun '08

13 Jun '08

Because the code is derived from Drupal, yes, it must be distributed under the GPL if it is distributed. (There is no legal requirement that you distribute your changes at all, just that if you distribute them you do so under the GPL). Other PHP code that interacts with these "extracted subsystems" *is* affected by the GPL as well. Because it is interacting in the same memory space and sharing the same data structures, the combined work is then a derivative work of the extracted subsystem, and therefore the GPL on the extracted subsystem requires that the combined work also be distributed under the GPL if it is distributed. So the sort of API trickery you describe below is irrelevant; the GPL still applies. If you wanted the trickery below to work, you'd need to be using the LGPL, which exists for exactly that purpose. (That is an aside, though, since Drupal is under the GPL only.) In general, as long as the license is followed I have no problem with these "extracted systems". I think they're actually very good for Drupal, because we *should* be making subsystems that are as insulated from each other and loosely coupled as possible. I actually would love to see efforts like this contribute back to Drupal to help make our subsystems even more modular and loosely coupled. I've been seriously considering doing the same to the new database API after it lands for the same reasons; it's cool in its own right, and modularity is a very good thing. --Larry Garfield On Fri, 13 Jun 2008 20:10:43 +0200, "Bob Pepin" <bob.pepin(a)gmail.com> wrote: > Well for now I've put GPL on it, which makes sense cause a lot of what > I have done is simply assembling the drupal functions used by the > theme system into one place. You could even create a script for > extracting those functions from the drupal codebase, which would also > make maintenance easier, maybe something like this even exists > already? Besides, I figured most of the development happening on this > will be improving compatibility with certain themes by either > importing or adding stubs for the extra drupal functions used by them, > which is something where it makes a lot of sense to share > contributions. > > Anyway, I plan on layering a very thin entry point to this library > just on top of the drupal callbacks, so the idea is for example not to > implement any custom cache facility inside this but instead to provide > hooks where you can register your own routines for handling caching > from outside the library. This will hopefully prevent the GPL from > infecting your projects ;) > > But besides, I'd also be interested to know if theoretically I would > be forced to use the GPL in this particular case, so if we've got any > license war veterans in here, feel free to comment. > > On Fri, Jun 13, 2008 at 19:15, Ken Rickard <agentrickard(a)gmail.com> wrote: >> Question for the pseudo lawyers in the room. Does this mean that Bob's > work >> must be GPL'd? >> >> >> On Fri, Jun 13, 2008 at 1:04 PM, Adrian Rossouw <adrian(a)bryght.com> > wrote: >>> >>> On 13 Jun 2008, at 6:59 PM, Matt Galvin wrote: >>> >>>> >>>> Drupal is open source. Anyone is free to use it for what they wish as >>>> long as they share their derivative work. He is sharing his. It may >>>> not be useful for you but it might be for someone. Among other things >>>> Drupal takes PHPTemplate and builds on top of it for theming. What Bob >>>> is doing is not all that different. >>> >>> yeah. tbh, i wrote and tested phptemplate (and formsapi) completely >>> separately >>> from drupal before starting to integrate it. >>> >>> Some of the more recent changes in D6 might make it a bit harder to >>> separate, >>> but it should still be workable. >>> >> >> >> >> -- >> Ken Rickard >> agentrickard(a)gmail.com >> http://ken.therickards.com

1 0

problem rebuild-permissions
by Lluís 13 Jun '08

13 Jun '08

I have problems rebuilding my node_access table (too much nodes...). Increasing my php execution time/memory limit is not an option so I thougth of creating a script which updates one node at a time, and using javascript loads to save the next node (I know making a module with ajax would be more elegant, but not enough time...) It basically recive a nid, load the node, node_access_acquire_grants(), and refresh with the next node. Should it work or it has some problem? thanks <?php if ($_SERVER['REMOTE_ADDR']!='XXX.XXX.XXX.XXX') exit(); //ensure just me can run this script require_once './includes/bootstrap.inc'; drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL); user_authenticate('admin', 'admin'); $actual=db_result(db_query("SELECT nid FROM {node} WHERE nid > %d ORDER BY nid",$_GET['node'])); if ($actual>0) { $sencer=node_load($actual); node_access_acquire_grants($sencer); } ?><html> <head> <script type="text/javascript">  </script> </head> <body <?=($actual>0 ? " onLoad=\"setTimeout('delayer()', 1000)\"" : "") ?>> <?php if ($actual>0) echo "doing...".$actual; else echo "Done"; ?> </body> </html> -- *La felicitat ha de ser compatible, compartible i cooperativa. *Envellim quan els records superen les esperances. *Als llocs desconeguts només s'hi arriba per camins desconeguts. *Abans d'imprimir aquest missatge, pensa en el medi ambient.

2 1

Why function t() arguments are not passed through t() again ?
by Juan Rodriguez 13 Jun '08

13 Jun '08

Hello, I am trying to translate what comes from the following piece of code inside node.module:node_add() .... drupal_set_title(t('Submit @name', array('@name' => $types[$type]->name))); .... Using localization I can translate "Submit @name" to "Enviar @name". The problem is that the node type name is written in english and I can not change that name without breaking a lot of custom pages. I wonder why the previous line is not written this way: ... drupal_set_title(t('Submit @name', array('@name' => t($types[$type]->name)))); ... Another option would be to modify function t(), to automatically pass all arguments through t(). Do you see any problem with modifiying t() ?

3 2

WebCalendar Module
by Daniel Morante 12 Jun '08

12 Jun '08

I've updated the WebCalendar integration module so that is (partly) works with Drupal 6.0 (user accounts are not integrated yet). How would I submit my changes?

2 1

What to do with Drupal FTP?
by Aaron Winborn 12 Jun '08

12 Jun '08

Regarding Drupal FTP at http://drupal.org/project/drupal_ftp I just had a conversation with chx in irc about the status of Drupal FTP, and its possible uses (if completed) for malware, and possible security holes. Particularly in light of the SoC project Plugin Manager, and that I stopped work on the project a year ago, I'm happy to drop the module. However, the concept itself does have some merit, and there are many other uses I can think of other than what's planned for the Plugin Manager. Additionally, I've had a few queries over the months that indicate some developers are actually using the module, although I imagine they're in the minority. The project itself came partly out of the poor file handling that Drupal has had in the past (but will hopefully be fixed with http://drupal.org/node/142995 hint hint...) So my question is what is the best course of action at this point? Currently, the module works, although is incomplete from its original goals. It does currently store the u/p of its designated FTP server, which is a weakness, although it would have to be developed beyond how it is to exploit that weakness. I have no intention in the near term of continuing development of the project, don't plan to upgrade it to Drupal 6, and believe a better approach for remote file handling will emerge for Drupal 7. Should I entirely remove the project? Officially abandon it? Amend or replace the project page with a warning, in case people are actually using it? Ask for a security team audit if we decide to keep it? Thanks, Aaron Winborn

6 8

possible change in xml on update.drupal.org site breaks drush
by Doug Holton 12 Jun '08

12 Jun '08

I wasn't sure if there is a project page for the update.drupal.org site to post this. Was the xml output on that site recently changed? For example with this xml file: http://updates.drupal.org/release-history/lightbox2/5.x The update-status module's xml parser class (I'm using drupal 5.7) removes all information between the </terms> tag and the <releases> tag. That breaks drush because it needs the "default_major" data. Here's an issue with more information: http://drupal.org/node/269444

1 0

node/create inside a tab
by Lluís 11 Jun '08

11 Jun '08

I have created some node types, different views for them, and special forms. Now I want to make a page with tabs to them. Adding views and forms is easy; but I have problems with "add form": $items[] = array('path' => 'comptacau/assentaments/add', 'title' => t('Gestió d\'assentaments'), 'callback' => 'drupal_get_form', 'callback arguments' => 'comptacau_assentament_form', 'access' => true, 'type' => MENU_CALLBACK); This doesn't work; any hint of how to achieve this? Is there a way to make an aliases: comptacau/assentament/add -> node/add/comptacau-assentament? thanks -- *La felicitat ha de ser compatible, compartible i cooperativa. *Envellim quan els records superen les esperances. *Als llocs desconeguts només s'hi arriba per camins desconeguts. *Abans d'imprimir aquest missatge, pensa en el medi ambient.

2 2

Easier PHP4 compatibility for Drupal modules
by Jose A. Reyero 11 Jun '08

11 Jun '08

Hello, It seems many of us -if not most of us- are already developing modules and other stuff using PHP5. As a module maintainer I'm bothered from time to time with "PHP4 compatibility" feature requests and patches that are usually like this one: |if (!function_exists('array_diff_key')) { function array_diff_key() { .... } } |So most of the times, its just a few conditional function definitions that will make the module backwards compatible with PHP4. I'm thinking it would be really nice to have a 'php4' Drupal module that handles these simple cases. Then we can just tell people wanting our modules to work with PHP4 to go and try this other module. This module also wouldn't even need to use conditional function definitions as it is supossed to be enabled only for PHP4 sites so it would be even easier. So.. Anyone? PS: Yes, I know, "why don't you do it yourself?" But a) I am already maintaining a number of modules and I can hardly keep up with the issue queue - I've already added some to the "Abandoned modules" user - and b) I'm not using PHP4 for anything anymore so I won't even be able to test such a module.... So please, someone who needs PHP4 compatibility..... Jose A. Reyero ||

9 9