June 2008 - Development - lists.drupal.org

Code freeze?
by Caleb Gilbert 30 Jun '08

30 Jun '08

Reading this thread has me very excited - what a great decision to extend the code freeze of Drupal 7 for a while! In particular, I enjoyed/share chx's comment that 'Drupal 5/6 is quite good enough to hang-a-reputation-on for some time to come'. Indeed they are. :-) - Caleb OK, we'll postpone the code freeze for now. At this point, I won't make any decisions or promises about when the code freeze will be. I'l revisit this question in a couple months time. On 26 Jun 2008, at 22:02, Laura Scott wrote: >>* The slow uptake of D6 is due mostly to everyone and their brother *>>* taking the opportunity to rewrite their contrib modules at the same *>>* time as upgrading to D6, or right before doing so. Views, Panels, *>>* Project*, CCK, filefield, imagefield, and a half-dozen others have *>>* major improvements planned in contrib space that are progressing; *>>* they just take time. Those, in turn, block dozens of other modules. *>* *>* +1 from a community marketing perspective as well. I'm glad there's *>* general consensus that with the tail wagging the dog, Drupal will *>* benefit from a slowdown so D6 can get established in the marketplace *>* before pushing D7 out. However, I'm -1 on making this a policy *>* towards a new 18-month release cycle. I feel rolling with the flow *>* makes sense. If D8 is coming along well, there will be little to *>* gain by delaying it in the interests of a general slowdown. * -- Dries Buytaert :: http://buytaert.net

2 1

Re: [development] Drupal Function Frequency Report?
by Marjorie Roswell 29 Jun '08

29 Jun '08

I've got both books. Matt, when he signed my copy, looked at all my notes, and said "you've read the heck out of this book!" I have to read it again, as it was my first exposure to Drupal on a "vacation" without a computer. I read every word, but without ever having used drupal before. I should re-read it now that I know something! (I have been referencing it.) I also bought the D6 Packt book, but we're still using version 5, so I need to be careful with that one. All that said, I guess I have an analytic mind, and I do think that getting a function frequency list would actually be a helpful guide. If anyone wants to create such a thing, probably of interest to the community. But I do understand that if I can't do it (and I don't think I can), someone else might not have that same itch. Best, Margie P.S. John, and Angie, et. al.: Looking forward to your respective books. They're destined for my collection the moment they're available!

1 0

Resetting Drupal's menu cache
by Matt Connolly 29 Jun '08

29 Jun '08

Hi all, I've noticed that when you make a change to your MODULE_menu hook, that you need to disable and re-enable the module before the changes are made effective. This is fine for my module because I can do that, but I want to make a change to a core module (for example, make the weight of Logout 1000 so it is always at the bottom). The menu module is a core module and cannot be disabled, so how do I reset this menu cache for core modules? -Matt

7 7

Please do not mark core issues RTBC
by Karoly Negyesi 29 Jun '08

29 Jun '08

unless you ran all tests. Report what you saw -- we have a few know fails right now, but I expect that very soon you will be able to report "all passed". I also ask Dries not to commit unless there is such a report. Thanks to all Karoly Negyesi

1 0

We now have test coverage reports!
by Charlie Gordon 29 Jun '08

29 Jun '08

We have now generated test coverage reports, which are publically available at http://coverage.cwgordon.com/. If you would like the raw data for manipulation, it is available at http://coverage.cwgordon.com/cc.tgz. For those of you who don't want to click links, the essence of the matter is: we have 66.68% test coverage with our current tests. However, we can also learn a lot from these reports, such as which files and functions we need to pay more attention to in our testing. Hopefully this report will prove useful! :) -Charlie

3 5

Code freeze?
by Augustin (Beginner) 27 Jun '08

27 Jun '08

Hi, What is the latest news about the D7 code freeze. I haven't seen any announcement on this list. Do we have a date for the code freeze, or at least a better estimate than what was offered at the beginning of the thaw? thanks, Augustin.

23 31

module_exists vs. functions_exists?
by Greg Knaddison - GVS 26 Jun '08

26 Jun '08

Hi, In building some contrib modules that interact with other modules I often find myself writing something like: if (module_exists('module_name')) { $foo = module_name_api_function($bar); } This seems to be pretty common across core and contrib. I'd even call it standard. Another option would be: if (function_exists('module_name_api_function')) { $foo = module_name_api_function($bar); } The benefit of the second format is that if/when module_name's maintainer decides to rewrite module_name and change all their functions then my module may simply stop interacting with it rather than failing on a function not found error. The benefit of the first format is that it fails quickly and is likely to generate a bug report with a very clear solution. Thoughts? Thanks, Greg -- Greg Knaddison Denver, CO | http://knaddison.com | 303-800-5623 Growing Venture Solutions, LLC | http://growingventuresolutions.com

19 39

Bug in profile.module for new users
by Matt Connolly 26 Jun '08

26 Jun '08

I've discovered a bug that is manifesting itself in the "profile.module" when new users are created via my remote authentication module. My module calls user_external_login_register, which calls user_load which calls user_module_invoke with $type = "insert" which calls profile_user which calls profile_save_profle which calls _profile_get_fields which calls user_access And this is where the problem is. The user is still being created, and calling user_access creates a bad sql query and presents a whole bunch of warnings to the user when their account is created. Attached is a patch, which removes the problem. But I wanted to know whether the problem is really in the profile.module (_profile_get_fields) or in the user.module (user_access) ?? Any thoughts? -Matt

2 1

Extending menu objects to store node translations
by Frank Steiner 26 Jun '08

26 Jun '08

Hi, I would like to discuss if menu objects could be extended to store pointers to a node and all of its translations. Some other people but me would like to see that, too, see http://drupal.org/node/230868 Why could such menus make sense? At our site most stuff is language neutral because as long as we don't have e.g. a translation of the english research site, we show it for all languages. But for the teaching sites, we need english and german versions. But we have nodes with menu entries and those menu entries have children. A menu looks like "Programming Course A" |- Material for Practice 1 |- Material for Practice 2 ... The "Material pages" just contain code snippets or PDFs for download, they don't have lot of text, so they don't have to exist for two languages. The nodes are language neutral. But the "Programming Course A" node contains a lot of explanations so it must exist in english and german. The problem is clear: When I translate this node I must give the translation a new menu item "Programmierung Kurs A" so that a menu item appears when switching the language. But then the whole "Material" subtree is gone for this new menu item. So I would have to create translations for all "Material" nodes, attach the attachments once again and put all those translated nodes below "Programmierung Kurs A". Useless, since the "Material" nodes wouldn't change but just be duplicated. What I would like to have is a menu object that can store pointers to the translated versions of the node it points to, too. Then when swichting the language, the menu system could check if a translated version for the nodes exists and keep showing the menu item. If the menu string was localized, it could display the translated version (as works already). This way, the "Material" subtree would stay because all translated nodes would have the same single menu item. This wouldn't be hard to do. With changing a bit of code in the i18n menu, I already achieved that the menu item changes its href to the path of the translated node, so with translating the menu string, the menu item "Programming Course A" pointing to "node/xx" changed to "Programmierung Kurs A" and points to "node/yy". The only problem: When I'm viewing the translated node, the function menu_tree_page_data in menu.inc rebuilds the tree by searching for the menu object of the node it currently shows. Since the translated node doesn't have an own menu item, menu_tree_page_data shows the "Programming Course A"/"Programmierung Kurs A" item but doesn't unfold its subtree because it doesn't realize it is connected to the current node. I think all that would be neccessary for a conservative extension not destroying anything else was extending the menu object by another array to store the links to the translated nodes. When translating nodes, you could have a checkbox to "reuse the menu item" or sth. menu_tree_page_data would just have to check that array, too, when looking for connections between the currently showing node and the menu system. I consider hacking this for our own site, but I would like to know if there are chances that the menu system could be extended this was for drupal 7. What do you think about the idea? cu, Frank -- Dipl.-Inform. Frank Steiner Web: http://www.bio.ifi.lmu.de/~steiner/ Lehrstuhl f. Bioinformatik Mail: http://www.bio.ifi.lmu.de/~steiner/m/ LMU, Amalienstr. 17 Phone: +49 89 2180-4049 80333 Muenchen, Germany Fax: +49 89 2180-99-4049 * Rekursion kann man erst verstehen, wenn man Rekursion verstanden hat. *

1 0

internal messaging among users for Drupal 6.x?
by zeljko blace 25 Jun '08

25 Jun '08

Hi folks! Not sure if this fits support or development...sorry for cross-posting. What is the logical solution to providing interface for internal messaging among users for Drupal 6.x? I need just basic inbox & outbox view, and compose, reply & forward forms. Is there a specific Module? something being ported from 5.x or made new for 6.x? Regards - Zeljko

3 4