December 2009 - Development - lists.drupal.org

Weird Javascript behavior after form_set_error on Drupal forms
by David Thibault 17 Dec '09

17 Dec '09

Hello all, I'm developing a Drupal-based Purchase Order Management module for my company. The purchase order node form uses a few autocomplete elements as well as other JQuery bits to do a pop-up using blockUI to fill out the PO line items. The PO line item form is hidden by default (display: none). If I skip a required field on the parent Drupal node form (using Drupal's built-in #required => TRUE) then Drupal comes back as expected with the red form_set_error box at the top of the page listing all the required elements I skipped. However, that seems to break much of my Javascript. Here are some specifics: 1) Before the form is submitted the autocomplete fields go look up contacts from my Drupal contacts database (another custom module I've developed), then bring back the selected contact's mailing address and pop it into a div below the autocomplete box. After the form_set_error returns, the autocomplete still looks up the values in the contacts database, but the resulting mailing address is not popped into the div. 2) Before the form is submitted there's a link entitled "Add/Edit/Delete line items" and when clicked it does a blockUI and shows the line items form in the javascript pop-up window above a grayed out screen. After the form_set_error returns, the "Add/Edit/Delete line items" link doesn't block the UI and show the line items form. However, the line items form is displayed on the main parent page (no longer display: none until blockUI as it was before I submitted). I added a javascript alert at the top of $(document).ready() to show when the document is done loading, and it doesn't reappear after the form_set_error comes back, so I'm guessing it's not reloading the page when it does that. However, I'm not sure why it would break all the javascript, or where I could intercept the form submit processing to fix the situation. Any help for ideas of where to troubleshoot this would be appreciate. I'd be happy to post code as well, but it's quite a bit of code so I'll spare you all the details until I get some ideas of where to drill down. Any help would be appreciated. Best, Dave

2 4

Consulting about calendars
by Gastón Pablo Pérez 14 Dec '09

14 Dec '09

Hi! I'm using Drupal 6 and i need to have calendars in which the users will be able to add events, if is possible would be well if this calendars would be able to work with organic groups. Which are the best modules do i have to install to do that? i saw that exist a module named Event, but it is in devel for Drupal 6 Thanks in advance "La perseverancia es un árbol de raíces amargas, pero de frutos muy dulces." Gastón Pablo Perez Email: gpperez(a)gmail.com Web: http://cv.gpperez.com.ar

3 2

Node types in hook_form_alter()
by James Benstead 13 Dec '09

13 Dec '09

I'm writing a module that adds a field to the create/edit forms for nodes of certain types - the actual types can be chosen by the user. There are loads of ways to identify the type of the current node from within hook_form_alter(), but is there an accepted standard way to do it? If I use $form['type']['#value'] I get "Notice: Undefined variable" warnings as my local server's error reporting is very verbose. I know I could change the error reporting level, but surely it's better practice to try and kill the bug? And if I use $form_id I have to use nodetype_node_form and convert it to nodetype - and, as an aside, I can't find a PHP function to do this cleanly. So, what's the accepted way to do this? -- Google Talk/Windows Live Messenger/AIM: james.benstead(a)gmail.com Yahoo! Messenger/Twitter/IRC (Freenode): jim0203 Jabber: jim0203(a)jabber.org // ICQ: 7088050 Skype: jimbenstead

4 5

is drupal a MVC stuff
by sivaji j.g 11 Dec '09

11 Dec '09

I was updating the wikipedia's drupal page with pressflow distribution yesterday, there i observed that drupal is build using MVC design pattern [1]. But i remember my mentor telling me that drupal is NOT based on MVC. Is it changed in the recent version or the person who updated the wiki page has misunderstood the concept. Please enlighten me. Snapshot of the wiki page http://img101.imageshack.us/img101/4592/drupalmvc.png [1] http://en.wikipedia.org/wiki/Drupal#MVC_Framework -- Thanks Sivaji

9 11

Overriding theme function in module for specific case
by Steve Edwards 11 Dec '09

11 Dec '09

I have a module called feature_package.module that embeds the nodequeue_arrange_subqueue_form, and I need to override the theme function for that form (theme_nodeuqueue_arrange_subqueue_form) only when I'm embedding it (i.e. I don't want to override the theme function when the form is being displayed in the admin area). I would also like to do it in the module, and not template.php. so my questions are, how would I implement the function and hook_theme in my module? I've been playing around with various combinations of hook_theme values and function names and haven't been able to get the theme function to be used for the form. For example: function feature_package_theme() { return array( 'nodequeue_arrange_subqueue_form' => array( 'arguments' => array('form' => NULL), 'function' => 'feature_package_nodequeue_arrange_subqueue_form', ), ); } I can see my changes taking place in the theme_registry (by using dsm() inside hook_theme_registry_alter) after clearing cache, so I know that's not the issue. Thanks. Steve

2 2

paging in D7
by Bob Hutchinson 11 Dec '09

11 Dec '09

I'm moving towards upgrading some modules to D7 but cannot figure out how paging works, the function pager_query() has gone in D7, can anyone give me any pointers or examples of how to do this in D7? -- ----------------- Bob Hutchinson Midwales dot com -----------------

2 2

Re: [development] Consolidating duplicate contrib modules for D7
by Marcel Partap 10 Dec '09

10 Dec '09

> If you want to contribute code to a module, do it by providing a patch > in the issue queue. The reasons for this are legion: Yes, that's the accepted standard approach, and it works well ~90% of the time. But that still means there's a _huge_ number of cases where it _does not work very well_. > * The code needs really needs to go through more than one person > before it is released to the public. How exactly do you define 'release to the public'? Commiting code to a development branch used only by developers? Or releasing ready-made quality-inspected module packages? > The issue queue is the appropriate way to handle that. Well yes, it is one feasible way to handle it. > * The maintainer still really should be the only one creating release > tags, Why? > and for that matter is the only one that can edit the project > page and create the release nodes. mmh.. What is the key characteristic of the internet project with the hugest growth rate in the last decade? (*) > * Sometimes a change can be great on the surface but have horrible > consequences. ..ack, had that before ;) > The person who is most likely to know this is the > maintainer, because they have the most experience with that code. Actually - that's bad for core CMS functionality like messaging, file management, payment, workflow, isn't it? Is it not preferable to have a bigger group of people be involved and familiar to such implementations? > Note that core is the extreme of this, with massive interdependence > and 2 committers. Yes, but there are more than two people in the project capable of grokking every commit that goes into drupal core. These two 'just' mostly do the (highly critical!) job of judging code readiness (relying heavily of course on opinions voiced on the report thread), plucking the cherries from that big colourful issue queue tree ;==) > * If anything I'd say this would discourage people from contributing a > module, since other people breaking their code is now a hassle they > have to deal with. Breaking *whose* code? Is this still free software - or just freeware hosted on a common platform? > * This change doesn't solve any real problem (especially eliminating > forks). Not by itself, of course. We shouldn't do software like some politicians do geopolitics (i.e. 'nicht zuende gedacht' ;) > If the maintainer is not doing their job, there is a process > for replacing them. Bureaucreacy (how tf is this spelled **g) to solve problems that wouldn't exist without it, we need more of it. > If that process needs work then fine, but it at > least mostly works when it is used. Might be or not, it is a barrier, putting people off from contributing. And one's persistence to have his work published somewhere on drupal.org might not be correlated to that work's quality (means good sh1t might - instead of automagically being supported - lay stale = double plus bad).. regards, marcel. * hint: anyone can change any article in wikipedia, anonymously and instantly. That's a NULL height entry barrier. -- GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT! Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01

7 13

Convention for accessing global variables
by Brian Vuyk 10 Dec '09

10 Dec '09

Obviously, there are two ways to access global variables. 1. Via the global keyword: <?php global $user; print $user->uid; ?> 2. By accessing the $GLOBALS array directly: <?php print $GLOBALS['user']->uid; ?> Is there an established convention for this within Drupal core? The majority of cases in HEAD use the global keyword (~470) instead of accessing the $GLOBALS array (~40 cases). Is this something that should be made a coding style issue for consistency across the codebase? As a sidenote, accessing the $GLOBALS array directly in on average 25% faster than using the global keyword. Of course, both run fast enough that the difference is hardly noticeable. Brian Vuyk

3 3

Style's stuff
by Gustavo Cabral 10 Dec '09

10 Dec '09

Hello everyone: I need to change the look of certain pages, ie I have installed the organic group, and only I want to change the appearance of any content generated by this module with CSS. How can I differentiate them from other content? I know I have to change or rename the file page.tpl.php, but I do not know what I need to put as file name. I am a rookie in styles, forgive me. Thank you very much. I appreciate their support. Gustavo .-

3 2

consulting about user maps
by Gastón Pablo Pérez 09 Dec '09

09 Dec '09

Hi! I'm using Drupal 6 and i want to add something to view in the user profile a map (gmap if it's posible) with her/his location. how can i do that? I would like to edit a particular user and add data for example the street phone city, country, etc. Also it would be well if i would be able to relate several users to the same location. thanks in advance. Gastón Pablo Perez Email: gpperez(a)gmail.com Web: http://cv.gpperez.com.ar

2 1