January 2010 - Development - lists.drupal.org

the better approach to split $content output on page.tpl.php file(D6)
by Wang Zi Feng 19 Jan '10

19 Jan '10

hi, here is a rookie question. I want to split $content output before it were return by page callback function which declared by hook_menu, so that allow me to print directly $content_top and $content_main at page.tpl.php file. Meanwhile, $content_top and $content_main were generated by different function. I found 2 approach to make it happen, First one is using modulename_preprocess_page to declare variables before it were passed to template file. It works fine. e.g. $var['$content_top']=function_name(); Second one is that split the content into many blocks, taking the advantages of block visibility setting option to control the appearance of regions based on the '?q=' path.It works fine too. Any one know better approach to solve the problem? Thanks Wang

2 1

replacement for $custom_theme in D7
by Markus Kalkbrenner 15 Jan '10

15 Jan '10

Hi! Today's release of the first alpha version of Drupal 7 motivated me to have a deeper look at the code in order to start porting ThemeKey to Drupal 7. I already know that the global variable $custom_theme doesn't exist anymore. But if I look at the code, some patches that went into Drupal 7 and (most important) the still pending patches in the issue queue it seems to me that the corresponding feature in Drupal 7 is not ready yet. What ThemeKey for Drupal 6 does is to set $custom_theme in it's implementation of hook_init(). I already have an idea how to do something similar in Drupal 7. But is there a recommended or official way to that? see http://drupal.org/project/themekey see http://drupal.org/node/670828 Markus mkalkbrenner http://drupal.org/user/124705

2 2

The Status and Future of the Body Field
by Shai Gluskin 15 Jan '10

15 Jan '10

I'm working on a "What's New" in D7 screencast and I'm having trouble figuring out the body field and what a best practice would be. A quick review leads me to the following conclusion: The body field is a legacy of a pre-fields-in-core Drupal. I can understand, for ease of upgrading, why the body field might remain in the node_revisions table. But this is what I don't get: Why is the body field still there when you create a *new* content-type the body field is still there on the content-type edit screen. If you want to add a "long text with summary" field you should just go to, "Manage Fields", choose "Text" and then "Long text with summary." I understand that upgraded existing content-types with body fields will still need to be edited. But shouldn't there be a way to edit existing body fields from updated content types without presenting the body field in the legacy manner when creating new content-types? Shai

3 4

Different default local task in tabs?
by Zhang Xiao 15 Jan '10

15 Jan '10

Hi, In my case I have menu entries like: user/123/feedback user/123/feedback/add user/123/feedback/received user/123/feedback/sent 1) is MENU_LOCAL_TASK, it displays in primary tabs and is called "Feedback" 2) is MENU_DEFAULT_LOCAL_TASK, it displays in secondary tabs and is called "Add" 3) and 4) are MENU_LOCAL_TASK, they display in secondary tabs called "Received" and "Sent" 1) and 2) go to same page - a form where current user can leave a feedback for user #123. BUT the user #123 CANNOT leave a feedback for him/herself. 3) lists feedbacks #123 has received while 4) lists feedbacks #123 has sent for others. Both are only visible for user #123 him/herself. the problem now is when #123 go to his/her profile, primary tab "Feedback" is not visible because the form page is denied. So he/she cannot see all sub tabs include "Received" and "Sent". How can I set different default local task so when user goes to own profile page, "Received" tab will be active by default instead of "Add"? Thanks! x.

1 0

Creating embedded unordered lists of checkboxes
by Steve Edwards 15 Jan '10

15 Jan '10

I have a need to create a two-level unordered list of checkboxes from a two level taxonomy vocabulary. So for instance, if my vocabulary is - Level 1 term 1 -- Level 2 term 1 -- Level 2 term 2 -- Level 2 term 3 - Level 1 term 2 -- Level 2 term 4 -- Level 2 term 5 - Level 1 term 3 I want to create the following: <ul> <li><input type = checkbox">Level 1 term 1</li> <ul> <li><input type = checkbox">.Level 2 term 1</li> <li><input type = checkbox">Level 2 term 2</li> <li><input type = checkbox">Level 2 term 3</li> </ul> <li><input type = checkbox">Level 1 term 2</li> <ul> <li><input type = checkbox">Level 2 term 4</li> <li><input type = checkbox">Level 2 term 5</li> <ul> <li><input type = checkbox">Level 1 term 3<li> </ul> What is the best way to do this? Just use a checkboxes element type and create my own theme function for the form? Modify something like theme_item_list? Or is there a better (and easier) way that I'm missing? What I tried doing was to create a theme function for my checkboxes element by setting the #theme property for the element to my custom theme function (and registering the function in hook_theme). I then just made a copy of theme_checkboxes() (and theme_form_element since it's called from theme_form_checkboxes) and renamed to match hook_theme and the #theme property. However, when doing that, none of my checkboxes are rendered at all. On stepping through the code, I found the problem in drupal_render starting at line 2868: if (!isset($elements['#children'])) { $children = element_children($elements); // Render all the children that use a theme function. if (isset($elements['#theme']) && empty($elements['#theme_used'])) { $elements['#theme_used'] = TRUE; $previous = array(); foreach (array('#value', '#type', '#prefix', '#suffix') as $key) { $previous[$key] = isset($elements[$key]) ? $elements[$key] : NULL; } // If we rendered a single element, then we will skip the renderer. if (empty($children)) { $elements['#printed'] = TRUE; } else { $elements['#value'] = ''; } $elements['#type'] = 'markup'; unset($elements['#prefix'], $elements['#suffix']); $content = theme($elements['#theme'], $elements); foreach (array('#value', '#type', '#prefix', '#suffix') as $key) { $elements[$key] = isset($previous[$key]) ? $previous[$key] : NULL; } } // Render each of the children using drupal_render and concatenate them. if (!isset($content) || $content === '') { foreach ($children as $key) { $content .= drupal_render($elements[$key]); } } } So basically, because I have #theme set for the checkboxes field, it skips the rendering of the individual checkbox elements. To me, it makes sense that I override the theme function for the checkboxes type since that's the element type, but that doesn't seem to be the case. So what do I need to do to be able to simply theme my checkboxes element? Thanks. Steve

3 6

So confused about arg(...)
by Nancy Wichmann 15 Jan '10

15 Jan '10

I'm working on a hook_preprocess_page and it seems to be behaving strangely. I have: drupal_set_message('stuff '. arg(0) . '/' . arg(1)); $variables['nancy'] = $hook . arg(0) . '/' . arg(1); In exactly that order, with no intervening lines. Displaying the variable in the page.tpl.php shows "page taxonomy/term" but the message shows "stuff r/ms" (even if I refresh the page, or clear the cache). How can this be happening? Nancy E. Wichmann, PMP Injustice anywhere is a threat to justice everywhere. -- Dr. Martin L. King, Jr.

5 7

No reaction on security mails?
by Markus Kalkbrenner 14 Jan '10

14 Jan '10

Hi! We discovered a critical security issue in Drupal 6 Core and wrote a mail about it to security(a)drupal.org more than two weeks ago. (2009-12-27) The only reaction so far was an auto response mail from security-bounces(a)drupal.org the next day telling "All e-mails sent to us are read by a member of the team and acted upon if necessary." Now I'm not sure how to continue. Does it take more than two weeks to read through the mails and I just have to wait or is my message lost? Markus mkalkbrenner http://drupal.org/user/124705

4 4

cck filefield related question
by luca capra 14 Jan '10

14 Jan '10

Hi, probably I'm in the wrong place but I try to ask.. I'm using hook_form_alter to present a special form to anonymous users in D6. I got unlimited upload for a cck image field, but I would to limit to 1 for unauthenticated user. I've found this un-answered question in the cck issue queue: http://drupal.org/node/530828#comment-2288010 Should I maybe play with the submit hook? Thanks in advice, Luca

1 0

Creating a user and assigning a node in the node's submit callback.
by Brian Vuyk 13 Jan '10

13 Jan '10

Hi all. I've been trying to get a bit of code working, and I would appreciate a set of eyes. Basically, I have a content type ('profile') which has fields for user account details. If they are filled out, and a 'Create account' checkbox is checked, a user account is created with those details, and the profile node should be assigned to the newly-created user instead of the user creating the node. The issue is that, while the new user is created properly in the submit hook, the last line in the submit callback where I override the 'uid' value from the form values doesn't work - the node just saves with the user's uid instead of the uid of the new account that is specified on the last line. Does anyone have any idea how to make this work? Thank you in advance for anyone that can suggest a solution! Brian <?php function mymodule_form_profile_node_form_alter(&$form, &$form_state) { // Add our submit handler. We use array_unshift to prepend it, as we want it // to execute before the regular node form submit handler. array_unshift($form['buttons']['submit']['#submit'], 'mymodule_profile_form_submit'); } // Submit the user account creation fields in the profile_node_form. function mymodule_profile_form_submit($form, &$form_state) { // Create the user account. if ($form_state['values']['create']) { $account['name'] = $form_state['values']['username']; $account['mail'] = $form_state['values']['mail']; $account['pass'] = $form_state['values']['pass']; $account['status'] = 1; $account = user_save(array(), $account); // Now set the uid of the profile node to be owned by this new account. $form_state['values']['uid'] = $account->uid; } } ?>

5 9

Problem I am unable to locate
by Cory Gilliam 13 Jan '10

13 Jan '10

*Starting a new module and cant find the solution for this problem. I am trying to check the admin settings page for the module, and I am getting this error: Invalid argument supplied for foreach()* in * /home/dangerou/public_html/includes/menu.inc* on line *258*. Here is the code in the .module: function time_card_menu() { $items['admin/settings/time_card'] = array( 'title' => 'Time card settings', 'description' => 'Change how time card behave.', 'page callback' => 'drupal_get_form', 'page arguments' => array('time_card_admin_settings'), 'access arguments' => array('administer site configuration'), 'type' => MENU_NORMAL_ITEM, 'file' => 'time_card.admin.inc', ); return $items; } Here is the code in the .inc: function time_card_admin_settings() { $options = array('weekly' => 'Weekly'); $form['time_card_pay_periods'] = array( '#type' => 'checkboxes', '#title' => t('Your Pay Period is:'), '#options' => $options, '#default_value' => variable_get('time_card_pay_periods', array('weekly')), '#description' => t('This will tell the system how many weeks of information to collect for hour totals.'), ); return system_settings_form($form); } What is it that I am not seeing.

3 2