January 2011 - Development - lists.drupal.org

Id is not passing
by mahesh gajabar 11 Jan '11

11 Jan '11

Hi I have wrote a module for despalying my database table data into html format table. I have delete and edit button infront of every button. delete function is working fine. Code is as below *<?php* *function doctor_menu() {* * $items = array();* * * * $items['doctor'] = array(* * 'title' => t('Doctors'),* * 'page callback' => 'doctors_list',* * 'access arguments' => array('access doctor'),* * 'type' => MENU_NORMAL_ITEM,* * );* * * * $items['doctor/delete/%doctor_user'] = array(* * 'title' => t('Delete doctor'),* * 'page callback' => 'drupal_get_form',* * 'page arguments' => array('doctor_delete_confirm', 2),* * 'access arguments' => array('access doctor'),* * 'type' => MENU_CALLBACK,* * );* * * * $items['doctor/edit/form'] = array(* * 'title' => t('doctor'),* * 'page callback' => 'drupal_get_form',* * 'page arguments' => array('doctor_page',2),* * 'access arguments' => array('access doctor'),* * 'type' => MENU_NORMAL_ITEM,* * );* *$items['doctor/edit/%doctor_user'] = array(* * 'title' => t('Edit Form'),* * 'page callback' => 'drupal_get_form',* * 'page arguments' => array('doctor_edit_confirm', 2),* * 'access arguments' => array('access doctor'),* * 'type' => MENU_NORMAL_ITEM,* * );* * return $items;* *}* *function doctors_list() {* * $header = array(t('Doctor Name'), t('Gender'), t('Status'), t('Action'));* * * * $query = "SELECT * FROM {doctor}";* * $rs = db_query($query);* * * * $row = array();* * * * if ($rs) {* * while ($data = db_fetch_object($rs)) {* * $gender = $data->gender;* * $status = $data->status ;* * $row[] = array(stripslashes(ucwords($data->firstname)) . ' ' . stripslashes(ucwords($data->lastname)), $gender, $status, * * "<a href='doctor/edit/{$data->doctorid}'>" . t('Edit') . "</a> | <a href='doctor/delete/{$data->doctorid}'>" . t('Delete') . "</a>");* * }* * }* * * * $str .= theme_table($header, $row);* * * * return $str;* *}* *function doctor_user_load($doctorid) {* * $query = "SELECT * FROM {doctor} WHERE doctorid = %d";* * $rs = db_query($query, $doctorid);* * * * if ($rs) {* * while ($data = db_fetch_object($rs)) {* * return $data;* * }* * }* * * * return FALSE;* *}* *function doctor_delete_confirm(&$form_state, $doctor) {* * $form['_doctor'] = array(* * '#type' => 'value',* * '#value' => $doctor,* * );* * * * return confirm_form($form,* * t('Are you sure you want to delete this doctor?'),* * isset($_GET['destination']) ? $_GET['destination'] : "doctor",* * t('This action cannot be undone.'),* * t('Delete'),* * t('Cancel'));* *}* *function doctor_delete_confirm_submit($form, &$form_state) {* * $form_values = $form_state['values'];* * * * if ($form_state['values']['confirm']) {* * $doctor = $form_state['values']['_doctor'];* * * * $query = "DELETE FROM {doctor} where doctorid=$doctor->doctorid";* * $rs = db_query($query);* * * * //doctor_delete($form_state['values'], $doctor->doctorid); * * * * drupal_set_message(t('Doctor has been deleted successfully.'));* * }* * * * drupal_goto("doctor");* *}* *function doctor_edit_confirm(&$form_state,$doctor){* * $form = array();* *$form['_doctor'] = array(* * '#type' => 'value',* * '#value' => $doctor,* * );* * $form['firstname']=array(* * '#title'=>t('First Name'),* * '#type'=>'textfield',* * //'#prefix'=>'<table class="formtable"><tr><td class="labeltext">First Name</td><td class="textbox">',* * '#suffix'=>'</td></tr>',* * );* *$form['lastname']=array(* * '#title'=>t('Last Name'),* * '#type'=>'textfield',* * '#default_value' => $lastname,* * );* *$form['gender']=array(* * '#title'=>t('Gender'),* * '#type'=>'radios',* * * * '#options' => array(t('male'), t('female')),* * '#default_value' => male,* * );* *$form['status']=array(* * '#title'=>t('Status'),* * '#type'=>'radios',* * '#default_value' => active,* * '#options' => array(t('active'), t('inactive')),* * * * );* * * *return confirm_form($form,t(''),* * isset($_GET['destination']) ? $_GET['destination'] : "doctor",* * t(''),* * t('Edit'),* * t('Cancel'));* *}* *function doctor_edit_confirm_submit($form, &$form_state)* *{* *if ($form_state['values']['confirm']) {* *$doctor = $form_state['values']['_doctors'];* * $firstname = $form_state['values']['firstname'];* * $lastname = $form_state['values']['lastname'];* * $gender1= $form_state['values']['gender'];* *$gender = $gender1 ? t('female') : t('male');* * $status1 = $form_state['values']['status'];* *$status = $status1 ? t('inactive') : t('active');* *$query = "UPDATE {doctor} SET firstname = '$firstname', lastname= '$lastname', gender = '$gender', status = '$status' WHERE doctorid=$doctor->doctorid";* * $rs = db_query($query); * * * * }* *drupal_goto("doctor");* *}* when i put hardcoded value infront of doctorid like doctorid=2 then its getting edited after i click on edit button but when i paasing it using varible and clicking edit button then its showing following error where firstname ->anitha,lastname->abc are the values i enetering in form while editing. *user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: UPDATE doctor SET firstname = 'anitha', lastname= 'abc', gender = 'female', status = 'inactive' WHERE doctorid= in D:\FR-Server\Apache2\htdocs\fr\sites\all\Modules\doctor\doctor.module on line 157.* my html table on drupal screen Doctor NameGenderStatusAction Mahesh Gajabarmaleinactive Edit<http://localhost/fr/doctor/edit/1>| Delete <http://localhost/fr/doctor/delete/1> Anitha PatilfemaleactiveEdit<http://localhost/fr/doctor/edit/2>| Delete <http://localhost/fr/doctor/delete/2> Pavithra MfemaleactiveEdit<http://localhost/fr/doctor/edit/3>| Delete <http://localhost/fr/doctor/delete/3> Ravi MandayammaleactiveEdit<http://localhost/fr/doctor/edit/4>| Delete <http://localhost/fr/doctor/delete/4> edit form : First Name: Last Name: Gender: male female Status: active inactive Cancel <http://localhost/fr/doctor> Please help me how i can pass that doctorid and also help me for getting default values in form when i click edit button in table. *MAHESH GAJABAR Software Developer FrontalRain Technologies,Bengaluru*

2 1

Issue priority
by Steven Jones 11 Jan '11

11 Jan '11

Hello Drupal developers, With automated testing, Drupal 7 has had the policy that a failing test would be a sufficient condition for the related issue to be marked as 'critical'. This was according to the handbook page that describes the meaning of the issue priorities: http://drupal.org/node/45111 However, this was not true. Drupal 7 was released with several tests that failed, but only in the secondary testing environments notably: PostgreSQL and SQLite on Linux. They passed in the primary testing environment of MySQL + Linux. I think that this is fair, but a failing test should still be given a higher priority that other issues, so I've updated the aforementioned handbook page so that failing tests in the secondary environments are 'Major' issues. I've basically changed this because it makes sense to me, and because changes to the handbook are really easy to revert. Was this the right change to make? Regards Steven Jones ComputerMinds ltd - Perfect Drupal Websites Phone : 024 7666 7277 Mobile : 07702 131 576 Twitter : darthsteven http://www.computerminds.co.uk

2 2

Re: [development] Module proposal: Append ?XDEBUG_SESSION_START to allsite URLs
by Richard Burford 11 Jan '11

11 Jan '11

> Are those bookmarklets available anywhere online? If they aren't, and you're happy to share them, I'll write a blog post on them - and credit you, of course. Obviously no problem at all if you don't want to share the code. I've been meaning to write it up myself, not that it's such a special technique or super cool code or anything, just that it's pretty useful. But, alas, as always, I have no time. This is one I use to switch from dev to prod (edited the real URLs for security - hopefully you can get them working for you): javascript://%0Aif(/dev\./.test(location.href)){location.href=location.href.replace('dev.','www.');}; Here's another one I hacked together to go from QA to my dev environment for the theme branch: javascript://%0Aif(/qa\.example\.com/.test(location.href)){location.href=lo…'qa.example.com/','dev.example.com/~USER/BRANCH/?q=');}; Credit goes to poetro for suggesting the use of regex literal. psynaptic http://twitter.com/psynaptic http://drupalcontrib.org/

1 0

Module namespace reclamation
by Jonathan Dale 11 Jan '11

11 Jan '11

I have a module that I have been using for quite some time privately that I think would be of use to the community. At present the module namespace is already in use by an abandoned module which has not been updated since D5. Is there a procedure for being able to claim that module namespace and reuse it for something that would be relevant to the namespace? Thanks, Jonathan Dale @darthclue

2 1

[support] Submitted patch errors (Authorize API tests bugged?)
by Leonard den Ottolander.nl 11 Jan '11

11 Jan '11

Hi, I submitted a patch (http://drupal.org/node/1020006) to make chmod values configurable. Fixed the patch so it applies from the base directory and retested it. The patch gives a couple of warnings and errors when run through the automated test system, all in Authorize API (http://qa.drupal.org/pifr/test/120509) However, the errors are 'Parsed page successfully.', 'authorize.php page title is correct.', '"To continue, provide your server connection details" found', 'Raw "System Test FileTransfer" found', '"System Test Username" found'. Reads more like successful tests so I'm unsure what's wrong. Also, on a fresh Drupal-7 with this patch applied I cannot reproduce these errors. Could anyone have a look at the patch and the errors and shed some light on this? Are those tests bugged? What should I do next to get this patch to pass the tests? Regards, Leonard. -- mount -t life -o ro /dev/dna /genetic/research

2 1

An automated way of locating unused modules?
by James Benstead 11 Jan '11

11 Jan '11

Originally posted to http://drupal.org/node/1017416: I have a list of 60+ modules that I download, via drush, to each new Drupal > site that I build. I then enable whatever modules are needed for the > specific site I'm working on as I carry out the build. > This means that once the site is launched, there may be modules that are > not being called by Drupal core but that are still enabled and/or installed. > Is there an automated way - a specific module, for example - that will tell > me which of the modules that are enabled on a site are being called by > Drupal core? > Secondly, is there any performance implication for having lots of modules > installed on a site if they are not enabled? The answer to the second question seems to be "no". And It doesn't seem that such a module does exist - would it be technically possible to write this module for D6? --Jim -- My IM and Skype details are at http://state68.com/contact

10 16

Changing Residence.
by Dayton Perkins 11 Jan '11

11 Jan '11

To all my clients and contacts. Thank you so much for your ongoing support. I am currently in the process of moving to Hong Kong. Please note that I have included my business address in the footer of my email dayton(a)goodnewsdesign.com <mailto:dayton@goodnewsdesign.com> Please make a note and use this as the email to contact me from this time going forward: *perkinsd(a)chartermi.net will soon be orphaned*. If you have been using tonebari(a)yahoo.com <mailto:tonebari@yahoo.com>, this address will still be functional. Thanks so much! -- /Kindest regards,/ /*Dayton Perkins*/ Dayton Perkins dayton(a)goodnewsdesign.com <mailto:dayton@goodnewsdesign.com> Good News Design Intelligent Web Programming for Business 3611 Butternut Drive, Suite 40 Holland MI 49424 616-399-5617 http://goodnewsdesign.com GND

1 0

Values not retained
by pavithra m 10 Jan '11

10 Jan '11

This part of the code is not retaining the previous value..... $form['characteristics']=array( '#type' => 'textfield', '#size'=> 20, //'#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<table class="table2"><tr><td class="table2row">', '#suffix'=>'</td>', '#default_value' => !empty($form_state['values']['characteristics']) ? $form_state['values']['characteristics'] : '', '#parents' => array('rows', $delta, 'chars'), ); $form['description']=array( '#type' => 'textfield', '#size'=> 20, //'#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<td class="table2row">', '#suffix'=>'</td>', '#default_value' => !empty($form_state['values']['description']) ? $form_state['values']['description'] : '', '#parents' => array('rows', $delta, 'descr'), ); $form['minimum']=array( '#type' => 'textfield', '#size'=> 20, // '#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<td class="table2row">', '#suffix'=>'</td>', '#default_value' => !empty($form_state['values']['minimum']) ? $form_state['values']['minimum'] : '', '#parents' => array('rows', $delta, 'min'), ); $form['maximum']=array( '#type' => 'textfield', '#size'=> 20, //'#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<td class="table2row">', '#suffix'=>'</td></tr></table>', '#default_value' => !empty($form_state['values']['maximum']) ? $form_state['values']['maximum'] : '', '#parents' => array('rows', $delta, 'max'), ); -- *Cheers* * *

1 0

Values not retained
by pavithra m 10 Jan '11

10 Jan '11

This part of the code is not retaining the previous value..... $form['characteristics']=array( '#type' => 'textfield', '#size'=> 20, //'#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<table class="table2"><tr><td class="table2row">', '#suffix'=>'</td>', '#default_value' => !empty($form_state['values']['characteristics']) ? $form_state['values']['characteristics'] : '', '#parents' => array('rows', $delta, 'chars'), ); $form['description']=array( '#type' => 'textfield', '#size'=> 20, //'#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<td class="table2row">', '#suffix'=>'</td>', '#default_value' => !empty($form_state['values']['description']) ? $form_state['values']['description'] : '', '#parents' => array('rows', $delta, 'descr'), ); $form['minimum']=array( '#type' => 'textfield', '#size'=> 20, // '#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<td class="table2row">', '#suffix'=>'</td>', '#default_value' => !empty($form_state['values']['minimum']) ? $form_state['values']['minimum'] : '', '#parents' => array('rows', $delta, 'min'), ); $form['maximum']=array( '#type' => 'textfield', '#size'=> 20, //'#title' => t('rows @n', array('@n' => ($delta + 1))), '#prefix'=>'<td class="table2row">', '#suffix'=>'</td></tr></table>', '#default_value' => !empty($form_state['values']['maximum']) ? $form_state['values']['maximum'] : '', '#parents' => array('rows', $delta, 'max'), ); -- *Cheers* * *

1 0

Security and Drupal
by Austin Einter 10 Jan '11

10 Jan '11

Hi All I just made a site using Drupal6.2 and in front page I have kept "user login" block. I hosted this site using some third party web server. I tried to login to new site from my PC using my user name and password and prior to that I was capturing the packets those were being send/received by my PC. By checking few packets content I could figure out the user name and password in plain text. So it looks others can see these packets and get the administrative user name and corresponding password and hence can modify site content and it is really dangerous. I assume people must have thought of it and there should be some way to make sure username and password should be encrypted by default hence avoidimg third party role in site content modification. Please guide in this regard and provide some pointers how can I make username/password secure while logging in sites based on Drupal. Regards Austin

8 8