- Development - lists.drupal.org

Patch reviewing best practices [was] What about reviewing patches?
by Jerad Bitner 14 Aug '08

14 Aug '08

So I'd like to hear from those of you who do a lot of core patch reviews to find out what is your workflow? It was pointed out in the last thread that it's not a matter of it taking a long time to actually review a patch, but to get everything in place in order to review a patch and having a standard environment setup that is conducive to reviewing patches. I'm sure there are many devs out there that have a standard set of steps they go through to test out a d6 patch and something similar for then testing out a d7 patch. I'm sure it would help many people to hear some of these setups in order to replicate these practices on their own machines and get some patch reviewing done. If anything, comparing notes from different developers on how they approach this could lead to some great standard set of practices and therefor, handbook pages ;) ~Jerad sirkitree.net drupalmao.com

1 0

Please help fix db_rewrite_sql in search
by Robert Douglass 13 Aug '08

13 Aug '08

Did you know that Drupal's search module doesn't properly use db_rewrite_sql? Surprised? Well, it's been in the issue queue since 2006. http://drupal.org/node/54622 There is also a patch that has been waiting for review ever since the Minnesota Search Sprint (May 10) that nobody has looked at. I've marked the bug as "critical". As Drupal's standards get higher bugs like this aren't acceptable. Hopefully this mail will stir up some interest.

2 2

Unique/Random IDs and drupal
by Ethan Fremen 12 Aug '08

12 Aug '08

Gentlebeings, I've read the recent thread on devel->staging->deployment, and I wanted to share what I've done in the area. My main interest lies in moving away from monotonically incrementing integers as id values so I have a greater chance of being able to "shard" the drupal DB for high performance. As a first step, I am working on moving drupal core to using 64 bit integers. It was relatively trivial to change schema to create 64 bit tables, but right now there's nothing in schema that marks "foreign keys" as also being special. Would anyone object to schema requiring foreign ID references to be marked specially? Anyway, the direction I'm interested in heading is a 64 bit int + creation date timestamp for every row; the two can be combined to form a valid UUID if there are useful reasons for doing so. Note that Postgresql has UUID creating functions and MySQL 5.1 has uuid_short() which generates a 64 bit random int based on the UUID algorithm. The UUID() algorithm in mysql 5.0 isn't viable for scaling purposes because it's not cluster-safe. I do have some preliminary performance data on the speed at which one can create UUIDs: http://mindlace.net/archives/2008/06/23/generating-uuids-in-php-for-drupal/ I'm very interested in any feedback about the feasibility of at least widening the ids to 64 bits in D7. ~ethan

7 12

PHP 4 is dead, long live PHP 4
by Johan Forngren 11 Aug '08

11 Aug '08

Yep, no more PHP 4. The PHP development team would like to announce the immediate availability > of PHP 4.4.9. It continues to improve the security and the stability of > the 4.4 branch and all users are strongly encouraged to upgrade to it as > soon as possible. This release wraps up all the outstanding patches for the > PHP 4.4 series, and is therefore the *last* PHP 4.4 release. > http://www.php.net/archive/2008.php#id2008-08-07-1 http://www.computerworld.com.au/index.php/id;1239055978 -- Regards, Johan Forngren :: http://johan.forngren.com/

1 0

Choosing the N number for .install's hook_update_N
by Zohar Stolar 09 Aug '08

09 Aug '08

Is there some policy, or a thumb rule, about choosing the N number for .install's hook_update_N? I've proposed this patch <http://drupal.org/node/288946>, and I chose the number of the update to be the next one available. However, by the time this patch is applied (if it is accepted), it has a good chance of failing on this sequential number, if a former patch is applied before. Any directives I should be aware of? Thanks -- Zohar Stolar

17 42

Question about error_reporting()
by Juan Rodriguez 08 Aug '08

08 Aug '08

Hi guys, I am looking at the implementation of error_reporting: http://api.drupal.org/api/function/error_handler/5 and I don't understand this line: if ($errno & (E_ALL ^ E_NOTICE)) { does it means that all errors but E_NOTICE are gonna be reported ? (what I really dont get is the meaning of the ^ php operator....).... I am trying to understand this code because my watchdog table is getting full of PHP warning messages, and I was not able to found a configuration option to filter this kind of messages. Would it be possible to change the behaviour to report messages above or below a specific level like it is done in php.ini ? Thanks in advance.

5 6

FAQ: Why is Drupal still using CVS when X is a much better choice?
by Angela Byron 07 Aug '08

07 Aug '08

Since we're all sick of answering this question every week, I've made an attempt at documenting this here: http://drupal.org/node/289117 If someone has some of the old threads laying around and could help flesh that page out (esp. with "here's where you jump in if you want to change this" stuff), that'd be lovely. -Angie

28 80

: FAQ: Why is Drupal still using CVS when X is a much better choice?
by Sheldon Rampton 06 Aug '08

06 Aug '08

I've followed a bit of this discussion and just thought I'd throw in my two cents. Personally, I think SVN is easier to learn and use than CVS. I've had trouble using CVS to maintain my contrib modules on Drupal.org. Probably the worst example occurred when I tried using an applications (recommended in the documentation at drupal.org) that was supposed to provide a graphical user interface for CVS on my Mac. In practice, it just added one more layer of abstraction between me and the actions I was trying to take. I ended up calling some command from the application menu that I though would commit a change to one of my files. Instead it iterated through my entire downloaded collection of nearly a hundred Drupal modules, committing changes to all of them (including modules that other people had written). Someone else must have cleaned up the mess that left behind, because I didn't know how to. Having said all this, I also recognize that there is value to constancy in purpose, and the Drupal repository has a long history of being maintained under CVS, which I think would make it rather difficult to change over to something else at this point. Rather than switching from CVS to something else, it might be better to work on improving the documentation, which right now seems rather scattered and hard to follow. (It looks like it was written by committee, which of course it was.) If someone could come up with the money, I think it would be a good idea to hire a skilled technical writer who can go through the Drupal documentation systematically with an eye to making it more user-friendly. ------------------------------------------- SHELDON RAMPTON Research director, Center for Media & Democracy Center for Media & Democracy 520 University Avenue, Suite 227 Madison, WI 53703 phone: 608-260-9713 Subscribe to our free Weekly Spin email: <http://www.prwatch.org/cmd/subscribe_sotd.html> Subscribe to our Weekly Radio Spin podcasts: <http://www.prwatch.org/audio/feed> Read and add to articles on people, issues and groups shaping the public agenda: <http://www.sourcewatch.org> Support independent, public interest reporting: <http://www.prwatch.org/donate>

2 1

Sambasiv Rao wants to add you as a friend
by Sambasiv Rao Yarramsetty 05 Aug '08

05 Aug '08

I want to add you as a friend in Grouply so you can see my profile with my pictures, my groups, and my favorite group messages. Here is the link: http://www.grouply.com/register.php?r=271020&vt=3026539 Sambasiv Rao ==================== Click here to block all emails from Grouply, 495 Seaport Court, Suite 103, Redwood City, CA 94063.

1 0

unsubscribe
by Stuart Neilson 04 Aug '08

04 Aug '08

On Fri, Aug 1, 2008 at 5:43 PM, <development-request(a)drupal.org> wrote: > Send development mailing list submissions to > development(a)drupal.org > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.drupal.org/listinfo/development > or, via email, send a message with subject or body 'help' to > development-request(a)drupal.org > > You can reach the person managing the list at > development-owner(a)drupal.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of development digest..." > > > Today's Topics: > > 1. Re: FAQ: Why is Drupal still using CVS when X is a much > better choice? (Sam Boyer) > 2. EER Diagram for MySQL (Brett Stoppel) > 3. Re: FAQ: Why is Drupal still using CVS when X is a much > better choice? (Lyle Mantooth) > 4. Re: EER Diagram for MySQL (Angela Byron) > 5. Re: EER Diagram for MySQL (Fr?d?ric G. MARAND) > 6. Drupal CVS outage on Tuesday 2008-08-05, 11pm-midnight GMT > (Derek Wright) > 7. Re: Drupal CVS outage on Tuesday 2008-08-05, 11pm-midnight > GMT (Jerad Bitner) > 8. Re: Drupal CVS outage on Tuesday 2008-08-05, 11pm-midnight > GMT (Marjorie Roswell) > 9. Re: Drupal CVS outage on Tuesday 2008-08-05, 11pm-midnight > GMT (Kathleen Murtagh) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Fri, 01 Aug 2008 13:32:46 -0500 > From: Sam Boyer <drupal(a)samboyer.org> > Subject: Re: [development] FAQ: Why is Drupal still using CVS when X > is a much better choice? > To: development(a)drupal.org > Message-ID: <1217615566.12087.139.camel@thereishope> > Content-Type: text/plain > > On Fri, 2008-08-01 at 11:18 -0700, Derek Wright wrote: > > On Aug 1, 2008, at 6:26 AM, Adrian Simmons wrote: > > > > > Can we have a commitment that *if* everything needing to be done > > > that Angie kindly listed on http://drupal.org/node/289117 and links > > > therefrom *gets done* we *will* move? > > > > Once upon a time, in a post someone with time and motivation could > > surely find, Dries wrote something to the effect of: > > > > "I'd be happy to switch to something other than CVS _if all the > > dependencies on CVS are safely removed and addressed_". > > > > (approximate quote from memory). > > > > - The #1 dependency on CVS is project_release.module. > > - The #2 dependency on CVS is all the CVS account creation stuff. > > - The #3 dependency on CVS are the CVS commit log viewing pages, > > links on project nodes, etc. > > - The best way to fix all of that is VersionControl API. > > - There are pages dedicated to what needs to happen to get us closer, > > already linked from Angie's wonderful document. > > > > If all that work is done, d.o is running VersionControl API with the > > CVS backend, the SVN backend is demonstrated to be stable and working > > on project.drupal.org, we've got the packaging script ported and > > working, we've got the CVS -> SVN import documented and working, > > we've got all the SVN access control worked out (per project like we > > have now, preventing commits to tags, etc, etc), we've got something > > like svn.drupal.org setup care of the OSUOSL, and we've got a team of > > documentation folks lined up to go nuts, I can pretty safely > > guarantee that Dries will say "Yay, go for it!". > > > > That still doesn't answer the question of how the choice of SVN vs. > > XXX will ultimately be decided, nor if decree from Dries is good > > enough for the switch. The lack of a clear process for making > > decisions like this continues to haunt us. By default, a decree from > > Dries (if he's willing to make it) carries the day. If not, I guess > > decree from Dries on how to decide will be necessary. > > > > Meanwhile, it can't possibly hurt to at least move towards project* + > > versioncontrol_cvs as a first (monster) step down this path. The > > other stuff will be pretty easy (relatively speaking) once that's > > done. Hurray to Sam for volunteering to help. But I can assure you > > that more resources will be needed to finish the job. > > Indeed there will. Help is VERY welcome :) > > s > > > > > Cheers, > > -Derek (dww) > > > > > > > > > > ------------------------------ > > Message: 2 > Date: Fri, 1 Aug 2008 13:41:13 -0500 > From: "Brett Stoppel" <brett(a)telosstudios.com> > Subject: [development] EER Diagram for MySQL > To: development(a)drupal.org > Message-ID: > <800700680808011141g3e46b9e9td4cab1d207afe41b(a)mail.gmail.com> > Content-Type: text/plain; charset="utf-8" > > Hi All. > > I am in the process of creating an EER Diagram for Drupal with MySQL > Workbench. I have a good start on it, but thought I would ask if one > already > exists? I find them really helpful for learning the database side of > applications. If one doesn't exists, is this the right place to ask > questions about the design of the DB? For instance, I am not sure if the > column "aid" in Access, Actions, Actions_id, Authmap are primary keys or if > they are foreign keys. I would love to get a little more done on the > diagram > and then upload it for you all to review and make suggestions. > > Thanks. > > Brett > > -- > Brett Stoppel > Telos Studios > brett(a)telosstudios.com | 785-218-4493 >

1 0