- Development - lists.drupal.org

passing data is free
by Karoly Negyesi 10 Oct '07

10 Oct '07

To quote one of the most experienced Drupal developer: "The menu item array includes a copy of the whole node for example on node pages. Well, obviously that might be useful for some help stuff, but most of the time it is not required, so why pass on this data in all cases?" Why not? Passing data around is basically free. You are not copying the data, you are creating a reference, deep copy only happens if you modify the passed in argument (PHP5 only deep copies an object if you instruct it with clone()). So do not hesitate to pass around as many data as you want. Not for the first time I urge fellow developers to read http://web.archive.org/web/20061205052540rn_1/www.zend.com/zend/art/ref-cou… this excellent article which is so old that you need archive.org to read it but is still valid. For deeper understanding read http://book.chinaunix.net/special/ebook/php/Programming.PHP_2/0596006810/pr…

6 6

og_forum error during installation through profile
by divya d 09 Oct '07

09 Oct '07

Hi, I am trying to install the og_forum module through the installation profile. However when I add og_forum in drupal_my_profile_modules, it throws up an error at installation. The error is: Fatal error: Call to undefined function _forum_get_vid() in /var/www/drupal/modules/og_forum/og_forum.install on line 19 All I am doing right now is just adding og_forum in the module list. I have: * enabled forum, organic groups *have not yet made any configuration additions to the profile. Can someone help me out on what I need to do or what I am doing wrong? Thanks in advance, Divya D --------------------------------- Boardwalk for $500? In 2007? Ha! Play Monopoly Here and Now (it's updated for today's economy) at Yahoo! Games.

2 1

hook_schema() now in .install, not .schema
by Barry Jaspan 09 Oct '07

09 Oct '07

Public service announcement: Prior to http://drupal.org/node/150245, hook_schema() was always defined in a module's .schema file. There was never any good reason for it to be there. The bad reason was "to avoid parsing the extra code in .install." However, the results of hook_schema() are cached so the functions only have to be called when modules are enabled/disabled or when CCK type structures change. This is very rare and parsing the .install files only on those occasions is not a performance issue. Now, hook_schema() must be defined in .install. The good reason for this is that it makes much more sense to have the schema definition and the schema update functions in the same place. It will make bugs of the "changed hook_schema() without a hook_update_N() or vice versa" sort less likely. And it is where God intended hook_schema() to be (says the atheist). If this had been an actual emergency, your mail server would already have crashed. Thanks, Barry

6 6

Another notable guy: Desbeers
by Karoly Negyesi 08 Oct '07

08 Oct '07

One of the oldest Drupal users, Nick Berendsen http://drupal.org/user/149 has returned to the project and produces very remarkable patches which reflect a deep understanding of Drupal. Welcome back and thanks!

2 1

strategy for naming module/theme/profile
by Simon Hobbs 08 Oct '07

08 Oct '07

Inspired by Boris Mann, I was going to start adding my company's standard install profile / module / theme in CVS. I've had issues in the past with a theme and module sharing the same name. Is this still an issue? Was this ever a recognised issue? Can I do this in D5 without any repurcussions when it comes to installation? module - "emspace" - support code and snippets for our install profile profile - "emspace" - our default install profile theme - "emspace" - our site's theme including an admin variation. Or to avoid issues described above, should I be doing: "emspace_code" "emspace_profile" "emspace_theme" Any suggestions are welcome. Simon

3 3

new feature: comment settings now per node type
by Chad Phillips -- Apartment Lines 08 Oct '07

08 Oct '07

in order to greatly improve the usability of project module on drupal.org in Drupal 6, we snuck this feature in today... ;) it's a nice new end user feature which also cleans up the UI -- developer impact is minimal, and detailed here: http://drupal.org/node/114774#comment_settings_per_node_type hunmonk

2 1

Views & lots-o-data
by Ryan Courtnage ☠ 08 Oct '07

08 Oct '07

Hi all, I've just written a node module that implements a view. First, I got my simple view to display the node title & body - this works. Next, I add a field that I've exposed from my custom module's table (a "city" field). This is where I run into a problem. My module's node-type has over 88,000 entries. The query that the Views module runs will cause mysql to pin the CPU (I've watched it pin for over 100 minutes before killing the process). What can I do to improve the perfomance (in a big big way)? I'm not a DBA, is there something I should be doing at the DB table level to improve performance? Or perhaps there's a Views option I'm missing? My views implementation follows. I've commented above the $view->field array that causes the problem. Thank you! Ryan irc: Bentley ---- function node_charity_views_tables() { $table = array( 'name' => 'node_charity', 'join' => array( 'left' => array( 'table' => 'node', 'field' => 'nid' ), 'right' => array( 'field' => 'nid' ), ), 'fields' => array( 'address_city' => array( 'name' => t('Charity: City'), 'help' => t('City of Charity'), 'sortable' => FALSE ), ) ); $tables["node_charity"] = $table; return $tables; } function node_charity_views_arguments() { } function node_charity_views_default_views() { $view = new stdClass(); $view->name = 'Charities1'; $view->description = 'CCOs'; $view->access = array ( ); $view->view_args_php = ''; $view->page = TRUE; $view->page_title = 'Charities'; $view->page_header = ''; $view->page_header_format = '1'; $view->page_footer = ''; $view->page_footer_format = '1'; $view->page_empty = ''; $view->page_empty_format = '1'; $view->page_type = 'list'; $view->url = 'charities1'; $view->use_pager = TRUE; $view->nodes_per_page = '50'; $view->sort = array ( ); $view->argument = array ( ); $view->field = array ( array ( 'tablename' => 'node', 'field' => 'title', 'label' => '', 'handler' => 'views_handler_field_nodelink', 'options' => 'link', ), array ( 'tablename' => 'node', 'field' => 'body', 'label' => '', 'handler' => 'views_handler_field_body', ), // the following array causes cpu to pin for hours. array ( 'tablename' => 'node_charity', 'field' => 'address_city', 'label' => '', ), ); $view->filter = array ( array ( 'tablename' => 'node', 'field' => 'type', 'operator' => 'OR', 'options' => '', 'value' => array ( 0 => 'node_charity', ), ), ); $view->exposed_filter = array ( ); $view->requires = array(node, node_charity); $views[$view->name] = $view; return $views; }

2 3

Re: [development] Views & lots-o-data
by andy＠spiders-lair.com 07 Oct '07

07 Oct '07

Doh, I should have read to the bottom to see the view..... you can ignore that last email --Andy

1 0

Re: [development] Views & lots-o-data
by andy＠spiders-lair.com 07 Oct '07

07 Oct '07

Is your "city" field indexed? CREATE INDEX {my_modules_table}_city ON {my_modules_table} (city); regards, --Andy ----- Original Message ---- From: Ryan Courtnage ☠ <ryan(a)courtnage.ca> To: development(a)drupal.org Sent: Sunday, October 7, 2007 9:27:23 PM Subject: [development] Views & lots-o-data Hi all, I've just written a node module that implements a view. First, I got my simple view to display the node title & body - this works. Next, I add a field that I've exposed from my custom module's table (a "city" field). This is where I run into a problem. My module's node-type has over 88,000 entries. The query that the Views module runs will cause mysql to pin the CPU (I've watched it pin for over 100 minutes before killing the process). What can I do to improve the perfomance (in a big big way)? I'm not a DBA, is there something I should be doing at the DB table level to improve performance? Or perhaps there's a Views option I'm missing? My views implementation follows. I've commented above the $view->field array that causes the problem. Thank you! Ryan irc: Bentley ---- function node_charity_views_tables() { $table = array( 'name' => 'node_charity', 'join' => array( 'left' => array( 'table' => 'node', 'field' => 'nid' ), 'right' => array( 'field' => 'nid' ), ), 'fields' => array( 'address_city' => array( 'name' => t('Charity: City'), 'help' => t('City of Charity'), 'sortable' => FALSE ), ) ); $tables["node_charity"] = $table; return $tables; } function node_charity_views_arguments() { } function node_charity_views_default_views() { $view = new stdClass(); $view->name = 'Charities1'; $view->description = 'CCOs'; $view->access = array ( ); $view->view_args_php = ''; $view->page = TRUE; $view->page_title = 'Charities'; $view->page_header = ''; $view->page_header_format = '1'; $view->page_footer = ''; $view->page_footer_format = '1'; $view->page_empty = ''; $view->page_empty_format = '1'; $view->page_type = 'list'; $view->url = 'charities1'; $view->use_pager = TRUE; $view->nodes_per_page = '50'; $view->sort = array ( ); $view->argument = array ( ); $view->field = array ( array ( 'tablename' => 'node', 'field' => 'title', 'label' => '', 'handler' => 'views_handler_field_nodelink', 'options' => 'link', ), array ( 'tablename' => 'node', 'field' => 'body', 'label' => '', 'handler' => 'views_handler_field_body', ), // the following array causes cpu to pin for hours. array ( 'tablename' => 'node_charity', 'field' => 'address_city', 'label' => '', ), ); $view->filter = array ( array ( 'tablename' => 'node', 'field' => 'type', 'operator' => 'OR', 'options' => '', 'value' => array ( 0 => 'node_charity', ), ), ); $view->exposed_filter = array ( ); $view->requires = array(node, node_charity); $views[$view->name] = $view; return $views; }

1 0

Druplicon not in IRC?
by Matthew Farina 07 Oct '07

07 Oct '07

I noticed the Druplicon isn't in the IRC rooms right now. Is something wrong or is there something I didn't know about? Matt

4 3