- Development - lists.drupal.org

form_set_value()
by Robrecht Jacques 02 Mar '07

02 Mar '07

Hi all, I have a problem with form_set_value(). I thought that this would set a value in the form, but the attached example module doesn't work as I expect. It is a simple form with radios and in the _validate() I want to select a different radio button if t('Next') is clicked. Can someone help me? I've tried on #drupal, but noone was helpful (although chx tried to be). Thanks, Robrecht

1 0

3 months to code freeze
by Dries Butyaert 02 Mar '07

02 Mar '07

Hello world, just wanted to let you know that we only have 3 months left until the next code freeze. Time we start working and pushing for some of the bigger changes. -- Dries Buytaert :: http://www.buytaert.net/

1 0

idea for an install profile (and "distribution"): devel install
by Derek Wright 01 Mar '07

01 Mar '07

while waiting for Dries to officially RTBC the issue for hosting install profiles on d.o [1], i just had an idea for a install profile: the development profile. things it could do: 1) install/configure devel.module 2) setup some standard roles for testing (non-uid-1 admin, content admin, a role that only has "switch users" permission, etc), and configure all perms appropriately. 3) create a small pool of users in each of the roles, all of which are also in the "switch users" role, enable the switch users block from devel.module, etc. [2] 4) also create a bunch of random users with the generate script from devel.module... 5) create a bunch of test content with the generate script. 6) create a bunch of malicious (XSS-seeking) content: node titles, taxonomy terms, anything we can think of that some module might not be escaping properly somewhere. basically, wrap js alert boxes around just about any possible user-input we can find. ;) 7) install as much of the simpletest.module and framework as possible, and otherwise prompt/warn the user about the external library they should download and install. 8) perhaps install some per-node-access module(s) (tac_lite, simpleaccess, etc) and configure some of the auto-generated content to be private. 9) optionally install some other handy modules folks use for testing (i'm a big fan of diff.module and dba.module, but there might be others that would be useful). 10) perhaps install/configure some kind of benchmarking tools (if any exist that would be appropriate). ... this would: a) save a ton of time whenever one of us needs to setup a local test site b) make it *much* easier for newer developers to get a standard test environment up and running c) facilitate being able to reproduce bugs, since everyone could be working from a more standardized test environment most of the time d) lower the barrier to developers running (and therefore writing) simpletests for their code e) help find XSS more quickly, since folks (and automated tests) would be navigating through a site that was trying to XSS-ify itself all over the place. just having the per-node-privacy content auto- generated would help remind folks to test those sorts of edge cases in their code, too. i don't have time to work on this, but i'd be willing to help someone (s) else. or, if anyone thinks this is such a good idea, they want to pay me to work on it instead of my other consulting gigs, that might work, too. ;) if we could stand to wait that long, this might make a nice SoC 2007 project, too. thoughts? -derek [1] http://drupal.org/node/113939 [2] it'd be nice if there was a setting in devel.module to restrict the choices in the switch user block to users that have 'switch users' permission, so that such a test environment would always allow you to quickly switch back and forth across differently perm'ed users, without ever getting "stuck" on a random user that didn't have switch perms...

8 9

Advanced forms api question (#submit and #programmed)
by Dave Cohen 01 Mar '07

01 Mar '07

I'm trying to provide a patch for an issue I recently submitted <http://drupal.org/node/123702>. I'm having trouble grokking some forms API intricacies and I'm sure someone on this list can help. Briefly, I'm trying to customize the update.php form using hook_form_alter(). Unfortunately update.php does not handle its form the normal way. Normally, a form is created by calling drupal_get_form() and also processed by calling drupal_get_form(). Update.php does not do this. My first question is why not? But that is a bit off topic. Because update.php calls drupal_get_form() only when displaying the form and not when processing it, changes made (in my hook_form_alter) to $form['#submit'] have no effect. That is, there is no way to have my custom submit handler called when the form is submitted. So, I've added a call to drupal_get_form in my copy of update.php, in the update_update_page method. This does what I want, in that my #submit handler is called. But there is an unwanted side-effect, which is the forms code then redirects the browser. So I never get to the update.php progress page. So it seems I cannot add my own handler and also have update.php do its handling. I poured through the forms code looking for where (and why) it does the redirecting. There is a mysterious $form['#programmed'] variable which seems to control this, but I can't figure out what that variable is really supposed to be about, or where it's supposed to be set. I feel like I'm close to solving my problem. But I could be going down the wrong road. Or perhaps there is a much simpler solution. So I come here for advice. Any help is really appreciated. Thanks, -Dave

1 0

CK-ERP (Open Source ERP / CRM / MRP) v.0.22.1 released
by C K Wu 01 Mar '07

01 Mar '07

Hi, folks, I have posted a new release, v.0.22.1, of CK-ERP, at SourceForge.Net, http://sourceforge.net/projects/ck-erp . This release features connectors for Moodle, Atutor, vTiger, XRMS, WordPress, b2evolution and e107. CK-ERP is an open source accounting/MRP/ERP/CRM system that runs on top of multiple middlewares. It comprises 22 modules - Administration, i18n, Contact Management, Customer Relationship, Customer Self Service, Vendor Relationship, Ledger, Bank Reconciliation, MRP, Warehouse, Inventory, Service, AP, AR, PO, SO, Quotation, POS for Cashier, POS for Manager, HR, Staff Self Service and Payroll. Operating platform can either be LAMP or LAPP. It provides accounting and back office functionalities to SMEs and utilizes the underlying middleware to administer accounts/groups. Please report error and suggestion to the discussion group / mailing list, CK-ERP-en(at)googlegroups.com or CK-ERP-zh_CN(at)googlegroups.com . General history and expected development is available at the discussion group's Archive. Supported MiddleWares: eGroupWare, Horde-GroupWare; Zencart, CRELoaded, osCommerce; Drupal, Joomla, Mambo, e107, XOOPS, Xaraya; Moodle, Atutor; vTiger, XRMS; WordPress, b2evolution; TikiWiki; phpBB. Information Websites: http://ck-erp.org http://ck-erp.net Download is available from, http://sourceforge.net/projects/ck-erp http://gforge.oss.org.cn/projects/ck-erp http://gf.cs.hit.edu.cn/projects/ck-erp http://www.cnforge.org/modules/xfmod/project/?ck-erp http://gro.clinux.org/projects/ck-ledger http://cosoft.org.cn/projects/ck-ledger Cheers, Wu Chiu Kay, aka CK Wu, aka CK (CK is the preferred alias) Hong Kong

1 0

Core developer quiz
by Earnie Boyd 28 Feb '07

28 Feb '07

See http://drupal.org/node/116820#comment-205539 for the quiz. Keep the responses in the ticket. Have fun, Earnie

1 0

link admin/help
by Glenn Wybo 28 Feb '07

28 Feb '07

Grtz, I'm writing a new module for drupal and was just trying to add some help in the module. Adding a description in admin/modules wasn't a problem, nut I also wanted to add some information to the admin/help. The code is : function product_help($section = 'admin/help#product') { $output = ""; switch ($section) { case 'admin/help#products': $output = t('<p>Extends the functionality of the products - menu.</p>'); $output .= t('<p>We have actually added a tree structure to the products - menu, '); $output .= t('which makes it easier to select a group of products and so navigate '); $output .= t('through the store.</p>'); return $output; } return $output; } Unfortunately, I don't see the link under admin/help. I think the code above is just wright, but I have to add a link somewhere. Can anyone help me on this? thks _________________________________________________________________ De meest trendy stuff voor Windows Live Messenger ... http://entertainment.msn.be/funwithmessenger

2 1

Drupal Association
by Dries Buytaert 28 Feb '07

28 Feb '07

Hello world, last week I was away from the keyboard, and earlier this week we announced the Drupal Association. I'm still catching up with e-mail, digging out from the Drupal Association buzz. I did start committing patches again though. Incorporating the Drupal Association was a _lot_ of work -- we worked on it for months. We don't expect that you instantly understand the ins and outs so if anyone has questions regarding the Drupal Association, I'd be happy to answer them. The Statutes are available online (http://association.drupal.org/ about/statutes-and-internal-regulations) and we tried to answer all common questions in the FAQ (http://association.drupal.org/about/ faq), but if there is anything you'd like to see clarified, just ask. The important point (for this mailing list) is Article 4, Section 4 of the Statutes: "The community of Drupal developers decides independently on the functionality on the one hand and on planning the development of the Drupal software on the other. The Association shall not have a casting vote in such matters." This means that the Drupal Association can't enforce that certain features make it into Drupal core, nor can it enforce that a contributed module has to incorporate feature X and/or drop feature Y. Instead, there is a clear separation of powers. The Drupal Association manages the assets in such a way that it supports the (developer) community, and the (developer) community continues to provide support and works on the code. -- Dries Buytaert :: http://www.buytaert.net/

2 1

filtering PHP_SELF
by David Caylor 27 Feb '07

27 Feb '07

bootstrap uses PHP_SELF in conf_init and request_uri, as far as I can tell without filtering. This isn't safe. Is this getting filtered somewhere or somehow that I'm missing? If it isn't getting filtered elsewhere, adding htmlentities to these two functions would be an inelegant but sufficient (for security purposes) fix. See here for a discussion about not trusting PHP_SELF: http://blog.phpdoc.info/archives/13-guid.html

3 2

SVN vs. CVS? (was re: CVS branch work best practices?)
by Derek Wright 26 Feb '07

26 Feb '07

Rob Thorne wrote: > So if we are going to start using branches more, and encouraging > more developers to play with tags and branch tags, it might be > worth studying whether or when to migrate to a more modern system. i'll be the first to admit that CVS can be daunting to the untrained. however, the entire thread about best practices for branching has nothing to do with CVS's failings regarding branches, tags, and merging. when to branch, if/when/what to merge (and if not, what branch(es) to apply patches to) are generic questions that would face Drupal developers, no matter what revision control system we used. as far as i know, the *only* viable alternative to CVS that might be considered for drupal development is SVN. sadly, in spite of the other ways SVN improved things that CVS sucks at (basically, renaming files), SVN still fails to make merging branches easy. sure, the syntax of the command changed from: "cvs update -j [revision_1] -j [revision_2]" to: "svn merge -r [revision_1] -r [revision_2]" but otherwise, all the same suckiness is there in both cases [1]. getting into the details of this is OT -- my real point is that SVN is no paradise for revision control, especially regarding branches. sure, the "svn tag" operation is orders of magnitude *faster* than "cvs tag" in many cases, but it's no *simpler* to understand or get right. and no one is complaining about wasted time while "cvs tag" runs, they're complaining (with some justification) about wasted time thinking about the revision control problems (when/why to branch/tag, where to apply patches, when to make releases, etc), instead of their Drupal code problems. bottom line: nearly all of the confusion is being caused because of misunderstanding revision control concepts (and the incredibly complicated world Drupal has created for itself, see my other post), not the syntax or functionality of a specific revision control tool [2]. that said, i'm not fanatically opposed to moving Drupal development to a different revision control system, but it's going to take a *LOT* of work, and (in a year of *many* people trying) i've yet to hear an argument that holds any water about ways SVN would significantly improve our development practices to offset the very high cost of switching. that said, if someone(s) wants to pay me enough to do all the work (and i won't make the same mistake of wildly under-guessing how many hours this would actually take from start to finish as i did with the release system) i'd be more than happy to do the clean separation/abstraction required so we could use SVN instead of CVS. if you're serious (and have a big budget), talk to me off list. thanks, -derek [1] http://www.dellroad.org/svnmerge/index has promise to solve some of these problems, and is now included in the SVN source, but it's still basically "contrib" as far as i can tell. :( [2] to address Rob's other comment: > First is the notorious "forgot -kb on cvs add" problem. this is a non-issue in a repository with a properly configured CVSROOT/cvswrappers file, which thankfully, the Drupal contrib repo has been for at least a few months now. ;)

7 10