- Development - lists.drupal.org

Drupal 5 Themer Pack
by Earl Miles 24 Jan '07

24 Jan '07

Transferred from my blog at Dries' request. First, the blog post: > Today on drupal.org I just posted my ‘personal battle plan’ and it includes > a fairly large project that doesn’t actually require a great deal of Drupal > experience to help on; it requires just enough coding knowledge to extract > the right amount of code, create the files, and then — probably the only > place where a little bit of coding knowledge is really needed — effectively > separate logic from presentation without adding too much processing time to > the code. > > The idea here is that I think there should be a project called the Drupal 5 > Themer Pack which includes every (or nearly every) theme function in Drupal > 5 core as a .tpl.php and the corresponding template.php code. Right now I > envision the structure that each Drupal ‘system’ might have a file such as > template-forum.php which is included from your standard template.php. It > includes all of the forum theme functions, and each one has a .tpl.php for > presentation. This code does not change the output in any way but makes it > easier for Drupal themers to identify the theme functions they need and > actually modify them. > > As a bonus, it might include alternate versions — maybe a PHPbb-like set of > templates for forum, or whatever. Plug it in, make the changes you need, and > go. > > There is a fair bit of work here, but it’s also learning work — because in > so doing, whoever extracts the theme functions will be forced to learn > something about how Drupal actually does that part of the code. It could > lead to recommendations for patches for future versions of Drupal to improve > the theming functions, and it could make life a whole lot easier for themers > who don’t want to have to know anything about code at all, because they can > take these things that are already created for them and simply tweak them. > That’s a lot easier than doing the actual extraction like they have to do > now. > > Right now I am basically doing an exploration of who might be interested in > contributing to this project, and working to organize effort and get > something good going here. I’m thinking of pitching this to the Drupal Dojo > as something that students can work on as a learning exercise AND contribute > to Drupal. > > Any thoughts? Want to work on it? Make sure I have contact info — as I’ll be > putting together a list. Second, Dries' response: > Earl, for Drupal 5.0, Vlado, Adrian and myself spent a couple of weeks > trying to move all theme functions out of the modules into stand-alone > phpTemplate files. The idea is that designers should simply copy the > template file and start modifying it, rather than having to convert a module > into a theme themselves. > > We created a script that does just that -- and that got us 95% there. It > removes the theme functions from the modules, converts them to template > files, and stores the template files in the module-specific directories. > > It all worked (except for the last 5%), but the problem we ran into is that > it turned out to be 10% slower. > > I'm hoping you and others can pick up the work (with help from us), and help > us get this _in_core_. I think this is a case where we are better of > changing the default behavior. It makes too much sense not to do it in core > -- plus, we already started working on it. > > What needs to be done is "simply" this: we need to make it 10% faster. :-) > > Let's talk more about this on the mailing list? My response: Yes, there are absolutely aspects of this that are a good push toward core. However, there are a couple of important things here: 1) Drupal 6 should be 6 months away, and this kind of project can benefit now, as well as having a future benefit by having the bulk of the theming work be done now. By being useful now, people who might not otherwise participate in this work might participate and contribute. 2) I think it's important to get more themers participating in Drupal, and making this easier is a good way to do it, and to follow up 1, can be a major benefit now. 3) I don't have a solution for the 10% slower yet. 4) This project mitigates that 10% problem by presenting the pack as a pick & choose type deal. You don't include the templates for items you aren't overriding, but for themes that do want to override them, they drop the code in, add a line to their template.php to include the right stuff, and start modifying. To refute 3) above, I might have a solution to the 10% issue which involves template compiling -- I believe the bulk of the slowdown comes from having to read template files into memory over and over again. Compiling all the .tpl.phps into a single file could mitigate that effect. I don't know, it'd have to be proofed and benchmarked. This work could benefit that. Also, I have access to Frando's work on creating .theme files but I don't have access to Adrian/Vlado's work on separating out into .tpl.php. Frando's work includes an extractor, though, that I think can be repurposed to do just that, so I'm not terribly concerned.

14 34

Re: [development] Is DRUPAL-5 branch necessary for module?
by Ken Rickard 24 Jan '07

24 Jan '07

>>I hate to sound elitist, but maybe one of the problems is the ease >>with which hundreds(?) of people have obtained CVS accounts? If you >>either (1) don't know what you are doing with CVS, or (2) are not >>willing to learn how to use it without bugging Derek, then maybe you >>shouldn't have a CVS account? I don't think this attitude is being elitist. It's realistic. The only reason I involved Derek was that the troubleshooting documentation referred issues to the Project issue queue. This misuse of Derek's time has since been identified (and corrected). - Ken Rickard agentrickard

1 0

Re: [development] [drupal:dries] /includes bootstrap.inc common.inc locale.inc menu.inc module.inc path.inc / install.php /modules/aggregator aggregator.module /modules/block block.module /modules/blog blog.module /modules/blogapi blogapi.module /mod
by Johan Forngren 24 Jan '07

24 Jan '07

Interesting that http://drupal.org/node/34755 is still RTBC. On 1/24/07, Stefan Nagtegaal <development(a)istyledthis.nl> wrote: > > > Op 24-jan-2007, om 15:48 heeft drupal-cvs(a)drupal.org het volgende > geschreven: > > Log message: > > - Patch #34755 by chx et al: faster menu system. HEAD is > > temporary broken and there is no upgrade path yet. > > How much faster is this new menu system after all? I tried to find > some benchmark number, but I wasn't able to find/locate any.. > > > > Steef > -- // Johan Forngren /** * Email: johan(a)forngren.com * WWW: http://johan.forngren.com/ * Skype: forngren * MSN: johan(a)forngren.com * IRC: forngren @ freenode * Jabber/GTalk: forngren(a)gmail.com */

1 0

Re: [development] [drupal:dries] /includes bootstrap.inc common.inc locale.inc menu.inc module.inc path.inc / install.php /modules/aggregator aggregator.module /modules/block block.module /modules/blog blog.module /modules/blogapi blogapi.module /modules/book book.module /modules/comment comment.module /modules/contact contact.module /modules/drupal drupal.module /modules/filter filter.module /modules/forum forum.module /modules/help help.module /modules/legacy legacy.module /modules/locale locale.module /m
by Stefan Nagtegaal 24 Jan '07

24 Jan '07

Op 24-jan-2007, om 15:48 heeft drupal-cvs(a)drupal.org het volgende geschreven: > Log message: > - Patch #34755 by chx et al: faster menu system. HEAD is > temporary broken and there is no upgrade path yet. How much faster is this new menu system after all? I tried to find some benchmark number, but I wasn't able to find/locate any.. Steef

2 1

Re: [development] Is DRUPAL-5 branch necessary for module?
by Ken Rickard 24 Jan '07

24 Jan '07

All- As one of the developers who harassed Derek recently ( http://drupal.org/node/108635) let me say a few nice things about him. 1) His documentation is excellent. I never had problems with releases; my problems were with version control (HEAD means what?). 2) Even at my dumbest, he was patient and encouraging. The Drupal community is remarkably good at not discouraging novice developers even when refusing (rightly so) to solve their every minor problem. And I owe Derek several beers. - Ken Rickard agentrickard

4 3

(no subject)
by drupal-devel＠drupal.org 24 Jan '07

24 Jan '07

SEALANT LOTTERY ORGANISATION, Sealant Tolpits lane WD 18 9RN Registered in England & Wales No 2822203. Ref: Number: ENG/UK5500/5E Batch Number:UK0090/ENG LOTTERY AWARD WINNING NOTIFICATION We are pleased to inform you of the result of the just concluded annual final draws of the Sealant Lottery International end of the year Lottery programs held in the England on 22th of January 2007. The online cyber lotto draws was conducted from an exclusive list of 25,000 e-mail addresses of individual and corporate bodies picked by an advanced automated random computer search from the internet. No tickets were sold. Your email address was attached to ticket number 112-6657789005, drew the lucky numbers 1-00-234-009-44-78, batch number UK0090/ENG and consequently won the lottery in category A. You have therefore been approved of a lump sum pay out of 2.000,000,00 Pounds (Two Million Pounds) in credited to file lottery Ref Number ENG/UK5500/5E. This is from total prize money of 20.000,000,00 Pounds shared among the international winners in categories A with Serial Number: UK/ENG/72-545/06. All participants were selected through a computer ballot system drawn form 25,000 company email addresses and 70,000,000 individual email addresses from Australia, Africa, New Zealand, Europe, South/North America and Asia as part of International Promotional Program, which is conducted annually. CONGRATULATIONS!!! Your fund is now in the custody of a financial company insured in your File Reference number. Due to mix up of some numbers and names, we advice that you keep this lottery winning strictly from public notice until your Claims has been process and your winning is remitted to you. This is part of our security policy to avoid double claims or unscrupulous acts by participants of this program. This lottery program was promoted by our group of philanthropist headed by the BRITISH LOTTERY BOARD. We hope with a part of your prize, you will participate in our next stakes 8,000,000.00 Pounds International Lottery. To file for your claim, please contact our financial claim agent:Contact details below. Mr.FRANK JOHN Sealant lottery Org Tel: 00447-031-902-780 Fax: +44-703-0401-932 Email:agentjohn2006@yahoo.co.uk Email:claims2007@consultant.com Remember that all winning prize must be claimed not later than February 7th, 2007. After this date, all lottery winning funds that are not claimed will be returned as unclaimed. Note: In order to avoid unnecessary delays and complications, please remember to always quote your reference and batch numbers in every correspondence with your financial/claims agent. Furthermore, should there be any change of address, do inform your financial/claim agent as soon as possible. Congratulations once again from our team of staff and thank you for being part of our promotion.Anybody under the age of 16 is automatically disqualified. ====================================================================== APPLICATION FOR PRIZE CLAIM (Receipt Official Notification Letter) [WINNING NO 1013AP-4] ---------------------------------------------------------------------- [FULL NAME OF WINNER] [FULL MAILING ADDRESS] [COUNTRY/ REGION] [STATE/ PROVINCE] [DATE OF BIRTH] [SEX] [MARITAL STATUS] [OCCUPATION] [CURRENT E-MAIL] [TEL HOME] [CELLPHONE NUMBER] [FAX] WINNING INFORMATION: --------------------------------------------------------- [REFERENCE NUMBER:] [BATCH NUMBER] [LOTTERY DATE] ---------------------------------------------------------------------- Submitted Form will be manually verified and processed by the assigned Claims Processing Officer (CPO) The Processing of your form will be completed within the next 24 hours of receiving your LOTTERY CLAIMS APPLICATION FORM-C. You will receive an update on the status of your Application once completely processed. ======================================================================== ======================================================================== � 2007 SEALANT LOTTERY. All rights reserved. Offer valid to winners who Are at least 18 years of age. Void where prohibited. No purchase necessary to claim winning prize. You will need to meet all of the steps to redeem as outlined in the Terms & Conditions before you can receive your promotional prizes. To receive this promotion, you must: 1) submit email and Mailing address information: 2) check your email inbox for "Redemption Notification" 3) Follow Redemption instructions. Once again, accept our congratulations on your prize winning. Sincerely, Yours sincerely, Mrs.Lisa Relly. (Lottery Co-ordinator) Sealant Lottery Organisation

1 0

Re: [development] Is DRUPAL-5 branch necessary for module?
by Metzler, David 23 Jan '07

23 Jan '07

I recently had a discussion with Derek about the same thing, where he convinced me that branching was the right thing to do. The current recommended best practices would suggest that you branch once you've got a stable 5.x compatible release, but before you start developing any new features. The reason to do so is so that you can do a bug fix if you need to on the stable code without forcing people to upgrade to potentially unstable code to fix some bug. -----Original Message----- From: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Vernon Mauery Sent: Tuesday, January 23, 2007 7:42 AM To: development(a)drupal.org Subject: Re: [development] Is DRUPAL-5 branch necessary for module? I am not a CVS guru, but I think this model makes perfect sense to me -- until HEAD is not compatible with 5.0, there is no need to branch. But then, it sounds like that won't be too long before some major changes are introduced to HEAD. But you still might keep your module HEAD compatible with D5 until the D6 API (or whatever is next) stabilizes. --Vernon On 1/22/07, _craig <drupal-list(a)2craig.com> wrote: > Do I really need to have a separate DRUPAL-5 branch for my contributed > module? The documentation* seems to indicate I need to. Is anything > preventing me from just tagging files under HEAD with DRUPAL-5--1-0? Right > now and in the near future I will only be making changes for 5.x so I don't > see the need to have a separate branch. Of course if you look at my > module**, it's too late... > > Thanks! > Craig > > * http://drupal.org/handbook/cvs/quickstart#branch-tag > ** > http://cvs.drupal.org/viewcvs/drupal/contributions/modules/taxonomy_brea dcru > mb/taxonomy_breadcrumb.module?view=log&only_with_tag= > >

1 0

Re: [development] nodify, objectify, CRUD-ify ...
by FGM 23 Jan '07

23 Jan '07

I checked it (quickly) against what is currently the HEAD section of API, which I suspect is still 5.0 What would be nice would be if some core hackers could check it and offer suggestions for improvement or corrections before I redo it in HTML for d.o. ---- Original Message ---- From: kb(a)2bits.com To: development(a)drupal.org Subject: Re: [development] nodify, objectify, CRUD-ify ... Date: Tue, 23 Jan 2007 09:25:17 -0500 >Fred > >Very useful. > >Please add it somewhere in the handbook, and tag it with the release >it >relates to. >This of course may change from one release to the other, but it has v >alue >regardless.

1 0

all DRUPAL-4-(7|6) tags are now branches
by Derek Wright 23 Jan '07

23 Jan '07

hello world, after manually helping various folks convert DRUPAL-4-(7|6) tags into branches, i couldn't stand it anymore, so i wrote a script to do this conversion in bulk. after lots of testing on scratch.drupal.org, and coordination with killes in IRC, i just ran this script for real on the d.o contrib repository. everything went smoothly, so there are no longer any DRUPAL-4-(7|6) tags in our repository. they're all branches now, like we always intended. the cvs access control scripts prevent people from adding new tags (e.g. DRUPAL-5) that should really be branches, so this was only a problem for older modules and themes. see http://drupal.org/node/103429 for details (and, if you care, the script i used for this). list of all DRUPAL-4-7 tags that were converted to branches (71 total): http://drupal.org/node/103429#comment-182186 list for DRUPAL-4-6 (90 total): http://drupal.org/node/103429#comment-182188 enjoy, -derek p.s. i disabled the repository's email notification on new tags when these scripts ran, so if you're wondering why you didn't get email about any of these branches being added as it was happening, that's why.

2 3

Re: [development] adoption for 'abandoned' modules?
by Steven Peck 22 Jan '07

22 Jan '07

> -----Original Message----- > From: development-bounces(a)drupal.org [mailto:development- > bounces(a)drupal.org] On Behalf Of Darren Oh > Subject: Re: [development] adoption for 'abandoned' modules? > > On Jan 19, 2007, at 11:41 AM, Karen Stevenson wrote: > > > Also, I would require that anyone listed as a maintainer must have > > their contact form enabled, otherwise they get de-listed and their > > project gets put up for adoption on a special adoption page. OK, > > maybe that last bit is a little strong :-) but whether or not there > > is a way to contact the maintainer should be another factor in our > > 'gold star' system. > > Not too strong at all. If a person wants to control a project but > doesn't want to be contacted, he should maintain the project on his > own computer, not on Drupal. Let people who disable their contact > forms have CVS access, but find someone who will actually maintain a > project to be the maintainer. > Um, and those that out of frustration with people using the contact forum to mail them directly for support instead of using the issue queue? Do we disable their contrib. modules? Site admins can use the contact form. We have the email information and can email directly. Not to put a fine point on it but I know several active module contributors who have disabled their contact modules because of this sort of abuse.

7 12