- Development - lists.drupal.org

taxonomy_link doesn't make sense and link_alter hook requires more context.
by adrian rossouw 02 Dec '06

02 Dec '06

I'm sending this in mail form, as I'm currently in an airplane , and i didn't trust myself to remember to post about it later =) We have a link hook for a reason, yet it's impossible to add links to the terms. ( i wanted to add a link to the user's blog, instead of it cluttering up the comments / read more.). From the comments : > * if (module_exists('taxonomy')) { > * $this->links(taxonomy_link('taxonomy terms', $node)); > * } Umm. this doesn't make sense, as we don't use objects in drupal, and we have no 'links' method defined for any object. Why should taxonomy link be called any differently from any other link hook ? > function taxonomy_link($type, $node = NULL) { > if ($type == 'taxonomy terms' && $node != NULL) { That kind of makes sense, Except we expressly are supposed to not call it with module_invoke_all, which means 'taxonomy terms' is completely pointless in this case. It gets even more pointless later. > // We call this hook again because some modules and themes call > taxonomy_link('taxonomy terms') directly > foreach (module_implements('link_alter') AS $module) { > $function = $module .'_link_alter'; > $function($node, $links); > } My point is they shouldn't be. calling it directly. Also, what's so special about this snippet of code that we can't wrap it in drupal_get_links($links_id, $object) ? It's far more consistent that way, and that could be done in themes. The other GLARING issue is that link alter doesn't have the link type as one of the parameters. Imagine trying to do a form_alter if you didn't even know which form you were busy altering? Crazy, right. I hope to science it's not too late to change this. As it depreciates the usefulness of the _links imo.

1 0

Re: [development] [drupal(DRUPAL-4-7):killes] /misc autocomplete.js collapse.js drupal.css drupal.js progress.js textarea.js update.js upload.js
by Karthik 01 Dec '06

01 Dec '06

3 3

Question about Forms API?
by Richard Morse 01 Dec '06

01 Dec '06

Hi! I have a question about the forms api -- if this is not the best place to ask it, please let me know where I should. I want to be able to add an element to a form which is _not_ in the 'edit[]' space. Specifically, I need to be able to set the 'q' item so that it will not be lost across a GET form submission if the site is not using clean urls. Any suggestions of where to look for how to do this would be greatly appreciated. Thanks, Ricky

3 6

Re: [development] Port status
by Steven Peck 30 Nov '06

30 Nov '06

If someone writes it yes. Who is 'someone'? -----Original Message----- From: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] On Behalf Of James Walker Sent: Wednesday, November 29, 2006 5:28 PM To: development(a)drupal.org Subject: Re: [development] Port status On 29-Nov-06, at 5:06 AM, Karthik wrote: > On 28/11/06, Darren Oh <darrenoh(a)sidepotsinternational.com> wrote: >> Is there going to be a page in the handbook on this? > > No idea. +1 anyway -- James Walker :: http://walkah.net/ :: xmpp:walkah@walkah.net

2 1

Port status
by Karthik 30 Nov '06

30 Nov '06

As per http://drupal.org/node/97571 , a 'patch (to be ported)' status has been added to the issue tracker. Therefore, if a patch has been committed and needs to be back or forward ported, please set it to this status along with the appropriate version. Regards, Karthik.

3 3

RFC: letting modules phone home to check for new releases
by Derek Wright 29 Nov '06

29 Nov '06

(if you're impatient and won't read this message ;) please comment here: http://drupal.org/node/94154 -- "module page could say if new releases are available"). one of the many benefits of the new release system is that contrib maintainers can now make an official release when they think their users should upgrade. this is particularly important for security fixes. my goal is for the admin/build/modules page to tell you if you're running out-of-date code. project.module just has to provide an RSS feed for new release nodes and/or an XML-RPC interface so that something on the modules page can either display the aggregated feed items in a block, or the UI could directly display the needs-update info. for example, you visit your modules page and the row for one of your installed contribs is now bright red with a giant warning: "SECURITY UPDATE RELEASED FOR THIS VERSION, YOU ARE URGED TO UPGRADE IMMEDIATELY" wouldn't that be slick? ;) my goal is to get this into core someday. it's too late in 5.x for that. however, since the modules page is all happy FAPI, we could do this via a form_alter()'ing contrib for 5.x and see that eventually migrate into core in 6.x or beyond. why am i asking for comments? there needs to be some more data in the .info files for 5.x modules if a contrib is going to be able to do this properly. as of today, the packaging script on drupal.org that creates the downloadable tarballs will automatically append the version of your module into the .info files[1]. this is b/c the modules page in core is about to be enhanced to display this data[2]. however, just knowing the version and the human-readable name of the module isn't enough for a 5.x contrib to be able to find out if your code is out of date. we also need something along the lines of: ; Project identification Project home = drupal.org Project name = views then, the soon-to-be-written check_updates.module can get this info and use it to construct the right URLs for the XML-RPC calls or to find the right RSS feed, etc. the packaging script can easily add this info automatically, but i need to finalize exactly what the fields are going to be called and what data they should really hold. i don't want to just hard-code a full URL since the project.module changes aren't done to provide the info yet, and we might change our mind on exactly the right path to use (and XML-RPC vs. RSS, etc). also, we can't assume *every* module installed on your site is from drupal.org, since that would break things for 3rd-party modules or custom-built ones. in that case, "Project home" should point to something else, or not exist at all. similarly, using a "Project name" instead of a "Project nid" is both more sane for end users to grok, and provides a level of indirection in case project nodes ever move around, get deleted and re-created, whatever. i *really* want to get this data into the .info files ASAP so that there aren't many 5.x contribs out in the wild that are missing it. however, i don't want to just unilaterally decide the fields and format of the values without any input from the rest of you. so, please comment ASAP here: http://drupal.org/node/94154 thanks! -derek [1] http://drupal.org/node/97286 "automatically insert human-readable version into .info files" [2] http://drupal.org/node/87298 "Add version info to modules page"

24 64

Patch reviews requested
by Heine Deelstra 28 Nov '06

28 Nov '06

Good day to all of you, Apart from a few critical bugs left, there are some additional bugs that would be nice to have fixed. Not all that critical, mosty nothing difficult, but the more polish, the better. Some of the patches have been sitting in the queue for a while and need review. If you have some time today, please review one of the following patches: <http://drupal.org/project/issues?projects=3060&versions=96923&categories=bu…> If you have lots of time today, here's a list of patches that need work: <http://drupal.org/project/issues?projects=3060&versions=96923&categories=bu…> Thanks in advance, Heine

1 0

Re: [development] Updating modules tables
by Metzler, David 27 Nov '06

27 Nov '06

May have missed the response to this, but my recommendation would be, yes. You need both the install and the update function to be implemented. The mysite_install would fire when someone who never used your module enabled it. Users who are upgrading will hit the mysite_update_1 function. Dave ________________________________ From: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Ken Rickard Sent: Sunday, November 26, 2006 11:52 AM To: development(a)drupal.org Subject: [development] Updating modules tables I'm not seeing the answer in the handbooks. I have a stable release of the mysite module. In the new 4.7 release, I have added a new db table. Do I need to write a mysite_update() function to handle this? Thanks, Ken Rickard agentrickard.

1 0

Attention: Module Developers. Your .info files...
by Earl Miles 27 Nov '06

27 Nov '06

The 'package' field is meant entirely for modules that are packaged together. From the updating modules page: > If you assign a package string for your module, on the admin/build/modules > page it will be listed with other modules with the same category. If you do > not assign one, it will simply be listed as 'Uncategorized'. Not assigning a > package for your module is perfectly ok; in general packages are best used > for modules that are distributed together or are meant to be used together. If your module stands alone, please simply leave this blank. Perhaps 'Uncategorized' is misnamed. Originally I had this as 'contributed' and I'd probably just as soon go back to that. To re-iterate: If you have a module, and your module has a .info file, and that .info file has a package line, and that package line is anything other than another module that 1) also has that package name and 2) needs to be listed with that module, DO NOT USE the package item. Leave it blank. Having just 1 or 2 modules in a 'package' completely destroys the usability of the modules page.

2 2

opinions needed
by Karoly Negyesi 27 Nov '06

27 Nov '06

There is no coding or reviewing required. I am just asking for opinions on http://drupal.org/node/99656 Thanks NK

3 3