- Development - lists.drupal.org

Re: [Privatemsg feature] Send to all
by mixel 30 Sep '06

30 Sep '06

I'm on vacation, will be back to check my mails on 30 september On 29-sep-06, at 17:19, jeffleeismyhero <drupal-devel(a)drupal.org> wrote: > Issue status update for http://drupal.org/node/86670 > Post a follow up: http://drupal.org/project/comments/add/86670 > > Project: Privatemsg > Version: 4.7.0 > Component: Code > Category: feature requests > Priority: normal > Assigned to: Anonymous > Reported by: jeffleeismyhero > Updated by: jeffleeismyhero > Status: active > > I would like a "Send to all" button to allow administrators to send a > message to everyone at once. > > > > > jeffleeismyhero

1 0

Re: [Privatemsg bug] Incorrect approach in theme_privatemsg_list
by mixel 30 Sep '06

30 Sep '06

I'm on vacation, will be back to check my mails on 30 september On 26-sep-06, at 16:38, Duke <drupal-devel(a)drupal.org> wrote: > Issue status update for http://drupal.org/node/86090 > Post a follow up: http://drupal.org/project/comments/add/86090 > > Project: Privatemsg > Version: 4.7.0 > Component: Code > Category: bug reports > Priority: normal > Assigned to: Anonymous > Reported by: Duke > Updated by: Duke > Status: active > Attachment: http://drupal.org/files/issues/privatemsg_list.patch > (1.31 KB) > > Hello. > > > You may consider this to be a minor bug, but it I decided to tell > about > it because it breaks Drupal form API idea. > > > It is incorrect to create a theme_privatemsg_list function and build a > form component model in it which is then displayed with help of > drupal_get_form('privatemsg_list_form', $form). A part of the form is > outputed in theme_privatemsg_list and another part in > drupal_get_form() > which is inconvinient - we need to override both theme functions to > customize output, difficult to create an accurate layout. > > > drupal_get_form() function already has an ability to call a theme() > function depending on form_id. So, you just need to build a form model > and call drupal_get_form('privatemsg_list_form', $form). Then you can > override theme_privatemsg_list_form() function to customize output of > the whole form. > > > My patch is very simple, it does 2 main things: > 1. Change theme("privatemsg_list",...) call to privatemsg_list() call. > 2. Remove $out = theme('links', $folder_list); from privatemsg_list() > function and change it to: > $form['folders'] = array( > '#type' => 'markup', > '#value' => theme('links', $folder_list) > ); > which is the main fix which gives us a single form with all data in > it. > > > Please review my patch. > Thank you for your good and usefull module. > > > > > Duke

1 0

javascript ids of cck fields
by fago 29 Sep '06

29 Sep '06

I have just written a small module "form_enabler", which enables/disables form fields in dependency of a checkbox. http://drupal.org/project/form_enabler I integrated this with the CCK, however I need the javascript ids of all target fields (= fields that depend of a checkbox). I couldn't find a simple way to get these IDs. So I wrote a function (form_enabler_form_get_ids()), which works similar like form_builder(). It builds all #parents, processes the form (#process), sets the #id like form_builder() would do and returns an array of ids for me. This is called during hook_form_alter(). This does already work, but the actual question I have is: Can this be done easier? Have I missed anything? -fago

1 0

Expressions of interest for paid community portal project
by caign 29 Sep '06

29 Sep '06

Hi, I'm seeking skilled & experienced Drupal developer(s) to work on a community portal project, incorporating jobs, classifieds, business listings, homes for sale & rent and other functionality. This is paid work for a commercial venture. To register your interest, please DON'T reply to this list. Reply to my email address or to communityportal(a)caignwebs.com.au (temp address only available for a week). Be advised I'll be looking for resumes, references and most importantly, examples of tight, elegant code. I know this is a technical forum but I thought some of you would welcome this opportunity - please forgive me if you don't agree. Thanks -- caign

5 5

Re: [development] Drupal 5.0 Theme - v2
by Trae McCombs 29 Sep '06

29 Sep '06

On 9/29/06, Eric Goldhagen <eric(a)openflows.org> wrote: > > I don't care how wide the left or right columns are, I care that I > can easily change their size via editing a css file. I don't really > like the washed out blue tones, but I could not care less as long as > I can easily modify values in a css file and get the result I want. > You should care how wide the left and right columns are, as if you enable some modules, such as event module, then if they are not at least 180px wide (200px is best) it'll break your design. Knowing this and how the modules work with Drupal is what seperates a good Drupal themer from just someone else who does themeing. To go back to a point you made (which I didn't quote) that we should care about those who've done TONS of installations for smaller groups, I agree there. And I too have done this. I've installed countless Drupal sites for very small groups or individual clients. The other comments you made are personal opinions (In my own personal opinino ;) So I declined to comment on everything. I'm sure someone else will debate it with you. Cheers, Trae -- Trae McCombs || http://occy.net/ Founder - Themes.org // Linux.com

1 0

Re: [development] Drupal 5.0 Theme - v2
by Boris Mann 29 Sep '06

29 Sep '06

On 9/29/06, Eric Goldhagen <eric(a)openflows.org> wrote: > Drupal is what it is not because of the one or two huge high profile > sites using it. It is what it is because of the multiple thousands of > small sites. The large folks will always have the money to make it do > anything they want, so we must focus on what people with limited > resources need -- in other words, the majority of users. And, as mentioned elsewhere, make it easy for folks to change. This might be for the beginning designer, as well as simple CSS editing (including formatting the CSS file so that colours, widths, etc. are near the top and well commented). > I think we need to separate the debate and discussion of what a > default theme needs from the discussion/review of any visual design > mockups or proposals. +1 -- Eric, your write up here is good, but perhaps a point form version would make it easier to checklist against. -- Boris Mann Vancouver 778-896-2747 San Francisco 415-367-3595 Skype borismann http://www.bryght.com

1 0

Re: [development] Drupal 5.0 Theme - v2
by Eric Goldhagen 29 Sep '06

29 Sep '06

I've been watching this debate with much interest. I have to respond at this point with a number of thoughts and opinions. I hope this is viewed in the constructive manner in which I intend. What is drupal and why does drupal have such a large userbase? What made drupal big? What is important to focus on? These are important questions to me and should inform decisions that we make, especially decisions about default theme. One person in the debate supported their opinions by pointing out their association with the production of one of the largest sites using drupal. In my mind that is the wrong way to look at things and demonstrates a major danger for any f/oss project. What the majority of users need and want will have little to do with that the largest users need and want. I'm more interested in the opinions of people that have implemented drupal for large number of small groups than those that have done the largest high profile projects. As well, please keep in mind that this mailing list is not anywhere close to a representation of the users of drupal. What themes are popular? what have people, by their actions, told us they like/need/want? how does that inform or relate to the construction of the default theme? Drupal is what it is not because of the one or two huge high profile sites using it. It is what it is because of the multiple thousands of small sites. The large folks will always have the money to make it do anything they want, so we must focus on what people with limited resources need -- in other words, the majority of users. browsers: we must make a default theme that works in any and all the browsers in common use. All the small organizations I have helped out still have a good percentage of folks that use browsers that people here have said are not necessary to support in a default theme (yes this includes making sure nothing breaks too badly with IE 5). Ignoring those users would be a huge blow to the growth of drupal. When I do a default installation to show drupal to a potential client, I can rest comfortably knowing that no matter what they hit it with, bluemarine will hold up and display as I expect. The goal of a default theme is not to wow the user, a default theme should first and foremost have a simple goal -- do not get in the way of the user looking around and learning how things work. window size: some seem to think that just because the average developer has a huge screen and most brand new computers have big screens that we can simply ignore the older machines and folks that, believe it or not, are still browsing the web at 600x800 pixels. To limit the core default design to large screens is foolish and will also limit the satisfaction people have with their installation. rounded corners: please don't do it! don't re-create why slashcode's default theme sucked (I thought I left those messes far behind when I started using drupal as my primary cms instead of slashcode a few years back). A default theme should be simple and have minimal bells and whistles. Avoid overly complex formatting and too many images. fluid vs fixed width. For the use of node edit and creation screens, as has been pointed out, the default drupal theme must be fluid. Allow this to be changed in CSS or wherever if the user desires a fixed width, but please have the default state be variable width. What is the use of a default theme? it is not to look really fancy and uber-cool, it should be simple and not detract from someone seeing drupal -- seeing the existence of header, footer, left and right sidebars and blocks; primary and secondary links, etc. (how they are separate and inter-related). A default theme should make the structure of drupal (blocks / sidebars / regions / menus / primary and secondary links) as clear as possible to a new user, not hide these distinctions in a sea of whitespace. I think there are different debates overlapping in this discussion so far. It is one thing to create really fancy looking themes to distribute *with* drupal, it is a completely different thing to design a default theme that will be the first place that most people interact with drupal. A default theme is about functionality and ease of modification of colors and sizes; optional themes distributed with core are about art and design. This sort of concern is not "design by committee," it is about defining specs for a designer to work from. Let's discuss what we all need and want in a default theme *before* the design work is done. Let that set of needs guide the designer and then get out of the way and let the designer design. Let's talk about what the header should be from a functional perspective, not about our like or dislike of washed out blue. I don't care how wide the left or right columns are, I care that I can easily change their size via editing a css file. I don't really like the washed out blue tones, but I could not care less as long as I can easily modify values in a css file and get the result I want. The default theme not only needs to be clean but it must be easy to change into something else with only css modifications. Drupal should allow me to let my designers tweak things without learning new skills. Please don't do fancy hacks to have cute rounded corners; make clear and understandable code and styles that anyone with a certain level of knowledge can manipulate. Save the fancy stuff for non-default themes. Much of what the theme under debate does and demonstrates is wonderful for a theme distributed with drupal, but in my opinion fails all tests for what a default theme should be. I think we need to separate the debate and discussion of what a default theme needs from the discussion/review of any visual design mockups or proposals. --Eric -- ------------------------------------------- Openflows Community Technology Lab, Inc. New York | Toronto | Montreal | Vienna http://openflows.com People are intelligent. Machines are tools.

1 0

RE: [development] Drupal 5.0 Theme - v2
by Steven Peck 29 Sep '06

29 Sep '06

The big blue bar on top does nothing for the theme except push down the title bar and drown the rest of the site. No matter how I try I can't look away. As I try and look down the page, my eye is constantly drawn to the big huge empty dominating color bar on top -sepeck ________________________________ From: development-bounces(a)drupal.org [mailto:development-bounces@drupal.org] On Behalf Of Trae McCombs Sent: Wednesday, September 27, 2006 6:22 PM To: development(a)drupal.org Subject: [development] Drupal 5.0 Theme - v2 First things first, Farsheed has done OUTSTANDING work on trying to incorporate a whole bunch of peoples ideas of what should or shouldn't be in the theme. Below isn't meant to be "open for discussion" per se. It is My Take[tm] on the direction I think the theme should go. If Dries likes it, cool, I hope everyone does too, but I know there will be those who absolutely hate my proposal. My "code" is based off of the 14.zip version that Farsheed put up. I still feel he's the best person to pull these changes together once everything is all settled, I hope I've not made too much of a mess for him. ;) I don't know how to use diff and all that stuff as he does. I just make things pretty[tm]. "My" Theme: http://themes.net/ WHILE you look at the theme above, keep in mind I've only worked on the Fixed version. That isn't to say that I won't work on the fluid version too. Also note that It is NOT a finished version. Below are the tweaks I want to implement of which I feel will push this theme over the edge and make it worth of Drupal 5.0 default theme: * Rounded Corners Yes, we love them don't we? I would like to have rounded corners on the following areas [current colors kept in tact]. 1. Search area 2. Mission 3. Footer If you have Inkscape [ http://inkscape.org ] create a rectangle and click the rectangle select and set Rx and Ry to either 8 or 13. Those are the corner radii I'm thinking of using. I know how to implement a "pure html" way to do rounded corners with no images { as can be seen on my bands site -- yes, it's crappy looking -- http://theinterference.com/ } But wanted to discuss this implementation with maybe Ted, Farsheed, others as to what would be the best way technically to implement the rounded corners. My way I think is smooth and clean, and works on all browsers, but does put a lot of extra mark-up. Do we want that much extra mark-up going into a core theme? * Search bar and Footer bar Texture... these areas will have a nice clean texture in the background (of course, depending on the method we use for rounded corners) But the texture will really make those areas pop. I'll work on this tomorrow. I might simply repeat the "Glassy" feel from the Primary links to those areas. * Secondary Links I'd say we should have a place for Secondary links built into the top search bar, much like the Primary links. These are probably just small font links left aligned. * Logo on Right Not sure which logo to use... There are several Drupal Icon's laying around and wanted to know which is the "official one". This could tie into the "change the logo" discussion we had earlier. Would be nice to at least get the ability to change the logo easily with AJAX goodness into Drupal 5.0 That's about it... If everyone hates this and loves Farsheeds better, my feelings won't be hurt. I figured I'd spend some time, and put up instead of shutting up. :) The way that Farsheeds theme worked, still works, 2col(l/r) and 3col as is displayed. Again, I haven't touched fluid, so I'd have to go back in and fix those things. I can dedicate the rest of this week to this project should everyone (read: Dries) approve of my work thus far, and possibly a wee bit more time after that. Peace love and Bananas, Trae "The Artist Formerly Known as Occy" PS. I hope I didn't forget anything that should have gone in this PS area. :) -- Trae McCombs || http://occy.net/ Founder - Themes.org // Linux.com

10 18

RE: [development] Drupal 5.0 Theme - v2
by Steven Peck 29 Sep '06

29 Sep '06

I will mention some thoughts. 1. 12.24% of one of my sites is 800x600. Some of that traffic is from people who have old equipment and can't afford new and other is from large monitors and bad eyesight. There are still sites out there using modified versions or unmodified versions of Blue Marine. 2. I certainly hope we are not considering 'AD' space for the default Drupal theme. I really don't want to look at an ad out of the box with the default base theme. Or look at the big message that says PLACE AD BLOCK HERE 3. The blue color is fine, just to big and dominating. Perhaps a fade gradient ala Chameleon and tighten it up a bit. Something to make it dominate the content less. Putting secondary links is fine but does it go away when there is no search bar/secondary links? Secondary links to me are not needing to be huge and overpowering... They are meant to be secondary, or context sensitive 4. If rounded corners add DIV's then it should not be done. Not because of Morbus' reason of markup (which are perfectly fine reasons), etc, but from a practicality standpoint of keeping it simple for those learning how to use Drupal theme's and for those maintaining it in core. 5. Using JavaScript to round corners has the added benefit of providing an example of using JQuery in a core theme. Sides, Steven's comment about 'all the pastelly rounded corners and soft shadows' when he did his redesign kind of interesting. Just my thoughts. -sepeck

1 0

Logo And other component changes in themes [ Was 5.0 theme ]
by Trae McCombs 29 Sep '06

29 Sep '06

Here you go Kieran... Keep in mind this is a completely cheesy mockup and NOT my idea of a great UI solution. It is merely an illustration to hopefully convey a point. http://occy.net/tmp/Change_Logo-mockup-1.png http://occy.net/tmp/Change_Logo-mockup-2.png Trae PS. I changed the subject, as this seems like a fork of the original discussion. But an important one nonetheless. On 9/26/06, Kieran Lal <kieran(a)civicspacelabs.org> wrote: > > > On Sep 26, 2006, at 6:35 AM, Trae McCombs wrote: > > Hmmm, I just had an interesting idea... > > > How about a mock-up/Wireframe? > > Kieran > > -- Trae McCombs || http://occy.net/ Founder - Themes.org // Linux.com

7 11