- Development - lists.drupal.org

moderate flag
by Dries Buytaert 10 Jul '06

10 Jul '06

Hello world, I committed Chris' moderate-flag patch to CVS HEAD: http://drupal.org/node/72343 The module upgrade instructions in the Drupal handbook need to be updated. A number of modules need to be updated as well. -- Dries Buytaert :: http://www.buytaert.net/

1 0

Re: [development] hook_nodeapi vs. $form['#submit']
by Dave Cohen 10 Jul '06

10 Jul '06

Resending mail that didn't make it to the list... > I've come to realize for my node relationship code, I need to handle node > deletion and do some things when loading as well. So to answer my own > question, hook_nodeapi is required, and for more than just the inserting > and updating. > > So thanks but never mind! > > On Sunday 09 July 2006 18:57, Dave Cohen wrote: > > I'm building a site which has two custom node types with a one-to-many > > relationship. That is, one type is a container for items of the second > > type. > > [blah blah blah...]

1 0

hook_nodeapi vs. $form['#submit']
by Dave Cohen 10 Jul '06

10 Jul '06

I'm building a site which has two custom node types with a one-to-many relationship. That is, one type is a container for items of the second type. When creating/editing container nodes, I want the form to allow the user to choose from nodes of the contained type. Similarly when creating/editing the contained type the user may choose a container in which to place it. I know about the node relativity module, but without going off on a tangent I don't think its appropriate for this case. The way I see it, I have two ways to implement this. Because I'm defining the two node types, I can put all the code I need into hook_form, hook_insert and hook_update. That's the first option. Another option is to not modify the modules defining the node types, and instead introduce another module which is aware of the two types and defines the relationship between them. In this module I would use hook_form_alter to add what is needed in the edit forms and hook_nodeapi for the insert and update events. I'm partial to using this second option, because in the end I'll have a nifty code snippet that I could use anytime I want to make one node type a collection of other node types. So my question is, for the second option, do I really need hook_nodeapi? Wouldn't it be nice to use hook_form_alter to add fields to the forms, and define $form['#submit'] to call callbacks to handle inserts and updates? That way, my callbacks would only be called when necessary whereas hook_nodeapi gets called an aweful lot (every node load, for instance). And my answer is yes, I really do need to define hook_nodeapi. Because the $form['#submit'] callback does almost what I need, but not quite everything. In particular, when the submit callback is called during a node insert, there is no way to learn the new node's id. And for my code the node id is necessary. What do you think? Would it make more sense to use the combination of hook_form_alter and $form['#submit'] callback, rather than hook_form_alter and hook_nodeapi? Is there some way to get the inserted node id that I'm not aware of? Should there be a way? Thanks, -Dave

2 1

Moderation bit behavior
by Neil Drumm 09 Jul '06

09 Jul '06

Right now we have an inconsistency with our moderation bit. Is it supposed to control the visibility of posts, or is that solely dependent on status? 13 queries say it should have an effect and /up to/ 38 queries say no. The issue for this is over at http://drupal.org/node/71730. I think the underlying problem may be that published (status) is not mutually exclusive with moderation. -- Neil Drumm http://delocalizedham.com/

25 66

Extend database abstraction layer, to include table creation.
by Adrian Rossouw 09 Jul '06

09 Jul '06

http://drupal.org/node/63049 Now that we have .install files for modules, I believe it is time we extended our database abstraction layer. I recommend we create the following extra functions : 1. db_create_table($tablename, $columns); // columns is an associative array with the 'name' => 'type' 3. db_drop_table($tablename); 3. db_create_index($tablename, $columns); // columns is an array of column names, or just a single column. 4. db_drop_index($tablename, $columns); 5. db_add_column($tablename, $column, $type); // PGSQL already has a similar function, but it isn't in both systems. 6. db_drop_column($tablename, $column); The installer that is coming in, will be converting the database.*sql files into a system.install file, and with these functions, we can collapse ALL THREE SCHEMA FILES, into a single, much simpler file. This will also _drastically_ simplify updates, and it will give us consistent usage of types across the database. Certain things will still need to happen only on postgres (like create function calls for instance), but this DRASTICALLY decreases the amount of work we have to do to support multiple db types. At the moment, there are no create table statements that can be changed in core itself (until we have a system.install) , however, contrib modules can already be ported to use these functions, which would mean that we have (preliminary) postgres support across the board on all contrib modules. These functions should possibly keep track of what tables / columns / indexes have already been created, that would allow us to check (in a cross db way) what tables are available, and maintaining this information could possibly be useful in the future, such as not creating tables which have already been created. Additionally, each of these functions can be used to trigger a process for entering additional database credentials, in the case that the specific database user is not allowed to create tables and the like. This also helps make the patch for the installer a lot simpler, so if you want to help out with the installer, this would be a good thing to get involved with =) -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com

31 110

Release critical bugs for July 09, 2006
by drupal-devel＠drupal.org 09 Jul '06

09 Jul '06

/ bug reports 4.7 Beta/ CVS Errors assigned: msameer age: 15 weeks 2 days url: http://drupal.org/node/55533 / bug reports Chatbox logs can be seen without permission age: 1 week 6 days url: http://drupal.org/node/70724 Localization problem age: 6 weeks 6 days url: http://drupal.org/node/64847 No check for loading chatbox with other name age: 32 weeks 5 days url: http://drupal.org/node/38397 / bug reports User warning: unknown column age: 2 weeks 3 days url: http://drupal.org/node/70131 event_start not being set age: 6 weeks 2 days url: http://drupal.org/node/65609 Next link will not show for Junes events age: 8 weeks 7 hours url: http://drupal.org/node/63454 Fatal Error After activating "Browse Scheduled Events" in modules age: 9 weeks 2 days url: http://drupal.org/node/61920 Event module preventing me from uploading age: 11 weeks 1 day url: http://drupal.org/node/59775 INSTALL.txt incorrect age: 11 weeks 6 days url: http://drupal.org/node/59019 event calendars off by day/not respecting timezones - fix? age: 14 weeks 5 days url: http://drupal.org/node/56189 Flexinode generates an error age: 15 weeks 4 days url: http://drupal.org/node/55135 Body text missing age: 16 weeks 2 days url: http://drupal.org/node/54383 Calendar subscribing not working age: 16 weeks 4 days url: http://drupal.org/node/54036 Problem Selecting Event by Type age: 17 weeks 4 days url: http://drupal.org/node/52883 Drupal Event age: 28 weeks 4 days url: http://drupal.org/node/41833 Event start and end times not getting saved in database age: 29 weeks 2 days url: http://drupal.org/node/41300 Issues with list view for events age: 30 weeks 6 days url: http://drupal.org/node/39943 Database error keeps popping up age: 31 weeks 4 days url: http://drupal.org/node/39396 Date problem on calendar, off by a day age: 31 weeks 5 days url: http://drupal.org/node/39193 Events module bugs adding and changeing events age: 32 weeks 2 hours url: http://drupal.org/node/39016 gmdate() warnings on windows install age: 1 year 1 week url: http://drupal.org/node/26140 / support requests Blank Page After Submit age: 12 weeks 16 hours url: http://drupal.org/node/58918 Can't Administer Event Module age: 26 weeks 2 days url: http://drupal.org/node/43509 displaying event start info in flexinode tabular view? age: 39 weeks 4 days url: http://drupal.org/node/33019 Event block missing content of many fields age: 42 weeks 1 hour url: http://drupal.org/node/31532 / bug reports ArrayMerge Errors with PHP5 age: 19 weeks 1 day url: http://drupal.org/node/51174 / bug reports Embedded G2: blank pages with Gallery Block enabled age: 8 weeks 1 day url: http://drupal.org/node/63326 errors on cron run and in watchdog age: 8 weeks 6 days url: http://drupal.org/node/62335 IE error using embed not error with none-embed... age: 9 weeks 1 day url: http://drupal.org/node/62119 Gallery module render wrong size with 4.7b5 age: 17 weeks 5 days url: http://drupal.org/node/52706 block manage - Block specific settings can save item selected - with drupal 4.7B4 age: 18 weeks 6 days url: http://drupal.org/node/51436 Gallery Module Settings Fatal Error age: 20 weeks 6 days url: http://drupal.org/node/49046 Latest patch hosed my G2 integration and G2 Standalone age: 31 weeks 5 days url: http://drupal.org/node/39168 problem viewing newly added photos in embedded gallery. age: 32 weeks 6 days url: http://drupal.org/node/38352 problem viewing newly added photos in embedded gallery. assigned: trobison age: 32 weeks 6 days url: http://drupal.org/node/38351 Full screen slideshow in Gallery module is not working (erroring out on the wrong URL) age: 1 year 2 days url: http://drupal.org/node/26479 / feature requests Unable to initialize embedded Gallery age: 20 weeks 4 days url: http://drupal.org/node/49417 / support requests Gallery Module stopped working age: 30 weeks 5 days url: http://drupal.org/node/40117 import existing gallery2 user account age: 35 weeks 5 days url: http://drupal.org/node/35920 / feature requests po files and other language support age: 23 weeks 4 days url: http://drupal.org/node/46313 / feature requests Goofy Forum UI age: 40 weeks 5 days url: http://drupal.org/node/32294 / bug reports htmlArea/xinha firefox freezes (multiple textareas) age: 5 weeks 2 days url: http://drupal.org/node/66746 Layout is quirky age: 17 weeks 5 days url: http://drupal.org/node/52741 view source broken in firefox 1.5 age: 23 weeks 4 days url: http://drupal.org/node/46246 Toolbar won't display correct in IE 6 with Pushbutton Theme age: 43 weeks 2 days url: http://drupal.org/node/30696 / support requests Problem with size of button assigned: khayman age: 10 weeks 5 days url: http://drupal.org/node/60255 / bug reports Localization issue for Premiew and Thumbnail links age: 2 weeks 2 days url: http://drupal.org/node/70396 Category module and image_gallery age: 6 weeks 5 days url: http://drupal.org/node/65066 Problem in Image Gallery display especially in Internet Explorer age: 19 weeks 2 days url: http://drupal.org/node/50943 By CHanging the following the error changes assigned: walkah age: 29 weeks 2 days url: http://drupal.org/node/41353 imagemagick.inc file does not contain the function... age: 34 weeks 14 hours url: http://drupal.org/node/37372 Error when Submitting New Image Node age: 34 weeks 15 hours url: http://drupal.org/node/37366 only variables can be passed by reference on line 713 age: 35 weeks 3 days url: http://drupal.org/node/36092 image.module 4.6.0 strange actions age: 39 weeks 2 days url: http://drupal.org/node/33292 File copy failed: source file does not exist error after running update-image.php age: 41 weeks 4 days url: http://drupal.org/node/31816 Path for image folder not inserted correctly when nodetype = image age: 44 weeks 4 days url: http://drupal.org/node/30031 image module patch & image_import module age: 45 weeks 6 days url: http://drupal.org/node/29377 image module fails on dual site configuration age: 51 weeks 3 days url: http://drupal.org/node/26657 Cannot upload .jpgs age: 1 year 18 weeks url: http://drupal.org/node/18076 / feature requests Copying original age: 35 weeks 2 days url: http://drupal.org/node/36321 / support requests showing the galleries separately age: 2 weeks 1 day url: http://drupal.org/node/70499 upload image wont' display, it show a file not found page age: 14 weeks 3 days url: http://drupal.org/node/56491 I need to change the style of displaying each node. Please help. age: 26 weeks 6 days url: http://drupal.org/node/43017 What does update-image.php do exactly? age: 28 weeks 1 day url: http://drupal.org/node/42222 images not showing2 age: 31 weeks 1 day url: http://drupal.org/node/39773 Image Folder Permissions age: 37 weeks 1 day url: http://drupal.org/node/34839 Image Module Permissions age: 1 year 5 days url: http://drupal.org/node/26280 / bug reports user lookup on name only assigned: zeroj age: 14 weeks 3 hours url: http://drupal.org/node/56936 Link to mailhandler does not use l() function age: 25 weeks 1 day url: http://drupal.org/node/44599 Listhandler caused error in "comment.module on line 996" ? age: 35 weeks 2 days url: http://drupal.org/node/36244 Listhandler 4.6.0 fails to send emails at all age: 50 weeks 4 days url: http://drupal.org/node/27095 / tasks Correct/Complete Documentation age: 37 weeks 16 hours url: http://drupal.org/node/34909 / support requests Creating a page using mailhandler age: 3 weeks 4 days url: http://drupal.org/node/68947 Mail Body not downloaded age: 26 weeks 3 days url: http://drupal.org/node/43374 / bug reports Update: beta5 and possible problem with php 4 age: 18 weeks 3 days url: http://drupal.org/node/52004 Patch for member.module to bring it up to 4.7 age: 22 weeks 1 day url: http://drupal.org/node/47829 foreach() assigned: neablo age: 27 weeks 5 days url: http://drupal.org/node/42350 / feature requests Enable nodewords for node type? age: 21 weeks 1 day url: http://drupal.org/node/48869 / bug reports nodes are being created with no body age: 30 weeks 3 days url: http://drupal.org/node/40373 missing promote column assigned: Bèr Kessels age: 32 weeks 1 day url: http://drupal.org/node/38836 Naming issues with files and DB tables age: 37 weeks 6 days url: http://drupal.org/node/34298 RSS "no element found at line 1" age: 1 year 1 week url: http://drupal.org/node/26185 Outdated help texts age: 1 year 48 weeks url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 2 years 5 weeks url: http://drupal.org/node/8128 / tasks move XML-parser into an inclde file. age: 1 year 2 weeks url: http://drupal.org/node/25439 / bug reports Content published by scheduler not mailed out age: 4 weeks 5 days url: http://drupal.org/node/67475 Notify not playing well with Organic Groups age: 29 weeks 5 days url: http://drupal.org/node/40967 / bug reports Login as an alias gets cached age: 41 weeks 5 days url: http://drupal.org/node/31699 / bug reports Malformed PDFs age: 27 weeks 6 days url: http://drupal.org/node/42312 support dynamic content? age: 33 weeks 1 day url: http://drupal.org/node/38181 please explain html2fpdf age: 33 weeks 4 days url: http://drupal.org/node/37748 Management of french charaters age: 34 weeks 6 days url: http://drupal.org/node/36605 / support requests Problem with PDFView age: 24 weeks 5 days url: http://drupal.org/node/45092 / bug reports Replying to a message from a person who doesn't accept private messages leads to blank screen age: 14 weeks 5 days url: http://drupal.org/node/56136 privatemsg module: - database error - incompatibility with relationship module age: 21 weeks 1 day url: http://drupal.org/node/48866 anonymous users can create folders and view all anonymous sent-mail age: 29 weeks 2 days url: http://drupal.org/node/41361 Reminder email links don't work age: 1 year 2 weeks url: http://drupal.org/node/25677 / bug reports "issues" page: search criteria reset when viewing custom search results pages 2-"last" age: 2 weeks 6 days url: http://drupal.org/node/69626 Tagging of Sub-projects. age: 6 weeks 4 days url: http://drupal.org/node/65110 attachements missing after pressing preview age: 11 weeks 6 days url: http://drupal.org/node/59039 upper right search form on issue pages is broken age: 13 weeks 6 days url: http://drupal.org/node/57023 Can't attach patch to initial issue post age: 14 weeks 6 days url: http://drupal.org/node/55984 drupal.org tarballs out of date age: 17 weeks 6 days url: http://drupal.org/node/52560 Problems with project_projects_select_options() - taxonomy hierarchies age: 18 weeks 1 day url: http://drupal.org/node/52262 SQL errors on issues and my projects pages age: 28 weeks 2 days url: http://drupal.org/node/42160 Issues from multiple projects listed on a single issue's page age: 32 weeks 3 days url: http://drupal.org/node/38704 Get disconnected from server on attempting to add an issue age: 35 weeks 3 days url: http://drupal.org/node/36124 issue query table: can't select all projects assigned: dww age: 39 weeks 2 days url: http://drupal.org/node/33262 Projects not listed and page not complete age: 1 year 5 weeks url: http://drupal.org/node/23956 / feature requests Need Documentation age: 30 weeks 2 days url: http://drupal.org/node/40392 Allow subscription to individual project issues age: 37 weeks 4 days url: http://drupal.org/node/34496 / support requests Fatal error: Only variables can be passed by reference age: 16 weeks 4 days url: http://drupal.org/node/53984 Add the project release manually without the scan feature age: 37 weeks 4 days url: http://drupal.org/node/34500 / tasks New method for contributed project releases and versions age: 12 weeks 6 days url: http://drupal.org/node/58066 / bug reports PHP Fatal error: Call to undefined function: form_textarea() in [drupal root]\modules\recipe\recipe.module on age: 6 weeks 4 days url: http://drupal.org/node/65168 Node not added after filling in ad recipe template age: 11 weeks 3 days url: http://drupal.org/node/59548 Error with URL to recipe age: 44 weeks 6 days url: http://drupal.org/node/29885 / tasks recipe module not security checked age: 16 weeks 2 days url: http://drupal.org/node/54431 / bug reports Argument #1 is not an array age: 3 weeks 2 days url: http://drupal.org/node/69286 Cron job creates SQL error age: 5 weeks 5 days url: http://drupal.org/node/66202 / support requests Need help with Sched and Agregator age: 12 weeks 3 days url: http://drupal.org/node/58540 / bug reports Error when searching an existing user.... age: 23 weeks 4 days url: http://drupal.org/node/46288 / bug reports Error on Page with Internet Explorer 6 age: 3 weeks 4 days url: http://drupal.org/node/68906 Taxonomy DHTML's cache ignores user privileges age: 7 weeks 1 day url: http://drupal.org/node/64532 IE hangs on loading js or when clicking before before page finishes loading age: 15 weeks 1 hour url: http://drupal.org/node/55924 taxonomy_dhtml breaks security? age: 27 weeks 3 days url: http://drupal.org/node/42531 Does not work correctly in Internet Explorer age: 39 weeks 1 day url: http://drupal.org/node/33354 Blocks switch and reset when vocabs are modified age: 1 year 8 weeks url: http://drupal.org/node/22631 javascrip downloads square.gif for every category age: 1 year 20 weeks url: http://drupal.org/node/17366 / feature requests A unique page for each category group? age: 37 weeks 3 days url: http://drupal.org/node/34610 / bug reports Taxonomy links only work for the first line of links assigned: PierreFWalter age: 19 weeks 1 day url: http://drupal.org/node/51149 / support requests Taxonomy has dissapeared age: 39 weeks 4 days url: http://drupal.org/node/33061 / bug reports Sends trackbacks for unpublished nodes assigned: ankur age: 1 year 23 weeks url: http://drupal.org/node/16239 / bug reports Fatal error for Drupal 4.7.0 installed with Fantastico age: 1 week 2 days url: http://drupal.org/node/71407 Sometimes when I open the drupal site in My Local machine I am getting the error. age: 17 weeks 6 days url: http://drupal.org/node/52652 Event start/end date section should *not* show first on Submit event page age: 28 weeks 4 days url: http://drupal.org/node/41869 meet age: 29 weeks 4 days url: http://drupal.org/node/40996 / feature requests A better Drupal.org Index (homepage) interface/layout mockup age: 23 weeks 6 days url: http://drupal.org/node/45967 A small but effective improvement to Improvement of admin/user accessability suggestion age: 38 weeks 1 day url: http://drupal.org/node/34073 / support requests block module / side-content module age: 8 weeks 5 days url: http://drupal.org/node/62506 Acess denied to login Newly installed and upgraded site that I need up and running A.S.A.P assigned: Johnny age: 33 weeks 15 hours url: http://drupal.org/node/38227 / bug reports Logging out error age: 14 weeks 2 days url: http://drupal.org/node/56663 / bug reports the wiki module can't work with HTML age: 22 weeks 5 days url: http://drupal.org/node/47124

1 0

MySQL tools
by Khalid B 09 Jul '06

09 Jul '06

These two MySQL tools may prove useful for troubleshooting, benchmarking and optimization ... http://hackmysql.com/mysqlreport http://mtop.sourceforge.net

3 3

image button form element module?
by Karoly Negyesi 09 Jul '06

09 Jul '06

Hi, Anyone written an image button form element module? It's easy, I am just sooo lazy :) Regards NK

4 3

blogapi client
by Karoly Negyesi 09 Jul '06

09 Jul '06

Hi, I have a blogapi client module for 4.6. It can post nodes via blogger, metaweblog or Atom APIs and autodiscover all these (yay for blogger.com which has two service.post links but only one of them is actually usable... I worked around that.) I still need to make a wizard form based on b) and hook a) into the node process but that's fairly trivial and will happen within a day. I am willing to contribute this module and will submit my enhancements as I write them (for my dayjob, that is) but I am not willing to maintain this. If you are interested, drop me a line and I will send you the module. That the module is 4.6 does not matter much at this point, there is very little that needs to be changed to make it work under 4.7 (it will be more when that wizard form is done). Regards NK

1 0

RE:[development] Drupal's database interaction
by AjK 09 Jul '06

09 Jul '06

> I did some experiments that can help us understand and improve Drupal's database interaction: > > http://buytaert.net/drupal-database-interaction > > From the looks, there is some stuff that can be optimised. :) > > -- > Dries Buytaert :: http://www.buytaert.net/ Taking up the challenge, I've made a start on looking at optimisation. For those interested in this subject please look at my first "report" at http://spiders-lair.com/node/23 (is there a better place for me to post articles like this?) I'd rather get feedback from those "in the know" before I start going down a complex road that may be just a waste of time. Also, on a more conventional note, I'm starting to look for SQL optimisations within "core". My first possibility is posted on this issue:- http://drupal.org/node/72828 Expect more :) I'd appreciate it if any "follow ups" to these were done either on the issue or in response to my article via this list as opposed to leaving comments (your are welcome to post comments though but I think a better place is needed for articles like this). best regards, --AjK (Andy) http://drupal.org/user/39030

2 2