- Development - lists.drupal.org

[drupal-devel] [bug] Menu cache prohibiting access for users
by Uwe Hermann 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/24034 Post a follow up: http://drupal.org/project/comments/add/24034 Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: nysus Updated by: Uwe Hermann Status: patch (code needs work) Attachment: http://drupal.org/files/issues/user.menu.cache_0.patch (1.5 KB) Rerolled patch for HEAD (untested, though). Uwe Hermann Previous comments: ------------------------------------------------------------------------ Wed, 01 Jun 2005 00:05:09 +0000 : nysus See http://drupal.org/node/24019 for description of the problem. ------------------------------------------------------------------------ Wed, 01 Jun 2005 01:04:21 +0000 : Steven Attachment: http://drupal.org/files/issues/user.menu.cache.patch (1.62 KB) Patch attached. ------------------------------------------------------------------------ Mon, 01 Aug 2005 01:32:36 +0000 : killes(a)www.drop.org Does not apply anymore.

1 0

[drupal-devel] [feature] Increase performance of node_page
by jvandyk 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/29335 Post a follow up: http://drupal.org/project/comments/add/29335 Project: Drupal Version: cvs Component: node.module Category: feature requests Priority: normal Assigned to: jvandyk Reported by: jvandyk Updated by: jvandyk Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/node_speedyview.patch (1.8 KB) The switch statement on $op in node_pager() currently has to go through feed, add, revisions, rollback-revision, delete-revision and edit cases before hitting the most common case, the view operation. This patch simply moves the location of the view operation to second, after feed, as we want view to be as fast as possible. It also removes the blank line before the delete case for consistency. jvandyk

1 1

[drupal-devel] [bug] Bug with error_level in includes/common.inc?
by Uwe Hermann 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/25084 Post a follow up: http://drupal.org/project/comments/add/25084 Project: Drupal -Version: 4.6.1 +Version: cvs Component: base system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: jasonmcmunn Updated by: Uwe Hermann -Status: active +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/common_12.patch (680 bytes) AFAIK it's not the code that is wrong but the docs. Here's a patch. Someone should review this before committing. Uwe Hermann Previous comments: ------------------------------------------------------------------------ Wed, 15 Jun 2005 17:35:45 +0000 : jasonmcmunn In the following code it says that it will log to the database if it is set to 1, and log to the screen if it is set to 2. Well, as it stands, it logs to the screen if it's one and not two. very easy fix, just change the two 1s to 2s. /** * Log errors as defined by administrator * Error levels: * 1 = Log errors to database. * 2 = Log errors to database and to screen. */ function error_handler($errno, $message, $filename, $line) { if ($errno & (E_ALL ^ E_NOTICE)) { $types = array(1 => 'error', 2 => 'warning', 4 => 'parse error', 8 => 'notice', 16 => 'core error', 32 => 'core warning', 64 => 'compile error', 128 => 'compile warning', 256 => 'user error', 512 => 'user warning', 1024 => 'user notice', 2048 => 'strict warning'); $entry = $types[$errno] .': '. $message .' in '. $filename .' on line '. $line .'.'; if (variable_get('error_level', 1) == 1) { print '<pre>'. $entry .'</pre>'; }

1 0

[drupal-devel] [bug] Teaser always truncated at 600 characters
by killes 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/28211 Post a follow up: http://drupal.org/project/comments/add/28211 Project: Drupal -Version: 4.6.2 +Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: neale Updated by: killes(a)www.drop.org -Status: active +Status: patch (code needs review) changing version and status. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Thu, 04 Aug 2005 19:18:23 +0000 : neale Attachment: http://drupal.org/files/issues/diff_27 (1.16 KB) The truncation code in node_teaser doesn't make any sense to me: <?php foreach ($breakpoints as $point => $charnum) { if ($length = strpos($body, $point, $size)) { return substr($body, 0, $length + $charnum); } } ?> I don't understand: why is the offset given to strpos the maximum teaser size? This would cause teasers to only be nicely split if they are enough longer than the max. teaser size to have one of the special characters. But this guarantees the teaser will either be abruptly truncated, or over the max. teaser size! In fact, this is what I'm seeing on my installation. Attached is a patch that makes it work the way I think it was intended. At least, it makes more sense to me.

1 0

[drupal-devel] [feature] List of bloggers
by Bèr Kessels 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/17030 Post a follow up: http://drupal.org/project/comments/add/17030 Project: Drupal Version: cvs Component: blog.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels -Status: patch (code needs work) +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/blog_bloggers_list_1.patch (1.75 KB) Bingo! My own patch, brought to you by patchbingo! Bèr Kessels Previous comments: ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:27:27 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:31:49 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:34:15 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ Sat, 19 Feb 2005 20:13:20 +0000 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano. ------------------------------------------------------------------------ Thu, 17 Mar 2005 22:17:39 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) ) ------------------------------------------------------------------------ Thu, 17 Mar 2005 22:19:53 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2_0.patch (1.71 KB) sigh. something tells me i should stop working.... a silly "F" sneaked into the previous patch. ------------------------------------------------------------------------ Thu, 24 Mar 2005 20:25:01 +0000 : Anonymous I applied the patch, reuploaded the blog.module and then deactivated and reactivated it. I cannot see a difference. How do I access the blog users page? Drupal 4.6rc thanks for the help. ------------------------------------------------------------------------ Thu, 24 Mar 2005 20:53:26 +0000 : Bèr Kessels look in the menu admin. ------------------------------------------------------------------------ Wed, 18 May 2005 13:38:39 +0000 : Bèr Kessels Nearly two months since the patch. If there is no need for this I will mark it won't fix. ------------------------------------------------------------------------ Wed, 18 May 2005 13:52:56 +0000 : tostinni I made a custom block for this, but it still need a little improvment (add "read more" for example). So I don't know if it's usefull but if anyone care : <?php $result = db_query("SELECT u.uid, u.name, COUNT(0) AS num FROM {node} n LEFT JOIN {users} u ON u.uid = n.uid WHERE n.type = 'blog' GROUP BY u.uid, u.name ORDER BY u.name ASC"); while ($blog = db_fetch_object($result)) { $output .= '<li />'.l($blog->name. ' ('.$blog->num.')', 'blog/'.$blog->uid); } return '<ul>'.$output.'</ul>'; ?> ------------------------------------------------------------------------ Wed, 18 May 2005 16:06:36 +0000 : Chris Johnson I think this is a useful feature. I've coded custom blocks in the past to provide it on my sites. ------------------------------------------------------------------------ Sat, 21 May 2005 05:23:11 +0000 : Andrzej7 I was a little afraid (poor PHP) to install the patch (March...), but I have made a block. And it's very nice. One question only. All the bloggers are shown, but the Admin (user No 1) is on the list and he has no blogs. What's that? ------------------------------------------------------------------------ Sun, 22 May 2005 16:24:08 +0000 : Bèr Kessels To avoid confusion: this patch ads no blocks, but shows the list inline: as content! ------------------------------------------------------------------------ Sat, 18 Jun 2005 22:07:42 +0000 : igrcic aaargh.....there is a problem when using PostgreSQL db. After I successfully patch blog.module and enable it in menu, click on it and following sql errors pop up: warning: pg_query(): Query failed: ERROR: function count(integer, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 45. user error: query: SELECT COUNT(DISTINCT u.uid, u.name) FROM users u LEFT JOIN node n ON n.uid = u.uid WHERE n.type = 'blog' AND n.status =1 ORDER BY n.created DESC in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 62. warning: pg_query(): Query failed: ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 45. user error: query: SELECT DISTINCT u.uid, u.name FROM users u LEFT JOIN node n ON n.uid = u.uid WHERE n.type = 'blog' AND n.status = 1 ORDER BY n.created DESC LIMIT 10 OFFSET 0 in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 62 For first one its clear, there is no such fucntion in Postgresql, and second one is typical Postgresql/Mysql error, n.created isn't in select syntax. But if we put it in a select distinct syntax , it isn't DISTINCT anymore, so I get lots of lines with user and all of his blogs, with different time of course. So we must modify query a bit: SELECT DISTINCT u.name, u.uid, MAX(n.created) as time FROM users u LEFT JOIN node n ON n.uid = u.uid WHERE n.type = 'blog' AND n.status = 1 GROUP BY u.name,u.uid ORDER BY time DESC It works fine like this :) Didn't look for first one yet... will when I catch some time. Cheers! ------------------------------------------------------------------------ Sat, 18 Jun 2005 22:15:29 +0000 : igrcic Attachment: http://drupal.org/files/issues/blog_bloggers_list_0.patch (1.75 KB) Sorry, here is a patch for a blog_bloggers_list_2_0.patch :) ------------------------------------------------------------------------ Tue, 05 Jul 2005 09:08:19 +0000 : Bèr Kessels That doesz not seem a patch of a patch, but a regular patch. Igrirc, please note that the SQL contains unbracketed tablenames. That is unacceptible. If you don't want to fix it, please report it back here, So I can fix it otherwise :)

1 0

[drupal-devel] [bug] collapsible fieldset icon and ie 5.0
by fago 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: 4.6.0 Component: other Category: bug reports Priority: minor Assigned to: fago Reported by: fago Updated by: fago Status: patch (code needs review) Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached fago

5 6

[drupal-devel] [bug] Time zone improperly handled in archive.module
by killes 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/8287 Post a follow up: http://drupal.org/project/comments/add/8287 Project: Drupal Version: cvs Component: archive.module Category: bug reports Priority: normal Assigned to: Goba Reported by: Goba Updated by: killes(a)www.drop.org -Status: active +Status: patch (code needs work) Changing status. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Fri, 04 Jun 2004 11:00:12 +0000 : Goba Attachment: http://drupal.org/files/issues/Drupal-archive-time.patch (706 bytes) The user time zone values are added and substracted from local time values (mktime() and friends), and therefore the resulting datetime values are not right. gmmktime() should be used instead of mktime(), since GMT is what the timezone setting is supposed to be relative to. Here is a patch which fixes part of the problem. It would be nice if someone with understanding of the calendar printout code (or enough time to find out how does it work) would submit a patch against the mktime() issues there. This patch fixes the archive_page time issue. Probably also relevant for HEAD (patch against 4.4.x CVS) ------------------------------------------------------------------------ Fri, 04 Jun 2004 18:08:17 +0000 : Kjartan I would like to see a complete patch that handles everything. For that matter I would love to have the archive module improved in general. ------------------------------------------------------------------------ Tue, 01 Mar 2005 09:29:45 +0000 : Bèr Kessels Setting this to CVS. We discussed removing this module on the Drupal Sprint. Whenever that happens, we can close this. ------------------------------------------------------------------------ Sat, 05 Mar 2005 01:56:55 +0000 : paul(a)murphymaphia.com So the solution to the problem is to just scrap the module? This patch doesn't seem to fix the problem in my case. Is there a newer patch?

1 0

[drupal-devel] [bug] Supernumerary messages "The menu item has been removed"
by killes 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/27669 Post a follow up: http://drupal.org/project/comments/add/27669 Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: wiz Updated by: killes(a)www.drop.org -Status: active +Status: patch (code needs work) we use && not "and". killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Thu, 28 Jul 2005 11:07:22 +0000 : wiz Attachment: http://drupal.org/files/issues/node_delete_menu_msg.patch (583 bytes) When deleting a node, the function modules/menu.module:menu_node_form_delete() removes a custom menu entry for the node if it exists. The problem is that it will always print a message about a removed menu item, even though nothing has been actually deleted. Suggested fix: use db_affected_rows().

1 0

[drupal-devel] [feature] aggregator: make filtered HMTL tags configurable
by Uwe Hermann 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/29275 Post a follow up: http://drupal.org/project/comments/add/29275 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: Uwe Hermann Reported by: Uwe Hermann Updated by: Uwe Hermann Status: patch (code needs review) Attachment: http://drupal.org/files/issues/aggregator_allowed_html_tags.patch (2.34 KB) I'm currently trying to get aggregator.module in shape for being used as a planet-like software for a Planet Drupal [1]. Here's a patch which allows the site admin to specify which HTML tags are stripped from feeds (or not). This is hardcoded in aggregator.module right now, the attached 2-line patch (for HEAD) makes it configurable. I propose to add at least " " " to the default list of allowed HTML tags, but I'll leave that for another patch. Any objections? [1] http://drupal.org/node/28194 Uwe Hermann

6 13

[drupal-devel] [feature] Add vim modeline to have better support for vim editor and code style.
by Cvbge 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/29310 Post a follow up: http://drupal.org/project/comments/add/29310 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: minor Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge Status: patch (code needs review) Attachment: http://drupal.org/files/issues/vim.diff (23.56 KB) Vim can be instructed to set special settings. The line added by this patch tells vim that the file type is php, tab and 'shiftwidth' size is 2 characters and to expand tabs with spaces. Cvbge

4 5