- Development - lists.drupal.org

[drupal-devel] [bug] Forum module's use of if in Postgresql
by Dries 26 May '05

26 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: Dries Status: patch Can you guys provide a patch? I don't have a PostgreSQL setup to test it against. Will commit to DRUPAL-4-6 and HEAD. Dries Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 06:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 25, 2005 - 00:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 25, 2005 - 00:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 25, 2005 - 00:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 25, 2005 - 00:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 25, 2005 - 00:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 07:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 07:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 08:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 08:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 12:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. ------------------------------------------------------------------------ May 25, 2005 - 12:41 : plj '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7. ------------------------------------------------------------------------ May 25, 2005 - 12:45 : plj Sheesh. I meant that '<>' was missing. Gotta learn to use that preview button... ------------------------------------------------------------------------ May 25, 2005 - 23:53 : patrickslee Is nullvalue() a function? I cannot find it in neither postgres manual nor mysql manual. Use "IS NOT NULL" would be better as it is more standard-compatible. SO we have this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT IF(($1 <> 0) AND $1 IS NOT NULL, $2, $3); ' LANGUAGE 'sql'; Looks we have a satisfying fix here. Is this fix going to be committed in CVS for next release? ------------------------------------------------------------------------ May 26, 2005 - 02:26 : adrian hostmaster=# \df nullvalue List of functions Result data type | Schema | Name | Argument data types ------------------+------------+-----------+--------------------- boolean | pg_catalog | nullvalue | "any" But it doesn't matter to me =)

1 0

[drupal-devel] [task] Theme XML_icon should allow inline xml icons
by Bèr Kessels 26 May '05

26 May '05

Issue status update for http://drupal.org/node/17028 Project: Drupal Version: cvs Component: theme system Category: tasks Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels -Status: active +Status: patch status must be patch Bèr Kessels Previous comments: ------------------------------------------------------------------------ February 8, 2005 - 23:44 : Bèr Kessels Attachment: http://drupal.org/files/issues/theme_xml_icon_allow_inline.patch (862 bytes) theme('xml_icon') uses hardcoded DIVS, which is great. But what Drupal really needs is some method (and implemetations!) to allow xml icons in lists. i.e. each forum should list an icon. This patch allows none-inline icons If Param inline is set to true, a span is returned as wrapper, otherwise the default div is returned.s ------------------------------------------------------------------------ February 19, 2005 - 19:19 : tangent Why aren't all xml icons inline? There is no reason I can think of. Can't we just change them to span to eliminate the need for another argument? ------------------------------------------------------------------------ February 19, 2005 - 20:05 : Bèr Kessels we could. But I beleive a block element should be a div and an inline should be span. Off course you can achieve this with CSS, but I would like to follow the semantics. And a lot of XML icons are block elements. In fact: all of them areblock elements in drupal ATM. So changing that would be semantically incorrect. ------------------------------------------------------------------------ February 19, 2005 - 22:00 : tangent Yes, they are ALL currently block elements because theme_xml_icon() marks them up that way. My argument is that there is no justification for using a block level tag (DIV) for an image. If it should be displayed as a block then it will be contained in a block by the calling code. If it should not then it will not be. I still see no reason that it should be marked up with DIV. ------------------------------------------------------------------------ May 18, 2005 - 22:23 : Bèr Kessels Attachment: http://drupal.org/files/issues/theme_xml_icon_allow_inline_0.patch (507 bytes) this one changes it into a span;, like tangent suggests.

1 0

[drupal-devel] [feature] Improve grouping in default profile page
by moshe weitzman 26 May '05

26 May '05

Issue status update for http://drupal.org/node/23633 Project: Drupal Version: cvs Component: profile.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: moshe weitzman Updated by: moshe weitzman Status: patch Attachment: http://drupal.org/files/issues/profile.group.patch (634 bytes) One reason our profile page look lame today is that there is no visual or semantic grouping around a profile 'category'. This one line patch fixes this. moshe weitzman

3 5

[drupal-devel] [bug] Handle full URLs in url() and l()
by Bèr Kessels 26 May '05

26 May '05

Issue status update for http://drupal.org/node/10888 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Bèr Kessels Reported by: jhriggs Updated by: Bèr Kessels Status: patch Yes, that el() But let me explain why i am anxious for my solution: el(), by default will not do much, in fact it will just be an URL()-clone but one that allows outgoing links. But it has a hook-caller. Again: by default it does nothing much, for there will not be any hooks around in core. It will allow, for example, weblinks, to track clicks, or to look up a permission and allow or disallow users to follow a link. Now, the whole issue, IMO is, that we should *not* provide two ways for handling external URLS, but rather a single one, that is weblink-safe. If we would introduce URL() with outgoing links-capabilities, we can no longer track any outgoing URLs trough them. We will then have two ways for handling outgoing URLs, resulting in inconsistencies, and confused users. (hey, my anonymous users can follow link foo, while i have "follow outgig links" permission disabled for them). (BTW weblink will soon be renamed into links, just for reference) Bèr Kessels Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 16:01 : jhriggs Attachment: http://drupal.org/files/issues/full_url.patch (1.97 KB) This little patch allows full URLs to be used for the url() and l() functions, giving modules a single interface for creating links. Currently, modules must use l() for drupal links and raw HTML for external links. This patch changes url() to handle -- basically pass through -- full URLs while still doing the proper handling of internal paths and works with clean URLs enabled or disabled. It also shortens (and hopefully simplifies) the url() code a bit. Some examples of calls that now work: <?php l('a link', 'some/path'); // same as before l('an external link', 'http://drupal.org/'); l('full with query', 'http://google.com/search?q=define:foo'); l('full with separate query', 'http://google.com/search', array(), 'q=define:foo'); // same link as above l('full with fragment', 'http://drupal.org/node/5942#comment-12374'); l('full with separate fragment', 'http://drupal.org/node/5942', array(), NULL, 'comment-12374'); // same link as above ?> ------------------------------------------------------------------------ September 30, 2004 - 12:09 : moshe weitzman +1. less HTML in code is a good thing for readability, if nothing else. ------------------------------------------------------------------------ January 24, 2005 - 21:06 : mathias Attachment: http://drupal.org/files/issues/external_urls.patch (838 bytes) Revisiting this issue one year later shows we're almost there. The only thing that's left is the ability to handle external urls when clean_urls is disabled. Once implemented, menu.module can happily accept external urls and not just Drupal paths, making the menu system much more attractive to end users. I'll update the menu.module docs if this patch (or an alternative solution) is accepted. ------------------------------------------------------------------------ March 13, 2005 - 23:36 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/external_urls_0.patch (909 bytes) Updated from Drupal root directory. ------------------------------------------------------------------------ March 14, 2005 - 01:05 : gordon +1 This is a good thing for people who can't using clean urls. ------------------------------------------------------------------------ April 2, 2005 - 07:23 : TDobes This patch seems like a good idea, but does not apply anymore. Also, shouldn't the comments for l() and url() be updated to indicate that the functions will work with both internal and external URL's? ------------------------------------------------------------------------ April 2, 2005 - 08:25 : asimmonds Attachment: http://drupal.org/files/issues/external_urls_1.patch (897 bytes) The &'s had been changed to & amp; , here's a valid patch ------------------------------------------------------------------------ May 12, 2005 - 15:57 : adrian This is a new patch against cvs that allows url() to create external links, with the side-effect that menu can now be used to make external links. Also closes http://drupal.org/node/10177 This will be even more important with the primary links menu integration. (This patch already cleans up a special case in phptemplate for that). Killes benchmarked this, and it turns out the difference is negligible. Requests per second: 1.33 [#/sec] (mean) = with patch Requests per second: 1.31 [#/sec] (mean) = without patch. ------------------------------------------------------------------------ May 12, 2005 - 15:59 : killes(a)www.drop.org I had benchmarked /node as anon user without cache. ------------------------------------------------------------------------ May 25, 2005 - 05:50 : Steven +1 on the idea of this patch. It allows people to use l() for external links. However, I don't like the implementation. Running that complicated regexp for every url() call is simply wasteful. 95% or more of url() calls have a fixed string as parameter and point to Drupal's own paths. I suggest we create an url_external() wrapper around url() which allows external URLs. Any path which we want to allow external URLs in can use url_external() instead. The places where we use it will not be many anyway. ------------------------------------------------------------------------ May 25, 2005 - 06:05 : gordon splitting into url() url_external is not a good idea. The main reason for this patch that I see is for putting external urls into the navigation menu using the menu.module, and if all goes to plan, the primary and secondary menus. ------------------------------------------------------------------------ May 25, 2005 - 07:00 : Steven gordon: I still think this is a bit excessive. Perhaps instead of valid_url() we could use a simpler regexp !^[a-z]://!i or even strpos('://'). ------------------------------------------------------------------------ May 25, 2005 - 07:15 : gordon I am not says that it is or is not excessive. I was just saying that this is where it is going to be used, so creating url() and url_external() is not really an option ------------------------------------------------------------------------ May 25, 2005 - 07:57 : Bèr Kessels we /do/ need an external_url() thing. The links bundle (handling weblinks and the likes) willprovide this /and/ need this. People will get all sorts of tools to do /stuff/ with external links, like add permissions, track clicks etc. depending on the modules they have and the settings. All outgoing weblinks, should somehow respect those. Patches for core are coming, though. On top of that, a external_l() finction is simple. And if people want them in primary links they can do the regexping /before/ the function, not /in/ the function. The calling code can decide whether to call l() or external_l(), instead of putting logic in l() that is unneded 95% of the times. But i hereby promise to introduce such a function tbefore the end of this week :) ------------------------------------------------------------------------ May 25, 2005 - 08:17 : gordon The only thing I do not see in this plan is how with this work with the menu module and the navigation menu. ------------------------------------------------------------------------ May 25, 2005 - 11:04 : adrian Attachment: http://drupal.org/files/issues/url_external_links.patch (1.75 KB) What happened to the patch i uploaded ? It doesn't use a complex regexp, but uses strpos($url, '://') < 5. ------------------------------------------------------------------------ May 26, 2005 - 07:19 : Bèr Kessels Allthough this works, is clean AND does what it should do, I still am in favour of a better nitegrated solution. So please do not yet commit this, untill I upload my patch. We can then discuss what solution to take. It will not differ a big lot though. ------------------------------------------------------------------------ May 26, 2005 - 09:39 : adrian is this the patch where you want to introduce an el() to allow for counting of external links ? That's a different patch altogether. This is primarily about stopping url() from not handling external links when there is no good reason for it to do so. Your el() has a very specific use in the weblinks api, and should probably be included with it.

1 0

[drupal-devel] [bug] Handle full URLs in url() and l()
by adrian 26 May '05

26 May '05

Issue status update for http://drupal.org/node/10888 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Bèr Kessels Reported by: jhriggs Updated by: adrian Status: patch is this the patch where you want to introduce an el() to allow for counting of external links ? That's a different patch altogether. This is primarily about stopping url() from not handling external links when there is no good reason for it to do so. Your el() has a very specific use in the weblinks api, and should probably be included with it. adrian Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 17:01 : jhriggs Attachment: http://drupal.org/files/issues/full_url.patch (1.97 KB) This little patch allows full URLs to be used for the url() and l() functions, giving modules a single interface for creating links. Currently, modules must use l() for drupal links and raw HTML for external links. This patch changes url() to handle -- basically pass through -- full URLs while still doing the proper handling of internal paths and works with clean URLs enabled or disabled. It also shortens (and hopefully simplifies) the url() code a bit. Some examples of calls that now work: <?php l('a link', 'some/path'); // same as before l('an external link', 'http://drupal.org/'); l('full with query', 'http://google.com/search?q=define:foo'); l('full with separate query', 'http://google.com/search', array(), 'q=define:foo'); // same link as above l('full with fragment', 'http://drupal.org/node/5942#comment-12374'); l('full with separate fragment', 'http://drupal.org/node/5942', array(), NULL, 'comment-12374'); // same link as above ?> ------------------------------------------------------------------------ September 30, 2004 - 13:09 : moshe weitzman +1. less HTML in code is a good thing for readability, if nothing else. ------------------------------------------------------------------------ January 24, 2005 - 22:06 : mathias Attachment: http://drupal.org/files/issues/external_urls.patch (838 bytes) Revisiting this issue one year later shows we're almost there. The only thing that's left is the ability to handle external urls when clean_urls is disabled. Once implemented, menu.module can happily accept external urls and not just Drupal paths, making the menu system much more attractive to end users. I'll update the menu.module docs if this patch (or an alternative solution) is accepted. ------------------------------------------------------------------------ March 14, 2005 - 00:36 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/external_urls_0.patch (909 bytes) Updated from Drupal root directory. ------------------------------------------------------------------------ March 14, 2005 - 02:05 : gordon +1 This is a good thing for people who can't using clean urls. ------------------------------------------------------------------------ April 2, 2005 - 08:23 : TDobes This patch seems like a good idea, but does not apply anymore. Also, shouldn't the comments for l() and url() be updated to indicate that the functions will work with both internal and external URL's? ------------------------------------------------------------------------ April 2, 2005 - 09:25 : asimmonds Attachment: http://drupal.org/files/issues/external_urls_1.patch (897 bytes) The &'s had been changed to & amp; , here's a valid patch ------------------------------------------------------------------------ May 12, 2005 - 16:57 : adrian This is a new patch against cvs that allows url() to create external links, with the side-effect that menu can now be used to make external links. Also closes http://drupal.org/node/10177 This will be even more important with the primary links menu integration. (This patch already cleans up a special case in phptemplate for that). Killes benchmarked this, and it turns out the difference is negligible. Requests per second: 1.33 [#/sec] (mean) = with patch Requests per second: 1.31 [#/sec] (mean) = without patch. ------------------------------------------------------------------------ May 12, 2005 - 16:59 : killes(a)www.drop.org I had benchmarked /node as anon user without cache. ------------------------------------------------------------------------ May 25, 2005 - 06:50 : Steven +1 on the idea of this patch. It allows people to use l() for external links. However, I don't like the implementation. Running that complicated regexp for every url() call is simply wasteful. 95% or more of url() calls have a fixed string as parameter and point to Drupal's own paths. I suggest we create an url_external() wrapper around url() which allows external URLs. Any path which we want to allow external URLs in can use url_external() instead. The places where we use it will not be many anyway. ------------------------------------------------------------------------ May 25, 2005 - 07:05 : gordon splitting into url() url_external is not a good idea. The main reason for this patch that I see is for putting external urls into the navigation menu using the menu.module, and if all goes to plan, the primary and secondary menus. ------------------------------------------------------------------------ May 25, 2005 - 08:00 : Steven gordon: I still think this is a bit excessive. Perhaps instead of valid_url() we could use a simpler regexp !^[a-z]://!i or even strpos('://'). ------------------------------------------------------------------------ May 25, 2005 - 08:15 : gordon I am not says that it is or is not excessive. I was just saying that this is where it is going to be used, so creating url() and url_external() is not really an option ------------------------------------------------------------------------ May 25, 2005 - 08:57 : Bèr Kessels we /do/ need an external_url() thing. The links bundle (handling weblinks and the likes) willprovide this /and/ need this. People will get all sorts of tools to do /stuff/ with external links, like add permissions, track clicks etc. depending on the modules they have and the settings. All outgoing weblinks, should somehow respect those. Patches for core are coming, though. On top of that, a external_l() finction is simple. And if people want them in primary links they can do the regexping /before/ the function, not /in/ the function. The calling code can decide whether to call l() or external_l(), instead of putting logic in l() that is unneded 95% of the times. But i hereby promise to introduce such a function tbefore the end of this week :) ------------------------------------------------------------------------ May 25, 2005 - 09:17 : gordon The only thing I do not see in this plan is how with this work with the menu module and the navigation menu. ------------------------------------------------------------------------ May 25, 2005 - 12:04 : adrian Attachment: http://drupal.org/files/issues/url_external_links.patch (1.75 KB) What happened to the patch i uploaded ? It doesn't use a complex regexp, but uses strpos($url, '://') < 5. ------------------------------------------------------------------------ May 26, 2005 - 08:19 : Bèr Kessels Allthough this works, is clean AND does what it should do, I still am in favour of a better nitegrated solution. So please do not yet commit this, untill I upload my patch. We can then discuss what solution to take. It will not differ a big lot though.

1 0

[drupal-devel] [bug] Handle full URLs in url() and l()
by Bèr Kessels 26 May '05

26 May '05

Issue status update for http://drupal.org/node/10888 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Bèr Kessels Reported by: jhriggs Updated by: Bèr Kessels Status: patch Allthough this works, is clean AND does what it should do, I still am in favour of a better nitegrated solution. So please do not yet commit this, untill I upload my patch. We can then discuss what solution to take. It will not differ a big lot though. Bèr Kessels Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 16:01 : jhriggs Attachment: http://drupal.org/files/issues/full_url.patch (1.97 KB) This little patch allows full URLs to be used for the url() and l() functions, giving modules a single interface for creating links. Currently, modules must use l() for drupal links and raw HTML for external links. This patch changes url() to handle -- basically pass through -- full URLs while still doing the proper handling of internal paths and works with clean URLs enabled or disabled. It also shortens (and hopefully simplifies) the url() code a bit. Some examples of calls that now work: <?php l('a link', 'some/path'); // same as before l('an external link', 'http://drupal.org/'); l('full with query', 'http://google.com/search?q=define:foo'); l('full with separate query', 'http://google.com/search', array(), 'q=define:foo'); // same link as above l('full with fragment', 'http://drupal.org/node/5942#comment-12374'); l('full with separate fragment', 'http://drupal.org/node/5942', array(), NULL, 'comment-12374'); // same link as above ?> ------------------------------------------------------------------------ September 30, 2004 - 12:09 : moshe weitzman +1. less HTML in code is a good thing for readability, if nothing else. ------------------------------------------------------------------------ January 24, 2005 - 21:06 : mathias Attachment: http://drupal.org/files/issues/external_urls.patch (838 bytes) Revisiting this issue one year later shows we're almost there. The only thing that's left is the ability to handle external urls when clean_urls is disabled. Once implemented, menu.module can happily accept external urls and not just Drupal paths, making the menu system much more attractive to end users. I'll update the menu.module docs if this patch (or an alternative solution) is accepted. ------------------------------------------------------------------------ March 13, 2005 - 23:36 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/external_urls_0.patch (909 bytes) Updated from Drupal root directory. ------------------------------------------------------------------------ March 14, 2005 - 01:05 : gordon +1 This is a good thing for people who can't using clean urls. ------------------------------------------------------------------------ April 2, 2005 - 07:23 : TDobes This patch seems like a good idea, but does not apply anymore. Also, shouldn't the comments for l() and url() be updated to indicate that the functions will work with both internal and external URL's? ------------------------------------------------------------------------ April 2, 2005 - 08:25 : asimmonds Attachment: http://drupal.org/files/issues/external_urls_1.patch (897 bytes) The &'s had been changed to & amp; , here's a valid patch ------------------------------------------------------------------------ May 12, 2005 - 15:57 : adrian This is a new patch against cvs that allows url() to create external links, with the side-effect that menu can now be used to make external links. Also closes http://drupal.org/node/10177 This will be even more important with the primary links menu integration. (This patch already cleans up a special case in phptemplate for that). Killes benchmarked this, and it turns out the difference is negligible. Requests per second: 1.33 [#/sec] (mean) = with patch Requests per second: 1.31 [#/sec] (mean) = without patch. ------------------------------------------------------------------------ May 12, 2005 - 15:59 : killes(a)www.drop.org I had benchmarked /node as anon user without cache. ------------------------------------------------------------------------ May 25, 2005 - 05:50 : Steven +1 on the idea of this patch. It allows people to use l() for external links. However, I don't like the implementation. Running that complicated regexp for every url() call is simply wasteful. 95% or more of url() calls have a fixed string as parameter and point to Drupal's own paths. I suggest we create an url_external() wrapper around url() which allows external URLs. Any path which we want to allow external URLs in can use url_external() instead. The places where we use it will not be many anyway. ------------------------------------------------------------------------ May 25, 2005 - 06:05 : gordon splitting into url() url_external is not a good idea. The main reason for this patch that I see is for putting external urls into the navigation menu using the menu.module, and if all goes to plan, the primary and secondary menus. ------------------------------------------------------------------------ May 25, 2005 - 07:00 : Steven gordon: I still think this is a bit excessive. Perhaps instead of valid_url() we could use a simpler regexp !^[a-z]://!i or even strpos('://'). ------------------------------------------------------------------------ May 25, 2005 - 07:15 : gordon I am not says that it is or is not excessive. I was just saying that this is where it is going to be used, so creating url() and url_external() is not really an option ------------------------------------------------------------------------ May 25, 2005 - 07:57 : Bèr Kessels we /do/ need an external_url() thing. The links bundle (handling weblinks and the likes) willprovide this /and/ need this. People will get all sorts of tools to do /stuff/ with external links, like add permissions, track clicks etc. depending on the modules they have and the settings. All outgoing weblinks, should somehow respect those. Patches for core are coming, though. On top of that, a external_l() finction is simple. And if people want them in primary links they can do the regexping /before/ the function, not /in/ the function. The calling code can decide whether to call l() or external_l(), instead of putting logic in l() that is unneded 95% of the times. But i hereby promise to introduce such a function tbefore the end of this week :) ------------------------------------------------------------------------ May 25, 2005 - 08:17 : gordon The only thing I do not see in this plan is how with this work with the menu module and the navigation menu. ------------------------------------------------------------------------ May 25, 2005 - 11:04 : adrian Attachment: http://drupal.org/files/issues/url_external_links.patch (1.75 KB) What happened to the patch i uploaded ? It doesn't use a complex regexp, but uses strpos($url, '://') < 5.

1 0

[drupal-devel] Release critical bugs for May 26, 2005
by drupal-devel＠drupal.org 26 May '05

26 May '05

/ bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 18 weeks 4 days url: http://drupal.org/node/15654 / bug reports "Welcome to Drupal" page won't disappear after first post & proper access permissions age: 5 days 6 hours url: http://drupal.org/node/23296 In some case, "Recent comment" is not linked to THE COMMENT refered to. age: 1 week 14 hours url: http://drupal.org/node/23136 Tagging Issues age: 1 week 2 days url: http://drupal.org/node/23026 Can't submit forum post assigned: mohaqa age: 1 week 2 days url: http://drupal.org/node/22960 Error in TEMP DIRECTORY age: 1 week 3 days url: http://drupal.org/node/22916 PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. age: 1 week 3 days url: http://drupal.org/node/22911 Full path and other information disclosure on DB connect error age: 1 week 4 days url: http://drupal.org/node/22872 Search memory limit problems after 4.6 upgrade age: 2 weeks 1 day url: http://drupal.org/node/22497 Warning: Wrong parameter count for mysql_connect() assigned: jselva(a)drupal.org age: 2 weeks 5 days url: http://drupal.org/node/22188 Podcasting feeds broken age: 3 weeks 1 day url: http://drupal.org/node/21924 Teaser problem assigned: childhood age: 5 weeks 1 day url: http://drupal.org/node/20843 UTF-8 node title gets truncated at wrong position age: 5 weeks 5 days url: http://drupal.org/node/20537 database table "term_node" not updated when removing a term from a node under editing and submitting age: 6 weeks 2 days url: http://drupal.org/node/20315 Attached files can not be deleted age: 6 weeks 2 days url: http://drupal.org/node/20307 Reassigning a node to a different term does not work properly age: 6 weeks 3 days url: http://drupal.org/node/20278 4.6 aggregator showing/not interpreting HTML tags age: 7 weeks 4 days url: http://drupal.org/node/19874 Search ranking broken on pgsql age: 8 weeks 2 days url: http://drupal.org/node/19629 New submit error, non-admin user, postgresql database assigned: adrian age: 11 weeks 1 day url: http://drupal.org/node/18552 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 14 weeks 9 hours url: http://drupal.org/node/17428 OPML Import for Aggregator age: 16 weeks 6 days url: http://drupal.org/node/16282 Change to sesssion.inc violates UID database constraint age: 18 weeks 4 days url: http://drupal.org/node/15666 forum.module problem with postgresql v7.4.1 age: 19 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 19 weeks 2 days url: http://drupal.org/node/15399 postgresql error age: 20 weeks 4 hours url: http://drupal.org/node/15175 Entering an empty title broke drupal age: 27 weeks 2 days url: http://drupal.org/node/12974 Argument NOT must be type boolean age: 27 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 31 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 32 weeks 6 days url: http://drupal.org/node/11366 Prevent browser page caching of dynamic content assigned: mathias age: 1 year 14 weeks url: http://drupal.org/node/5900 / feature requests Provide a way to select a term from a vocabulary via a drop down list in a users profile age: 9 hours 54 min url: http://drupal.org/node/23601 Add a footer that is specific to a particular book, shown only on certain pages age: 7 weeks 6 days url: http://drupal.org/node/19757 moving pages en masse age: 7 weeks 6 days url: http://drupal.org/node/19754 Taxonomy module should use nodeapi 'load' age: 11 weeks 8 hours url: http://drupal.org/node/18631 Auto PHP memory maximisation age: 13 weeks 2 days url: http://drupal.org/node/17663 Don't reset existing password on request, prevent DoS password reset abuse age: 15 weeks 3 days url: http://drupal.org/node/16909 User info exposed to anonymous user age: 25 weeks 5 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 26 weeks url: http://drupal.org/node/4213 / support requests Please help me out i am stuck here :( assigned: neerajshokeen age: 2 weeks 4 days url: http://drupal.org/node/22227 Fatal error: Unknown column 'headers' in 'field list' query assigned: Eagle-i age: 10 weeks 1 day url: http://drupal.org/node/18928 Strange session behavior age: 10 weeks 3 days url: http://drupal.org/node/18821 user redirected to homepage when logging in age: 11 weeks 5 days url: http://drupal.org/node/18381 Problem with Forums age: 19 weeks 4 days url: http://drupal.org/node/15299 / bug reports search over fields.inc fields conceptual error age: 29 weeks 6 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 29 weeks 6 days url: http://drupal.org/node/12257 Start Time of Event is NOT Preserved age: 48 weeks 6 days url: http://drupal.org/node/8565 / bug reports Menu item not showing age: 33 weeks 5 days url: http://drupal.org/node/11210 / bug reports segmentation fault related to filestore age: 1 year 34 weeks url: http://drupal.org/node/3001 / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 1 year 7 weeks url: http://drupal.org/node/6827 Unserialize error at line 104 age: 1 year 14 weeks url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 1 year 15 weeks url: http://drupal.org/node/5619 Filestore Module Problems unaddressed assigned: harishkm age: 1 year 17 weeks url: http://drupal.org/node/5365 / bug reports Gallery error age: 4 weeks 2 days url: http://drupal.org/node/21290 Fatal Error: variable_get() age: 9 weeks 3 days url: http://drupal.org/node/19189 No Gallery Image Block age: 9 weeks 6 days url: http://drupal.org/node/19045 Mini applet can't find gallery at url / age: 10 weeks 4 days url: http://drupal.org/node/18785 Fatal error: Undefined class name 'galleryembed' age: 13 weeks 1 day url: http://drupal.org/node/17746 / support requests Can't Embed Gallery into Drupal age: 12 weeks 3 days url: http://drupal.org/node/18029 / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 1 year 10 weeks url: http://drupal.org/node/6392 / bug reports Image module thumbnail/preview stop working after l10n age: 4 weeks 6 days url: http://drupal.org/node/21036 Cannot upload .jpgs age: 12 weeks 3 days url: http://drupal.org/node/18076 Wrongly formed html in image gallery age: 13 weeks 6 days url: http://drupal.org/node/17462 Image.Module does not know the correct filename age: 27 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 30 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 32 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 34 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 34 weeks 4 days url: http://drupal.org/node/11064 / support requests path problems on upgrading... age: 3 weeks 3 days url: http://drupal.org/node/21725 / bug reports Please update Node_Aggregator age: 9 weeks 5 days url: http://drupal.org/node/19096 Import doesn't like XML/RSS feeds with no Title element age: 51 weeks 4 days url: http://drupal.org/node/8128 / feature requests RSS items overwriting edited items age: 49 weeks 5 days url: http://drupal.org/node/8455 / bug reports Organic Groups subscription notifications are being sent to *all* group members instead of just group manager age: 3 weeks 4 days url: http://drupal.org/node/21635 / feature requests Notify.module ignores the true submission queue age: 1 year 30 weeks url: http://drupal.org/node/3765 / feature requests Internationalization support for PDF assigned: TheLibrarian age: 1 year 8 weeks url: http://drupal.org/node/6795 / bug reports Date for latest is incorrect age: 5 weeks 6 days url: http://drupal.org/node/20485 Invalid link to release files age: 13 weeks 3 days url: http://drupal.org/node/17625 blank page after install age: 16 weeks 1 day url: http://drupal.org/node/16575 "Page Not Found" when trying to view issues or add new release age: 24 weeks 6 days url: http://drupal.org/node/13815 Project pages display only title and description age: 27 weeks 6 hours url: http://drupal.org/node/13082 Fatal error: Cannot use string offset as an array in includes/tablesort.inc on line 113 assigned: publian age: 33 weeks 6 days url: http://drupal.org/node/11187 Can't create new project with issue tracker age: 40 weeks 21 hours url: http://drupal.org/node/10148 / support requests Help with everything - nothing seems to work in the latest build age: 26 weeks 2 days url: http://drupal.org/node/13310 / bug reports Can't get the inline tag to show series age: 2 weeks 1 day url: http://drupal.org/node/22520 / bug reports MySQL Error age: 8 weeks 6 days url: http://drupal.org/node/19413 javascrip downloads square.gif for every category age: 14 weeks 1 day url: http://drupal.org/node/17366 / bug reports SQL Errors during CRON run assigned: ankur age: 2 weeks 1 min url: http://drupal.org/node/22638 / feature requests Drupal Search usability improvement age: 6 days 21 hours url: http://drupal.org/node/23185

1 0

[drupal-devel] [feature] Add path user/{uid}/content to get a listing of one user's nodes
by robertDouglass 26 May '05

26 May '05

Issue status update for http://drupal.org/node/22183 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: robertDouglass Status: patch Attachment: http://drupal.org/files/issues/usernodes.patch.txt (2.27 KB) This creates a new path user/{uid}/content which functions just like node, except it returns only one user's nodes. Minimally intrusive. Hopefully useful. Open to alternate suggestions on the path (should it be a path in the node module?) and the page title (currently "user content"). robertDouglass

7 11

[drupal-devel] [bug] Forum module's use of if in Postgresql
by adrian 26 May '05

26 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: adrian Status: patch hostmaster=# \df nullvalue List of functions Result data type | Schema | Name | Argument data types ------------------+------------+-----------+--------------------- boolean | pg_catalog | nullvalue | "any" But it doesn't matter to me =) adrian Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 06:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 25, 2005 - 00:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 25, 2005 - 00:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 25, 2005 - 00:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 25, 2005 - 00:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 25, 2005 - 00:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 07:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 07:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 08:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 08:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 12:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. ------------------------------------------------------------------------ May 25, 2005 - 12:41 : plj '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7. ------------------------------------------------------------------------ May 25, 2005 - 12:45 : plj Sheesh. I meant that '<>' was missing. Gotta learn to use that preview button... ------------------------------------------------------------------------ May 25, 2005 - 23:53 : patrickslee Is nullvalue() a function? I cannot find it in neither postgres manual nor mysql manual. Use "IS NOT NULL" would be better as it is more standard-compatible. SO we have this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT IF(($1 <> 0) AND $1 IS NOT NULL, $2, $3); ' LANGUAGE 'sql'; Looks we have a satisfying fix here. Is this fix going to be committed in CVS for next release?

1 0

[drupal-devel] [bug] Forum module's use of if in Postgresql
by patrickslee 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: patrickslee Status: patch Is nullvalue() a function? I cannot find it in neither postgres manual nor mysql manual. Use "IS NOT NULL" would be better as it is more standard-compatible. SO we have this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT IF(($1 <> 0) AND $1 IS NOT NULL, $2, $3); ' LANGUAGE 'sql'; Looks we have a satisfying fix here. Is this fix going to be committed in CVS for next release? patrickslee Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 16:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 25, 2005 - 10:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 25, 2005 - 10:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 25, 2005 - 10:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 25, 2005 - 10:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 25, 2005 - 10:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 17:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 17:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 18:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 18:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 22:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. ------------------------------------------------------------------------ May 25, 2005 - 22:41 : plj '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7. ------------------------------------------------------------------------ May 25, 2005 - 22:45 : plj Sheesh. I meant that '<>' was missing. Gotta learn to use that preview button...

1 0