- Development - lists.drupal.org

[drupal-devel] [feature] More powerful way of combining terms
by Cvbge 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23262 Project: Drupal Version: 4.6.0 Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge Status: patch Warnings, not "errors" Cvbge Previous comments: ------------------------------------------------------------------------ May 20, 2005 - 10:51 : Cvbge I'd like to have possibilty to use more then one type of operation at once. For example, I'd like to say taxonomy/term/1,2+3,4 (nodes with terms 1 and 2 or with terms 3 and 4), or taxonomy/term/1,2+1,4 (that'd be the same as 1,(2+4) - it means terms with 1 and (2 or 4)) ------------------------------------------------------------------------ May 24, 2005 - 12:18 : Cvbge Attachment: http://drupal.org/files/issues/taxonomy-not_operator-dirty_patch.diff (4.56 KB) Since it's not easy to add mixed operators i've started with something simpler - adding !term (not term) support. This allows to use something like taxonomy/term/1,!3 The patch is just a test, it'll be completly rewritten to support mixed operators (if I implement it), but at least shows that adding ! operator is quite simple and can be done without big changes. ------------------------------------------------------------------------ May 25, 2005 - 12:22 : Cvbge Attachment: http://drupal.org/files/issues/taxonomy-combined_operators-dirty_patch.diff (8.8 KB) Here's another dirty patch - this time everything is implemented, but I need to clean it up and make a patch against 4.6.0/cvs - currently it's against little modified 4.6.0 version (but, OTOH, taxonomy_select_nodes gets allmost completly rewritten so it does not matter too much). This patch allows combining AND (,), OR (+) and NOT (!) operators for taxonomy selections, e.g. taxonomy/term/1,2+3+4,!5,!6/3 ------------------------------------------------------------------------ May 25, 2005 - 13:26 : Cvbge Attachment: http://drupal.org/files/issues/taxonomy-combined_operators-4.6.diff (10.47 KB) Attached patch works, is cleaned, and is against DRUPAL-4-6 :) Comments are welcome. BTW, implicit object creating (taxonomy.module line 936: $current->tid = $tids[0];, $current was NULL before that) is generating errors in PHP5, as chx says. Probably needs to be fixed.

1 0

[drupal-devel] [feature] More powerful way of combining terms
by Cvbge 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23262 Project: Drupal Version: 4.6.0 Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Cvbge Updated by: Cvbge -Status: active +Status: patch Attachment: http://drupal.org/files/issues/taxonomy-combined_operators-4.6.diff (10.47 KB) Attached patch works, is cleaned, and is against DRUPAL-4-6 :) Comments are welcome. BTW, implicit object creating (taxonomy.module line 936: $current->tid = $tids[0];, $current was NULL before that) is generating errors in PHP5, as chx says. Probably needs to be fixed. Cvbge Previous comments: ------------------------------------------------------------------------ May 20, 2005 - 10:51 : Cvbge I'd like to have possibilty to use more then one type of operation at once. For example, I'd like to say taxonomy/term/1,2+3,4 (nodes with terms 1 and 2 or with terms 3 and 4), or taxonomy/term/1,2+1,4 (that'd be the same as 1,(2+4) - it means terms with 1 and (2 or 4)) ------------------------------------------------------------------------ May 24, 2005 - 12:18 : Cvbge Attachment: http://drupal.org/files/issues/taxonomy-not_operator-dirty_patch.diff (4.56 KB) Since it's not easy to add mixed operators i've started with something simpler - adding !term (not term) support. This allows to use something like taxonomy/term/1,!3 The patch is just a test, it'll be completly rewritten to support mixed operators (if I implement it), but at least shows that adding ! operator is quite simple and can be done without big changes. ------------------------------------------------------------------------ May 25, 2005 - 12:22 : Cvbge Attachment: http://drupal.org/files/issues/taxonomy-combined_operators-dirty_patch.diff (8.8 KB) Here's another dirty patch - this time everything is implemented, but I need to clean it up and make a patch against 4.6.0/cvs - currently it's against little modified 4.6.0 version (but, OTOH, taxonomy_select_nodes gets allmost completly rewritten so it does not matter too much). This patch allows combining AND (,), OR (+) and NOT (!) operators for taxonomy selections, e.g. taxonomy/term/1,2+3+4,!5,!6/3

1 0

[drupal-devel] [bug] non-standard form fields
by Robin Monks 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23531 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Alex Reisner Updated by: Robin Monks Status: patch That's a good thought, I'll try to make a patch with inline. Robin Robin Monks Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 17:40 : Alex Reisner User.module manually creates several form fields (on lines 1091 and 1664) rather than calling the form_ functions in common.inc. The fields on line 1664 are lacking a class attribute and all are missing id attributes, making their appearances difficult to control. It strikes me as better if the form_ functions were used, but I don't know enough about user.module to know if this is possible. At least the class and id info should be added manually. Relevant code: *Line 1091* $group .= form_item(t('Password'), '<input type="password" class="form-password" name="edit[pass1]" size="12" maxlength="24" /> <input type="password" class="form-password" name="edit[pass2]" size="12" maxlength="24" />', t('Enter your new password twice if you want to change your current password, or leave it blank if you are happy with your current password.'), NULL, TRUE); *Line 1664* $rows[] = array('<input type="text" size="32" maxlength="64" name="edit[name]" />', '<input type="submit" name="op" value="'. t('Add role') .'" />'); ------------------------------------------------------------------------ May 24, 2005 - 18:12 : Robin Monks Attachment: http://drupal.org/files/issues/hard.coded.form.fields.patch (2.19 KB) This patch should take care of that. I was unable to get someone to review it, so it may have a rough spot. Robin ------------------------------------------------------------------------ May 24, 2005 - 20:31 : Dries IMO, the usability of the forms degrades with this patch. It makes them look weird-ish. ------------------------------------------------------------------------ May 25, 2005 - 04:20 : Steven We can use container-inline to put the two password boxes on one row, no?

1 0

[drupal-devel] [bug] Forum module's use of if in Postgresql
by plj 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: plj Status: patch Sheesh. I meant that '<>' was missing. Gotta learn to use that preview button... plj Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 04:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 24, 2005 - 22:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 24, 2005 - 22:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 24, 2005 - 22:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 24, 2005 - 22:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 24, 2005 - 22:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 05:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 05:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 06:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 06:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 10:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. ------------------------------------------------------------------------ May 25, 2005 - 10:41 : plj '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7.

1 0

[drupal-devel] [bug] Forum module's use of if in Postgresql
by plj 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: plj Status: patch '' was missing. So what adrian actually means is this: CREATE OR REPLACE FUNCTION IF (integer, anyelement, anyelement) RETURNS anyelement AS ' SELECT if (($1 <> 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; I applied that and now forums work -- no module patches. PostgreSQL 7.4.7. plj Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 04:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 24, 2005 - 22:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 24, 2005 - 22:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 24, 2005 - 22:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 24, 2005 - 22:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 24, 2005 - 22:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 05:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 05:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 06:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 06:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 10:12 : adrian perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something.

1 0

[drupal-devel] [bug] Forum module's use of if in Postgresql
by adrian 25 May '05

25 May '05

Issue status update for http://drupal.org/node/23499 Project: Drupal Version: 4.6.0 Component: forum.module Category: bug reports Priority: normal Assigned to: patrickslee Reported by: cchamilt Updated by: adrian Status: patch perhaps we could also just add more wrapper functions for the specific types ? create or replace function IF (integer, anyelement, anyelement) returns anyelement as ' SELECT if (($1 0) AND NOT nullvalue($1), $2, $3); ' LANGUAGE 'sql'; Or something. adrian Previous comments: ------------------------------------------------------------------------ May 24, 2005 - 06:32 : cchamilt Postgresql function "if" is defined to return a boolean value, yet forum requests an integer - last_comment_uid. user error: query: SELECT n.nid, l.last_comment_timestamp, IF(l.last_comment_uid, cu.name, l.last_comment_name) as last_comment_name, l.last_comment_uid FROM node n, node_comment_statistics l /*! USE INDEX (node_comment_timestamp) */, users cu, term_node r WHERE n.nid = r.nid AND r.tid = 1 AND n.status = 1 AND n.type = 'forum' AND l.last_comment_uid = cu.uid AND n.nid = l.nid ORDER BY l.last_comment_timestamp DESC LIMIT 1 OFFSET 0 in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 62. warning: pg_query() [function.pg-query]: Query failed: ERROR: function if(integer, character varying, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /var/www/hosts/www.ambigc.com/htdocs/includes/database.pgsql.inc on line 45. ------------------------------------------------------------------------ May 25, 2005 - 00:07 : patrickslee Attachment: http://drupal.org/files/issues/forum.module_3.patch (2.69 KB) I have also encountered this bug and made a possible patch by replacing IF statements to CASE. A patch file is attached. ------------------------------------------------------------------------ May 25, 2005 - 00:28 : adrian There is an IF function defined in the database.pgsql function. On what page is this happening, as what might be happening is that the type isn't being picked up correctly. It's defined as IF(anyelement, anyelement, text) returns anyelement. IIRC. What I have seen happen is that it wants the text field to return integer, or vice versa. ------------------------------------------------------------------------ May 25, 2005 - 00:32 : patrickslee I found the definition in database.pgsql. It is like this: CREATE FUNCTION "if"(boolean, anyelement, anyelement) RETURNS anyelement AS ' SELECT CASE WHEN $1 THEN $2 ELSE $3 END; ' LANGUAGE 'sql'; So it is actually wanting boolean. ------------------------------------------------------------------------ May 25, 2005 - 00:43 : patrickslee So my patch will work, and we can make it easier by replacing the IF function to: IF(l.last_comment_uid 0 AND l.last_comment_uid NULL, cu.name, l.last_comment_name) BTW there is another place in forum.module use IF like this. ------------------------------------------------------------------------ May 25, 2005 - 00:45 : patrickslee Oops... my <>s are stolen. IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) ------------------------------------------------------------------------ May 25, 2005 - 07:20 : cchamilt Yes that line works great. Thanks for your help! ------------------------------------------------------------------------ May 25, 2005 - 07:52 : patrickslee This patch shows another problem. The last post user will always show "Anonymous" or whatever you defined. Looking for solution... ------------------------------------------------------------------------ May 25, 2005 - 08:00 : patrickslee Use this line instead: IF(l.last_comment_uid <> 0 AND l.last_comment_uid <> NULL, cu.name, l.last_comment_name) Don't forget there are two places in forum.module need to be changed. ------------------------------------------------------------------------ May 25, 2005 - 08:10 : patrickslee Oh what have I done! I changed nothing! IF(l.last_comment_uid <> 0 AND l.last_comment_uid IS NOT NULL, cu.name, l.last_comment_name)

1 0

[drupal-devel] [bug] Handle full URLs in url() and l()
by adrian 25 May '05

25 May '05

Issue status update for http://drupal.org/node/10888 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Bèr Kessels Reported by: jhriggs Updated by: adrian Status: patch Attachment: http://drupal.org/files/issues/url_external_links.patch (1.75 KB) What happened to the patch i uploaded ? It doesn't use a complex regexp, but uses strpos($url, '://') < 5. adrian Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 17:01 : jhriggs Attachment: http://drupal.org/files/issues/full_url.patch (1.97 KB) This little patch allows full URLs to be used for the url() and l() functions, giving modules a single interface for creating links. Currently, modules must use l() for drupal links and raw HTML for external links. This patch changes url() to handle -- basically pass through -- full URLs while still doing the proper handling of internal paths and works with clean URLs enabled or disabled. It also shortens (and hopefully simplifies) the url() code a bit. Some examples of calls that now work: <?php l('a link', 'some/path'); // same as before l('an external link', 'http://drupal.org/'); l('full with query', 'http://google.com/search?q=define:foo'); l('full with separate query', 'http://google.com/search', array(), 'q=define:foo'); // same link as above l('full with fragment', 'http://drupal.org/node/5942#comment-12374'); l('full with separate fragment', 'http://drupal.org/node/5942', array(), NULL, 'comment-12374'); // same link as above ?> ------------------------------------------------------------------------ September 30, 2004 - 13:09 : moshe weitzman +1. less HTML in code is a good thing for readability, if nothing else. ------------------------------------------------------------------------ January 24, 2005 - 22:06 : mathias Attachment: http://drupal.org/files/issues/external_urls.patch (838 bytes) Revisiting this issue one year later shows we're almost there. The only thing that's left is the ability to handle external urls when clean_urls is disabled. Once implemented, menu.module can happily accept external urls and not just Drupal paths, making the menu system much more attractive to end users. I'll update the menu.module docs if this patch (or an alternative solution) is accepted. ------------------------------------------------------------------------ March 14, 2005 - 00:36 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/external_urls_0.patch (909 bytes) Updated from Drupal root directory. ------------------------------------------------------------------------ March 14, 2005 - 02:05 : gordon +1 This is a good thing for people who can't using clean urls. ------------------------------------------------------------------------ April 2, 2005 - 08:23 : TDobes This patch seems like a good idea, but does not apply anymore. Also, shouldn't the comments for l() and url() be updated to indicate that the functions will work with both internal and external URL's? ------------------------------------------------------------------------ April 2, 2005 - 09:25 : asimmonds Attachment: http://drupal.org/files/issues/external_urls_1.patch (897 bytes) The &'s had been changed to & amp; , here's a valid patch ------------------------------------------------------------------------ May 12, 2005 - 16:57 : adrian This is a new patch against cvs that allows url() to create external links, with the side-effect that menu can now be used to make external links. Also closes http://drupal.org/node/10177 This will be even more important with the primary links menu integration. (This patch already cleans up a special case in phptemplate for that). Killes benchmarked this, and it turns out the difference is negligible. Requests per second: 1.33 [#/sec] (mean) = with patch Requests per second: 1.31 [#/sec] (mean) = without patch. ------------------------------------------------------------------------ May 12, 2005 - 16:59 : killes(a)www.drop.org I had benchmarked /node as anon user without cache. ------------------------------------------------------------------------ May 25, 2005 - 06:50 : Steven +1 on the idea of this patch. It allows people to use l() for external links. However, I don't like the implementation. Running that complicated regexp for every url() call is simply wasteful. 95% or more of url() calls have a fixed string as parameter and point to Drupal's own paths. I suggest we create an url_external() wrapper around url() which allows external URLs. Any path which we want to allow external URLs in can use url_external() instead. The places where we use it will not be many anyway. ------------------------------------------------------------------------ May 25, 2005 - 07:05 : gordon splitting into url() url_external is not a good idea. The main reason for this patch that I see is for putting external urls into the navigation menu using the menu.module, and if all goes to plan, the primary and secondary menus. ------------------------------------------------------------------------ May 25, 2005 - 08:00 : Steven gordon: I still think this is a bit excessive. Perhaps instead of valid_url() we could use a simpler regexp !^[a-z]://!i or even strpos('://'). ------------------------------------------------------------------------ May 25, 2005 - 08:15 : gordon I am not says that it is or is not excessive. I was just saying that this is where it is going to be used, so creating url() and url_external() is not really an option ------------------------------------------------------------------------ May 25, 2005 - 08:57 : Bèr Kessels we /do/ need an external_url() thing. The links bundle (handling weblinks and the likes) willprovide this /and/ need this. People will get all sorts of tools to do /stuff/ with external links, like add permissions, track clicks etc. depending on the modules they have and the settings. All outgoing weblinks, should somehow respect those. Patches for core are coming, though. On top of that, a external_l() finction is simple. And if people want them in primary links they can do the regexping /before/ the function, not /in/ the function. The calling code can decide whether to call l() or external_l(), instead of putting logic in l() that is unneded 95% of the times. But i hereby promise to introduce such a function tbefore the end of this week :) ------------------------------------------------------------------------ May 25, 2005 - 09:17 : gordon The only thing I do not see in this plan is how with this work with the menu module and the navigation menu.

1 0

[drupal-devel] [bug] Handle full URLs in url() and l()
by gordon 25 May '05

25 May '05

Issue status update for http://drupal.org/node/10888 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Bèr Kessels Reported by: jhriggs Updated by: gordon Status: patch The only thing I do not see in this plan is how with this work with the menu module and the navigation menu. gordon Previous comments: ------------------------------------------------------------------------ September 17, 2004 - 01:01 : jhriggs Attachment: http://drupal.org/files/issues/full_url.patch (1.97 KB) This little patch allows full URLs to be used for the url() and l() functions, giving modules a single interface for creating links. Currently, modules must use l() for drupal links and raw HTML for external links. This patch changes url() to handle -- basically pass through -- full URLs while still doing the proper handling of internal paths and works with clean URLs enabled or disabled. It also shortens (and hopefully simplifies) the url() code a bit. Some examples of calls that now work: <?php l('a link', 'some/path'); // same as before l('an external link', 'http://drupal.org/'); l('full with query', 'http://google.com/search?q=define:foo'); l('full with separate query', 'http://google.com/search', array(), 'q=define:foo'); // same link as above l('full with fragment', 'http://drupal.org/node/5942#comment-12374'); l('full with separate fragment', 'http://drupal.org/node/5942', array(), NULL, 'comment-12374'); // same link as above ?> ------------------------------------------------------------------------ September 30, 2004 - 21:09 : moshe weitzman +1. less HTML in code is a good thing for readability, if nothing else. ------------------------------------------------------------------------ January 25, 2005 - 06:06 : mathias Attachment: http://drupal.org/files/issues/external_urls.patch (838 bytes) Revisiting this issue one year later shows we're almost there. The only thing that's left is the ability to handle external urls when clean_urls is disabled. Once implemented, menu.module can happily accept external urls and not just Drupal paths, making the menu system much more attractive to end users. I'll update the menu.module docs if this patch (or an alternative solution) is accepted. ------------------------------------------------------------------------ March 14, 2005 - 08:36 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/external_urls_0.patch (909 bytes) Updated from Drupal root directory. ------------------------------------------------------------------------ March 14, 2005 - 10:05 : gordon +1 This is a good thing for people who can't using clean urls. ------------------------------------------------------------------------ April 2, 2005 - 16:23 : TDobes This patch seems like a good idea, but does not apply anymore. Also, shouldn't the comments for l() and url() be updated to indicate that the functions will work with both internal and external URL's? ------------------------------------------------------------------------ April 2, 2005 - 17:25 : asimmonds Attachment: http://drupal.org/files/issues/external_urls_1.patch (897 bytes) The &'s had been changed to & amp; , here's a valid patch ------------------------------------------------------------------------ May 13, 2005 - 00:57 : adrian This is a new patch against cvs that allows url() to create external links, with the side-effect that menu can now be used to make external links. Also closes http://drupal.org/node/10177 This will be even more important with the primary links menu integration. (This patch already cleans up a special case in phptemplate for that). Killes benchmarked this, and it turns out the difference is negligible. Requests per second: 1.33 [#/sec] (mean) = with patch Requests per second: 1.31 [#/sec] (mean) = without patch. ------------------------------------------------------------------------ May 13, 2005 - 00:59 : killes(a)www.drop.org I had benchmarked /node as anon user without cache. ------------------------------------------------------------------------ May 25, 2005 - 14:50 : Steven +1 on the idea of this patch. It allows people to use l() for external links. However, I don't like the implementation. Running that complicated regexp for every url() call is simply wasteful. 95% or more of url() calls have a fixed string as parameter and point to Drupal's own paths. I suggest we create an url_external() wrapper around url() which allows external URLs. Any path which we want to allow external URLs in can use url_external() instead. The places where we use it will not be many anyway. ------------------------------------------------------------------------ May 25, 2005 - 15:05 : gordon splitting into url() url_external is not a good idea. The main reason for this patch that I see is for putting external urls into the navigation menu using the menu.module, and if all goes to plan, the primary and secondary menus. ------------------------------------------------------------------------ May 25, 2005 - 16:00 : Steven gordon: I still think this is a bit excessive. Perhaps instead of valid_url() we could use a simpler regexp !^[a-z]://!i or even strpos('://'). ------------------------------------------------------------------------ May 25, 2005 - 16:15 : gordon I am not says that it is or is not excessive. I was just saying that this is where it is going to be used, so creating url() and url_external() is not really an option ------------------------------------------------------------------------ May 25, 2005 - 16:57 : Bèr Kessels we /do/ need an external_url() thing. The links bundle (handling weblinks and the likes) willprovide this /and/ need this. People will get all sorts of tools to do /stuff/ with external links, like add permissions, track clicks etc. depending on the modules they have and the settings. All outgoing weblinks, should somehow respect those. Patches for core are coming, though. On top of that, a external_l() finction is simple. And if people want them in primary links they can do the regexping /before/ the function, not /in/ the function. The calling code can decide whether to call l() or external_l(), instead of putting logic in l() that is unneded 95% of the times. But i hereby promise to introduce such a function tbefore the end of this week :)

1 0

[drupal-devel] [task] Introduce Daylight Saving Time for Drupal
by gordon 25 May '05

25 May '05

Issue status update for http://drupal.org/node/11077 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: crunchywelch Reported by: killes(a)www.drop.org Updated by: gordon Status: patch Do not take this the wrong what, but when it comes to dst, this is exemely simplisict. What would be the best method of doing this is to use the Zone Info files from libc. These not only have all the dst splits, but also all the timezones, and would be the most acurate. Have a look at Sources of Time Zone and Daylight Savings Data [1] whcih has pointers to where all this information is. Did you know that Australia has 21 different Timezones and DST areas. If you could enter the same information from tzdata then this would be the altermate dst system [1] http://www.twinsun.com/tz/tz-link.htm gordon Previous comments: ------------------------------------------------------------------------ September 26, 2004 - 13:01 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst.patch (6.04 KB) Many people have wanted to have a Daylight Saving Time setting in the past. If we use the "server time" modell (all times are displayed the same around the world) this isn't all that hard to do. I found a lot of usefull information here: http://webexhibits.org/daylightsaving/g.html The patch introduces a new DST setting and uses it if the "Configurable time zones" setting is switched off. ------------------------------------------------------------------------ September 26, 2004 - 14:40 : gordon This is a lovely patch, but you do realise that you have opened a can of worms. Daylight saving is a messy business, I had to write the Contestable Electricity billing for a company here in Australia which had multiple installations in multpile timezones, all with different daylight savings rules, which impacted upon the bill. The way that dst is legistated is very messy and here is Australia it is very messy. Daylight savings don't follow state lines, as some towns that are very close to the border may choose to follow the only the daylight saving period of the next state, and when we had the olympics NSW went into daylight savings months before anyone else. There are other examples of weird things like even the 1 hour forward is not also true. I know that in the 1999 change to daylight savings there was a small set of islands north of New Zealand that went ahead by 2 hours as they wanted to be the first into 2000. >From what I can see of your patch it only allows for a single daylight savings period for the entire system. Their can be situations where there can be users from multiple countries and in different timezones/dst. I think that entire timezone system needs to looked at again, and maybe re-implement it so that it will allow for dst. Maybe make it a bit more user friendly so instead of setting up the timezone by name much like how operating systems do it, and then this will automatically work out the timezone. +1 for this is something that would be good, but it still needs work. ------------------------------------------------------------------------ September 27, 2004 - 00:13 : Anonymous The patch works as it is now. I had good reason to limit its capability to the setting where users cannot chose their own timezone. ;) I also assume that a server administrator knows if he has dst or not. I also didn't (yet) cater for all countries where dst is in use mainly because some insist on not giving a sensible rule for the change dates. ------------------------------------------------------------------------ September 27, 2004 - 08:54 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/dst_0.patch (6.04 KB) The last comment was mine. After a code review by Kjartan I provide a slightly improved patch. I want to stress that solving the DST issue in a "suits everybody" manner isn't the intention of this patch. It solves the problem for people who have chosen to let all times on their site be displayed in the server's time setting. By covering a large portion of the earth's landmass I hope to be able to help most site admins. It would be possible to extend the patch to allow users to chose their DST setting, too. In my experience, however, users tend to not care about time settings at all. This may be EUrocentric though, as we have only one time zone. Feedback is welcome. ------------------------------------------------------------------------ September 28, 2004 - 07:12 : drumm +1 >From a code review I think this is an excellent solution. Could use a little more comments in the section that sets $node->date to explain the (probably good) reasoning behind that chunk of code. I don't have anything resembling a good set of tests so I did not apply the patch and try it. ------------------------------------------------------------------------ January 26, 2005 - 06:38 : killes(a)www.drop.org I just want to point out that this patch still applies and would make for a fine feature for Drupal 4.6... ------------------------------------------------------------------------ January 27, 2005 - 02:46 : alliax wouldn't hurt to have this feature in upcoming drupal. I would use it for sure, my users are from the same place, with dst ------------------------------------------------------------------------ April 29, 2005 - 02:12 : Sage This is an incredibly useful feature and I would like to see it incorporated into the next release (current release is 4.6.0). ------------------------------------------------------------------------ May 5, 2005 - 02:06 : syntaxerror Works beautifully.. I'm going to work on getting this to work with event.module. ------------------------------------------------------------------------ May 5, 2005 - 03:53 : crunchywelch I have just discussed with killes and rorris an enhancement to this patch which I will implement. We have proposed putting the ical timezone db (http://cvs.drupal.org/viewcvs/drupal/contributions/modules/ical/ical.sql?re…) in core. We will implement a DST field in that db for each zone which coreesponds with the zones in killes' patch here for dtermining whether a zone is currently in dst or not. Currently, the 5 zones in the drupal_is_dst() function in this patch will be the only regions assigned to timezones. If more regions are desired they can be submitted by the community. To be clear, this must be implemented before additional development on ical/event.module can proceed properly. We would like this to be in core for 4.7, and move one more step with timezone handling in event module to use this as well. Discuss! ------------------------------------------------------------------------ May 5, 2005 - 04:13 : tostinni I agree to put more specific region to DST as it's easier for someone to know which city DST he belongs than which DST Zone (Pacific Standard Time...). I like pretty much the way that windows manage this. +1 ------------------------------------------------------------------------ May 5, 2005 - 12:45 : Jaza The patch looks good... however, it doesn't take into account the fact that in Australia, DST starts and ends at 2am on Sunday morning. So these lines: case 4: // Australia // start of DST (last Sunday in October) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + $timezone; // end of DST (last Sunday in March) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + $timezone; break; Should read: case 4: // Australia // start of DST (last Sunday in October at 2am) $dststart = strtotime("-1 week sunday GMT", strtotime("1 november $year GMT")) + 7200 + $timezone; // end of DST (last Sunday in March at 2am) $dstend = strtotime("-1 week sunday GMT", strtotime("1 april $year GMT")) + 7200 + $timezone; break; There are also a whole lot more countries (and their specific DST rules) on http://webexhibits.org/daylightsaving/g.html than are implemented in this patch. I'd ultimately like to see an admin interface to let the webmaster add additional DST rules for whatever country they live in (or are developing for). These rules could be entered in raw PHP, or using a somewhat friendlier interface. Jaza. ------------------------------------------------------------------------ May 25, 2005 - 16:11 : Steven +1 on this patch. Catches most cases and at least provides a base for others to work on.

1 0

[drupal-devel] [feature] i18n - Adding language to nodes, taxonomy terms and vocabularies
by Steven 25 May '05

25 May '05

Issue status update for http://drupal.org/node/16547 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Jose A Reyero Updated by: Steven Status: patch char(2) is not sufficient for language codes. There are 3 letter codes too, but also, you can add local variants (en-gb, nl-be). I'm not sure we need this in core. Core already outputs a language attribute in the <html> tag. This belongs in i18n.module in a separate table. Steven Previous comments: ------------------------------------------------------------------------ February 1, 2005 - 13:29 : Jose A Reyero Attachment: http://drupal.org/files/issues/i18n_language_fields_01.patch (4.65 KB) This one adds a simple language field to the following tables: node, vocabulary, term_data Includes a small patch for taxonomy module in order to add the new fields to the list of fields to be inserted/updated. This is not needed for node module, as the field can be introduced with hook_nodeapi

1 0