- Development - lists.drupal.org

[drupal-devel] Trouble with tracker SQL queries
by K B 18 May '05

18 May '05

I have a troubling issue that I did partially solve, but need feedback from other developers before I determine if this is a general issue and open an issue for it, or just specific to my sites. Background: I have several sites that were upgraded from 4.5 to 4.6 a few days ago. These sites were originally started as 4.4 (or whatever the current version on Jan 2004 was), then moved to 4.5 then 4.6. I have never enabled comments on those sites, since I did not need to. Now that I have converted to 4.6, I found out that tracker does not work (displays headers and an empty list of nodes). The query in tracker that does that is: SELECT DISTINCT(n.nid), n.title, n.type, n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, l.comment_count FROM be_node n INNER JOIN be_node_comment_statistics l ON n.nid = l.nid INNER JOIN be_users u ON n.uid = u.uid LEFT JOIN be_comments c ON n.nid = c.nid AND (c.status = 0 OR c.status IS NULL) WHERE n.status = 1 AND (n.uid = 1 OR c.uid = 1) ORDER BY last_post DESC Since node_comment_statistics table is empty in my case, no rows were returned. Changing the first INNER to LEFT took care of this part. Then I found that the nodes were not sorted correctly. This was because last_post returned NULL. I changed the ORDER BY to be "n.changed" instead of last_post and that took care of the sorting. So, the SQL now becomes: SELECT DISTINCT(n.nid), n.title, n.type, n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, l.comment_count FROM be_node n LEFT JOIN be_node_comment_statistics l ON n.nid = l.nid INNER JOIN be_users u ON n.uid = u.uid LEFT JOIN be_comments c ON n.nid = c.nid AND (c.status = 0 OR c.status IS NULL) WHERE n.status = 1 AND (n.uid = 1 OR c.uid = 1) ORDER BY n.changed DESC However, the last post column now has "35 years 20 weeks ago" because the tracker.module tries to do "time() - last_posted", and since last_posted is NULL, it gives the number of years since the epoch. I overcame this by checking of last_post is null, and printing a - instead of an interval. I tried enabling comments, and did enter a few test comments. Still the node_comment_statistics is empty, and hence the replies column still shows 0 replies. So, my question is: - Did anyone else see a similar issue (node_comment_statistics table is empty and tracker gives no results)? - Is it normal to have an empty table, and not having anything inserted in it even after enabling comments? As far as I can tell, the inserts are done via the nodeapi of the comment.module, and are in real time (not via cron for example)? - Is this an exception case that we did not program for (someone has comments disabled on their web site)? Based on your replies, I will create a patch for the issue of having correct tracker output. I am still puzzled as to why no inserts are happening for node_comment_statistics.

1 2

[drupal-devel] [feature] Order taxonomy terms by vocabulary weight, then term weight
by grohk 18 May '05

18 May '05

Issue status update for http://drupal.org/node/7684 Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: MrRoot Updated by: grohk Status: patch Attachment: http://drupal.org/files/issues/taxonomy_vocab_weight_2.patch (901 bytes) As per a suggestion Moshe made in an email, I have updated this patch to order by vocabulary weight then term weight. grohk Previous comments: ------------------------------------------------------------------------ May 10, 2004 - 21:33 : MrRoot Attachment: http://drupal.org/files/issues/taxonomy.module_2.patch (866 bytes) This is a trivial patch to the taxonomy_node_get_terms() function. Currently, it was only sorting the results by term weight; the patch joins in the vocabulary table and adds the vocabulary weight as a second preference ordering. I wrote this because I wanted to force ordering of vocabularies when listing the taxonomies of a node using the taxonomy_link() function. Basically, what I was doing was this: I created a "Story Type" vocab which described the overall *type* of post ( News, Rant, Review, ... ) and a "Topic" vocab which described the *topic* of the post ( Programming, Math, Political, Family, ... ). Now, when you added a new story, you picked a Story Type and a Topic. When the story is displayed, it shows the taxonomy assignments as a list of links. The ordering of that list was by term weight, term name. That meant that if I wanted to control the left to right layout of that information, I'd have to set the weight on every term in each vocabulary. That seemed tedious, especially since the vocabularies themselves already had a weight associated with them. Hence, I dug around for about 15 minutes and wrote this patch. It's been tested and seems to work quite well. I can now *force* which taxonomy vocabulary is listed when, and thereby always make the posts appear as "Story Type | Topic". Hope it's useful.. :) ------------------------------------------------------------------------ May 10, 2004 - 21:40 : MrRoot Ack - that patchfile was generated against the current CVS tree, so I suppose the Version should have been 'cvs'? Sorry about that if it was misplaced. ------------------------------------------------------------------------ May 10, 2004 - 22:48 : moshe weitzman this patch makes a lot of sense ... however, your sql is non standard for drupal. we use the x JOIN y ON x.field = y.field syntax. Your SQL doe snot use this JOIN syntax. Please resubmit and then I'll bet that this will be accepted into core. ------------------------------------------------------------------------ May 10, 2004 - 23:47 : MrRoot Attachment: http://drupal.org/files/issues/taxonomy.module_3.patch (872 bytes) Ah.. I was wondering about that.. Looks like most of the rest of taxonomy.module does not make use of JOIN statements. So I was following that. Anyhow, I updated the patch to use JOIN on all of the tables. Cheers ------------------------------------------------------------------------ May 11, 2004 - 16:15 : Dries Is that ANSI SQL? If these are 'left' joins, please use 'LEFT JOIN'. If these are 'inner' joins, please use 'INNER JOIN'. Also, I'd add a small comment to code to explain the rationale behind that query. ------------------------------------------------------------------------ August 12, 2004 - 11:28 : killes(a)www.drop.org Patch doesn't apply. ------------------------------------------------------------------------ May 8, 2005 - 03:16 : grohk Attachment: http://drupal.org/files/issues/taxonomy_vocab_weight.patch (901 bytes) I have been looking for this funtionality for a long time, so I have attempted to bring this patch up-to-date and clean it up as per the suggestions.

1 0

[drupal-devel] [bug] file_create_path() is faulty in 4.6 and HEAD
by drumm 18 May '05

18 May '05

Issue status update for http://drupal.org/node/23100 Project: Drupal Version: 4.6.0 Component: file system Category: bug reports Priority: critical Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/file.inc_4.diff (1.04 KB) Conditions to reproduce: - 'Temporary directory' on the admin/settings page is configured to something not starting with the configuration of 'File system path'. For example, the default '/tmp' does not start with the default file system path 'files'. - There are not directories named the same as the temporary directory in the file system path. In the above example, path/to/drupal/files/tmp should not exist. What happens: 1. file_create_path('/tmp/something') is called. 2. file_check_location('/tmp/something', 'files') returns false. 3. Fall back to file_check_location('files//tmp/something', 'files'), which does one of two things: - if path/to/drupal/files/tmp exists that is happily used, ignoring the admin's configuration, and things work. - otherwise the whole thing returns FALSE and a bunch of stuff up the stack gets horribly confused. Solution: Lets add in another check to see if the file is in the temporary directory between steps 2 and 3. drumm

1 0

[drupal-devel] [bug] Revert the theme.inc patch
by mathias 17 May '05

17 May '05

Issue status update for http://drupal.org/node/23083 Project: Drupal Version: 4.6.0 Component: theme system Category: bug reports Priority: normal Assigned to: mathias Reported by: mathias Updated by: mathias Status: patch Attachment: http://drupal.org/files/issues/revert_theme_inc.patch (1.41 KB) The last patch [1] to theme inc should probably be reverted as it changes the behavior of the theme_image function and also requires core (system.module) and contrib modules (image.module) to also update their 4.6 releases. Just to be clear, this patch should stay in HEAD. [1] http://cvs.drupal.org/viewcvs/drupal/drupal/includes/theme.inc?only_with_ta… mathias

1 0

[drupal-devel] Question on valid_input_data()
by K B 17 May '05

17 May '05

In 4.6 includes/common.inc, in the function valid_input_data(), there is a check for various entities. Among these entities, there is a check for "style". http://drupaldocs.org/api/4.6/function/valid_input_data I use the banner module with text ads, and I use things like: <div style="some-style-definitions">some text</div> This check causes the above to be flagged as a security breach attempt and is logged to the watchdog as such. http://drupal.org/node/20608#comment-29106 My question is: Can the "style" element be used in malicious attacks? If yes, then how? Thanks in advance.

5 8

[drupal-devel] Admin Help writing instructions - 60 patches coming soon
by Kieran Lal 17 May '05

17 May '05

Hi, last week I ran an admin help documentation sprint for 60 modules. Through lots of discussion and various different attempts we have arrived at some writing instructions for what should be in admin help text. We probably still have a draft or two to do. I want to make sure that the development community is going to be behind this effort when the patches come. This would be a good time to include your feedback into the writing instructions or the admin help drafts themselves. Everything is in a wiki so edit away! Here are the writing instructions: http://dev.bryght.com/t/wiki/ AdminHelpWritingInstructions Here are the drafts: http://dev.bryght.com/t/wiki/ DrupalAdminHelpDocumentation, http://dev.bryght.com/t/wiki/ DrupalContribsAdminHelpDocumentation We are looking for experts to review to the admin help when we think we have done enough drafts. Please let me know if you would be willing to review documentation to ensure it is accurate. Cheers, Kieran

8 12

[drupal-devel] [bug] DST support
by pyromanfo 17 May '05

17 May '05

Issue status update for http://drupal.org/node/23029 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: pyromanfo Updated by: pyromanfo Status: patch One quick and dirty way to fix Daylight Savings Time in Drupal would be to add the following line in the function format_date in common.inc <?php $timestamp += date("I")*3600; ?> It adjusts the timestamp if DST is currently active. It fixed it on my site, at any rate, it seems it'd handle both cases, DST enabled or not using DST at all. pyromanfo

3 3

[drupal-devel] [feature] Order taxonomy_select_nodes
by tostinni 17 May '05

17 May '05

Issue status update for http://drupal.org/node/20963 Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: tostinni Updated by: tostinni Status: patch Attachment: http://drupal.org/files/issues/taxonomy_order-node.patch (2.36 KB) A very simple patch to provide an (too ?) easy way to configure how order selected nodes in a taxonomy_select_nodes call. I think we could provide such way for each module that make a call to this functions. tostinni

3 3

[drupal-devel] MySQL indices not being picked up
by Dries Buytaert 17 May '05

17 May '05

2 3

Re: [drupal-devel] Admin Help writing instructions - 60 patches coming soon
by Kobus Myburgh 17 May '05

17 May '05

Thanks a lot, Morten! Yes. I use poEdit. I will check it out. Regards, Kobus >>> wulff(a)psyke.org 5/17/2005 5:03 PM >>> Kobus Myburgh wrote: >>You can merge your translations against POT files from a later version >>and msgmerge will try to fit good matches to the new strings from the >>old ones. > A brief search for "msgmerge" got about 10000 results, and when refining this, I finally heard of one for Windows, but it is part of the Cygwin package. Isn't there a stand-alone Windows port of msgmerge that anyone know of? Once I get it, I will If you're using poEdit you can use "Catalog -> Update from POT File..." (I'm assuming poEdit since you mention Windows). Med venlig hilsen / Kind regards, Morten Wulff -- Self Injury Information and Support: http://www.psyke.org/ "I did not, you see, want to kill myself. Not at that time, anyway. But I wanted to know that if need be, if the desperation got so terribly bad, I could inflict harm on my body. And I could." - Elizabeth Wurtzel

1 0