- Development - lists.drupal.org

[drupal-devel] [bug] Expose encoding function
by killes 03 Mar '05

03 Mar '05

Issue status update for http://drupal.org/node/18319 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/drupal-convert-to-utf-8.patch (2.11 KB) Drupal should have a function that takes care of converting foreign encodings to UTF-8. I refactored drupal_xml_parser_create to expose that part of its functionality to be reused by other modules. killes(a)www.drop.org

2 1

[drupal-devel] [feature] Allow overriding of links returned by modules
by kbahey 03 Mar '05

03 Mar '05

Issue status update for http://drupal.org/node/18260 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: kbahey Updated by: kbahey -Status: active +Status: patch Setting status to patch, so we get it to the developers mailing list, and have a discussion going. kbahey Previous comments: ------------------------------------------------------------------------ March 2, 2005 - 10:23 : kbahey It is apparent that links returned by various modules need to often be changed to a different text, or disabled all together. For example, the issue of an Option to disable printer friendly version for book module [1], or for when using image.module to add product with image [2], or in let _link() return structured link info [3]. All these issues point for a desire to modify or disable various links in various modules. Crude Solution: One solution was to push this in every module out there, where each module would have options that would display or disable certain links. This is not the most elegant solution, since every module out there needs to change, and have options and more options. A Better Solution: A better approach is to allow the l() call to do a lookup in a table in the database (e.g. links). The links table would have module identifier, the original link text, and new link text. A user interface (mainly for the site admin) can provide a drop down list for all modules enabled, and allows overriding the text of the link, or disabling it altogether. Now when a module calls l(), it will lookup each link in the above table (or in the cache), and change them or disable them as appropriate. This would work with all modules, provided they do use the l() call, and not create the link by hand. Some potential issues: - More database access. However this is lessened somewhat by caching. - Ideally modules should have someway of answering a call to "list all links you have", and this can be used to populate the database when a module is enabled. This does not exist today, and I have no idea how feasible/easy/hard it is. Also, if modules are upgraded, how would Drupal know to update that table? By file timestamp for example which is kept? Please feel free to comment, refine, ...etc. [1] http://drupal.org/node/13211 [2] http://drupal.org/node/18249 [3] http://drupal.org/node/636

1 0

[drupal-devel] [bug] Changing roles for a user requires menu cache invalidate
by Dries 03 Mar '05

03 Mar '05

Issue status update for http://drupal.org/node/14977 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: moshe weitzman Updated by: Dries Status: patch Whatever we choose to do, the current patch does not improve consistentcy. Just look at the existing code to clear the menu cache, and unify it into one function. Dries Previous comments: ------------------------------------------------------------------------ December 31, 2004 - 20:46 : moshe weitzman When you remove a user from a given role, the effect is often not seen for a long time since the user's menu remains in cache. we should invaidate the menu cache for a user whenh is roles change (or anytime the $user is saved?). This same bug is apparent when you grant new roles to a user. ------------------------------------------------------------------------ January 27, 2005 - 19:34 : JonBob Attachment: http://drupal.org/files/issues/menu_18.patch (1.51 KB) Fixed by adding ability to invalidate cache only for one user. ------------------------------------------------------------------------ January 27, 2005 - 21:01 : Anonymous Don't we also need some code in user.module to call menu_rebuild? ------------------------------------------------------------------------ January 27, 2005 - 21:05 : JonBob Yes, the patch does that. ------------------------------------------------------------------------ January 27, 2005 - 23:54 : Dries I think the user module needs more work (last two chunks added by me): diff -r1.434 user.module 199a200,202 > > // Rebuild this user's menu to account for possibly changed permissions. > menu_rebuild($user->uid); 1135,1136d1137 < // Delete that user's menu cache. < cache_clear_all('menu:'. $account->uid); 1442d1442 < cache_clear_all(); Please verify/update as necessary. (I, for one, wouldn't expect menu_rebuild() to flush the page cache.) ------------------------------------------------------------------------ March 2, 2005 - 23:59 : JonBob I guess I don't have a strong opinion on this. Calling menu_rebuild() does the necessary cache clearing, but if this is deemed hard to understand, then just clearing the cache may be sufficient. However, we use menu_rebuild() in other places for this purpose; should those be changed to a set of cache clears instead? The difference between menu_rebuild() and just doing the cache clears is: - menu_rebuild() fixes the menu for the current page request, not just for future ones. - menu_rebuild() populates the menu table with newly added module-defined items.

1 0

Re: Drupal foundation (was: [drupal-devel] adsense from google for drupal)
by Boris Mann 03 Mar '05

03 Mar '05

(back on solid ground, have a ton of notes to post over the next couple of days) On Tue, 01 Mar 2005 13:57:51 +0000, Vladimir Zlatanov <vlado(a)dikini.net> wrote: > > Joining SPI would basically enable us to collect tax deductible > > donations from US citizens. Nothing more and nothing less. There is a > > similar organisation in .de but due to German tax laws they cannot > > _guarantee_ that we will get the money that people send to them on our > > behalf. I suspect that they say this to cover their legal behind, > > but... > > Also, this would only be applicable to people paying taxes in .de. > Tax deductions are good, but not the only thing which matters. > Things that matter IMHO are: Vlado makes a good point, and I think that is how we should approach the construction of a foundation. What do we need it to do? As I see it, there are actually only 3 things that are absolutely required, and everything else comes down to support functions. * have legal standing as some sort of entity which can do things (like own * be able to receive money (i.e. open a bank account) * pay out money While some sort of "foundation" would be a nice-to-have, I think a structure that handles those items would be a good start. Donations and tax-exempt status are additional issues. I'm putting my "general" notes underneath the Developer Sprint: http://drupal.org/node/18269 I've got a page on governance that is going to go up, which essentially recommends setting up some working groups not just for development (e.g. Metadata, Media & File, etc.) but also for management. We already partially have this with, for example, the Documentation mailing list, but we need a few more. The Community group would handle non-technical community issues. See my notes, then lets keep this momentum going! -- Boris Mann http://www.bryght.com

4 3

[drupal-devel] [task] Extend db_query()
by killes 03 Mar '05

03 Mar '05

Issue status update for http://drupal.org/node/17656 Project: Drupal Version: cvs Component: database system Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/db-query_1.patch (2.69 KB) After some discussion with Adrian at Drupal Con we found out that we do not know why node_save currently works with pgsql. It currently assumes that all db columns are strings. It seems to work but we should not rely on it. Here is a patch that checks for the type of field that is inserted. It needs testing. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ February 21, 2005 - 13:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/db-query.patch (2.16 KB) We should make our database abstraction layer more robust and ensure that module authors can use it without string manipulations inside the query. Several queries use implode() to get their arguments into the query. This is undesirable as we rely on the module author to check the keys and values of such arrays for exploitation attempts. I have created the attached patch which shouldbe able to allow us to not use implode anymore. A minor problem is that all inserted values will be treated as strings. This might be a problem with PostgreSQL at least. However, the same strategy is already used in Drupal core without any complaints I know of. Summary: This patch will alow us to simplify some code in node.module, user.module, taxonomy.module and probably others. ------------------------------------------------------------------------ February 21, 2005 - 18:03 : killes(a)www.drop.org It's a patch. ------------------------------------------------------------------------ February 21, 2005 - 18:19 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/db-query_0.patch (2.07 KB) Squeezed out two lines of code after consultation with Karoly. Adds only 10 loc (plus some docs). ------------------------------------------------------------------------ February 21, 2005 - 18:23 : chx Do I need to say +1?

1 0

[drupal-devel] Re: [drupal-docs] issues listings reverse chronologically.
by Boris Mann 03 Mar '05

03 Mar '05

Actually, oldest at the top is actually "chronologically" (from the past to the present). Blog posts et al are "reverse chronologically" (from the present to the past). And I agree, good call. On Tue, 1 Mar 2005 10:28:12 +0100, Bèr Kessels <berkessels(a)gmx.net> wrote: > Hi, > > Cross posting this to -docs ML, because people in there will have good ideas > about this too. > > Whenever I look into the patch queue, I start at the end, wlaking up slowly. > This works very well, because: > * you can close a lot of them. > * you are looking at them chonologically. > * less chance of duplicating (old) bugs. > * we get mails of the bugs/features etc when they are new anyway, s owe do not > miiss new features because they are "on the last page". > > So I suggest we turn around all these listings [1] to speed up cleaning of > the queues. So oldest first, newest last. > At least try my approach once (starting at the end). You will notice it works > pretty well. > > Bèr > [1] > http://drupal.org/project/issues?from=220&projects=3060&states=1&categories… > > | Bèr Kessels | webschuur.com | website development | > | Turnhoutsebaan 34/3 | 2140 Antwerpen | België | > | IM: ber(a)jabber.org.uk | MSN: berkessels(a)gmx.net | > | pers: bler.webschuur.com | prof: www.webschuur.com | > -- > [ drupal-docs | http://lists.drupal.org/listinfo/drupal-docs ] >

1 0

[drupal-devel] [bug] Changing roles for a user requires menu cache invalidate
by JonBob 02 Mar '05

02 Mar '05

Issue status update for http://drupal.org/node/14977 Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: moshe weitzman Updated by: JonBob Status: patch I guess I don't have a strong opinion on this. Calling menu_rebuild() does the necessary cache clearing, but if this is deemed hard to understand, then just clearing the cache may be sufficient. However, we use menu_rebuild() in other places for this purpose; should those be changed to a set of cache clears instead? The difference between menu_rebuild() and just doing the cache clears is: - menu_rebuild() fixes the menu for the current page request, not just for future ones. - menu_rebuild() populates the menu table with newly added module-defined items. JonBob Previous comments: ------------------------------------------------------------------------ December 31, 2004 - 13:46 : moshe weitzman When you remove a user from a given role, the effect is often not seen for a long time since the user's menu remains in cache. we should invaidate the menu cache for a user whenh is roles change (or anytime the $user is saved?). This same bug is apparent when you grant new roles to a user. ------------------------------------------------------------------------ January 27, 2005 - 12:34 : JonBob Attachment: http://drupal.org/files/issues/menu_18.patch (1.51 KB) Fixed by adding ability to invalidate cache only for one user. ------------------------------------------------------------------------ January 27, 2005 - 14:01 : Anonymous Don't we also need some code in user.module to call menu_rebuild? ------------------------------------------------------------------------ January 27, 2005 - 14:05 : JonBob Yes, the patch does that. ------------------------------------------------------------------------ January 27, 2005 - 16:54 : Dries I think the user module needs more work (last two chunks added by me): diff -r1.434 user.module 199a200,202 > > // Rebuild this user's menu to account for possibly changed permissions. > menu_rebuild($user->uid); 1135,1136d1137 < // Delete that user's menu cache. < cache_clear_all('menu:'. $account->uid); 1442d1442 < cache_clear_all(); Please verify/update as necessary. (I, for one, wouldn't expect menu_rebuild() to flush the page cache.)

1 0

[drupal-devel] Release critical bugs for March 02, 2005
by drupal-devel＠drupal.org 02 Mar '05

02 Mar '05

Bbcode / bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 6 weeks 4 days url: http://drupal.org/node/15654 Chatbox / support requests Cron run kills Chat? age: 12 weeks 1 day url: http://drupal.org/node/14032 Drupal / bug reports Durpal page crashes Mozilla, perhaps due to malformed HTML age: 7 hours 10 min url: http://drupal.org/node/18248 PHP 4.3.11 and upload in IE age: 1 week 4 days url: http://drupal.org/node/17595 When I delete a user, any forum in which s/he has commented also disappears. assigned: Jill6q age: 2 weeks 2 hours url: http://drupal.org/node/17428 problems with admin/user/configure/permission and 4.5.2 age: 2 weeks 2 days url: http://drupal.org/node/17282 Account image upload not working. age: 2 weeks 5 days url: http://drupal.org/node/17167 De-selecting all content type options creates in_array() error age: 2 weeks 5 days url: http://drupal.org/node/17158 node preview broken -- no clone() function age: 3 weeks 1 day url: http://drupal.org/node/16958 Published poll doesnt show up in poll block if in submission queue age: 3 weeks 6 days url: http://drupal.org/node/16671 Adding two custom blocks with the same name produces a sql warning age: 3 weeks 6 days url: http://drupal.org/node/16659 Cache-Control header not set age: 4 weeks 6 days url: http://drupal.org/node/16295 updates.inc deleting profile_data when updating age: 6 weeks 3 days url: http://drupal.org/node/15686 Change to sesssion.inc violates UID database constraint age: 6 weeks 3 days url: http://drupal.org/node/15666 problem with forum.module with postgresql v7.4.1 age: 7 weeks 2 days url: http://drupal.org/node/15412 forum.module problem with postgresql v7.4.1 age: 7 weeks 2 days url: http://drupal.org/node/15411 PHP 5 gives error when session table has no session assigned: adschar age: 7 weeks 2 days url: http://drupal.org/node/15399 postgresql error age: 7 weeks 6 days url: http://drupal.org/node/15175 UID 0, anonymous user account deleted age: 12 weeks 3 days url: http://drupal.org/node/13915 Styles broken after multisite patch assigned: TDobes age: 13 weeks 11 hours url: http://drupal.org/node/13738 Entering an empty title broke drupal age: 15 weeks 2 days url: http://drupal.org/node/12974 Argument NOT must be type boolean age: 15 weeks 2 days url: http://drupal.org/node/12950 Comments in approval queue still show up in tracker age: 19 weeks 4 days url: http://drupal.org/node/11647 Twin problems with comments assigned: Junyor age: 20 weeks 6 days url: http://drupal.org/node/11366 Drupal / feature requests Auto PHP memory maximisation age: 1 week 2 days url: http://drupal.org/node/17663 Don't reset existing password on request, prevent DoS password reset abuse age: 3 weeks 2 days url: http://drupal.org/node/16909 User info exposed to anonymous user age: 13 weeks 4 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 14 weeks url: http://drupal.org/node/4213 Drupal / support requests Problem with Forums age: 7 weeks 4 days url: http://drupal.org/node/15299 Drupal / tasks atom.module working version to 4.5.0 assigned: hugoromano age: 17 weeks 5 hours url: http://drupal.org/node/12496 Postgres Compatibility Update assigned: adrian age: 23 weeks 2 days url: http://drupal.org/node/10945 file.inc code review assigned: Stefan age: 45 weeks 2 days url: http://drupal.org/node/7235 Drupal.org maintenance / bug reports Konqueror problem age: 3 weeks 2 days url: http://drupal.org/node/16913 screenshots : page not found age: 3 weeks 5 days url: http://drupal.org/node/16752 Large Fonts problems age: 3 weeks 6 days url: http://drupal.org/node/16664 I can not add a release of Chinese Simplified Translation. age: 19 weeks 9 hours url: http://drupal.org/node/11770 Drupal.org maintenance / feature requests Plain text posting age: 2 weeks 1 day url: http://drupal.org/node/17335 Event / bug reports Doesn't work with i18n hack/module age: 1 day 19 hours url: http://drupal.org/node/18145 search menu tabs prints "array" age: 3 weeks 4 days url: http://drupal.org/node/16788 search over fields.inc fields conceptual error age: 17 weeks 5 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 17 weeks 5 days url: http://drupal.org/node/12257 Still GMT/TZ issues with CVS age: 18 weeks 6 days url: http://drupal.org/node/11870 Time entry is GMT even when site default is not age: 19 weeks 4 days url: http://drupal.org/node/11630 Start Time of Event is NOT Preserved age: 36 weeks 6 days url: http://drupal.org/node/8565 Feature / bug reports Menu item not showing age: 21 weeks 5 days url: http://drupal.org/node/11210 File / bug reports segmentation fault related to filestore age: 1 year 22 weeks url: http://drupal.org/node/3001 Filestore / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 48 weeks 10 hours url: http://drupal.org/node/6827 Unserialize error at line 104 age: 1 year 2 weeks url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 1 year 3 weeks url: http://drupal.org/node/5619 Filestore Module Problems unaddressed assigned: harishkm age: 1 year 5 weeks url: http://drupal.org/node/5365 Gallery / bug reports Fatal error: Undefined class name 'galleryembed' age: 1 week 1 day url: http://drupal.org/node/17746 Gallery / support requests Can't Embed Gallery into Drupal age: 3 days 15 hours url: http://drupal.org/node/18029 Goofy / bug reports Blocks with no name age: 3 weeks 3 days url: http://drupal.org/node/16860 Groups / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 50 weeks 5 days url: http://drupal.org/node/6392 Image / bug reports Cannot upload .jpgs age: 2 days 22 hours url: http://drupal.org/node/18076 Wrongly formed html in image gallery age: 1 week 6 days url: http://drupal.org/node/17462 Image.Module does not know the correct filename age: 15 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 18 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 20 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 22 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 22 weeks 4 days url: http://drupal.org/node/11064 Listhandler / bug reports International characters in created usernames are lost (e.g. "ø") age: 1 week 3 days url: http://drupal.org/node/17623 Mailhandler / bug reports warning: Cannot modify header information - headers already sent by (output started at /home/shengzhu/public_html/sz/modules/mai age: 1 week 1 day url: http://drupal.org/node/17736 Node Aggregator / bug reports Import doesn't like XML/RSS feeds with no Title element age: 39 weeks 4 days url: http://drupal.org/node/8128 Node Aggregator / feature requests RSS items overwriting edited items age: 37 weeks 5 days url: http://drupal.org/node/8455 Notify / feature requests Notify.module ignores the true submission queue age: 1 year 18 weeks url: http://drupal.org/node/3765 Online / support requests Need Help age: 1 week 6 days url: http://drupal.org/node/17475 Pdfview / feature requests Internationalization support for PDF assigned: TheLibrarian age: 48 weeks 1 day url: http://drupal.org/node/6795 Project / bug reports Invalid link to release files age: 1 week 3 days url: http://drupal.org/node/17625 blank page after install age: 4 weeks 23 hours url: http://drupal.org/node/16575 "Page Not Found" when trying to view issues or add new release age: 12 weeks 6 days url: http://drupal.org/node/13815 Project pages display only title and description age: 15 weeks 14 min url: http://drupal.org/node/13082 Fatal error: Cannot use string offset as an array in includes/tablesort.inc on line 113 assigned: publian age: 21 weeks 6 days url: http://drupal.org/node/11187 Can't create new project with issue tracker age: 28 weeks 14 hours url: http://drupal.org/node/10148 Project / support requests Help with everything - nothing seems to work in the latest build age: 14 weeks 2 days url: http://drupal.org/node/13310 Taxonomy dhtml / bug reports javascrip downloads square.gif for every category age: 2 weeks 1 day url: http://drupal.org/node/17366 TrackBack / bug reports Sends trackbacks for unpublished nodes age: 5 weeks 1 hour url: http://drupal.org/node/16239 Overly aggressive age: 12 weeks 5 days url: http://drupal.org/node/13865 trackback borks google and every other search engine age: 17 weeks 2 days url: http://drupal.org/node/12388 User experience / bug reports user interface problem http://drupal.org/forum/1?from=25 age: 12 hours 26 min url: http://drupal.org/node/18237 User experience / tasks WorkFlow and Action Module age: 1 week 5 days url: http://drupal.org/node/17517 Weblink / feature requests Display of child categories on the weblink directory default page age: 2 weeks 6 days url: http://drupal.org/node/17132 Display of child categories on the weblink directory default page age: 2 weeks 6 days url: http://drupal.org/node/17130

1 0

[drupal-devel] How do I... node submit, resubmit, folksonomy
by Morbus Iff 02 Mar '05

02 Mar '05

Alright. I'm working on a spec to take my homebrew NHPR.org CMS and turn it into a Drupal site. It'll be one of the more complicated Drupal sites I've ever worked on. I've got two related questions: * who was working on that folksonomy module? where is it? * can I, via a module, put up a page AFTER the node submit screen? NHPR.org has about 5000+ taxonomy terms. And as much as I hate the flipping name, consider this a "folksonomy" that has been built over 4 years. To minimize the duplication and similarity of names ("horse", "horses", and "horseriding"), I wrote some custom PHP code that: * checks all terms entered by a reporter AFTER the submit. * suggests terms that have a percentile of 75% match. * put up a checkbox list of "these terms may be better". * reporter optionally chooses new terms based on suggestions. * reporter resubmits the node, with the new terms. Since the taxonomy is 5000+ terms, I can't depend on Drupal's selectbox. So, the game plan was to write up some sort of module (or flexinode field type) that was a simple textbox that accepted terms. These terms would be checked/associated/created with their existing vocabulary programmatically (via some sort of module backend or custom flexinode code). My understanding, based on IRC snippets over the weeks, is that this is similar to someone's folksonomy module they were working on. On top of the above, I need to "interrupt" the normal node submission process. After a reporter has filled out their node and clicked "Submit", I need to show a page of "suggested terms", along with a form of checkboxes. Modifying/submitting the checkboxes would resubmit the node. Is there a hook to do this? What options do I have? Any code I write (most importantly, the "suggest new terms" formulas) will be submitted back to Drupal, naturally. -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ Spidering Hacks: http://amazon.com/exec/obidos/ASIN/0596005776/disobeycom icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus

4 6

[drupal-devel] RE: drupal-devel Digest, Vol 26, Issue 144
by Aldon Hynes 02 Mar '05

02 Mar '05

I just loaded the taxonomy_xml on a couple of my sites and despite a few tweaks I suggested to Sheldon, I really like it. As to Djun's comment about a repository for contributed taxonomies, I think that is a great idea. It does beg a question that has been going around about what taxonomies do people have in common and want to share. One of the key ones that I find I repeat over and over is a location taxonomy. Right now, http://www.bloggercorps.org has a nice location taxonomy with several countries, and for the United States and Canada, it breaks things down to the 50 states and the ten provinces. Anyone who wants to grab that taxonomy should feel free to take it from http://www.bloggercorps.org/taxonomy_xml/1 If anyone wants to expand on that taxonomy, they should feel free to create a userid there or login with their Drupal id, and drop me a note. I'll give you access to enhance the taxonomy. Aldon -----Original Message----- Date: Thu, 24 Feb 2005 21:45:51 -0800 From: Djun Kim <puregin(a)puregin.org> Subject: Re: [drupal-devel] New taxonomy_xml.module To: Sheldon Rampton <sheldon(a)prwatch.org> Cc: drupal-devel(a)drupal.org Message-ID: <20050224214551.su29kygbacgs8wow(a)www.cielosystems.com> Content-Type: text/plain; charset=ISO-8859-1; format="flowed" Sheldon, this is a great idea - much needed! I was thinking along the same lines and you've beaten me to it. I hope that this will help to further amplify the taxonomy system - one of Drupal's significant strengths. The availability of this feature suggests some kind of repository for contributed taxonomies. Any ideas around this? Thanks again! Djun

2 1