- Development - lists.drupal.org

[drupal-devel] warnings for bootstrap.inc and common.inc
by Negyesi Karoly 01 Mar '05

01 Mar '05

bootstrap.inc drupal_unpack, line 489 $field is not used and as it has a default value, we can nicely delete it. common.inc: error_handler, line 379 the parameter $variables seems to be not used in this function _fix_gpc_magic, line 392 $key is not used. form_file, line 1354 $error is used but I have not seen where it is initialized. Maybe this should be $name? These are produced by jEdit's PHPParser. It causes false warnings with references, but these three seems to be valid. I am not sure whether I shall fill a bug report or not, only the last one seems to be a real bug. Shall I continue with more files? Regards NK

4 4

[drupal-devel] [bug] file_check_location is not working on Windows 2000
by killes 01 Mar '05

01 Mar '05

Issue status update for http://drupal.org/node/10885 Project: Drupal -Version: 4.5.2 +Version: cvs Component: file system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: ccourtne Updated by: killes(a)www.drop.org Status: patch Still applies. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ September 16, 2004 - 14:46 : ccourtne Currently file_check_location is always returning false when passed a file as the $source path. If a directory is passed in $soruce file_check_location works. I've tracked this down to realpath returning an empty string when passed a relative path which points to a file. This probably goes unnoticed if you are using the file.api's to construct relative paths to the druapl file directory since check_location failing just causes the durpal file directory to get added which is what you wanted in the first place. Replacing this line $source = realpath(dirname($source)); with this $source = realpath(dirname($source)); fixes it on my windows box using PHP 4.3.8. I don't have things set up to do patches on my windows boxes here at work yet. I'll submit a formal patch tonight. ------------------------------------------------------------------------ September 16, 2004 - 14:47 : ccourtne Dag nabit. Replace $source = realpath($source); with $source = realpath(dirname($source)); Craig ------------------------------------------------------------------------ September 16, 2004 - 14:56 : Anonymous Attachment: http://drupal.org/files/issues/file-inc-file_check_location.patch (639 bytes) The sooner there are patches, the better it is... I tested this approach on my server and it works. Steef ------------------------------------------------------------------------ September 17, 2004 - 02:34 : ccourtne Attachment: http://drupal.org/files/issues/checklocation.patch (666 bytes) Here is the patch. ------------------------------------------------------------------------ February 23, 2005 - 01:30 : dan90(a)drupal.org This also fixed my file upload problems with some nonstandard paths under Linux/apache, php 4.3.4 drupal 4.5.2. maybe we should remove mention of windows 2000?

1 0

[drupal-devel] Jimmy Wales
by Jonathan Chaffer 01 Mar '05

01 Mar '05

Jimmy Wales (Wikipedia) was across the aisle from me and directly ahead of John and Matt on the way back from DrupalCon. We had a nice conversation. Some of the highlights: - He is interested in taxonomy, especially the possibility of syndicated and synchronized vocabularies. - He said it would be great if we had the ability to make a special syntax like double-brackets link automatically to Wikipedia. I briefly explained our filter system, and said that if he wanted we could knock out such a filter in an afternoon. Looking in contrib, it looks like interwiki.module can do this already; maybe it's just a matter of code review. - If we have need for writing-based tasks (like translation), he may be able to provide some manpower for us in that area. - "So, could I use this for my blog?" "Yes!" - He talked a bit about Wikinews, and how it's silly to have a news site without RSS, but the wiki format causes updates to be too frequent to make RSS sensible. He wants to move finished articles out of the wiki and into another system, and mentioned Drupal as a possibility for this. We may be getting a follow-up email at info(a)drupal.org. -- Jonathan Chaffer Applications Developer, structure:interactive (616) 364-7423 http://www.structureinteractive.com/

4 3

Re: [drupal-devel] CCK Nomenclature
by Chris Cook 01 Mar '05

01 Mar '05

On Mon, 28 Feb 2005 20:58:10 +0000, Gabor Hojtsy <gabor(a)hojtsy.hu> wrote: > Node != content. Or if we use the name 'content' for 'node', we could > actually replace all apperances of 'node' with 'content'... I assumed we > use the 'content' word on the interface to not scare people, but > acknowledging that a 'content' is less then a 'node'. It all comes down > to the definition of course, so both of these words can mean the same. > But is a 'user profile' (which is going to be buildable with CCK) a > 'content'??? Is a product a 'content'? I would not use this word for it. > But then I am not a native English speaker, so I might have a different > view on it... In my defense, perhaps I don't fully understand the purpose of the new module. Jonathan Chaffer wrote: > Suppose node.module handles all of the content types defined by node > modules as today, and a new module is added that handles the > administrator-defined content types. What should that module be called? I understood that this new module will manage administrator defined "content" types and that it would not replace node.module. I agree that a node may not necessarily be content but it does not sound like this module will be used to define user accounts as those would logically be be defined in the user module. If I am mistaken then some clarification regarding this module's purpose may be in order. As someone whose mother tongue is English I will say that I consider any entered data (i.e. is not text that is part of the user interface) to be technically content. That would include user profiles, blog comments, photos, hyperlinks, categories, et cetera. Note that I said "technically" though and that I don't think that end users should need to understand what either content or a node is. I may also be alone in my definition.

1 0

[drupal-devel] [task] Preview when clicking upload is confusing
by killes 01 Mar '05

01 Mar '05

Issue status update for http://drupal.org/node/10590 Project: Drupal Version: cvs Component: upload.module Category: tasks Priority: normal Assigned to: ccourtne Reported by: ccourtne Updated by: killes(a)www.drop.org Status: patch Still applies. Not sure we like the implementation. Sessions might be better. Screenshots to illustrate the problem too. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ September 6, 2004 - 14:24 : ccourtne Attachment: http://drupal.org/files/issues/uploadpreview.patch (1.15 KB) The screen radically changing when the use clicks upload is confusing. Many times a user may upload an attachment half way through typing a story (for example to upload an inline image) and adding the preview to the top of the screen would only confuse what they are doing. This patch adds a new op called nodeapi which validates the node and then re-displays the form sans preview. This allows those modules who wish to add new methods not be forced to preview. Once the preview is displayed it will stay on the screen. ------------------------------------------------------------------------ September 9, 2004 - 00:02 : ccourtne Attachment: http://drupal.org/files/issues/uploadpreview2.patch (1.49 KB) new patch that fixes typo and fixes breadcrumb and title

1 0

[drupal-devel] Re: Jimmy Wales
by Sheldon Rampton 01 Mar '05

01 Mar '05

Jonathan Chaffer wrote: >- He said it would be great if we had the ability to make a special >syntax like double-brackets link automatically to Wikipedia. I briefly >explained our filter system, and said that if he wanted we could knock >out such a filter in an afternoon. Looking in contrib, it looks like >interwiki.module can do this already; maybe it's just a matter of code >review. Aldon Hynes and I wrote interwiki.module specifically for this purpose. It can handle both single brackets and double brackets. Wikipedia's MediaWiki syntax uses both; double brackets are for internal links within Wikipedia, and single brackets are for external hyperlinks. There are other aspects of MediaWiki's simplified markup syntax that also might be worth emulating. For example, an asterisk at the beginning of a line translates into a <li> tag, with surrounding <ul> as needed. A pound sign translates into <li> with surrounding <ol>. And, list markup can be nested, e.g., *this item has three sub-items *#the first *#the second *#the third *this item has no sub-items *this item has two *#alpha *#beta Personally, I'd like to see a Drupal module version of the MediaWiki software, but creating it would require more programming skill than I possess. --Sheldon Rampton

1 0

[drupal-devel] [bug] module_invoke brokes default values
by chx 01 Mar '05

01 Mar '05

Project: Drupal Version: cvs Component: base system Category: bug reports Priority: critical Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/module_inc_no_default_nulls.patch (685 bytes) Try this: module_invoke('taxonomy', 'get_tree', 1); and compare the results with taxonomy_get_tree(1); What happens is that taxonomy_get_tree is called by the arguments 1, NULL, NULL, NULL which breaks it. Hence the patch. Every Drupal version I have met (4.4, 4.5, CVS) contains this error. I think this led module authors to not use module_invoke (at least I did so until now) which will be quite a problem if we decide on breaking up the modules into smaller pieces. chx -- View: http://drupal.org/node/17770 Edit: http://drupal.org/project/comments/add/17770

3 9

RE: [drupal-devel] adsense from google for drupal
by Boerland Bert 01 Mar '05

01 Mar '05

-----Original Message----- From: drupal-devel-bounces(a)drupal.org [mailto:drupal-devel-bounces@drupal.org]On Behalf Of Dries Buytaert [regarding usings ads for drupal] > That is awesome, Bert. We appreciate your contribution! :) Hate to push my luck, but I might get a better response if http://drupal.org/node/17905 is promoted to the frontpage. We still have to do some stuff. I'm willing to dontate as others might. But I am not that fond on paying the taxes of all the google ad payouts (esp in the Netherlands!). So for a generic account we might we might have to setup a drupal foundation that wont have to pay taxes. This was discussed some time ago on this list but I dont remember the outcome of this. Anyone? (put response please in thread on site) > Too bad you couldn't make it to FOSDEM. I'm sure there will be more > Drupal events in future. On the plus side, nobody of the drupal team got sick by/of me/my flue by me not showing up ;-)

4 7

RE: [drupal-devel] adsense from google for drupal
by Kobus Myburgh 01 Mar '05

01 Mar '05

Hi, What would this responsibility entail? I don't think my Drupal knowledge is good enough to start such a system from scratch, but I can surely maintain the code once it was written, and can research the legalities and so on. If I can get more detail on what this would entail, I might volunteer. Regards, Kobus >>> vlado(a)dikini.net 3/1/2005 9:01:00 AM >>> > > So for a generic account we might we > > might have to setup a drupal foundation that wont have to pay taxes. > > This was discussed some time ago on this list but I dont remember > > the outcome of this. Anyone? (put response please in thread on site) > Unfortunately, this has not been discussed in Antwerp. Should we set up > an IRC meeting to discuss this further? I think the foundation should be > EU-based. I cannot recommend Germany as a good place for something like > this... +1 for EU based foundation - the laws in Europe are generally very friendly to non-for profit foundations (AFAIK) I am not sure of the status and the legalities in UK but can do some research on that. What I suggest is let's take the facts in and decide on that basis - what will be the maintenance, administration involved, taxes, benefits, ease of access, etc... If anyone has experience running such a thing it's fine, but it might take over somebody's life. Any volunteers ? :) Cheers, Vlado

1 0

[drupal-devel] issues listings reverse chronologically.
by Bèr Kessels 01 Mar '05

01 Mar '05

Hi, Cross posting this to -docs ML, because people in there will have good ideas about this too. Whenever I look into the patch queue, I start at the end, wlaking up slowly. This works very well, because: * you can close a lot of them. * you are looking at them chonologically. * less chance of duplicating (old) bugs. * we get mails of the bugs/features etc when they are new anyway, s owe do not miiss new features because they are "on the last page". So I suggest we turn around all these listings [1] to speed up cleaning of the queues. So oldest first, newest last. At least try my approach once (starting at the end). You will notice it works pretty well. Bèr [1] http://drupal.org/project/issues?from=220&projects=3060&states=1&categories… -- [ Bèr Kessels | Drupal services www.webschuur.com ]

2 1