- Development - lists.drupal.org

[drupal-devel] [feature] Menu fast edit node links
by Bèr Kessels 25 Jan '05

25 Jan '05

Project: Drupal Version: cvs Component: menu system Category: feature requests Priority: minor Assigned to: mathias Reported by: mathias Updated by: Bèr Kessels Status: patch +1 on the feature, I use menu_otf all the time. -1 for the javascript. Not that i am against it, ion contrary. I think we should not start implementing JS on a per-case basis, but we should introduce a javascript system that can do your accordeon-magick on any element. So it should wait IMO. Bèr Kessels Previous comments: ------------------------------------------------------------------------ July 9, 2004 - 18:15 : mathias Attachment: http://drupal.org/files/issues/menu_fast_edit.patch (1.18 KB) When developers are creating custom menus, the process of adding content becomes twofold: 1. Create content 2. Navigate to administer > menus > add menu item and add the latest node entry This patch adds a link hook to the menu module. Specifically if a node does not have a menu entry the 'add menu item' link appears. If a menu item exists, the 'edit menu item' and 'delete menu item' are displayed thereby speeding up the publishing workflow. Note: This feature is only present when the menu module is enabled. Status: Waiting for JonBobs blessing ... ------------------------------------------------------------------------ July 10, 2004 - 18:21 : JonBob This is interesting. I do have a couple reservations. This adds a bunch of queries to node listing pages, since it has to check for every node whether that node has a menu item set. I also wonder how much time this saves the user in reality. It saves navigating to the menu admin screen, sure, but provides little other help. It seems that if we are to provide a link to the menu item add page, we should at least be pre-filling in the path and title fields for the user. The provided method is little better than having the menu admin page open in another browser tab. Maybe a node link isn't the right interface for this, anyway? Possibly a tab, or a hook_nodeapi('form admin') injection? If done right, this could finally replace that aging "link title" field in page.module nodes. ------------------------------------------------------------------------ January 24, 2005 - 22:23 : mathias Attachment: http://drupal.org/files/issues/menu_quick_link.patch (5.91 KB) This new patch gives users the ability to define menu items on any node creation/editing form. Screenshot here: http://asitis.org/tmp/menu_quick_link_form.png [1] It does this through nodeapi (as suggested by Jonbob), which means that any node has access to these fields unless specified otherwise via the new menu configuration settings. The functionality lives in menu.module, and users with 'administer menus' permission are allowed to edit the menu item fields inside the node form. One more note. I'm also proposing the addition of a misc/drupal.js [2] file to Drupal core (* gasp *). Currently it includes javascript functions to hide regions of a page. When a link is clicked on for a collapsed region, the region unfolds revealing the additional parts of a page. In this case the menu item fields are displayed after clicking the 'Menu item settings' link. I think it helps make best use of screen real estate, but we'll leave that verdict up to the usability experts. Let's remove the js file if it's the only thing stopping this patch from being submitted. I thought it might be worth exploring, especially for form pre and form post regions of the node form. [1] http://asitis.org/tmp/menu_quick_link_form.png [2] http://asitis.org/tmp/drupal.js ------------------------------------------------------------------------ January 24, 2005 - 22:34 : mathias Woops. Setting status to 'patch'. -- View: http://drupal.org/node/9178 Edit: http://drupal.org/project/comments/add/9178

1 0

[drupal-devel] missing db_escap_string() ?
by Chris Johnson 25 Jan '05

25 Jan '05

Is it just module taxonomy_menu, or is the database.mysql.inc file packaged in the 4.5.2 tarball faulty because it is missing db_escape_string()? The 4.5 tarball for taxonomy_menu contains version 1.11.0.2 of taxonomy_menu.module, which looks correct from the CVS log. But it calls db_escape_string(), which shouldn't be there until version 1.12, and does not exist in the 4.5 branch of database.mysql.inc from what I can tell. I've fixed my local copy, but something's not right someplace. Am I just terribly confused, or is there something wrong in the CVS or tarballs? -- Chris Johnson

2 1

[drupal-devel] [contributions:latpro] /modules/fckeditor/lib/editor/_source/commandclasses fck_othercommands.js fcknamedcommand.js fckpasteplaintextcommand.js fckpastewordcommand.js fckstylecommand.js fcktablecomman (fwd)
by Gerhard Killesreiter 25 Jan '05

25 Jan '05

4 6

[drupal-devel] [bug] Name conf.php still used in settings.php
by adschar 25 Jan '05

25 Jan '05

Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: adschar Reported by: adschar Updated by: adschar Status: patch Attachment: http://drupal.org/files/issues/settings.php.diff (617 bytes) Trying the HEAD version, I came across a mention of conv.php in the new settings.php file. adschar -- View: http://drupal.org/node/16145 Edit: http://drupal.org/project/comments/add/16145

1 0

[drupal-devel] XSLT
by Mark Quinn 25 Jan '05

25 Jan '05

I had a look round and didn't see much; does anyone know if there is any XSLT filter work going on at all?

1 0

[drupal-devel] [bug] User blog feed url is old style
by tangent 25 Jan '05

25 Jan '05

Project: Drupal Version: cvs Component: blog.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: tangent Updated by: tangent Status: patch Attachment: http://drupal.org/files/issues/blog.module.feedurl.patch (2.14 KB) The blog module creates user blog feed urls of the form "blog/feed/[UID]" while taxonomy follows the new url form of "taxonomy/term/1/1/feed". It seems that this should be changed to the new form of "blog/[UID]/feed" and the attached patch makes this change. Of course changing this will cause existing feed urls to become invalid so legacy.module is also patched to redirect old style urls. Legacy is modified as follows. "/blog/feed/52" will redirect to "/blog/52/feed" while "blog/feed" will not redirect tangent -- View: http://drupal.org/node/16021 Edit: http://drupal.org/project/comments/add/16021

3 7

Re: [drupal-devel] [feature] Show taxonomy admin link on taxonomy admin form
by Boris Mann 24 Jan '05

24 Jan '05

On Mon, 24 Jan 2005 21:45:35 +0100, Robert Douglass <rob(a)robshouse.net> wrote: > > Question: I've been working a bit with taxonomy-otf. This might be > > extended, or indeed rolled into taxonomy proper, to offer a field > > underneath each vocab displayed. > > Boris, this would indeed be nice, but one huge limitation is that users > can't really manage their terms, they can just create them. I think any > time we extend the permission of creating taxonomy terms we ought to > extend the permission of editing and deleting at least one's own terms. > This is a real drawback of teaxonomy_otf at the moment. Not suggesting it for "users" -- that's what folksonomy would be for (personal taxos --- sort of). This is a usability extension for admin/advanced users, so that instead of having to hop over to admin/taxonomy every time they want to add an entry, they can do it all in the node creation screen. It can also get used for single-user sites where the primary author manages their own taxonomy. -- Boris Mann http://www.bryght.com

1 0

[drupal-devel] Quick question: Where is "themes" directory set?
by Steve Dondley 24 Jan '05

24 Jan '05

I'm trying to determine where in the code Drupal sets the "themes" directory as the directory to search for themes. I'm having no luck. Can someone give me a quick hand?

2 2

[drupal-devel] [bug] Error while deleting user
by Dries 24 Jan '05

24 Jan '05

Project: Drupal Version: cvs Component: user.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: Dries Status: patch I can't reproduce this problem. Dries Previous comments: ------------------------------------------------------------------------ January 12, 2005 - 21:44 : chx Attachment: http://drupal.org/files/issues/user_delete_0.patch (875 bytes) Type error Date Wednesday, January 12, 2005 - 19:17 User chx Location /cvs/drupal/?q=user/2/edit Message array_keys(): The first argument should be an array in /var/www/cvs/drupal/modules/user.module on line 1048. Hostname 127.0.0.1 -- View: http://drupal.org/node/15511 Edit: http://drupal.org/project/comments/add/15511

1 0

[drupal-devel] [bug] admin/taxonomy/edit/vocabulary doesn't honor secondary node types of modules
by robertDouglass 24 Jan '05

24 Jan '05

Project: Drupal Version: 4.5.0 Component: taxonomy.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: robertDouglass Updated by: robertDouglass Status: patch Attachment: http://drupal.org/files/issues/taxonomy_5.patch (755 bytes) If a module has secondary node types (as defined in the node_node_types hook), the admin/taxonomy/edit/vocabulary screen ignores them (in function taxonomy_form_vocabulary) making it impossible to assign taxonomies to them. This applies to all versions, not just 4.5.x robertDouglass -- View: http://drupal.org/node/15662 Edit: http://drupal.org/project/comments/add/15662

2 1