December 2005 - Development - lists.drupal.org

Re: [development] proposal for theming nodes
by Kobus Myburgh 15 Dec '05

15 Dec '05

Hi, I feel that putting ANY structural HTML in the extra field will again influence theming, which will make this whole exercise null and void. On the other hand, if you don't add the HTML, you won't have any guarantee that your theme will be functioning correctly, because with so many things to customize, you are bound to look something over. I assume the solution to the latter is to set up a standard (CORE) Drupal site, enable all modules, create a node of each and every type, add a coment, some forum posts, some RSS feeds, or whatever else is needed, and export the database. Use that on a site where you're developing a theme - if all those elements display correctly, your theme must be okay, or what? Regards, Kobus >>> boris(a)bryght.com 12/14/2005 6:14:38 PM >>> On 12/14/05, Bèr Kessels <ber(a)webschuur.com> wrote: > > Hi, > > way too often i have to hack modules or even core (upload) to make it > *not* > append HTML to $node->body. > > I think this practice of appending stuff to the body is very bad, since it > makes it impossible to add thatdata elsewhere, without duplication. We've noticed this now with trackbacks and other such items (even book module navigation, althought this may have been fixed now) appearing in "full text feed" mode in RSS...you have to do special checking in your module to exclude extra data when it's being uses in the RSS feed. The hard part, imho is to convert **all** core modules to use this. and with > All i mean all :). Taxononomy, for example, should add its terms in there, > while book module should add its navigation. Taxonomy I don't think so, but book module navigation, certainly. Which brings up the point...do we then need an extra.tpl.php? Or options in taxonomy that says "Append taxonomy terms after node body"? Best not to touch the taxonomy issue for now, I think. -- Boris Mann http://www.bryght.com Vancouver 778-896-2747 / San Francisco 415-367-3595 IM boris_mann(a)jabber.org / SKYPE borismann

3 2

Re: [support] filemanager/attachment
by VJ 15 Dec '05

15 Dec '05

filemanager.module and attachment.module > Op woensdag 14 december 2005 21:30, schreef VJ: >> Is there a way to restrict attachment types for these modules? > > What modules? > > -- > PGP ber(a)webschuur.com > http://www.webschuur.com/sites/webschuur.com/files/ber_webschuur.asc > PGP berkessels(a)gmx.net > http://www.webschuur.com/sites/webschuur.com/files/ber_gmx.asc >

3 3

Re: proposal for theming nodes
by Ken Rickard 15 Dec '05

15 Dec '05

++ for Ber on this one. We're building a large site demo right now that takes auitomated news feeds. We're dumping stories into nodes, and related media into Flexinodes that have pointers back to their parent nodes (not perfect, but a fast hack to prove a demo point), In practice, this will give us "extras" related to a node body that we can place wherever we want in our theme (which, btw, may happen to be in a Flash player...). Both $node and $profile have problems when non-core modules start inserting objects into the output outsde the "obvious" control of themers and hack-level coders (like me). I think this line of thinking addresses that. (PS: When I get done with deadline hell, I promise to bang on 4.7!) -- Ken Rickard agentken

2 1

Re: Rapid Theme Development
by Ken Rickard 15 Dec '05

15 Dec '05

Here's a practical example of where theme development runs into trouble from module theme functions: overusing theme functions or using the wrong theme functions. In theme.inc (core) is the function theme_form_element which is roughly this (may be old code): function theme_form_element($title, $value, $description = NULL, $id = NULL, $required = FALSE, $error = FALSE) { $output = "<div class=\"form-item\">\n"; $required = $required ? '*' : ''; if ($title) { if ($id) { $output .= " <label for=\"$id\">$title:</label>$required \n"; } else { $output .= " <label>$title:</label>$required \n"; } } Now, the tags _aren't_ the big problem here. The problem is that modules (including core modules like profile.module) call this function for both form input _and_ form output. From a design/theme p.o.v., those are two distinct things and should be treated as such. Is this a _really big deal_ that causes Drupal to break? Probably not. But imagine my surprise when I used PHPTemplate to override this theme function, and all the form elements on my entire site changed instantly (and broke).

3 2

Fedora Core and the CMS Discussion
by Morbus Iff 15 Dec '05

15 Dec '05

I don't have time to send a private note off to the thread starter (or, for that matter, to the list), but perhaps someone in consulting or development could address the thread at: https://www.redhat.com/archives/fedora-websites-list/2005-December/thread.h… "We really need to move forward on selecting a CMS. It is highly unlikely that we'll see a PHP solution selected. I've heard many calls for Drupal, but let's not count on it. In particular, if a PHP solution is chosen, we'll have to be very, very careful in picking it out, and we'll probably need to disable any more dangerous functionality. In the case of Drupal and many others, that would include XML-RPC." -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ O'Reilly Author, Weblog, Cook: http://www.oreillynet.com/pub/au/779 icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus

2 1

Re: Drupal 4.7.0 beta2 / rc
by Gregg Banse 15 Dec '05

15 Dec '05

> 2. The number of bugs that need fixing grows steadily: http:// > drupal.org/project/issues? > projects=3060&versions=9728&states=1,8,13,14,2. How do we encourage > more people to help fix bugs? How do we help people fix bugs? > > bug report. Replying with one-liners like 'File a bug report!' or > 'RTFM' is not considered helping in this context. The goal is to > assist, to be helpful, to pull them on board and hopefully to make > them "stick". Similarly, I think there is room for people that Greetings, You hit the nail on the head Dries - at least for me. I have a Drupal install on one of my sites and have a strong interest in improving it. I have mid-level PHP skills meaning I still need to learn some fundamentals ... oop code being one of them. I'd like to help but I need to take small bites and learn what I need to learn with some help here and there. I don't need the manual read to me. I do occassionally need someone to say "read this" and give me a link or tell me what to look for. I like Drupal very much since I started using it this summer. I have issues with some aspects of it but I haven't gotten under the hood yet except to hack at the themes. Needless to say, I'm wet behind the ears and am slowly working to get up to speed. So all this being said, I'd like to know what - if anything - I could do to help. Gregg

5 4

RSVP and Eventfinder not sending HTML emails....
by Ryan Grace 15 Dec '05

15 Dec '05

Why am I seeing the HTML code in emails sent by RSVP even though i have enabled HTML emails option in the eventfinder settings? drupal 4.6.3-civicspace .8.2rc6 eventfinder is cvs rsvp is 4.6.0 because cvs is not working for me... please help, thanks, ryan grace

1 0

please review this very important patch
by Karoly Negyesi 15 Dec '05

15 Dec '05

Moshe have upgraded Alex Reisner's excellent http://drupal.org/node/39179 patch. Please review, this is an essential one before releasing 4.7 This patch and the like are (one of the) reasons for form API

1 0

performance foo
by Chris Johnson 14 Dec '05

14 Dec '05

Just came across something that triggered a bit of performance testing. One can cast objects to arrays and vice-versa in PHP. So, in common.inc, we have a function called object2array() that loops through an object and makes it into an array. Is that faster than the equivalent function using a cast (array) operator? No. In fact, it's about 2.4 times slower. However, both are very fast for an object with 26 elements. Here's the benchmark: 10000 'object2array' calls took 3.04 seconds. The average was 0.00030442 seconds per call. 10000 'better' calls took 1.27 seconds. The average was 0.00012693 seconds per call. Here are the tested functions: function object2array($object) { if (is_object($object)) { foreach ($object as $key => $value) { $array[$key] = $value; } } else { $array = $object; } return $array; } function better($object) { if (is_object($object)) { $array = (array) $object; } else { $array = $object; } return $array; } Worth a patch? ..chrisxj

8 14

filemanager/attachment
by VJ 14 Dec '05

14 Dec '05

Hi, Is there a way to restrict attachment types for these modules? Thanks, V

1 0