December 2005 - Development - lists.drupal.org

update span
by Karoly Negyesi 12 Dec '05

12 Dec '05

Hi! We should not include more updates than one version: from 4.5 to 4.6 , from 4.6 to 4.7 . Thoughts? Experience with jumping two versions? Regards NK

4 3

Disabling E-mail field in User Account > Edit
by Toufeeq Hussain 12 Dec '05

12 Dec '05

Hi, I'm trying to disable the e-mail and user_name filed in the User Account Edit page. These details will be populated from LDAP so an user should not be able to edit them. I've poked around and found the code which handles this in user.module. Now I need to disable this control. <Code> $group .= form_textfield(t('E-mail address'), 'mail', $edit['mail'], 30, 55, t('Insert a valid e-mail address. All e-mails from the system will be sent to this address. The e-mail address is not made public and will only be used if you wish to receive a new password or wish to receive certain news or notifications by e-mail.'), NULL, TRUE); </Code> looking up documentation for the form_textfield control (http://drupaldocs.org/api/head/function/form_textfield) tells me that I need to pass HTML attributes to this in the form of an associative array. Now to disable it I need to pass the attribute 'readonly' so I created an associative array as such $html_params = array("RO" => "readonly") and passed it to form_textfield as such: <Code> $group .= form_textfield(t('E-mail address'), 'mail', $edit['mail'], 30, 55, t('Insert a valid e-mail address. All e-mails from the system will be sent to this address. The e-mail address is not made public and will only be used if you wish to receive a new password or wish to receive certain news or notifications by e-mail.'), *$html_params*, TRUE); </Code> (The *'s highlight the change) However this does not seem to be working,E-mail field is still editable. What am I missing ? Please help. -Toufeeq -- blog @ http://toufeeq.blogspot.com

5 7

Re: image node type
by Ken Rickard 11 Dec '05

11 Dec '05

>> So, yes, we definately need to keep the option to let people place media anywhere. And yes, that needs to hook into WYSIWYWFU interfaces. But, no, this is not as badly needed as Simple Inline Media Handling. We need both, we need the flexibility, but IMHO an automatic-no-clutter solution should be the default. In core. I'm with Ber most of the way here, having struggled with some heavy image requests in a rather rigid templating evironment before. First, some discussion thread voting! +1 for files as an abstract data type full of rich, creamy metadata. +1 for image nodes (as a content type that exploits file uploads). +1 for browsing/creating images while creating other nodes. +1 for attaching files to user profiles. +1 for upload once, use many times. -1 for inline tokens [that's why we have HTML/PHP in posts!] -1 for requiring theme editing to handle file/image presentation. Here's what I'd recommend (humbly) for Drupal. Do not rely on theming to handle variation of presentation -- if advanced users want to do theme backflips, let them, but "normals" need nice file handling too. The default presentation of media that are attached /associated with nodes should be handled via /admin as part of content configuration. Some needs from an admin perspective: 1) Some node types might not accept any media attachments. Some might accept all. Admins should be able to decide based on what files users can upload. 2) Placement of attachments (by type) with relation to the body of the node should be set muich like custom blocks are set now. 3) I would even propose that attachments hook into the new (4.7) region system rather than the standard content system. (I'm writing a custom block right now that does this by reading the file extension of objects added to a given node via the attachment module.) 4) If attachments are not treated as blocks, placement of attachments within the body of the content might be done like teasers are defined now (insert photo 1 at character 400; photo 2 at character 1200; insert PDFs at node end; etc.). (This is the code I had to write in the other system). 4a) Be prepared to handle multiple objects of the same data type. There may be, say three ways to handle groups of photos. Option 1: Load one photo and link to the group as a separate node; Option 2: Load all in a region of the page; Option 3: Use AJAX or similar code to dynamically rotate pix on command. 5) Access control for attachments would define which roles could override the default placement of attachments using a token syntax (which, on general principle, I oppose, but will agree to include if others like it). The bottom line is this: a system like teasers, where the site admin sets the defaults, with an allowed override for advanced users. And while I would agree that WYSIWYG is not necessary, point-and-click setup by admins (rather than theme editing) is. (And, for the record, my clients all want to be able to layout their pages with photo 1 at graph 1, align right; photo 2 at graph 6 align, left; with a big fat ad space between graphs 3 and 4,) -- Ken Rickard agentken

2 1

I'd like to maintain the article module
by Mohammed Sameer 11 Dec '05

11 Dec '05

Hi, I know I should contact the current developer. I found 3, But it looks like the CodeMonkeyX was the last one to do a CVS commit. Unfortunately, His contact form states that he doesn't accept emails. What am I supposed to do ? Any ideas please ? Best regards, -- ---------------- -- Katoob Main Developer, Arabbix Maintainer. GNU/Linux registered user #224950 Proud Egyptian GNU/Linux User Group <www.eglug.org> Admin. Life powered by Debian, Homepage: www.foolab.org -- Don't send me any attachment in Micro$oft (.DOC, .PPT) format please Read http://www.gnu.org/philosophy/no-word-attachments.html Preferable attachments: .PDF, .HTML, .TXT Thanx for adding this text to Your signature

2 2

Stupid forms/node API question
by Syscrusher 11 Dec '05

11 Dec '05

I've been fighting this one for seven hours straight, and have read every bit of documentation I can find. I *know* I'm overlooking something really simple. Please help! Here's what I need to do in the edit handling of a custom node: 1. On initial entry to node/#/edit, I need to load values from the database using hook_load() and stuff them into the $node object. This is working perfectly, and the value from the databse loads into the visible form and displays correctly. 2. When a preview is submitted, I need to take the value that comes from $_POST and edit it before the form is generated. This is where things are breaking down. I can "validate" the value, issuing errors if I don't like it, but I can't seem to *change* it under programmatic control. I have tried changing $node->(my custom field) in nodeapi:validate, and in nodeapi:prepare, and even in hook_form. The thing is, I'm putting the modified value into the '#default_value' element of the appropriate part of $form, but somehow it's getting set back to the original $_POST contents from that field, between when I build the $form array and when that array is turned into HTML. I've been all over the code, but I can't seem to find where that's happening. Can someone help? Thanks! Scott -- ------------------------------------------------------------------------------- Scott Courtney Drupal user name: "syscrusher" http://drupal.org/user/9184 scott at 4th dot com Drupal projects: http://drupal.org/project/user/9184 Sandbox: http://cvs.drupal.org/viewcvs/drupal/contributions/sandbox/syscrusher

4 8

inline files. last desparate attempt.
by Bèr Kessels 11 Dec '05

11 Dec '05

Hello Last week and this week I am finalizing some work for remixreading (now remixcommons). One of the aims of us, was to move closer to vanilla Drupal. Using pure vanilla is still not possible, because of the limited file supprt. I have started betterupload, which I am developing primarily for remixcommons. But for now its still too betha to use in a production environment. However, since getting that drnd inline patch updated is far too much work after all the fapi changes, I decided to leave core what is and add some nice features to inline.module. * autoinline. One can now choose per node type, if attacements should go inline automatically: ** in the teaser ** in the body ** in both, ** not at all. * how small an image must be to show up inline. (dont show larger then 400*500, for example) * For themes: I add an inline flag: $node->file[fid]->inline == TRUE for inline files. All of this has rather crude default settings, but can be very well themed. None of this changes the default filter tokens or their behaviour. I have a few questions though: * Why does inline module not use the filter system, nodeapi(view) it uses now performs horrible! And previews do not show us the inline files. * How could we enhance the UI for inline images? I personally prefer to add a hook_quicktags, to add a JS button in the quicktags bar for each attached file. * How can we keep all this consistent? We should really re-think the ** logic to decide when an img must be inserted with an img tag (see above about settings) ** logic when to show a link and when to show nothing. ** how the tokens and the autoinline work together. e.g. should an image not be auto-inlined when a token for that image is inserted? Should we add a token autmatically rather then changing $node->body on nodeapi(view) ? and so on, I would love some feedback. (initial patch will follow soon) Bèr

29 76

Re: [development] BBCode Module Development
by naudefj 11 Dec '05

11 Dec '05

Hi Goba, > First let me stress that I am sorry for not being a good maintainer, > second I give you free way to continue maintanance. Sounds good. Working together would be much more fun :-) Who should I contact to get CVS access? > If you are about to add new features, and are in doubt about how is > it good to continue, let me know, or ask on the development mailing list > (this one) about best practices. I promise to consult you on all changes. Best regards. Frank

2 1

BBCode Module Development
by naudefj 11 Dec '05

11 Dec '05

Hi, Would there be any objections if I take over development of the BBCode project? If not, I would appreciate if I can be grated CVS access. The BBCode module is hugely neglected, yet very important to me and a bunch of other people. This module was last released with Drupal 4.5. If there are no objections, I will attempt the following: 1. Make an official Drupal 4.6 release (the 4.5 version works against 4.6) 2. Apply some of the patches that were submitted by users 3. Make the Forms API changes require for a 4.7 release (see my patch for this at http://drupal.org/node/40742) Best regards. Frank

2 1

Updated my contributed theme to phptemplate, should I replace or add a new project
by Fredrik Jonsson 11 Dec '05

11 Dec '05

I maintain the Slash theme <http://drupal.org/project/slash> and have updated it to a phptemplate theme. It used to be a plain PHP theme. Do you think I should replace the existing files or add a new project (slash_pt?)? The theme still looks very similar but the code is very different. Fredrik P.S A problem is that I can't edit <http://drupal.org/project/slash> (something with the role I belong to lack permission for the input filter that insert large theme images). It would be nice if this could be fixed one way or another. -- Web site: <http://xdeb.org/wiki/Fredrik>

2 1

Tracking, fixing and redirecting 404's
by Mike Gifford 11 Dec '05

11 Dec '05

Hello, This has been discussed a number of times, but there doesn't seem to be any comprehensive response to dealing with 404's. The best solution I've seen is to send a user to a search form. While this is better than showing them an error page it's not ideal either. I'm now in the process of migrating a largish static site to Drupal. What I would like to see is: 1) A page listing like admin/logs' Page Not Found reference but tracking - The most frequently incorrectly accessed page (in the log's history) - The biggest source of incorrect links (separated by internal & external links) - It should also be divided into those links that have specified redirects and those links which do not yet have a specified redirect defined (see below) 2) A link from the summary list above (next to details) to a redirect link that would allow you to indicate where that page should go. - This should list the redirect and allow you to edit it (if it is defined), or indicate that you can define the redirect. - It should also allow the admin to define either the full or partial URL as part of the redirect (sometimes multiple domains may be directed). - Would be great to see a list of all referrers (in the log's history) as an option here too to make it easier to update the links 3) After a redirect link is defined it should be transparent to the visiter. The use of the redirect should still be logged (as it is better to know that links should be updated on an external site). However, if a redirect hasn't been defined the user should be: - presented with a search page that is populated by strings parsed from the incorrect URL. - the choice that the users make should be logged and it would be really cool if there was an auto mode to set up a redirect link (if say 10 people all choose the same link). A module like this would make it easy for admins to know which urls are the biggest problem and provide them tools to fix it. Does something like this already exist? Are people interested in adding this kind of functionality (would make migrations easier after all). Are there things that should be on this 404 wish list that are missing? I'm interested in hearing from folks though and then seeing if we can't get something developed to do it. Mike -- Mike Gifford, OpenConcept Consulting Free Software for Social Change -> http://openconcept.ca http://del.icio.us/mgifford/drupal http://flickr.com/photos/mgifford/ sets/1178930/ Latest Launch -> CLC's Action Pages - http://action.clc-ctc.ca/

2 1