February 2005 - Development - lists.drupal.org

[drupal-devel] [bug] user_access returns invalid data
by javanaut 24 Mar '05

24 Mar '05

Project: Drupal Version: <none> Component: user.module Category: bug reports Priority: critical Assigned to: javanaut Reported by: javanaut Updated by: javanaut Status: patch Attachment: http://drupal.org/files/issues/user_access_bug.patch (473 bytes) The user_access function in user.module returns the results of the *strstr()* function, which returns a string, not a Boolean like the documentation suggests. This was screwing things up for me since flexinode relies on user_access for it's node_access('create'..) functionality. The attached patch uses strpos instead of strstr. It was created from a 4.5 codebase, but I noticed that the same issue is in HEAD as well. I'm using it on my dev site, and node_access('create'..) calls are now working properly and nothing I'm using seems to have any problems with it. javanaut -- View: http://drupal.org/node/16705 Edit: http://drupal.org/project/comments/add/16705

6 18

[drupal-devel] [feature] modifcation to allow theme engines to theme all theme hooks
by gordon 09 Mar '05

09 Mar '05

Project: Drupal Version: cvs Component: theme system Category: feature requests Priority: normal Assigned to: gordon Reported by: gordon Updated by: gordon Status: patch Attachment: http://drupal.org/files/issues/theme.inc_1.patch (889 bytes) Attached is a patch that I would like to get into 4.6. I didn't realise it but I am cutting this close. What this patch does is give the ability to theme engines to be able to handle all theme hooks with specifically having to code for them by creating a function {theme engine}_{theme hook} (eg. phptemplate_pager) What I have done to achieve this is I have created a new theme engine hook called theme_handler. This will check to see if the current theme has been set up to include this theme hook, and returns the function that it should called to handle this theme hook. Most the time this would most likely be a generic theme function. This function is then called with exactly the same arguements as the theme() was called with. (eg the theme hook as the first arguement) So in the case of the pager the function is called like so <?phpphptemplate_generic("pager", "", 10)?> The method that I have used, theme engines are not required to use this functionality, as some theme engines such as I think xtemplate will not be able to handle this, but it works extremely well in phptemplate. The reason that I have made this modification is that i can use a theme engine such as phptemplate to create the theme, and if I want to theme any additional features such as pager, menu_tree, I can without having to modify the theme engine from standard. So this gives me the best of both worlds. So with the phptemplate engine all I need to do to make use of the additional functionality is add template file to the themes directly like:- hook = hook.tpl.php, pager = pager.tpl.php, etc. It also means in the case of the phptemplate engine the theme creaters php skills can be limited, and still be able to expand the theme beyond that of the engines capibilities. gordon -- View: http://drupal.org/node/16409 Edit: http://drupal.org/project/comments/add/16409

7 19

[drupal-devel] CCK Nomenclature
by Jonathan Chaffer 06 Mar '05

06 Mar '05

Suppose node.module handles all of the content types defined by node modules as today, and a new module is added that handles the administrator-defined content types. What should that module be called? cck.module field.module type.module nodetype.module contenttype.module ... The chosen name will have an impact on the user interface to some degree, because in themes the content types will be prefixed by the name to distinguish them from content types defined by a node module. -- Jonathan Chaffer Applications Developer, structure:interactive (616) 364-7423 http://www.structureinteractive.com/

17 29

[drupal-devel] [bug] nodeapi 'settings' call sends string instead of object for $node value
by crunchywelch 06 Mar '05

06 Mar '05

Project: Drupal Version: cvs Component: node system Category: bug reports Priority: normal Assigned to: crunchywelch Reported by: crunchywelch Updated by: crunchywelch Status: patch Attachment: http://drupal.org/files/issues/node_24.patch (1.42 KB) when the 'settings' nodeapi operation is invoked, a string containing the type of node is sent for the $node argument, instead of an object like the rest of the operations. This breaks comment.module, and is inconsistent with the rest of the operations and documentation. This small patch fixes the problem. crunchywelch -- View: http://drupal.org/node/16384 Edit: http://drupal.org/project/comments/add/16384

4 4

[drupal-devel] [task] Remove use of form_item() in taxonomy
by drumm 03 Mar '05

03 Mar '05

Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/taxonomy.module_3.diff (4.94 KB) form_item() isn't right in a few cases. Such as confirmation pages and things which should be using other form functions. There was a subtle difference between form_select() and whatever taxonomy was doing. Thats why there is extra code here. I tested it a bit too. drumm -- View: http://drupal.org/node/17955 Edit: http://drupal.org/project/comments/add/17955

4 8

[drupal-devel] [bug] Deleting feeds and categories leaves error-generating block
by drumm 03 Mar '05

03 Mar '05

Project: Drupal Version: cvs Component: aggregator.module Category: bug reports Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/aggregator.module_1.diff (2.72 KB) Make a feed with the block enabled. Delete the feed. The block remains and spews a database error on every page view. This fixes that. As for 4.5, the diff file at http://trac.civicspacelabs.com/cgi-bin/trac.cgi/changeset/273?format=diff might apply if the attached diff does not. The indentation is the only thing which might have changed in the section of code from 4.5 to CVS that I can see. drumm -- View: http://drupal.org/node/17160 Edit: http://drupal.org/project/comments/add/17160

3 3

[drupal-devel] Comments count and tracking still broken
by Abalieno 02 Mar '05

02 Mar '05

Just FYI. The last acknowledgment I know is here: http://drupal.org/node/15500 It's marked as fixed but on my site is not. The current broken state is on drupal 4.5.2 and applying the patch posted by Zed Pobre. The comments count still doesn't get updated properly and I have to re-run the update to the database each time to get the comments count right. This happens on my site and with anonymous comments. Comments must be approved by me before they appear, but even when they are published their count isn't updated on the homepage and on the tracker module. I do not use caching options. -HRose / Abalieno

2 4

[drupal-devel] [feature] Editable node descriptions
by drumm 01 Mar '05

01 Mar '05

Project: Drupal Version: cvs Component: node.module Category: feature requests Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch Attachment: http://drupal.org/files/issues/node.module_2.diff (4.44 KB) Hey, lets make those things on the node/add page editable. And fix up some code style along the way. drumm -- View: http://drupal.org/node/17879 Edit: http://drupal.org/project/comments/add/17879

3 3

[drupal-devel] [bug] module_invoke brokes default values
by chx 01 Mar '05

01 Mar '05

Project: Drupal Version: cvs Component: base system Category: bug reports Priority: critical Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/module_inc_no_default_nulls.patch (685 bytes) Try this: module_invoke('taxonomy', 'get_tree', 1); and compare the results with taxonomy_get_tree(1); What happens is that taxonomy_get_tree is called by the arguments 1, NULL, NULL, NULL which breaks it. Hence the patch. Every Drupal version I have met (4.4, 4.5, CVS) contains this error. I think this led module authors to not use module_invoke (at least I did so until now) which will be quite a problem if we decide on breaking up the modules into smaller pieces. chx -- View: http://drupal.org/node/17770 Edit: http://drupal.org/project/comments/add/17770

3 9

RE: [drupal-devel] adsense from google for drupal
by Boerland Bert 01 Mar '05

01 Mar '05

-----Original Message----- From: drupal-devel-bounces(a)drupal.org [mailto:drupal-devel-bounces@drupal.org]On Behalf Of Dries Buytaert [regarding usings ads for drupal] > That is awesome, Bert. We appreciate your contribution! :) Hate to push my luck, but I might get a better response if http://drupal.org/node/17905 is promoted to the frontpage. We still have to do some stuff. I'm willing to dontate as others might. But I am not that fond on paying the taxes of all the google ad payouts (esp in the Netherlands!). So for a generic account we might we might have to setup a drupal foundation that wont have to pay taxes. This was discussed some time ago on this list but I dont remember the outcome of this. Anyone? (put response please in thread on site) > Too bad you couldn't make it to FOSDEM. I'm sure there will be more > Drupal events in future. On the plus side, nobody of the drupal team got sick by/of me/my flue by me not showing up ;-)

4 7