February 2005 - Development - lists.drupal.org

[drupal-devel] [bug] SQL error when node_access is used
by tangent 01 Mar '05

01 Mar '05

Project: Drupal Version: cvs Component: taxonomy.module Category: bug reports Priority: critical Assigned to: Anonymous Reported by: tangent Updated by: tangent Status: patch Attachment: http://drupal.org/files/issues/nodeaccess.patch (1.21 KB) I am testing the nodeperm_role.module and I experienced an SQL error when node permissions are changed. The problem is that the query in question uses "INNER JOIN {term_node} USING (tid)" but the db_rewrite_sql() function adds another inner join in front of this one so the USING clause breaks. My patch changes all the USING statements to ON to prevent this. Perhaps the documentation for db_rewrite_sql() should be updated to warn against the use of the USING clause. I don't see any other instances of it in core but many contrib modules use it. tangent -- View: http://drupal.org/node/17794 Edit: http://drupal.org/project/comments/add/17794

2 2

[drupal-devel] [feature] Add support for generating an RSS 0.92 feed of news aggregator items
by playdreamer 28 Feb '05

28 Feb '05

Issue status update for http://drupal.org/node/9167 Project: Drupal Version: cvs Component: aggregator.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: blake7 Updated by: playdreamer Status: patch Thrilled I found this as its the one killer feature that the aggregator appeared to be missing. One point I notice though is that the title of the generated feed is 'drupal', when presumably it should pick up something along the lines of 'sitename news aggregator'. playdreamer Previous comments: ------------------------------------------------------------------------ July 9, 2004 - 04:11 : blake7 Attachment: http://drupal.org/files/issues/aggregator.module_0.patch (2.96 KB) The attached patch adds support for generating an RSS 0.92 feed of the default news aggregator page (the output of aggregator_page_last()). This allows re-use of the Drupal aggregator in other RSS readers like Trillian. The patch consists of the aggregator_page_rss() function which builds the XML output needed. It uses the existing RSS building functions already present to construct the feed. Note the comment about how many items are in the feed. In Drupal 4.4.x, there was a variable "aggregator_page_limit" which represented how many items were returned for both the HTML and RSS versions. It defaulted to 75 items. In Drupal CVS, all the HTML output is now paged through a hard-coded limit of 20 items per page. A limit of 20 seems small for the RSS feed, so I reverted to the old limit of 75. Would it be better to add a new variable like "aggregator_rss_limit"? Also, there are 2 places that the callback to aggregator_page_rss are installed. One is in _aggregator_page_list right before the pager output and shows up as the XML icon (like how the OPML feeds are linked now). The other is in aggregator_menu where I try and install a menu itme called "RSS feed". For some reason, the menu itme is not displaying itself though I believe I am inserting it properly. Feel free to contact me if there are any questions. Thanks! ------------------------------------------------------------------------ July 9, 2004 - 17:29 : blake7 Attachment: http://drupal.org/files/issues/aggregator.module_1.patch (2.54 KB) Fixed the navigation menu problems mentioned above. Please consider this patch instead of the first one. ------------------------------------------------------------------------ July 9, 2004 - 18:09 : drumm When this functionality is added it should be able to generate feeds for each aggregator category as well. ------------------------------------------------------------------------ July 10, 2004 - 01:22 : blake7 Attachment: http://drupal.org/files/issues/aggregator.module_2.patch (3.25 KB) Done. The attached patch supports RSS feeds of each aggregator category through the XML icon at the bottom exactly like the main aggregator page. ------------------------------------------------------------------------ July 10, 2004 - 12:01 : Dries 1. $base_url . "/aggregator" . $url is incorrect. All URLs must be constructed using url() as it is aware of clean URLs and path aliasing. 2. Emitting 75 RSS items is quite much (uncommon) and can easily turn into a bandwidth bottleneck. Can we add one global setting that controls how many entries our feed should have (not just the newly introduced feeds)? To 'export' your content in case you wish to migrate to another tool, a special value 'all' (say '1000000') might be handy. ------------------------------------------------------------------------ September 17, 2004 - 08:19 : blake7 Attachment: http://drupal.org/files/issues/aggregator.module_3.patch (4.47 KB) 1. Using url() now. 2. Added the presistent variable aggregator_rss_limit which controls how many RSS items are generated. A form_select edit control to control the new variable, with all defined as 1000000, was added to the configure tab. I am not sure what you mean by "our feeds" versus "newly introduced feeds" in your comment. Also, even though the code-freeze has taken place, do you think it would be possible to get this into Drupal 4.5? The code change is very minimal and I believe the ability to share aggregated feeds is a great feature. ------------------------------------------------------------------------ September 17, 2004 - 18:07 : Boris Mann +1 I actually assumed (there was much discussion?) that the re-exporting of aggregator items on a per-bundle basis was going to be enabled for 4.5. Let's get this in before the code freeze -- this would be a major feature announcement for 4.5, and could perform the basis for other great functionality for 4.6 (e.g. per category OPML file generation). ------------------------------------------------------------------------ October 22, 2004 - 18:20 : blake7 Now that 4.5 has released. Can this go into CVS/HEAD? Is there any other changes to the patch that need to be made by me to make that happen? Thanks. ------------------------------------------------------------------------ October 23, 2004 - 18:05 : Dries I'll look at it again. Does the patch add XML-icons or how do people find out about the RSS feeds? Can't we make the URLs a bit more intuitive? For example by making it so that you merely have to append '/rss.xml' to the aggregator module's URLs: foo.com/aggregator/rss.xml foo.com/aggregator/categories/1/rss.xml It is certainly not a requirement, just a thought that might be worth considering. ------------------------------------------------------------------------ October 23, 2004 - 18:15 : Dries I'll look at it again. Does the patch add XML-icons or how do people find out about the RSS feeds? Can't we make the URLs a bit more intuitive? For example by making it so that you merely have to append '/rss.xml' to the aggregator module's URLs: foo.com/aggregator/rss.xml foo.com/aggregator/categories/1/rss.xml It is certainly not a requirement, just a thought that might be worth considering. ------------------------------------------------------------------------ October 25, 2004 - 10:50 : Bèr Kessels cross linking to a [feature] that talks about such a unified rss link: http://drupal.org/node/11937 ------------------------------------------------------------------------ February 9, 2005 - 20:17 : sethcohn Bump. Neat feature, would be nice for 4.6 What's the progress on making it happen? ------------------------------------------------------------------------ February 9, 2005 - 20:43 : Boris Mann Here's another bump to this. I would say since it missed 4.5 (and was ready at the time) we get this in to 4.6. Should mesh nicely with walkah's RSS updates. Dries: there is an XML icon at the bottom of each category page, plus the HTML header can include an alternate link to the feed. I vote against any sort of "rss.xml", people can alias if they wish. (ideally we could get per-category OPML links as well, but I'll leave that for another feature request) ------------------------------------------------------------------------ February 10, 2005 - 14:58 : Bèr Kessels A request for unification of feeds [1] is waiting in the queue already. [1] http://drupal.org/node/11937 ------------------------------------------------------------------------ February 10, 2005 - 15:23 : Boris Mann This patch is not about "feed unification", it adds RSS feeds for category bundles...which have been asked about (and coded for, here in this patch) since 4.4.

1 0

[drupal-devel] A Drupal site with paid subscriptions?
by Julian Bond 28 Feb '05

28 Feb '05

Has anyone done any work on Drupal to enable a site where subscribed members (via Paypal subscriptions say) get an additional set of permissions? -- Julian Bond Email&MSM: julian.bond at voidstar.com Webmaster: http://www.ecademy.com/ Personal WebLog: http://www.voidstar.com/ M: +44 (0)77 5907 2173 T: +44 (0)192 0412 433 S: callto://julian.bond/

6 7

[drupal-devel] Re: New taxonomy_xml.module
by Sheldon Rampton 28 Feb '05

28 Feb '05

Dries wrote: >I just checked but both modules/wmfilter and modules/interwiki exist in >CVS ... Does this need further attention or action? Yes, further action IS needed. I just checked, and it appears that Neil Drumm renamed modules/wmfilter to modules/interwiki. That's all well and good. However, modules/interwiki doesn't currently appear in the public list of downloads on drupal.org, and modules/wmfilter *DOES* appear, at the following URL: http://drupal.org/node/14980 If you go to that page and click on "Download latest release," you get a tarbell that contains a GNU public license and nothing else. This needs to be fixed, perhaps by editing project node 14980 so it points to modules/interwiki instead of modules/wmfilter. Unfortunately, I can't do this myself. The project node was created by Aldon Hynes, so I don't have editing access to it. Also: What's the status of my taxonomy_xml.module? The URL for that project is: http://drupal.org/node/17918 Regards, Sheldon Rampton

2 1

[drupal-devel] Re: [drupal:unconed] /modules user.module
by Dries Buytaert 28 Feb '05

28 Feb '05

drupal-devel(a)drupal.org wrote: > User: unconed Branch: HEAD Date: Mon, 28 Feb 2005 18:13:13 +0000 > > Modified files: > /modules user.module > > Log message: > - Delete a user's sessions when blocking his/her account. > > Links: > http://cvs.drupal.org/diff.php?path=drupal/modules/user.module&old=1.444&ne… That change looks incorrect! You are using $user (twice) instead of $account. -- Dries Buytaert :: http://www.buytaert.net/

1 0

[drupal-devel] Re: [drupal:unconed] /database updates.inc /includes session.inc /modules node.module search.module
by Dries Buytaert 28 Feb '05

28 Feb '05

drupal-devel(a)drupal.org wrote: > User: unconed Branch: HEAD Date: Mon, 28 Feb 2005 18:00:59 +0000 > > Modified files: > /database updates.inc > /includes session.inc > /modules node.module search.module > > Log message: > #17747: PGSQL improvements http://cvs.drupal.org/viewcvs/drupal/drupal/includes/session.inc?r1=1.11&r2… I don't understand this change. The $user object is only initialized later on in sess_read(). See also my concern in project issue #17747. -- Dries Buytaert :: http://www.buytaert.net/

1 0

[drupal-devel] [Fwd: [drupal.org] moviereview.module - New]
by Dries Buytaert 28 Feb '05

28 Feb '05

-------- Original Message -------- Subject: [drupal.org] moviereview.module - New Date: 27 Feb 2005 22:49:04 -0000 From: emiliano(a)opiniaopublica.com Dries, Emiliano (http://drupal.org/user/16470) has sent you a message via your contact form (http://drupal.org/user/1/contact) at drupal.org. If you don't want to receive such e-mails, you can change your settings at http://drupal.org/user/1. Message: Hello Dries! How are you doing? I'm writing you because I've just adapted book review module to a movie review module. Since I'm not a PHP programmer, the only thing I can do is update this module everytime bookreview.module gets updated. :-) I'm saying all this because I don't know if you are interested in having it published or not. You may see it in action here: http://www.novayork.com/index.php?q=moviereview If you know someone who might maintain this module, no problem for me, really. If nobody can and you think it's good to make it available, whenever bookreview gets updated I update moviereview.... Thansk, Regards, Emiliano. -- Dries Buytaert :: http://www.buytaert.net/

4 4

[drupal-devel] Remove menu item
by Maykel Moya 28 Feb '05

28 Feb '05

I'd been playing with a module that creates aditional URLS. As per 'Module's developer manual' I'd implemente the _menu hook. But, this way, an item is added to the navigation menu. How can I get rid of it ? Regards, maykel -- ,''`. Debian GNU/Linux : :' : The universal & free Operating System `. `' http://www.debian.org/ `-

3 2

[drupal-devel] Using Drupal as an applications framework?
by Chris Johnson 28 Feb '05

28 Feb '05

1. Executive Summary I propose to replace my employer's extranet website, which currently uses all custom-coding to generate dynamic web pages from database queries and trading partner electronic transactions, with one newly built upon Drupal. Is this a good idea? 2. Why Drupal developer might care to help me answer this question If I undertake to convert our current web applications to Drupal, I believe there are some benefits to the Drupal community which may accrue. They fall primarily in three categories: a) My employer will pay for me to spend a significant amount of my time working directly on Drupal or Drupal-related code. I expect this may be a thousand hours over the next year minimum. This means I will be paid to work on Drupal issues which affect my company, which would include bugs or limitations in core or module code. Fixing bugs is good for the Drupal community. b) My employer will need to develop a large amount of custom code to run its applications. Some of that will be very generic code which will be donated back to the Drupal community if they so desire it. For example, almost all of our applications involve date input for elements. I will spend the time necessary to perfecting a variety of form elements such as date which others in Drupal may wish to use. (It is also true that much of the code I develop with be of no interest or use to anyone else, and/or proprietary.) c) My employer currently employees several contract developers full time. I see a big opportunity to hire Drupal developers on contract to help us out with this conversion project, and with developing new applications in the future (we are constantly developing new software to meet our changing and growing business opportunities). The rest of this message is posted here: http://drupal.org/node/18124 If you are willing to help me answer the question of whether I should go ahead with this project, please respond there. Thanks, -- Chris Johnson

1 0

[drupal-devel] [bug] The DrupalCon bug -- node administrator privileges kills DISTINCT
by chx 28 Feb '05

28 Feb '05

Issue status update for http://drupal.org/node/18123 Project: Drupal Version: cvs Component: node system Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/drupalcon.patch (1.07 KB) At the conf, moshe pointed out a bug, and JonBob and I fixed it on site. The $return['distinct'] in the past should have been module_implements('node_grants') but after JonBob's node_access_view_all_nodes, that part happens only if node_grants is in effect, so it is simplified to 1. This orphans module_implements, but my module.inc patch uses it, so it won't be an orphan after all. chx

1 0