March 2005 - Development - lists.drupal.org

[drupal-devel] [bug] db_set_active problems
by adrian 27 Mar '05

27 Mar '05

Issue status update for http://drupal.org/node/13115 Project: Drupal Version: 4.5.0 Component: database system Category: bug reports Priority: normal -Assigned to: Anonymous +Assigned to: adrian Reported by: Anonymous Updated by: adrian Status: active I've clarified the documentation in this patch : http://drupal.org/node/19522 That's pretty much all that can be done in this case. adrian Previous comments: ------------------------------------------------------------------------ November 18, 2004 - 15:20 : Anonymous If you use the db_set_active function to change to another database, and then run a query that contains invalid syntax, watchdog module tries to insert the error, but uses the currently active database, instead of the drupal database. The errors in error_log are along the lines of: [Thu Nov 18 09:30:51 2004] [error] PHP Fatal error: Table 'someotherdb.watchdog' doesn't exist query: INSERT INTO watchdog (uid, type, message, link, location, hostname, timestamp) VALUES (2, 'error', 'user error: Unknown column \'favourite\' in \'field list\' query: --SNIP BAD QUERY-- in /var/www/httpd/includes/database.mysql.inc on line 125.', '', '/addespy?awitem=26', '192.168.0.1', 1100770251) in /var/www/httpd/includes/database.mysql.inc on line 125 [Thu Nov 18 09:30:51 2004] [error] PHP Fatal error: Table 'someotherdb.sessions' doesn't exist query: UPDATE sessions SET uid = 2, hostname = '192.168.0.1', session = 'messages|a:0:{}', timestamp = 1100770251 WHERE sid = '428af456a2ec4610951275d551ab6f6a' in /var/www/httpd/includes/database.mysql.inc on line 125 [Thu Nov 18 09:30:51 2004] [error] PHP Warning: Unknown(): A session is active. You cannot change the session module's ini settings at this time. in Unknown on line 0 ------------------------------------------------------------------------ November 18, 2004 - 15:35 : Anonymous not sure if this is the way to fix it or if there are deeper issues which need to be considered. something along the lines of database.inc add a function called db_get_active then in the watchdog call the function before any logging to the drupal database if the returned name != 'default' then remember what it was set to, call db_get_active('default') then after the watchdog has logged anything set the active database back to it's previous value. Thanks, Sil ------------------------------------------------------------------------ February 21, 2005 - 20:10 : yogadex The problem is not exactly as you describe. If you add some prints to db_set_active, you'll see that the watchdog code is being called after you've called db_set_active a second time, returning to the default database. (At least, you had better be doing that. But you'll still have the problem) My thinking is the problem has to do with PHP references. When you call db_set_active('your_db'), it calls // Set the active connection. $active_db = $db_conns[$name]; But at this point $active_db is a reference to the default database connection. Because of some nasty reference stuff, you''ve actually changed the default database connection to connect to your_db! Later, when you call db_set_active(), you don't really change anything! For me, the quickest fix was to simply change the if statement near the top of db_set_active... // if (!isset($db_conns[$name])) { if (true) { // Initiate a new connection, using the named DB URL specified. This way the code to create a new connection is always called, and active_db always points where it should. Of course you no longer are cacheing connections, but the doc for mysql_connect states that it does that for you. And I'm using mysql so I'm not worried about it. I tried an alternate fix, namely calling unset($active_db) before the line that sets it. That's supposed to get around the reference funkyness, but then the db connections failed every time. So for now I'm sticking with the fix above. ------------------------------------------------------------------------ February 21, 2005 - 20:35 : yogadex When I posted before I did not realize this was the bug report. I thought it was simply a forum post. I'll add a little more info. Also I'd like to see the priority higher than 'minor' doesn't anyone else use more than one database? (I'd submit a fix if I had one. I tried for a while but didn't come up with the right solution). My version info is Drupal 4.5.2, php 4.3.10. Here's my set_active_db with prints that helped me figure out what's going on. (Also I turned debugging on by default in db_query). function db_set_active($name = 'default') { global $db_url, $db_type, $active_db; static $db_conns; print "Setting active DB: $name\n"; if (!isset($db_conns[$name])) { // Initiate a new connection, using the named DB URL specified. if (is_array($db_url)) { $connect_url = array_key_exists($name, $db_url) ? $db_url[$name] : $db_url['default']; } else { $connect_url = $db_url; } $db_type = substr($connect_url, 0, strpos($connect_url, '://')); // TODO: Allow more than one database API to be present. if ($db_type == 'mysql') { include_once 'includes/database.mysql.inc'; } else { include_once 'includes/database.pgsql.inc'; } print "Connecting active DB: $connect_url\n"; $db_conns[$name] = db_connect($connect_url); } // Set the active connection. $active_db = $db_conns[$name]; print "Setting active DB: $active_db\n"; print "db_cons[default]: {$db_conns['default']}\n"; } And by the way, thanks for what seems like a great product. I have not used it long. I'm trying to figure out if I can convert my existing site (www.yogadex.org) to Drupal. ------------------------------------------------------------------------ February 22, 2005 - 00:38 : yogadex Ok, one more post... There may be two problems here. There may be a problem as described in the first post. That is, during a call to db_query on a secondary database the watchdog code may be called. That is, if there is an error in the first sql statement, that problem may occur. However, if there is no problem with the sql, the problem I describe occurs. Basically, it makes db_set_active unusable. And therefore the whole multiple database feature is broken, as far as I can tell. -Dave ------------------------------------------------------------------------ March 27, 2005 - 01:45 : adrian I use multiple database connections extensively. I set the default error handler to something else whenever I access my other database.

1 0

[drupal-devel] [feature] Allow multiple database connections within a single system
by adrian 27 Mar '05

27 Mar '05

Issue status update for http://drupal.org/node/7461 Project: Drupal Version: cvs Component: database system Category: feature requests Priority: normal Assigned to: adrian Reported by: adrian Updated by: adrian -Status: active +Status: closed I am closing this. Look here for a continuation : http://drupal.org/node/19522 adrian Previous comments: ------------------------------------------------------------------------ April 29, 2004 - 23:33 : adrian Attachment: http://drupal.org/files/issues/multi_db_connections.diff (5.23 KB) This patch allows multiple database connections to be used within Drupal. The method of specifying : <?php $db_url = "mysql://user:pass@localhost/dbname"; ?> will still work, it will create the 'default' connection. However, if you need multiple connections .. you can specify : <?php $db_url["default"] = "mysql://user:pass@localhost/dbname"; $db_url["other_db"] = "mysql://user:pass@localhost/other_dbname"; $db_url["other_server"] = "mysql://user:pass@my.server.com/dbname"; ?> Within your module you can execute <?php set_active_db("other_db"); //or another named connection ?> to switch the db_api to use that connection. If you do not remember to switch back to default, you might cause interesting errors. so beware. The set_active_db() function defaults it's first parameter to 'default', so you only need to run : <?php set_active_db(); // defaults to 'default' ?> to get back on the right track *Caveats:* If you specify a named connection that doesnt exist, it creates a duplicate of the default. I am not sure if this is the wrong behaviour though, as it is easily fixed , but creating a new pipe is perhaps the desired functionality? I don't know. please comment. Because of the nature of the DB Api , it does not allow you to have both postgres and mysql connections running simultaneously, infact only the first db api include loaded will function. It is beyond the scope of this feature request to rewrite the db api as extensively as is needed to fix this problem. More discussion is needed ------------------------------------------------------------------------ April 30, 2004 - 00:57 : adrian Attachment: http://drupal.org/files/issues/multi_db_connections_0.diff (6.54 KB) added some documentation as per Dries' request ------------------------------------------------------------------------ April 30, 2004 - 07:36 : Dries Committed to HEAD. Thanks Adrian. ------------------------------------------------------------------------ August 25, 2004 - 09:47 : sandeep If I was writing a module that needed to connect to another databases... for example my conf.php might look like this: $db_url["default"] = "mysql://user:pass@localhost/dbname"; $db_url["some_pgsql_db"] = "pgsql://user:pass@localhost/some_pgsql_db"; Within my module I execute set_active_db("some_pgsql_db"); Then I would get the Fatal error "Cannot redeclare..." because now there would be two sets of the db_* functions. One from database.mysql.inc which Drupal will include by default and another from database.pear.inc which my call to set_active_db() will include. ------------------------------------------------------------------------ August 25, 2004 - 10:06 : killes(a)www.drop.org I think using databases running two different systems is a feature rather than a bug. A feature that I don't think many people will require. There is also no easy way of providing this feature I am afraid. ------------------------------------------------------------------------ August 26, 2004 - 14:40 : sandeep I know of a friend who uses Drupal to manage his entire business process. He has written a custom reporting module that collates data form the Drupal database (MySQL) and his clients database which is in MSSQL. I do agree that not many people will require this feature but its a cool feature to have in a web application platform. I am currently working on a database abstration library based heavily on the Drupal database abstraction library to achieve the above feature. I think it should be fairly easy to implement. The idea is to have a wrapper file that has all the db_* functions. Depending on the current database connection type we can include the appropriate file for that particular database type. Now, the db_* function will check the current database type, for example if it is mysql, then db_connect() will call db_mysql_connect() which is defined in the mysql include file. Similarly, the other databases can be supported with the PEAR db library by defining the db_pear_* functions in the pear include file. When I get enough time to complete my library I will contribute a patch for the Drupal database system. ------------------------------------------------------------------------ September 8, 2004 - 15:55 : adrian Firstly, this patch made it into core early on in the 4.5 work. Secondly, I made a note about not being able to use postgres and mysql in the same application. I think there's even a comment in the source. Thirdly, we are moving away from PEAR in the next release, and mssql is no longer supported by drupal. Fourthly, changing the db api to have db_ functions that redirect to the correct function is probably a good idea, but good luck trying to convince people it's needed as it is such a specific use case. ------------------------------------------------------------------------ November 21, 2004 - 10:52 : Anonymous I think the idea of being able to flick databases is a good one, we are using it within our drupal code :) It seems to have introduced a problem, raised on a seperate report http://drupal.org/node/13115 Thanks, Sil

1 0

[drupal-devel] [feature] Adding GeoURL support
by ankur 27 Mar '05

27 Mar '05

Issue status update for http://drupal.org/node/1048 Project: Drupal Version: cvs Component: node system Category: feature requests Priority: minor Assigned to: Anonymous Reported by: antoine Updated by: ankur Status: active I was just searching for comments and posts related to geotagging nodes and this thread came up. If anyone is still following this, I'd like to point you in the direction of the location framework I've been working on recently: http://drupal.org/node/18723 It is currently comprised of a module that allows you to add a location (which can be a full or partial mailing address) and the re-usable API that the module is built on top of. It includes geotagging for geo-specific search engines and a search interface that currently takes a postal code and search radius. It hooks into the node system (and node access system) using location_nodeapi (in location.module). It's still in development stages and most of the architecturally hard work has been done though there is still plenty of room for fixes and modifications (see the issues queue for this project for a current list of open tasks: http://drupal.org/project/issues/18723) Locations just seem like something that would have a natural place on a number of community-driven sites when it comes to translating an online organization into real, physical world presences whether it is through events or geographically targetted community e-mails and the like. I can't imagine all the uses there could be, but I imagine pinpointing locations (and making them easily accessible via deep-links to mapping services, map plotting, etc) to be really helpful to people trying to organize/target community members in a way that can open up a door for Drupal in a CMS arena by being a platform that prevents virtual communities from dissipating into the virtual Ether of the internets. -Ankur ankur Previous comments: ------------------------------------------------------------------------ January 21, 2003 - 14:05 : antoine Is it possible to add a plugin to Drupal that automaticaly 'GeoCodes' (adds longitudinal and latitudinal coordinates to a post as metadata) a node? Someone has done the same for Moveable Type at http://geourl.org/mt.html This feature would allow a poster to identify the geographical location of the subject matter, and nearby blogs. ref: http://www.geourl.org ------------------------------------------------------------------------ March 12, 2003 - 04:53 : al I'm not sure how good an idea this is. Do you mean every node in the system to have a geocode? Most of them would be the same... If you submit identical geocode coordinates to the geocode database more than one, presumably it adds many nodes, which isn't the desired behaviour. It might be nice to have positional coordinates for a particular user. Then you could add the geocode information to just their blog. You'd submit the blog to the central geocode database automatically every time they updated their coordinates, but you'd only submit the one page (http://foo.com/blog/) What do people think? ------------------------------------------------------------------------ April 8, 2003 - 13:58 : Damon i think it would be an awesome feature ------------------------------------------------------------------------ August 3, 2004 - 13:02 : Anonymous GeoURL is really cool. For instance, one can visualize the posts on a map, like http://www.brainoff.com/geoblog/. Latest version of the worldkit even lets you click on a map, and write a blog entry with pre-filled coordinates. The way I would like to see it done is: On the user interface side: 1) Add lat/long to user preferences 2) Pre-fill each new node with users default lat/long 3) replace default coordinates with explicitely provided ones if "add node" is called with "&lat=&lon=" (worldkit does it). 4) Let the user edit the coordinates if he/she feels like it. On the DB side: Add a GIS "Point" (http://dev.mysql.com/doc/mysql/en/GIS_class_point.html) to user profiles and to each node. This way we could use all the spacial relation functions to easily fetch blogs from a certain area (100km around Vienna, and such). Once this is done, it would be easy to do all kinds of nice tricks: * show posts on a map, the way geoblog does * find bloggers near me * RSS feed with all the posts 100km around Vienna * events geovisualisation * "on the road" blog Deno (can't log-in at the moment) ------------------------------------------------------------------------ August 3, 2004 - 13:27 : Deno OK, here I am again. Two more points: 1) Here is an example of how the latest WorldKit and MT work together to produce something really cool. Please don't polute the map. http://brainoff.com/weblogs/blogtalk/map/ 2) MySQL spatial extensions have been introduced in MySQL 4.1 http://dev.mysql.com/doc/mysql/en/Spatial_extensions_in_MySQL.html I like this GeoURL stuff, and may be able to help with coding if you decide to introduce this extension to Drupal. ------------------------------------------------------------------------ August 3, 2004 - 13:43 : JonBob This doesn't seem like something that is so globally useful that it should be part of the core. On the other hand, I think it should be fairly easy to implement this in a module without touching the core anyway. You could use hook_nodeapi() to display the fields you need on node forms, save the information, and display it at view time.

1 0

[drupal-devel] [feature] pgsql function w/o need for plpgsql
by adrian 27 Mar '05

27 Mar '05

Issue status update for http://drupal.org/node/4124 Project: Drupal Version: cvs Component: database system Category: feature requests Priority: normal Assigned to: adrian Reported by: Anonymous Updated by: adrian Status: active i just neglected to get rid of the last of the plpgsql functions. drupal 4.6 will be the last version to depend on plpgsql (i promise) adrian Previous comments: ------------------------------------------------------------------------ November 13, 2003 - 20:12 : Anonymous in database/database.pgsql there are two functions. first of all plpgsql is not neccessary (and in some databases is not available), secondly i think the greatest() function has error but maybe it's supposed to emulate mysql error? here goes the code: --- --- Functions --- --CREATE FUNCTION "greatest"(integer, integer) RETURNS integer AS ' --BEGIN -- IF $1 > $2 THEN -- RETURN $1; -- END IF; -- RETURN $2; --END; --' LANGUAGE 'plpgsql'; -- this is the above function without the need of plpgsql -- but what if $1 = $2 ?! CREATE FUNCTION "greatest"(integer, integer) RETURNS integer AS ' SELECT CASE WHEN $1 > $2 THEN $1 ELSE $2 END; ' LANGUAGE 'sql'; --CREATE FUNCTION "rand"() RETURNS float AS ' --BEGIN -- RETURN random(); --END; --' LANGUAGE 'plpgsql'; CREATE FUNCTION "rand"() RETURNS float AS ' SELECT random(); ' LANGUAGE 'sql'; ------------------------------------------------------------------------ November 14, 2003 - 11:10 : adrian Thank you for your input. I will apply these changes to the schema files / update script. ------------------------------------------------------------------------ November 18, 2003 - 19:29 : adrian i originally had a patch which turned greatest into a case when statement. it turns out it didn't return the right data. I will have to test this more completely before i can patch this.. but i am paying attention to it. ------------------------------------------------------------------------ July 23, 2004 - 19:03 : killes(a)www.drop.org Is this still open?

1 0

[drupal-devel] [feature] Module Grouping by Folder in Admin/Modules
by jjeff 27 Mar '05

27 Mar '05

Issue status update for http://drupal.org/node/19477 Project: Drupal Version: cvs Component: module system Category: feature requests Priority: minor Assigned to: Anonymous Reported by: jjeff Updated by: jjeff Status: active It would be nice if the admin/modules listing grouped multiple modules that resided in subfolders of the main modules directory. This way module collectives (like ecommerce or massmailer) would all show up in the same area of the module listing. It would make enabling/disabling these modules a lot more intuitive and also make it clear which modules were part of a group. Single modules in a subfolder would not exhibit this behavior. Just a thought. -Jeff jjeff

5 4

[drupal-devel] [bug] db_set_active problems
by adrian 27 Mar '05

27 Mar '05

Issue status update for http://drupal.org/node/13115 Project: Drupal Version: 4.5.0 Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Anonymous Updated by: adrian Status: active I use multiple database connections extensively. I set the default error handler to something else whenever I access my other database. adrian Previous comments: ------------------------------------------------------------------------ November 18, 2004 - 15:20 : Anonymous If you use the db_set_active function to change to another database, and then run a query that contains invalid syntax, watchdog module tries to insert the error, but uses the currently active database, instead of the drupal database. The errors in error_log are along the lines of: [Thu Nov 18 09:30:51 2004] [error] PHP Fatal error: Table 'someotherdb.watchdog' doesn't exist query: INSERT INTO watchdog (uid, type, message, link, location, hostname, timestamp) VALUES (2, 'error', 'user error: Unknown column \'favourite\' in \'field list\' query: --SNIP BAD QUERY-- in /var/www/httpd/includes/database.mysql.inc on line 125.', '', '/addespy?awitem=26', '192.168.0.1', 1100770251) in /var/www/httpd/includes/database.mysql.inc on line 125 [Thu Nov 18 09:30:51 2004] [error] PHP Fatal error: Table 'someotherdb.sessions' doesn't exist query: UPDATE sessions SET uid = 2, hostname = '192.168.0.1', session = 'messages|a:0:{}', timestamp = 1100770251 WHERE sid = '428af456a2ec4610951275d551ab6f6a' in /var/www/httpd/includes/database.mysql.inc on line 125 [Thu Nov 18 09:30:51 2004] [error] PHP Warning: Unknown(): A session is active. You cannot change the session module's ini settings at this time. in Unknown on line 0 ------------------------------------------------------------------------ November 18, 2004 - 15:35 : Anonymous not sure if this is the way to fix it or if there are deeper issues which need to be considered. something along the lines of database.inc add a function called db_get_active then in the watchdog call the function before any logging to the drupal database if the returned name != 'default' then remember what it was set to, call db_get_active('default') then after the watchdog has logged anything set the active database back to it's previous value. Thanks, Sil ------------------------------------------------------------------------ February 21, 2005 - 20:10 : yogadex The problem is not exactly as you describe. If you add some prints to db_set_active, you'll see that the watchdog code is being called after you've called db_set_active a second time, returning to the default database. (At least, you had better be doing that. But you'll still have the problem) My thinking is the problem has to do with PHP references. When you call db_set_active('your_db'), it calls // Set the active connection. $active_db = $db_conns[$name]; But at this point $active_db is a reference to the default database connection. Because of some nasty reference stuff, you''ve actually changed the default database connection to connect to your_db! Later, when you call db_set_active(), you don't really change anything! For me, the quickest fix was to simply change the if statement near the top of db_set_active... // if (!isset($db_conns[$name])) { if (true) { // Initiate a new connection, using the named DB URL specified. This way the code to create a new connection is always called, and active_db always points where it should. Of course you no longer are cacheing connections, but the doc for mysql_connect states that it does that for you. And I'm using mysql so I'm not worried about it. I tried an alternate fix, namely calling unset($active_db) before the line that sets it. That's supposed to get around the reference funkyness, but then the db connections failed every time. So for now I'm sticking with the fix above. ------------------------------------------------------------------------ February 21, 2005 - 20:35 : yogadex When I posted before I did not realize this was the bug report. I thought it was simply a forum post. I'll add a little more info. Also I'd like to see the priority higher than 'minor' doesn't anyone else use more than one database? (I'd submit a fix if I had one. I tried for a while but didn't come up with the right solution). My version info is Drupal 4.5.2, php 4.3.10. Here's my set_active_db with prints that helped me figure out what's going on. (Also I turned debugging on by default in db_query). function db_set_active($name = 'default') { global $db_url, $db_type, $active_db; static $db_conns; print "Setting active DB: $name\n"; if (!isset($db_conns[$name])) { // Initiate a new connection, using the named DB URL specified. if (is_array($db_url)) { $connect_url = array_key_exists($name, $db_url) ? $db_url[$name] : $db_url['default']; } else { $connect_url = $db_url; } $db_type = substr($connect_url, 0, strpos($connect_url, '://')); // TODO: Allow more than one database API to be present. if ($db_type == 'mysql') { include_once 'includes/database.mysql.inc'; } else { include_once 'includes/database.pgsql.inc'; } print "Connecting active DB: $connect_url\n"; $db_conns[$name] = db_connect($connect_url); } // Set the active connection. $active_db = $db_conns[$name]; print "Setting active DB: $active_db\n"; print "db_cons[default]: {$db_conns['default']}\n"; } And by the way, thanks for what seems like a great product. I have not used it long. I'm trying to figure out if I can convert my existing site (www.yogadex.org) to Drupal. ------------------------------------------------------------------------ February 22, 2005 - 00:38 : yogadex Ok, one more post... There may be two problems here. There may be a problem as described in the first post. That is, during a call to db_query on a secondary database the watchdog code may be called. That is, if there is an error in the first sql statement, that problem may occur. However, if there is no problem with the sql, the problem I describe occurs. Basically, it makes db_set_active unusable. And therefore the whole multiple database feature is broken, as far as I can tell. -Dave

1 0

[drupal-devel] [feature] Feature Request: Text format input module similar to Wiki or XSL(T)
by khanreaper 26 Mar '05

26 Mar '05

Issue status update for http://drupal.org/node/19503 Project: Drupal Version: 4.5.2 Component: filter.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: khanreaper Updated by: khanreaper Status: active It would be nice if, in addition to the existing format engines, there could be another input filter that would automatically transform text input from some sort of markup--perhaps similar to Wiki or XSL(T)--to some form of systematically formatted output. This would be especially helpful when attempting to embed code-listings or other items into content postings. khanreaper

2 1

[drupal-devel] [bug] Comment module outputs duplicate IDs for all *new* comments
by Junyor 26 Mar '05

26 Mar '05

Issue status update for http://drupal.org/node/18870 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Junyor Updated by: Junyor Status: active I've been looking into this a bit today. The comment that should have the "new" ID is dependent on the order of the comment page. I think the first new message chronologically should have the "new" ID. We can do a check similar to the one in comment_render to see what order the page is in. If the page is reverse chronological, we'll have to use a counter to find the oldest new comment. I'll give this some more thought and see if I can come up with a good solution. Junyor Previous comments: ------------------------------------------------------------------------ March 14, 2005 - 13:24 : Junyor In theme_comment_view(), there's a check to see if a comment is new or not. If new, a "new" ID is output for the comment. If there are multiple new comments, they will get duplicate IDs, which is forbidden in (X)HTML. We should use classes instead of IDs so themes can style new comments. The first new comment should also have an ID. This would require theme changes, as well as comment.module changes. ------------------------------------------------------------------------ March 14, 2005 - 22:28 : moshe weitzman verified on drupal.org. we should not be doing this.

1 0

[drupal-devel] [bug] Patch for reported bug on flexinode's URL field type
by Scott Courtney 26 Mar '05

26 Mar '05

Good day! I've just posted a patch to the following issue on the flexinode URL field type: http://drupal.org/node/15955 The patch is against today's CVS version of the file modules/flexinode/contrib/field_url.inc NOTE: Please refer to the *second* posting of my update. The first time, I forgot to put HTML <code> tags around my code snippets, which caused sections of the code not to render right in the displayed page. (Oops.) I have not yet committed the patch to CVS, because the README for this contrib doesn't tell who "owns" it. I would appreciate any test reports on the patch, and if the owner is on-list, please let me know if you want me to commit this to CVS. Thanks! Scott -- -----------------------+------------------------------------------------------ Scott Courtney | "I don't mind Microsoft making money. I mind them scott(a)4th.com | having a bad operating system." -- Linus Torvalds http://4th.com/ | ("The Rebel Code," NY Times, 21 February 1999) | PGP Public Key at http://4th.com/keys/scott.pubkey

1 0

[drupal-devel] [feature] please include the bidi.module as a standard module
by alaa 26 Mar '05

26 Mar '05

Issue status update for http://drupal.org/node/13829 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Anonymous Updated by: alaa Status: active the code is already in my sandbox but as Steven demonstrated its a horrible hack and not really ready to be a proper module. I never got around to cleaning it or any of the other EGLUG modules up. alaa Previous comments: ------------------------------------------------------------------------ December 3, 2004 - 03:39 : Anonymous please include the bidi.module as a standard module, which could be found here: http://uniball.dyndns.org/cgi-bin/viewcvs.cgi/www/eglug/modules/bidi.module This is needed to make arabic function correctly. ------------------------------------------------------------------------ January 14, 2005 - 17:40 : killes(a)www.drop.org moving to Drupal. ------------------------------------------------------------------------ March 14, 2005 - 21:04 : kbahey To the original author of the bidi.module: Please commit it to the contrib respository, and create a project page for it. This way everyone can get it. ------------------------------------------------------------------------ March 21, 2005 - 18:09 : Steven This is in fact not needed at all for Arabic. It is needed to /mix/ two languages with different text directions. This is a different thing altogether. The code seems a bit excessive to me: you should use regular expressions for speed, as well as use Unicode character ranges instead of byte-based regexps (use the /u modifier). Finally, the filter settings should be removed, as they are not settings at all. This practice was removed in 4.5. Also, I'm not sure about the setlocale() call. In my tests, PHP seems to ignore the locale for almost everything. ------------------------------------------------------------------------ March 26, 2005 - 22:27 : msameer kbahey, Alaa is the original author of the module, It's in his sandbox in the drupal CVS. I just ported it to drupal 4.5 API. Infact the module isn't that clean. Alaa is sitting in front of me ATM and he'll reply to this issue. Best regards,

1 0