March 2005 - Development - lists.drupal.org

[drupal-devel] Searching of Stefan.
by Gordon Heydon 25 Mar '05

25 Mar '05

Hello, I am looking to get in contact with Stefan, user http://drupal.org/user/132 He has been doing some stuff with the image tool kits that are going in a similar direction that I want to go, but I can't seem to find his email address, or anything. Can someone please help me get in contact with him. Thanks. -- Gordon Heydon <gordon(a)heydon.com.au>

3 3

[drupal-devel] [bug] Comment Block for Anonymous Users
by timothy bennett 25 Mar '05

25 Mar '05

Issue status update for http://drupal.org/node/19405 Project: Drupal Version: cvs Component: node system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: timothy bennett Updated by: timothy bennett Status: active I'm running the latest CVS update of Drupal 4.6 RC (as of 23 MAR 2005), and I'm getting the following database error when an Anonymous user access my site, and the comment block is NOT populated with the latest comment links. user error: Unknown table 'n' in on clause query: SELECT DISTINCT(c.nid), c.* FROM comments c INNER JOIN node_access na ON na.nid = n.nid WHERE (na.grant_view = 1 AND CONCAT(na.realm, na.gid) IN ('all0','node_privacy_byrole_role1','node_privacy_byrole_user0')) AND c.status = 0 ORDER BY c.timestamp DESC LIMIT 0, 10 in /opt/lampp/htdocs/includes/database.mysql.inc on line 66. Once a user is authenticated, everything works fine. I've poked around the code some, and I'm pretty sure that "n.nid" should be "c.nid", but that is not getting built by the sql query builder (possibly in node.module). The comment block generation function in comment.module is passing a 'c' argument to the query builder, but whatever is building the query seems to be ignoring that argument and using 'n' instead. I'm trying to dig and understand how this code works, but I need a little help. Thanks! timothy bennett

2 4

[drupal-devel] [feature] new status for comments should be tracked separately from status for node
by leafish_dylan 25 Mar '05

25 Mar '05

Issue status update for http://drupal.org/node/6371 Project: Drupal Version: cvs Component: comment.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: jik Updated by: leafish_dylan Status: active This is still causing problems for my users, as only comments on the first page are flagged as new. Has anybody tried to fix this? leafish_dylan Previous comments: ------------------------------------------------------------------------ March 11, 2004 - 02:46 : jik Right now, when you view a node all of its new comments are suddenly treated as no longer new. This makes it essentially impossible to keep track of which comments on a node you've already seen. The status of a comment, i.e., whether you've seen it or not, should be independent of the status of the node. ------------------------------------------------------------------------ March 11, 2004 - 05:32 : jik Attachment: http://drupal.org/files/issues/diff_3 (7.79 KB) The attached patch for your evaluation implements this functionality. The one aspect of the patch that I'm concerned about is that I chose to implement the "read comments" table using ranges rather than recording a single comment in each row, to keep the size of the table small. My concern is that since I'm using ranges, hashes can't be used directly to search the table, so performance will be bad when it gets large. ------------------------------------------------------------------------ March 11, 2004 - 06:14 : jik Attachment: http://drupal.org/files/issues/diff_4 (6.06 KB) Here's a better patch for comment.module. The rest of my last patch remains unchanged. ------------------------------------------------------------------------ March 15, 2004 - 02:57 : jik Attachment: http://drupal.org/files/issues/diff2_5 (15.13 KB) Here's a new patch against 4.4.0-rc, which also incorporates my patches for forums list should show new comments [1] and add new \"new expanded\" comment display modes [2], since they are all interrelated and it's too hard to separate them now that I've ported all my patches to 4.4.0-rc. [1] http://drupal.org//node/view/6370 [2] http://drupal.org//node/view/6376 ------------------------------------------------------------------------ March 15, 2004 - 15:10 : jik Attachment: http://drupal.org/files/issues/diff_14 (482 bytes) Found a bug. Here's an additional patch on top of the last one. ------------------------------------------------------------------------ March 15, 2004 - 16:41 : jik Attachment: http://drupal.org/files/issues/diff_15 (1.05 KB) Another bug. When I added code for purging old entries from comments_history, I forgot to take that into account in comment_num_new and comment_is_new. Patch attached. ------------------------------------------------------------------------ March 17, 2004 - 18:36 : jik Attachment: http://drupal.org/files/issues/diff_19 (1.41 KB) Another patch, to make it possible to view a comment without marking it read. We use this to display unpublished comments for moderators so that they can approve comments without changing the system's indication of whether they've read them (so they can easily read them in context later). ------------------------------------------------------------------------ March 17, 2004 - 18:37 : jik Attachment: http://drupal.org/files/issues/diff_20 (532 bytes) Another patch. This is just a bit of paranoia in the code that removes old entries from the comment history. ------------------------------------------------------------------------ March 17, 2004 - 18:45 : jik Attachment: http://drupal.org/files/issues/diff_21 (234 bytes) Yet another patch. Shouldn't try to mark a comment read if the comment ID is 0 (i.e., we're previewing a comment that doesn't exist yet!) ------------------------------------------------------------------------ March 17, 2004 - 19:05 : jik Attachment: http://drupal.org/files/issues/diff_22 (678 bytes) Yet another patch to fix a precedence error in an SQL statement. ------------------------------------------------------------------------ March 18, 2004 - 04:04 : moshe weitzman The policy here is that the latest patch in the issue should be complete. A reviewer will not look at all the patches posted and figure out which ones add up to the functionality desired. Furthermore, when one posts more than a few patches for the same issue, he may give the reviewer the impression that he is not properly testing his code before upload. reputation is key in getting the attention/trust of the review team.

1 0

[drupal-devel] [bug] Can't apply database update_128
by timothy bennett 24 Mar '05

24 Mar '05

Issue status update for http://drupal.org/node/19399 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: timothy bennett Updated by: timothy bennett Status: active Commit# 14491 modifies the term_node table to make both tid and nid primary keys. That is, ALTER TABLE term_node ADD PRIMARY KEY (tid,nid); However, I've got nodes (as referenced by nid) that have multiple taxonomy terms associated with them (as reference by tid). As such, the node_term table with have duplicate entries of nid, one for each term (tid) that the node is associated with. I don't believe you can make a column a primary key if the values are not unique can you? (Ref: http://drupal.org/node/19275) -- timothy timothy bennett

3 3

[drupal-devel] [support] List of bloggers
by Bèr Kessels 24 Mar '05

24 Mar '05

Issue status update for http://drupal.org/node/17030 Project: Drupal Version: cvs Component: blog.module Category: support requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch look in the menu admin. Bèr Kessels Previous comments: ------------------------------------------------------------------------ February 9, 2005 - 00:27 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ February 9, 2005 - 00:31 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ February 9, 2005 - 00:34 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ February 19, 2005 - 21:13 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano. ------------------------------------------------------------------------ March 17, 2005 - 23:17 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) ) ------------------------------------------------------------------------ March 17, 2005 - 23:19 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2_0.patch (1.71 KB) sigh. something tells me i should stop working.... a silly "F" sneaked into the previous patch. ------------------------------------------------------------------------ March 24, 2005 - 21:25 : Anonymous I applied the patch, reuploaded the blog.module and then deactivated and reactivated it. I cannot see a difference. How do I access the blog users page? Drupal 4.6rc thanks for the help.

1 0

[drupal-devel] template.php of phptemplate engine is not gpl
by Karoly Negyesi 24 Mar '05

24 Mar '05

Hi! I just checked and I see that this small but important file is not GPL. I say we shall rewrite it, in a non-OOP manner while at that. Regards NK

3 2

[drupal-devel] [support] List of bloggers
by Anonymous 24 Mar '05

24 Mar '05

Issue status update for http://drupal.org/node/17030 Project: Drupal Version: cvs Component: blog.module -Category: bug reports +Category: support requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Anonymous Status: patch I applied the patch, reuploaded the blog.module and then deactivated and reactivated it. I cannot see a difference. How do I access the blog users page? Drupal 4.6rc thanks for the help. Anonymous Previous comments: ------------------------------------------------------------------------ February 8, 2005 - 23:27 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ February 8, 2005 - 23:31 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ February 8, 2005 - 23:34 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ February 19, 2005 - 20:13 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano. ------------------------------------------------------------------------ March 17, 2005 - 22:17 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) ) ------------------------------------------------------------------------ March 17, 2005 - 22:19 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2_0.patch (1.71 KB) sigh. something tells me i should stop working.... a silly "F" sneaked into the previous patch.

1 0

[drupal-devel] Taxonomy Cleanup > Hit Me With Your Best Shot (Fire AwwWWaaYyy!)
by Morbus Iff 24 Mar '05

24 Mar '05

Song lyrics in subject lines rule. I'm tellin' ya. With the recent 98%ing of my folksonomy patch, I'm finding some time to do something that a lot of folks seem to murmur everytime taxonomy comes up: clean up taxonomy.module. While implementing free tagging, I could certainly see some of the areas responsible for the murmur, but I'd be a fool to say I saw everything. So, what I'd like to hear is every annoyance, disgust, cleanup on aisle 3, and fatal flaw of the existing taxonomy.module. My very early gameplan: First patch: * add doxygen to everything. * use menu callbacks and get rid of taxonomy_admin. * remove/condense duplicitous and useless functions. Additionally: * rewrite _save so that the term_data deletion is smarter. -- Morbus Iff ( you are nothing without your robot car, NOTHING! ) Culture: http://www.disobey.com/ and http://www.gamegrene.com/ Spidering Hacks: http://amazon.com/exec/obidos/ASIN/0596005776/disobeycom icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / jabber.org: morbus

1 0

[drupal-devel] [feature] Pass include and exclude parameters to cron.php for fine grained cron timing
by robertDouglass 24 Mar '05

24 Mar '05

Issue status update for http://drupal.org/node/19173 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: robertDouglass Reported by: robertDouglass Updated by: robertDouglass Status: patch I think I am leaning in favor of extending cron.php in the following way: 1) Add admin screen which scans all modules for existence of cron hook 2) set a cron_interval variable for each one 3) allow admin to set an interval 4) check whether the current cron run falls outside of each module's interval before invoking its cron hook 5) before a module's cron hook gets called a {module_name}_cron_busy variable gets set. This would function like the current cron_busy now, just at a modular level. The admin would then set one cron tab to run at the smallest needed interval and could then decide on a module-by-module basis how often each is to run. How does this sound to people? robertDouglass Previous comments: ------------------------------------------------------------------------ March 20, 2005 - 11:08 : robertDouglass Attachment: http://drupal.org/files/issues/cronpatch.txt (1.99 KB) Some sites need fine grained timing for cron runs. For example, a site that relies heavily on moblogging, mailhandler or any other email based function would want to connect with the email server pretty often, say ever 2-5 minutes. On another site I'm working on we generate flat files for all of a certain node type on a regular basis, though not every 2-5 minutes. Thus the need for cron tasks on different schedules. This patch allows you to make a list of modules to either include or exclude when running cron, so that several cron tasks for one site can be defined. The default behavior in the absence of both parameters is to run all, so the patch preserves backwards compatibility. * Examples: * * runs all hooks * http://mysite.com/cron.php * * runs all hooks except the search and aggregator modules * http://mysite.com/cron.php?exclude=search,aggregator * * runs only search, archive and aggregator modules * http://mysite.com/cron.php?includ=search,archive,aggregator ------------------------------------------------------------------------ March 23, 2005 - 22:23 : Dries Isn't it possible to run all cron functions every 2-5 minutes? The impact of that should be minimal. ------------------------------------------------------------------------ March 23, 2005 - 22:33 : moshe weitzman an alternative approach is to make a quick PHP page which simply calls mailhandler_cron and any others that need to be called more frequently than normal. then call that php page from cron every couple minutes ... not so sure this complexity is worth having. ------------------------------------------------------------------------ March 24, 2005 - 08:32 : robertDouglass Whether or not this "complexity" is needed depends a lot on what you expect to do with cron. As soon as one starts aggregating not tens but several hundred RSS feeds or more, it is impossible to run cron every 2 minutes. Yet if the site depends on mailhandler keeping user moblog submissions current, 2 minutes is already about the maximum latency time acceptable. Thus the need for crons on different schedules. In terms of usage, writing ?include=mailhandler,search,event isn't so complex. On the code level, splitting that list on comma and looping over the resultant array also isn't really that complex. The patch defaults to normal behavior for people who don't need the feature, and I've seen more than one site that had to solve this problem. ------------------------------------------------------------------------ March 24, 2005 - 11:48 : Robert Castelo Could different cron runs be set to run different tasks based on a cron ID number.... For instance, set up 3 separate cron to run every hour, each one calls the cron.php page including a number variable which runs a certain set of tasks. An Admin control panel would list all cron tasks and allow administrators to split them into separate cron runs based on the number variable passed to the script when calling cron.php. ------------------------------------------------------------------------ March 24, 2005 - 12:24 : robertDouglass Robert, the id parameter is already a practical necessity for this patch if cron_busy is to be effective. I'm open to suggestions as to how we would track various cron tasks and whether they are busy. First things first, though: does anyone except me need this? I'm not going to program an admin-configurable cron mechanism unless there is demand for it. Furthermore, such a system would really be incomplete unless there were some actual mechanism for setting these cron runs up from the admin interface as well. This wouldn't be such a bad idea, I know a lot of people who still type /cron.php into their browser every day or so to updated thier sites (yes I've mentioned poormanscron). Anyway, first reactions to this patch have been cold, so maybe nobody wants it. ------------------------------------------------------------------------ March 24, 2005 - 12:39 : Robert Castelo +1 from me. I'll be needing something like this once my email newsletter is released and starts hogging cron runs. ------------------------------------------------------------------------ March 24, 2005 - 17:06 : Chris Johnson It does seem like a good idea to allow running different cron tasks at different intervals, so as to be efficient and reduce web server loads. There is little point in running tasks that do not need to be run. Many cron tasks only need to be run once to a few times per day. Note also that cron job scheduling on most Unix-variants is only within a +/- 1 minute range, so trying to run a cron program every 2 minutes is approaching the crumbling edge of being "on time."

1 0

[drupal-devel] [feature] tracker module should have a block
by hba 24 Mar '05

24 Mar '05

Issue status update for http://drupal.org/node/1570 Project: Drupal Version: cvs Component: tracker.module Category: feature requests Priority: minor Assigned to: Anonymous Reported by: hafif Updated by: hba Status: won't fix hafif: I just made a patch that creates the block you are look for, check here: http://drupal.org/node/19387. I don't know if killes wants to include it any more now than earlier, though... hba Previous comments: ------------------------------------------------------------------------ April 19, 2003 - 08:27 : hafif but it should be a clever block: it should display the comments title *and* the nodes title, and shouldn't display a node twice.. the GROUP BY query to get this list on a DB with thousands of nodes and comments is very slow. (tracker_page is also very slow) maybe a new table keeping only nid's, cid's and timestamps, would be nice.. ------------------------------------------------------------------------ April 21, 2003 - 20:29 : moshe weitzman I don't understand the 2nd paragraph. How is this different from the display current tracker_page? the idea for a new table is probably a good one. of course, it would be unnecessary if comments were stored as nodes. ------------------------------------------------------------------------ April 28, 2003 - 00:26 : hafif basically what i would like, is something like the "active forum topics" block of the forum.module, also displaying the comments subject. say, most recently node #456 had 3 new comments, node #956 had 2 comments, and node #123 had 1 comment. then the block would display: - subject of comment 3 of #456 title of #456 - subject of comment 2 of #956 title of #956 - subject of comment 1 of #123 title of #123 this way, when you enter the site, you would see say 10 items in that block, and if you recall any of the subjects you click the one above it, then the one above that, and so after a few clicks you catch up completely. the tracker page also displays older comments in the node that has recent activity. it's a good way for catching up if your last visit was a long time ago, but the block i'm suggesting is way faster and more usable for busy sites with frequent visitors. i did this on my installation of drupal which is at http://www.hafif.org/drupalometre using this query instead of the forum.module's block query it's the block right under the logo: SELECT MAX(c.cid) AS ccid, n.nid FROM comments c, node n WHERE c.nid = n.nid AND n.status = 1 GROUP BY n.nid ORDER BY timestamp DESC but it is slow (5 sec), since i have around 45.000 comments, and 15.000 nodes ------------------------------------------------------------------------ October 10, 2004 - 22:45 : killes(a)www.drop.org A tracker block would be quite expensive in terms of database queries. Blocks can also be generated outside the core, so I won't fix this.

1 0