May 2005 - Development - lists.drupal.org

[drupal-devel] [task] Usability tweaks: INSTALL.txt, .htaccess, settings.php.
by Morbus Iff 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/18641 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: Morbus Iff Status: patch The following patches clear up a number of minor inconsistencies during a Drupal installation. Largely, this is related to internal documentation and "where things go", but should help organize, clearup, and ease the installation. These aren't features, so they're eligible for a 4.6 commit. The INSTALL.txt no longer contains the SERVER CONFIGURATION block. These settings are now hardcoded into sites/default/settings.php, and are merely scary technical junk here. The INSTALL.txt has been updated with the latest system requirements. A whole sentence was struck regarding differing versions of PHP for the OSs. The INSTALL.txt contains URLs to MySQL and PostgreSQL. If we're including the URL for PHP in the same sentence, then there's no reason why we wouldn't include them for the database engines. What are the minimal requirements for the RDBMS? Those should be included here too. The INSTALL.txt's OPTIONAL COMPONENTS has renamed to OPTIONAL REQUIREMENTS. The only difference between the meaning is the amount of user confusion. The INSTALL.txt has a new CONTENTS OF THIS FILE, in hopes that people will more immediately notice that there are upgrade instructions at the bottom. The INSTALL.txt had some potentially confusing lines adjusted, including further clarifications, standarding to "userid" (instead of using both userid and username interchangebly) and so on. I've moved most of .htaccess php_value's to the ini_set system for /sites/. There are a few reasons for this, chiefly that it is centralizing all the PHP setting modifications to one place. But, this also clears up a few initial configuration issues: first, the user doesn't have to worry about whether they have Apache 1 or 2, and whether they need to change an IfModule line. Also, the running assumption is that these php_value's are /going to work by default anyways/, when the INSTALL.txt suggests otherwise (under OPTIONAL REQUIREMENTS, it talks about "the ability to use local .htaccess files", which suggests that "local .htaccess files" INCLUDING "mod_rewrite" are entirely optional.) Some variables, however, had to remain in .htaccess because they can't be overridden at runtime, but the amount was so small that duplicating them for both Apache 1 and Apache 2 possibilities is no longer a prohibitive concern. There are two variables in .htaccess that I'm concerned about: track_vars, and allow_call_time_pass_reference. track_vars appears to be no longer necessary (as of 4.0.3, track_vars is /always/ on [1], and my setting it here had no impact on the results of a phpinfo), and allow_call_time_pass_reference seems, at least here, to ONLY WORK if the .htaccess value is set to "1", and not "On" - meaning that Drupal installations are currently working correctly with its default value (off). According to the PHP docs, this feature is now deprecated. However, since both of these variables require further investigation, track_vars has been moved to settings.php, and allow_call_time_pass_reference has been "fixed" to a 1 (not 'On'). Along with the changes above for sites/default/settings.php, I've also removed the spacing indent in the documentation, as well as many a few grammatical/punctuation changes here and there. I don't think the leading spacing is "right" according to the style guidelines, but maybe there's a special need for it. Correct me if I'm wrong. These patches were made during the exploration and customization of Drupal by NHPR.org. In loving support of open source software, NHPR.org will continue to contribute patches they feel the community will benefit from. [1] http://us3.php.net/session Morbus Iff

10 30

[drupal-devel] [bug] Forums vocabulary title not localizable
by calanya 29 Jul '05

29 Jul '05

Issue status update for http://drupal.org/node/19534 Project: Drupal Version: cvs Component: forum.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: calanya Updated by: calanya Status: active The forums vocabulary title ('Forums') is not localizable. Workaround is to directly edit the vocabulary table. calanya

4 9

[drupal-devel] [feature] Roles should not be separated by a BR.
by Morbus Iff 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/20457 Project: Drupal Version: cvs Component: user.module Category: feature requests Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: Morbus Iff Status: patch Attachment: http://drupal.org/files/issues/_patch_usermodulebr.patch (848 bytes) On admin/user, the user's roles are separated both by a comma and a [br /]. The comma is quite enough - the [br /] merely makes the page look retarded ("fat" rows) on screens that have plenty of width to accomodate the entire table without the BR. On smaller width'd browsers, the "fat" rows will return, but naturally wrapped, not forced with inline HTML. Likewise, [BR] and the comma are both delimiters: only one is needed (if we use [BR], the newline becomes the visual delimiter; if we use comma, then we don't need the newlines). The attached patch removes the [BR]. Morbus Iff

5 6

[drupal-devel] [feature] Submission queue menu item should have count
by hba 27 Jul '05

27 Jul '05

Issue status update for http://drupal.org/node/19370 Project: Drupal Version: cvs Component: queue.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: hba Updated by: hba Status: active Attachment: http://drupal.org/files/issues/queue.module_0.patch (512 bytes) The 'submission queue' item in the menu block should have a count, so that users easily can see if there are new articles to vote for. Working patch attached. hba

2 2

[drupal-devel] [feature] Node module should provide node object to theme search hook
by Eric Scouten 27 Jul '05

27 Jul '05

Project: Drupal Version: 4.5.0 Component: page.module Category: feature requests Priority: normal Assigned to: Eric Scouten Reported by: Eric Scouten Updated by: Eric Scouten Status: patch Attachment: http://drupal.org/files/issues/node_search_hook.patch (719 bytes) As currently defined node.module's search hook doesn't provide enough information to allow a rich rendering of search results. For instance, in a photographic web site, I'd like the search results to show a thumbnail of each matched image. I can't do this without access to the node object. The attached one-line patch provides access to the node object in the search results. Eric Scouten -- View: http://drupal.org/node/16056 Edit: http://drupal.org/project/comments/add/16056

3 6

[drupal-devel] [feature] Check All | None on Content List Page (admin/node)
by jjeff 26 Jul '05

26 Jul '05

Issue status update for http://drupal.org/node/20641 Project: Drupal Version: cvs Component: node.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: jjeff Updated by: jjeff Status: patch Attachment: http://drupal.org/files/issues/node_module_check_all.patch (1.23 KB) >From the "what a great time-saver" department: Here is a short patch to node.module that adds a "Check all | none" javascript link to the bottom of the content listing table on admin/node. By clicking "all" or "none" you can select or deselect all of the check boxes in the table at once. The javascript is very non-invasive, should work older (non-DOM) browsers, and non-javascript browsers will simply lose this function. The patch also adds the attribute [name = "node-admin"] to the [form] tag. I don't know if there is a form naming convention, but this was the best guess I could come up with by looking at the page source. And incidentally, if Drupal is going to move toward javascript/ajax functioning, all forms are going to need 'name' and 'id' tags. Most don't have these now. -Jeff jjeff

8 12

[drupal-devel] [feature] i18n - Move drupal_goto to bootstrap.inc and some related features
by Jose A Reyero 22 Jul '05

22 Jul '05

Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Jose A Reyero Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/i18n_drupal_goto_01.patch (8.41 KB) This is firs of a serie of patches adding support for some i18n related features. This patch: - moves drupal_goto to bootstrap.inc, making it possible to use it from the module_init, even for cached pages - moves url() to bootstrap.inc, as it is needed by drupal_goto, and includes a check for not to resolve path aliases when called from bootstrap (it is not needed and would require including lot more stuff from common.inc) - adds a simple hook to call 'i18n_url_rewrite' from the function 'url()' , which allows outgoing urls to be rewrited, so some additional info can be placed in the path. Jose A Reyero -- View: http://drupal.org/node/16069 Edit: http://drupal.org/project/comments/add/16069

3 7

[drupal-devel] [feature] i18n - Support for language-dependent variables
by Jose A Reyero 22 Jul '05

22 Jul '05

Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Jose A Reyero Reported by: Jose A Reyero Updated by: Jose A Reyero Status: patch Attachment: http://drupal.org/files/issues/i18n_language_variables_01.patch (1.16 KB) This is a simple patch for bootstrap.inc, which adds a function call for all the variable functions (variable_get, variable_set, variable_del). This adds support for language-dependent variables, and does nothing when i18n.module is disabled. The idea is to add a language prefix to the variable name, depending on current language, thus allowing to easily translate some variables to different languages. Jose A Reyero -- View: http://drupal.org/node/16071 Edit: http://drupal.org/project/comments/add/16071

5 10

[drupal-devel] [feature] 'View terms' for vocabularies with > 25 terms
by Morbus Iff 19 Jul '05

19 Jul '05

Issue status update for http://drupal.org/node/20505 Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: Morbus Iff Reported by: Morbus Iff Updated by: Morbus Iff Status: patch Attachment: http://drupal.org/files/issues/_p_25termvocab.patch (1.28 KB) There was some small talk about this here and there during my folksonomy/free tagging patch, but I held off until now to actually implement it. Much like we handle free tagging vocabularies ("this is a free tagging vocabulary: view terms", which leads the admin into the taxonomy pager system), this patch does the same thing for NON-free tagging vocabularies, but ONLY if the vocabulary has more than 25 terms. These patches were made during the exploration and customization of Drupal by http://www.NHPR.org. In loving support of open source software, http://www.NHPR.org will continue to contribute patches they feel the community will benefit from. Questions about this patch should be directed to morbus(a)disobey.com. Morbus Iff

7 23

[drupal-devel] [bug] Consistent return values of comment post(), and much more
by moshe weitzman 18 Jul '05

18 Jul '05

Issue status update for http://drupal.org/node/18656 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: moshe weitzman Updated by: moshe weitzman Status: patch Attachment: http://drupal.org/files/issues/comment_post.patch (15.33 KB) This function which actually posts comments is comment_post(). This function is currently pretty messy, and not suitable for use by other modules. This patch assures that this function returns the comment ID if the submission was successful, or else returns FALSE. This is consistent with node_save(). In fact, I've renamed this function comment_save() for consistency. The old comment_save() was merged with comment_post(). I renamed comment_validate_form() to comment_validate() for consistency with node as well. To do this, I had to clean up quite more of the module. This patch unifies the admin comment form and the usual comment form, similar to what we did for nodes. This resulted lots of duplicate code removal. I was able give Admins the ability to change the author and timestamp of a comment. Thats been a feature request of mine since Jan 2003: http://drupal.org/node/983 I removed comment links from the bottom of the comment preview box (as we did for nodes) I hope this is considered for commit early in the 4.7 cycle. moshe weitzman

6 13