May 2005 - Development - lists.drupal.org

[drupal-devel] [task] Make local tasks more themeable
by drumm 13 Aug '05

13 Aug '05

Project: Drupal Version: cvs Component: menu system Category: tasks Priority: normal Assigned to: drumm Reported by: drumm Updated by: drumm Status: patch There is currently a lot of code that does some heavy lifting in the local task themeable functions. This is a bit of a simplification. No HTML is changed by this refactoring. To test this I tried making the local tasks hierarchical instead of two unordered lists. This was a easy change to do, with about 3 lines of changes. drumm -- View: http://drupal.org/node/17869 Edit: http://drupal.org/project/comments/add/17869

3 8

[drupal-devel] [bug] Menu system requires a local task to have more than 1 child in order to create secondary local tasks
by andremolnar 10 Aug '05

10 Aug '05

Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: andremolnar Updated by: andremolnar Status: patch Attachment: http://drupal.org/files/issues/menu_inc_1a.patch (826 bytes) This is a minor bug. The menu system requires a local task to have more than 1 child in order to create secondary local tasks. In other words if a local task only had 1 child, menu system would not create a secondary local task menu item. This patch fixes that with the addition of 1 character in the code. andre andremolnar -- View: http://drupal.org/node/17022 Edit: http://drupal.org/project/comments/add/17022

4 5

[drupal-devel] [feature] Sort logs by ID instead of timestamp
by njivy 04 Aug '05

04 Aug '05

Issue status update for http://drupal.org/node/23560 Project: Drupal Version: cvs Component: watchdog.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: njivy Updated by: njivy Status: patch In watchdog.module I propose changing the key used to sort logs chronologically. Instead of using the timestamp, which is accurate only to the nearest second, we could use the log entry id ("wid" in the database). As I understand it, the IDs are assigned sequentially, so this is a good approximation to the correct order in which the events are recorded. Also, I don't know of any events that are recorded after a delay. The problem with the current sorting key arises when logged events come within 1 second of each other. The order of events is not always preserved when viewing the log because the timestamp is identical for several events. In "modules/watchdog.module" neard line 91, the word "timestamp" is replaced with "wid": $header = array( ' ', array('data' => t('Type'), 'field' => 'w.type'), array('data' => t('Date'), 'field' => 'w.wid', 'sort' => 'desc'), array('data' => t('Message'), 'field' => 'w.message'), array('data' => t('User'), 'field' => 'u.name'), array('data' => t('Operations'), 'colspan' => '2') ); Preliminary testing suggests this is a good tweak. njivy

7 7

[drupal-devel] [feature] Trigger debug mode on-the-fly
by mathias 03 Aug '05

03 Aug '05

Issue status update for http://drupal.org/node/21379 Project: Drupal Version: cvs Component: other Category: feature requests Priority: normal Assigned to: Anonymous Reported by: mathias Updated by: mathias Status: patch Attachment: http://drupal.org/files/issues/devel_GET_params_core.patch (2.38 KB) This patch allows admins who are using devel.module to optionally toggle the page timer, query logger and page redirection for each request using GET parameters rather than navigating to admin/settings/devel and flipping the global settings back and forth. I added this since I usually don't need to print out this information for every page. Now I just use: http://example.com/index.php?q=node&dev_query=1 for the request I'm interested in. Two other params can also be toggled: dev_timer and dev_redirect. mathias

4 5

[drupal-devel] [task] GD2-specific functions should be moved to image.gd2.inc
by Junyor 01 Aug '05

01 Aug '05

Issue status update for http://drupal.org/node/19611 Project: Drupal Version: cvs Component: base system Category: tasks Priority: normal Assigned to: Junyor Reported by: Junyor Updated by: Junyor Status: patch Attachment: http://drupal.org/files/issues/system-image.patch (6.8 KB) The new image handling tools in core have a lot of GD2-specific logic, making image.inc overly cluttered and complicated. If gd2 were just treated like another toolkit (though the only one included by default), then the image.inc code would be much cleaner and more easily maintained. This patch removes all the GD2 stuff from image.inc and puts it into image.gd2.inc. The _settings hook is now doing what it sounds like it should, return settings for the toolkit. I've added a _check hook which will tell if the PHP functions needed are available. If _check fails, then the toolkit will not be listed on admin > settings and an error will be logged in watchdog. I've also update image.gd1.inc, image.imlib.inc, and image.imagick.inc with the same logic. Junyor

6 14

[drupal-devel] [bug] settings.php change to prevent PHPSESSID in URL
by kbahey 01 Aug '05

01 Aug '05

Issue status update for http://drupal.org/node/21170 Project: Drupal Version: 4.6.0 Component: other Category: bug reports Priority: normal Assigned to: kbahey Reported by: kbahey Updated by: kbahey Status: patch Attachment: http://drupal.org/files/issues/settings_0.patch (576 bytes) As per the workaround mentioned in discussion [1], the default settings.php file that is shipped does not always prevent PHP from adding the PHPSESSID in the URL. Although this is a hosting setting issue, a workaround exists for it: A patch is attached, and it just adds the following line to settings.php ini_set('url_rewriter.tags', ''); [1] http://drupal.org/node/17947#comment-36339 kbahey

3 3

[drupal-devel] [feature] Bind IP to session
by chx 01 Aug '05

01 Aug '05

Issue status update for http://drupal.org/node/19845 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: critical Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/bindip.patch (896 bytes) This would make session hijacking more than a bit harder. The code can be compacted even more, but I did not dare. chx

7 17

[drupal-devel] [feature] Flexiforum modifications
by pyromanfo 01 Aug '05

01 Aug '05

Issue status update for http://drupal.org/node/20295 Project: Drupal Version: cvs Component: forum.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: pyromanfo Updated by: pyromanfo Status: patch Attachment: http://drupal.org/files/issues/flexiforum.patch (10.01 KB) When I saw what was planned for the 4.6.0 forum improvements I was intrigued and a little disappointed. On the one hand, it really did make things easier. On the other hand, it was moving the forum module further away from what I wanted to use it for, making it a little less useful for me. The main thing I wanted the forums for Drupal to do was allow me to use any node type in the forums, following the generic node-based design of Drupal itself. This actually pushed it further away from that goal, having a specific walled-off section of the site that only forum posts are allowed in, and now it's seperate from the other categories as well. So I got to looking at the forum.module code and realized how easy it would be to modify it to use any node type. That, combined with my Quickpost project would allow me the node-generic forum posting I wanted for my site. Enough rambling, here's the goods. Patch Description This patch takes the CVS forum.module and allows users to see any node types in the forums, such as stories, images, book pages, blog entries and flexinode types. It's a suprisingly simple little patch, and if you're like me wanted the forums to be a little more flexible, this patch helps in that regard. It's fairly simple, and I only did preliminary testing so let me know what you think. I don't think this'll get accepted into core, but I didn't know where else to put it. It's too simple to be it's own module and I don't know where else I'd put a patch. If this should be in the forums or something, I'll put it there. pyromanfo

6 8

[drupal-devel] [bug] Various bugs in filter tip display
by Goba 31 Jul '05

31 Jul '05

Project: Drupal Version: cvs Component: filter.module Category: bug reports Priority: normal Assigned to: Goba Reported by: Goba Updated by: Goba Status: patch Attachment: http://drupal.org/files/issues/Drupal-various-bug-in-filter-tips.patch (1.79 KB) The theme_filter_tips() function has a $long attribute, which might have been inserted between the two attributes around it, since some of the function calls are not ready for passing that attribute. Therefor sometimes $long gets the $extra parameter value, and sometimes $long is missing (especially when long filter tips are displayed). Calling with the proper parameters fixes this issue. Also the $tip['id'] is directly used as a HTML id. But $tip['id'] contains things like 'bbcode/0' and 'glossary/0' and therefore is not capable to being used as a HTML id. I prefixed the HTML id with 'filter-', as it used to be and converted the / to -, so the ids become 'filter-bbcode-0' and 'filter-glossary-0' respectively. Patch attached. Might also be relevant for 4.5.x. Goba -- View: http://drupal.org/node/16016 Edit: http://drupal.org/project/comments/add/16016

3 4

[drupal-devel] [feature] New API function: truncate_utf8_conc
by Bèr Kessels 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/21576 Project: Drupal Version: cvs Component: base system Category: feature requests Priority: normal Assigned to: Bèr Kessels Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/common_inc_truncate_utf8_conc.diff (1.63 KB) This function truncates the string, but adds a string to the end, when requested. For example to concenate three dots (...) to a long username. For example to turn the long username * johndoe(a)www.personalweblog.com into johndoe(a)www.johndo... Its possible with the current truncate_utf8(), but than you need to do string comparison and some more truncation afterwards, which is not optimal. And please mark this as wontfix if not appropriate. I do not have time to maintain this patch, so if its not up to standards or so, just close this issue. Bèr Kessels

4 10