May 2005 - Development - lists.drupal.org

[drupal-devel] [feature] Multiple select functionality in profile module
by mathias 28 Aug '05

28 Aug '05

Issue status update for http://drupal.org/node/19356 Project: Drupal Version: cvs Component: profile.module Category: feature requests Priority: normal Assigned to: mathias Reported by: mathias Updated by: mathias Status: patch Attachment: http://drupal.org/files/issues/profile-multiple-select.patch (7.48 KB) This patch adds a 'multiple select' checkbox to the 'list selection' field type interface, allowing users to select multiple items from a single list. It looks the same as the 'multiple select' checkbox used during vocabulary creation. Field values are stored separately in the profile_values table and thus don't need to be serialized, keeping search functionality in tact. Note: this patch is not intended for 4.6. mathias

3 5

[drupal-devel] [task] Fix error reporting for failed mails to users
by nedjo 24 Aug '05

24 Aug '05

Issue status update for http://drupal.org/node/20139 Project: Drupal Version: cvs Component: user.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: nedjo Updated by: nedjo Status: patch Attachment: http://drupal.org/files/issues/user-mail-error-messages.patch (7.2 KB) The user module has error handling for failed emails sent on password changing, but not yet in other cases, so that users may register and get a message that email has been sent when in fact it has not, an issue reported, e.g., here [1]. This patch adds tests for mails sent on user registration, generating appropriate user feedback (e.g., "Unable to send mail", etc.) and logs errors to the watchdog. [1] http://drupal.org/node/20026 nedjo

3 6

[drupal-devel] [feature] OPML export by category
by Prometheus6 22 Aug '05

22 Aug '05

Issue status update for http://drupal.org/node/22637 Project: Drupal Version: 4.6.0 Component: aggregator.module Category: feature requests Priority: normal Assigned to: Prometheus6 Reported by: Prometheus6 Updated by: Prometheus6 Status: patch Attachment: http://drupal.org/files/issues/AGGREGATOR_OPML.txt (1.5 KB) Added an optional parameter to aggregator_page_opml() to specify which category, if any, to create the OPML file for. Modified aggregator_menu() to crerate callbacks for the files. Prometheus6

3 8

[drupal-devel] [feature] Taxonomy rewrite
by chx 21 Aug '05

21 Aug '05

Project: Drupal Version: cvs Component: taxonomy.module Category: feature requests Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/taxonomy_db_rewrite.patch (6.71 KB) I'd like to present a use for db_rewrite_sql: taxonomy rewrites. If this goes through, it will be possible to create an access mechanism, languages and whatever for taxonomy. This is a very small change, I think, much smaller than the node_rewrite_sql megpatch was 'cos at the moment nothing changes. There are no DISTINCTs deleted. But this opens a door for future things. Also, this only affects taxonomy.module, 'cos no other module deals with term_data and vocabulary tables (well, forum.module does, but those queries does not need a rewrite). chx -- View: http://drupal.org/node/16452 Edit: http://drupal.org/project/comments/add/16452

8 21

[drupal-devel] [feature] support for path alias chains in drupal_get_path_alias.
by aws 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/21239 Project: Drupal Version: 4.6.0 Component: base system Category: feature requests Priority: normal Assigned to: Anonymous Reported by: aws Updated by: aws Status: patch Attachment: http://drupal.org/files/issues/includes_bootstrap.inc_0.patch (739 bytes) This is a small patch for function drupal_get_path_alias in bootstrap.inc. This allows a path to have a non-cyclic chain of aliases, and enables the path alias finder to walk up the chain to the top level alias. For example: taxonomy_menu/4/1/50 | topics/whats_new/events taxonomy/term/50 | taxonomy_menu/4/1/50 Now I can have all references to taxonomy/term/50 automatically point to the top-level alias, topics/whats_new/events. I am also posting a patch against Pathauto module which creates these multi-links automatically for categories when taxonomy_menu is present. (I will add followup with a link to that patch). Note that the inverse case (alias => path) is *not* necessary (in fact it would break the intention of this patch... --- There are several other ways to accomplish this; all of which are more involved. YMMV. I won't be insulted if this patch is rejected. :) An alternative solution would be to allow the destination column to accept non-unique entries. This would also require some sort of weighting otherwise the final resolution would be indefinate. A second alternative would be to have drupal generate taxonomy links in a more general manner, so that the taxonomy_menu module could change all the taxonomy links via the proper hooks. A *third* alternative would be to fix the menu system so that it does not require nested paths in the hiearchy, this way taxonomy_menu would not need to create its own paths. aws

3 4

[drupal-devel] [bug] Change default for files directory
by killes 20 Aug '05

20 Aug '05

Issue status update for http://drupal.org/node/23467 Project: Drupal Version: cvs Component: file system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/file-default.patch (4.98 KB) Currently the defautl for the file storage directory is /files. This is a problrem if you should later decide to setup more than one site from the same source code. The attached page changes the default to be /sites/default/files (defautl is replaced by the site url if the default directory is renamed). killes(a)www.drop.org

6 9

[drupal-devel] [bug] Don't hard code forms into comment.module
by Robin Monks 17 Aug '05

17 Aug '05

Issue status update for http://drupal.org/node/23620 Project: Drupal Version: cvs Component: comment.module Category: bug reports Priority: normal Assigned to: Robin Monks Reported by: Robin Monks Updated by: Robin Monks Status: patch Attachment: http://drupal.org/files/issues/Comment.Control.hardcode.patch (4.02 KB) This patch removes all those nasty hard coded forms from comment.module's user Comment Control. Robin Robin Monks

5 15

[drupal-devel] [bug] Allow both postgres and mysql database connections from within the same site.
by adrian 17 Aug '05

17 Aug '05

Issue status update for http://drupal.org/node/19522 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: adrian Reported by: adrian Updated by: adrian Status: patch Attachment: http://drupal.org/files/issues/multi-dbtype.diff (14.57 KB) When I originally coded the multiple database support I noted the caveat that only one database type was useable at a time due to the conflicting function names, so including both database.pgsql.inc and database.mysql.inc would cause a crash. This was also brought up again when someone reopened the multi-db functionality issue, and I am attaching the patch here. I would love for this patch to get into 4.6 if possible. I don't believe it's very invasive, and it fixes a long standing bug in the db api. I have been using some form of this patch on Bryght for the last 3-4 months, and have not found any ill effects related to it. I also clarified the db_set_active() comments a bit after I saw this issue (http://drupal.org/node/13115) adrian

3 4

[drupal-devel] [bug] welcome text appears when the query in node_page_default is rewritten to have an empty result
by chx 17 Aug '05

17 Aug '05

Issue status update for http://drupal.org/node/18340 Project: Drupal Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: chx Reported by: chx Updated by: chx Status: patch Attachment: http://drupal.org/files/issues/default_as_node.patch (8.55 KB) As discussed on IRC, I have moved the welcome text into node 0 as a PHP node. Although there is a check for whether this welcome node is present for every node_page_default call, it is only a variable_get, so it is cheap. Also at every node save we check for the same variable, and if the welcome node is present, it gets silently deleted. So, as soon as the first node gets created, the welcome text disappears as it should. The one liner in node_validate is very important when a node with nid=0 is present. Otherwise, consider it a minor speedup. This patch should have a little positive effect on the memory requirements of node.module -- a long, rarely used text is removed. This is not a new feature but a usability issue so let's get it into 4.6. Although there is change (two INSERTs) to database.mysql and database.pgsql it does not mandate an update.inc change 'cos most probably noone will bother with updating an empty site. I payed special attention to spaces this time. chx

6 15

[drupal-devel] [bug] _db_query() shows each query error twice
by danielc 16 Aug '05

16 Aug '05

Issue status update for http://drupal.org/node/19942 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: danielc Updated by: danielc Status: patch Attachment: http://drupal.org/files/issues/database.silence.query.diff (1.2 KB) In _db_query(), when a query error happens, the error messages are displayed twice. First at the point of the pg_query()/mysql_query() call and then at the track_errors() call. Since there is an error handling/reporting process in place, the query calls should suppress error output by placing @'s in front of them. The attached patch does that for both the database.mysql.inc and database.pgsql.inc files. danielc

3 8