July 2005 - Development - lists.drupal.org

[drupal-devel] [bug] Drupal 4.6.2 Doesn't allow login (IIS 5.1, PHP 5.0.4)
by chx 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/26780 Post a follow up: http://drupal.org/project/comments/add/26780 Project: Drupal Version: 4.6.0 Component: base system Category: bug reports Priority: critical Assigned to: bigeye Reported by: bigeye Updated by: chx Status: patch (code needs review) I fail to see why this is needed and where is the patch? I searched for _VARS in Drupal HEAD, there is not a single instance of it, and frankly, I doubt we have had any in a long time. chx Previous comments: ------------------------------------------------------------------------ Fri, 15 Jul 2005 16:36:37 +0000 : bigeye BUG: Use valid user/passwd, kicked back to login page. Use invalid user/passwd, kicked back to login page and saying Access denied. It appears that the first case is passed the login check, for some reason, it cannot redirect to the correct page or the login info is not stored. It doesn't work with both IE and FireFox. We can see there is a cookie there in FirFox. So it's not the cookie problem also. FIX: In settings.php add this satement: ini_set('register_long_arrays', 1); or modify this in php.ini globally: register_long_arrays = On (the default is off in PHP 5.0.4) Woohoo! Please add this into your hotfix. :)

1 0

[drupal-devel] [bug] Another simple patch for database.mysql.inc
by kubaZygmunt 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27846 Post a follow up: http://drupal.org/project/comments/add/27846 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: kubaZygmunt Updated by: kubaZygmunt Status: patch Attachment: http://drupal.org/files/issues/database.mysql.inc_0.patch (657 bytes) Another simple patch which removes error: Notice: Undefined index: dev_query in ***\includes\database.mysql.inc on line 80 kubaZygmunt

3 5

[drupal-devel] [task] Maximum picture size help text in profile no longer needed
by nysus 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27234 Post a follow up: http://drupal.org/project/comments/add/27234 Project: Drupal Version: cvs Component: user.module Category: tasks Priority: normal Assigned to: nysus Reported by: nysus Updated by: nysus Status: patch Attachment: http://drupal.org/files/issues/user_22.patch (1.06 KB) This change removes the maximum dimensions and file size text appears in the description for uploading user profile images (avatars). Drupal appears to handle the resizing of images automatically now so text is not needed. nysus

7 18

[drupal-devel] [bug] undefined index
by killes 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27853 Post a follow up: http://drupal.org/project/comments/add/27853 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org -Status: active +Status: patch (code needs review) now... killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Sat, 30 Jul 2005 17:12:50 +0000 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/timers.patch (614 bytes) another one. this is a patch, but Dries is changing the patch statuses.

1 0

[drupal-devel] [bug] first login confusing
by killes 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27852 Post a follow up: http://drupal.org/project/comments/add/27852 Project: Drupal Version: cvs Component: user system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/user-uid-1.patch (1.52 KB) Everytime I create a new site it bugs me again, this time I roll a patch. The message for the first user says that "You may change your password on the next page.". That's not true, you have to click on "edit" before. I've changed the code to match the docs, as I think this behaviour makes more sense. killes(a)www.drop.org

1 0

[drupal-devel] [task] merging feedback.module into contact.module
by Tobias Maier 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27633 Post a follow up: http://drupal.org/project/comments/add/27633 Project: Drupal Version: cvs Component: contact.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: Tobias Maier Updated by: Tobias Maier Status: patch Attachment: http://drupal.org/files/issues/contact.module_3.patch (10.76 KB) contact.module.patch it includes the hidden input field maybe I release one without it... Tobias Maier Previous comments: ------------------------------------------------------------------------ Wed, 27 Jul 2005 23:00:09 +0000 : Tobias Maier The contact.module of the Drupal HEAD does now nearly the same as the feedback.module. kbahey [1] and I talked about to bring them together. To have just one module. a) Here comes a list of features which you can find in feedback.module and which are currently missing in contacts.module * add the following fields to contacts.module: * Postal Address * Phone Number * A real "Message Subject" (You say "What?? we have one!" - this one is used in the false way. Be patient i'll tell you later what i mean) * make it configurable if these fields are shown on the /Sites Contact-Page/ and/or on the /Users Contact-Page/ * Make it configurable which field is required and which one not * The Subject field is currently used to select on which team/department the message belongs to. this field should be renamed to /topic/category/department/ (just one of them / maybe let the user decide) and a Subject field with the default behavour should be introduced. * let the "Additional information:"-field be formatted. So add form_format() * Feedback has a feature "Log all feedback attempts to watchdog" * it also allows you to add an special "Subject Prefix:" to the e-mail which will be sent. * and to customize the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure") (personally i think this is not really needed) * it also allows you to define a "Navigation link text" and a "Feedback Page Header" - but the most users (including me) were a little bit confused about what that means (personally i think this is not really needed) b) here comes my list what i want to see beside the things mentioned above in contact.module: * why does contact have two places to configure it (/admin/contact/ and /admin/settings/contact/) i think they should be merged into one. So that it is easier for the User to get into this. * Help texts, everywhere :D * a new permission:"Let me use all Users Contact page" - allow specific Roles to contact the User through the Contact-Page, also if he deactivated it Please tell me what you think about it and if you have other ideas. I want to start to merge the feedback module into the contact module soon Yours sincerely Tobias Maier [1] http://drupal.org/user/4063 ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:40:21 +0000 : Tobias Maier i forgot to mention that it also sends the referrer in the E-Mail what I also want to include ------------------------------------------------------------------------ Thu, 28 Jul 2005 10:30:36 +0000 : lennart Hi Tobias, I am currently using both feedback.module and contact.module, so for me a merging would generally make sense. I agree with most of your ideas /except/; I do not think " the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure") " is not needed. I think this should stay. It gives comfort and certainty to the user to know that the mail has been sent succesfully Regards Lennart ------------------------------------------------------------------------ Thu, 28 Jul 2005 10:48:13 +0000 : Tobias Maier i think also that this messages should stay there, but I think they don't have to be customizable, like in Feedback. ------------------------------------------------------------------------ Thu, 28 Jul 2005 13:03:54 +0000 : kbahey Tobias, Thanks for the comparison. As the author of Feedback, I see a lot of overlap between contact and feedback. I would like to see them merged, and become part of core. contact is a good base to build on, and has some extra features (most importantly the ability to contact a specific user, as well as list different topic/category and route the message accordingly (think of sales, support, marketing, ..etc or complaint, comment, request, ...etc.) Add to all that one feature present to neither: a checkbox to send a copy of the email to the originator for filing. If both merge and add the above feature, I will be very happy, and feedback can then rest in peace starting from 4.7. ------------------------------------------------------------------------ Sat, 30 Jul 2005 02:32:58 +0000 : Tobias Maier here are the first patches regarding this: * [bugfix] if contact.module is unconfigured the form gets shown [2] * [bugfix/new feature] hide subject if there is just one [3] * [new feature] input format for contact.module [4] * [bugfix] Side-wide contact form: doesn't save entered text on input error reload [5] please test them all and integrate them all as fast as possible, because i want to develop the next steps on top of them Thanks [2] http://drupal.org/node/27757 [3] http://drupal.org/node/27822 [4] http://drupal.org/node/27824 [5] http://drupal.org/node/27139 ------------------------------------------------------------------------ Sat, 30 Jul 2005 13:30:40 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact.module_1.patch (10.38 KB) and here comes the first all-in-one patch: please try it, and tell me if it works for you: This is just the first step to solve the list above so there come much more enhancements later... Changelog: * Includes bugfix: if contact.module is unconfigured the form gets shown [6] * includes bugfix: if contact.module is unconfigured the form gets shown [7] * includes bugfix: Side-wide contact form: doesn't save entered text on input error reload [8] * renamed subject to category * added a real Subject-field * includes input format for contact.module [9] * includes hide subject if there is just one [10] * changes in contact-table (just MYSQL) * subject renamed to category * category is now PRIMARY KEY [6] http://drupal.org/node/27757 [7] http://drupal.org/node/27757 [8] http://drupal.org/node/27139 [9] http://drupal.org/node/27824 [10] http://drupal.org/node/27822 ------------------------------------------------------------------------ Sat, 30 Jul 2005 13:31:33 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/database.mysql_5.patch (720 bytes) the patch for the mysql-table ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:26:00 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact.module_2.patch (11.02 KB) contact.module updated again -->now it runs :D ------------------------------------------------------------------------ Sat, 30 Jul 2005 15:16:38 +0000 : Dries - You need to provide an update for updates.inc too. - You need to provide an update for database.pgsql. - Please drop the filter stuff for now. - Please don't capitalize the words category and subject in + form_set_error('subject', t('You must enter a Subject.')); and + form_set_error('category', t('You must select a valid Category.'));. - If there is only one category, we probably don't need a hidden category either? ------------------------------------------------------------------------ Sat, 30 Jul 2005 16:42:02 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/database.pgsql_5.patch (634 bytes) "If there is only one category, we probably don't need a hidden category either? " if I don't send it hidden I have to count the number of available categories at the field validation. I think this is the best way, because I don't have so much sql queries. "Please drop the filter stuff for now. " why? if it has security reasons than it would be a solution only to allow the dafault filter. here is the update - removed filter - changed the words to lowercase - update for updates.inc - update for database.pgsql I was not able to test the pqsql things... ------------------------------------------------------------------------ Sat, 30 Jul 2005 16:42:40 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/updates.inc_3.patch (1.13 KB) updates.inc.patch

1 0

[drupal-devel] [task] merging feedback.module into contact.module
by Tobias Maier 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27633 Post a follow up: http://drupal.org/project/comments/add/27633 Project: Drupal Version: cvs Component: contact.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: Tobias Maier Updated by: Tobias Maier Status: patch Attachment: http://drupal.org/files/issues/updates.inc_3.patch (1.13 KB) updates.inc.patch Tobias Maier Previous comments: ------------------------------------------------------------------------ Wed, 27 Jul 2005 23:00:09 +0000 : Tobias Maier The contact.module of the Drupal HEAD does now nearly the same as the feedback.module. kbahey [1] and I talked about to bring them together. To have just one module. a) Here comes a list of features which you can find in feedback.module and which are currently missing in contacts.module * add the following fields to contacts.module: * Postal Address * Phone Number * A real "Message Subject" (You say "What?? we have one!" - this one is used in the false way. Be patient i'll tell you later what i mean) * make it configurable if these fields are shown on the /Sites Contact-Page/ and/or on the /Users Contact-Page/ * Make it configurable which field is required and which one not * The Subject field is currently used to select on which team/department the message belongs to. this field should be renamed to /topic/category/department/ (just one of them / maybe let the user decide) and a Subject field with the default behavour should be introduced. * let the "Additional information:"-field be formatted. So add form_format() * Feedback has a feature "Log all feedback attempts to watchdog" * it also allows you to add an special "Subject Prefix:" to the e-mail which will be sent. * and to customize the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure") (personally i think this is not really needed) * it also allows you to define a "Navigation link text" and a "Feedback Page Header" - but the most users (including me) were a little bit confused about what that means (personally i think this is not really needed) b) here comes my list what i want to see beside the things mentioned above in contact.module: * why does contact have two places to configure it (/admin/contact/ and /admin/settings/contact/) i think they should be merged into one. So that it is easier for the User to get into this. * Help texts, everywhere :D * a new permission:"Let me use all Users Contact page" - allow specific Roles to contact the User through the Contact-Page, also if he deactivated it Please tell me what you think about it and if you have other ideas. I want to start to merge the feedback module into the contact module soon Yours sincerely Tobias Maier [1] http://drupal.org/user/4063 ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:40:21 +0000 : Tobias Maier i forgot to mention that it also sends the referrer in the E-Mail what I also want to include ------------------------------------------------------------------------ Thu, 28 Jul 2005 10:30:36 +0000 : lennart Hi Tobias, I am currently using both feedback.module and contact.module, so for me a merging would generally make sense. I agree with most of your ideas /except/; I do not think " the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure") " is not needed. I think this should stay. It gives comfort and certainty to the user to know that the mail has been sent succesfully Regards Lennart ------------------------------------------------------------------------ Thu, 28 Jul 2005 10:48:13 +0000 : Tobias Maier i think also that this messages should stay there, but I think they don't have to be customizable, like in Feedback. ------------------------------------------------------------------------ Thu, 28 Jul 2005 13:03:54 +0000 : kbahey Tobias, Thanks for the comparison. As the author of Feedback, I see a lot of overlap between contact and feedback. I would like to see them merged, and become part of core. contact is a good base to build on, and has some extra features (most importantly the ability to contact a specific user, as well as list different topic/category and route the message accordingly (think of sales, support, marketing, ..etc or complaint, comment, request, ...etc.) Add to all that one feature present to neither: a checkbox to send a copy of the email to the originator for filing. If both merge and add the above feature, I will be very happy, and feedback can then rest in peace starting from 4.7. ------------------------------------------------------------------------ Sat, 30 Jul 2005 02:32:58 +0000 : Tobias Maier here are the first patches regarding this: * [bugfix] if contact.module is unconfigured the form gets shown [2] * [bugfix/new feature] hide subject if there is just one [3] * [new feature] input format for contact.module [4] * [bugfix] Side-wide contact form: doesn't save entered text on input error reload [5] please test them all and integrate them all as fast as possible, because i want to develop the next steps on top of them Thanks [2] http://drupal.org/node/27757 [3] http://drupal.org/node/27822 [4] http://drupal.org/node/27824 [5] http://drupal.org/node/27139 ------------------------------------------------------------------------ Sat, 30 Jul 2005 13:30:40 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact.module_1.patch (10.38 KB) and here comes the first all-in-one patch: please try it, and tell me if it works for you: This is just the first step to solve the list above so there come much more enhancements later... Changelog: * Includes bugfix: if contact.module is unconfigured the form gets shown [6] * includes bugfix: if contact.module is unconfigured the form gets shown [7] * includes bugfix: Side-wide contact form: doesn't save entered text on input error reload [8] * renamed subject to category * added a real Subject-field * includes input format for contact.module [9] * includes hide subject if there is just one [10] * changes in contact-table (just MYSQL) * subject renamed to category * category is now PRIMARY KEY [6] http://drupal.org/node/27757 [7] http://drupal.org/node/27757 [8] http://drupal.org/node/27139 [9] http://drupal.org/node/27824 [10] http://drupal.org/node/27822 ------------------------------------------------------------------------ Sat, 30 Jul 2005 13:31:33 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/database.mysql_5.patch (720 bytes) the patch for the mysql-table ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:26:00 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact.module_2.patch (11.02 KB) contact.module updated again -->now it runs :D ------------------------------------------------------------------------ Sat, 30 Jul 2005 15:16:38 +0000 : Dries - You need to provide an update for updates.inc too. - You need to provide an update for database.pgsql. - Please drop the filter stuff for now. - Please don't capitalize the words category and subject in + form_set_error('subject', t('You must enter a Subject.')); and + form_set_error('category', t('You must select a valid Category.'));. - If there is only one category, we probably don't need a hidden category either? ------------------------------------------------------------------------ Sat, 30 Jul 2005 16:42:02 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/database.pgsql_5.patch (634 bytes) "If there is only one category, we probably don't need a hidden category either? " if I don't send it hidden I have to count the number of available categories at the field validation. I think this is the best way, because I don't have so much sql queries. "Please drop the filter stuff for now. " why? if it has security reasons than it would be a solution only to allow the dafault filter. here is the update - removed filter - changed the words to lowercase - update for updates.inc - update for database.pgsql I was not able to test the pqsql things...

1 0

[drupal-devel] [bug] undefined indices
by killes 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27850 Post a follow up: http://drupal.org/project/comments/add/27850 Project: Drupal Version: cvs Component: database system Category: bug reports Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch undefined indices make my ddevel environnment unhappy. I've created the attached patch, but Bart pointed out that we probably only need $dev_query = variable_get('dev_query', 0); maybe wrapped in an if(function_exist('dev_query')) Comments? killes(a)www.drop.org

1 1

[drupal-devel] [task] merging feedback.module into contact.module
by Tobias Maier 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/27633 Post a follow up: http://drupal.org/project/comments/add/27633 Project: Drupal Version: cvs Component: contact.module Category: tasks Priority: normal Assigned to: Anonymous Reported by: Tobias Maier Updated by: Tobias Maier Status: patch Attachment: http://drupal.org/files/issues/database.pgsql_5.patch (634 bytes) "If there is only one category, we probably don't need a hidden category either? " if I don't send it hidden I have to count the number of available categories at the field validation. I think this is the best way, because I don't have so much sql queries. "Please drop the filter stuff for now. " why? if it has security reasons than it would be a solution only to allow the dafault filter. here is the update - removed filter - changed the words to lowercase - update for updates.inc - update for database.pgsql I was not able to test the pqsql things... Tobias Maier Previous comments: ------------------------------------------------------------------------ Wed, 27 Jul 2005 23:00:09 +0000 : Tobias Maier The contact.module of the Drupal HEAD does now nearly the same as the feedback.module. kbahey [1] and I talked about to bring them together. To have just one module. a) Here comes a list of features which you can find in feedback.module and which are currently missing in contacts.module * add the following fields to contacts.module: * Postal Address * Phone Number * A real "Message Subject" (You say "What?? we have one!" - this one is used in the false way. Be patient i'll tell you later what i mean) * make it configurable if these fields are shown on the /Sites Contact-Page/ and/or on the /Users Contact-Page/ * Make it configurable which field is required and which one not * The Subject field is currently used to select on which team/department the message belongs to. this field should be renamed to /topic/category/department/ (just one of them / maybe let the user decide) and a Subject field with the default behavour should be introduced. * let the "Additional information:"-field be formatted. So add form_format() * Feedback has a feature "Log all feedback attempts to watchdog" * it also allows you to add an special "Subject Prefix:" to the e-mail which will be sent. * and to customize the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure") (personally i think this is not really needed) * it also allows you to define a "Navigation link text" and a "Feedback Page Header" - but the most users (including me) were a little bit confused about what that means (personally i think this is not really needed) b) here comes my list what i want to see beside the things mentioned above in contact.module: * why does contact have two places to configure it (/admin/contact/ and /admin/settings/contact/) i think they should be merged into one. So that it is easier for the User to get into this. * Help texts, everywhere :D * a new permission:"Let me use all Users Contact page" - allow specific Roles to contact the User through the Contact-Page, also if he deactivated it Please tell me what you think about it and if you have other ideas. I want to start to merge the feedback module into the contact module soon Yours sincerely Tobias Maier [1] http://drupal.org/user/4063 ------------------------------------------------------------------------ Thu, 28 Jul 2005 08:40:21 +0000 : Tobias Maier i forgot to mention that it also sends the referrer in the E-Mail what I also want to include ------------------------------------------------------------------------ Thu, 28 Jul 2005 10:30:36 +0000 : lennart Hi Tobias, I am currently using both feedback.module and contact.module, so for me a merging would generally make sense. I agree with most of your ideas /except/; I do not think " the Message which will be shown after the user pressed submit. ("Result Message - Success". "Result Message - Failure") " is not needed. I think this should stay. It gives comfort and certainty to the user to know that the mail has been sent succesfully Regards Lennart ------------------------------------------------------------------------ Thu, 28 Jul 2005 10:48:13 +0000 : Tobias Maier i think also that this messages should stay there, but I think they don't have to be customizable, like in Feedback. ------------------------------------------------------------------------ Thu, 28 Jul 2005 13:03:54 +0000 : kbahey Tobias, Thanks for the comparison. As the author of Feedback, I see a lot of overlap between contact and feedback. I would like to see them merged, and become part of core. contact is a good base to build on, and has some extra features (most importantly the ability to contact a specific user, as well as list different topic/category and route the message accordingly (think of sales, support, marketing, ..etc or complaint, comment, request, ...etc.) Add to all that one feature present to neither: a checkbox to send a copy of the email to the originator for filing. If both merge and add the above feature, I will be very happy, and feedback can then rest in peace starting from 4.7. ------------------------------------------------------------------------ Sat, 30 Jul 2005 02:32:58 +0000 : Tobias Maier here are the first patches regarding this: * [bugfix] if contact.module is unconfigured the form gets shown [2] * [bugfix/new feature] hide subject if there is just one [3] * [new feature] input format for contact.module [4] * [bugfix] Side-wide contact form: doesn't save entered text on input error reload [5] please test them all and integrate them all as fast as possible, because i want to develop the next steps on top of them Thanks [2] http://drupal.org/node/27757 [3] http://drupal.org/node/27822 [4] http://drupal.org/node/27824 [5] http://drupal.org/node/27139 ------------------------------------------------------------------------ Sat, 30 Jul 2005 13:30:40 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact.module_1.patch (10.38 KB) and here comes the first all-in-one patch: please try it, and tell me if it works for you: This is just the first step to solve the list above so there come much more enhancements later... Changelog: * Includes bugfix: if contact.module is unconfigured the form gets shown [6] * includes bugfix: if contact.module is unconfigured the form gets shown [7] * includes bugfix: Side-wide contact form: doesn't save entered text on input error reload [8] * renamed subject to category * added a real Subject-field * includes input format for contact.module [9] * includes hide subject if there is just one [10] * changes in contact-table (just MYSQL) * subject renamed to category * category is now PRIMARY KEY [6] http://drupal.org/node/27757 [7] http://drupal.org/node/27757 [8] http://drupal.org/node/27139 [9] http://drupal.org/node/27824 [10] http://drupal.org/node/27822 ------------------------------------------------------------------------ Sat, 30 Jul 2005 13:31:33 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/database.mysql_5.patch (720 bytes) the patch for the mysql-table ------------------------------------------------------------------------ Sat, 30 Jul 2005 14:26:00 +0000 : Tobias Maier Attachment: http://drupal.org/files/issues/contact.module_2.patch (11.02 KB) contact.module updated again -->now it runs :D ------------------------------------------------------------------------ Sat, 30 Jul 2005 15:16:38 +0000 : Dries - You need to provide an update for updates.inc too. - You need to provide an update for database.pgsql. - Please drop the filter stuff for now. - Please don't capitalize the words category and subject in + form_set_error('subject', t('You must enter a Subject.')); and + form_set_error('category', t('You must select a valid Category.'));. - If there is only one category, we probably don't need a hidden category either?

1 0

[drupal-devel] [bug] Some URLs get ?PHPSESSID added to them
by ufku 30 Jul '05

30 Jul '05

Issue status update for http://drupal.org/node/4109 Post a follow up: http://drupal.org/project/comments/add/4109 Project: Drupal Version: cvs Component: base system Category: bug reports Priority: normal Assigned to: Eric Scouten Reported by: Eric Scouten Updated by: ufku Status: patch in my case (shared hosting, ini_set() disabled) a php.ini file with only this line in it solved the problem. url_rewriter.tags = '' you should place the php.ini in your site's base directory ufku Previous comments: ------------------------------------------------------------------------ Thu, 13 Nov 2003 00:22:39 +0000 : Eric Scouten Some URLs get ?PHPSESSID=(whatever) added to them. I find this distracting and unnecessary for anonymous users. Submitting patch #147 for consideration to remove this issue. ------------------------------------------------------------------------ Fri, 05 Dec 2003 14:39:25 +0000 : Kjartan This is a local PHP configuration issue. Don't see it as something Drupal should mess with, the less PHP settings Drupal messes with the better. ------------------------------------------------------------------------ Fri, 05 Dec 2003 15:11:33 +0000 : killes(a)www.drop.org Could you elaborate which config setting one has to tweak? ------------------------------------------------------------------------ Fri, 05 Dec 2003 15:18:11 +0000 : Anonymous php_flag session.use_trans_sid off php_flag session.use_only_cookies on The first will disable the automatic addition of the session ID to internal URLs, the second will remove support for passing session IDs in URLs. See http://php.net/session [1] for more info. BTW the above settings are for Apache, in PHP.ini you should not add the php_flag part, and you should use = inbetween the name and value... [1] http://php.net/session ------------------------------------------------------------------------ Mon, 07 Jun 2004 22:42:06 +0000 : shane It seems that Drupal (via the .htaccess file) already "messes with" a bunch of PHP settings. For example, my Drupal install "came with" these messed with settings: php_value register_globals 0 php_value track_vars 1 php_value short_open_tag 1 php_value magic_quotes_gpc 0 php_value magic_quotes_runtime 0 php_value magic_quotes_sybase 0 php_value arg_separator.output "&" php_value session.cache_expire 200000 php_value session.gc_maxlifetime 200000 php_value session.cookie_lifetime 2000000 php_value session.auto_start 0 php_value session.save_handler user php_value session.cache_limiter none php_value allow_call_time_pass_reference On I'm not sure that adding two more "php_value" flags to the stock .htaccess file is going to arguably mess with more than already is. Personally I find it extremely un-professional and very un-clean to have funky PHPSESSID url strings tacked onto a majority of my URLs. I've worked extremely hard to implement clean URLs (above and beyond the already great "clean url" feature of Drupal - I don't like them being turned into muck. I'd vote that these two flags be added to the .htaccess file that is distributed with Drupal. However, I'm uncertain of the overall true impact of making these changes, so barring an technical reason - I would absolutely request this as a feature. I've implemented these in many of my production sites already (just today) - we'll see what impact they have. ------------------------------------------------------------------------ Tue, 08 Jun 2004 02:56:00 +0000 : marky It's a performance thing. You need to remember that while not everyone has edit access to php.ini, those of us that do control our own servers see no need for .htaccess directives that set php options. >From the Apache docs [2]: "Apache will look in every directory for .htaccess files. Thus, permitting .htaccess files causes a performance hit, whether or not you actually even use them! Also, the .htaccess file is loaded every time a document is requested." Ok, I'm lucky in that I control my own server, so I can effectively remove the .htaccess file and move its config options to php.ini and the vhost section of httpd.conf, thus speeding up the responsiveness of my server. But if you don't have that option there's nothing wrong with adding those directives to your directory .htaccess file. That's what it's for - it allows directory specific config options for those that don't have access to their server config. As Kjartan said, "the less PHP settings Drupal messes with the better". I've got to agree - as far as I'm concerned it's already big enough. The "php_value short_open_tag 1", "php_value session.auto_start 0" and "php_value session.cache_limiter none" for example serve little purpose, as they mirror the installation default settings (apart from the last, where the available options are: nocache, private or public). If you don't have the choice, use .htaccess, and add whatever directives you see fit. But please remember that not everyone uses it. Anyway, just my 2 beads. [2] http://httpd.apache.org/docs-2.0/howto/htaccess.html#when ------------------------------------------------------------------------ Tue, 08 Jun 2004 04:38:32 +0000 : cel4145 Why not add them, but commented out with an explanation? When I encountered this problem, I had to spend a little time on drupal.org finding the solution. However, I am familiar with the .htaccess file from doing installs. If it had been included there commented out, I would have probably remembered it. After all, this is much the same way that httpd.conf functions with it's many, optional, commented out configuration options. Just makes it easier when a non-standard configuration option has to be used. Besides, I've also seen many Drupal sites with this problem. I suspect that some of those sites would have implemented these flags if they had been an option in the .htaccess file. And it looks bad. People that visit the sites that don't know any better will assume it's Drupal, not the lack of proper PHP settings. ------------------------------------------------------------------------ Tue, 08 Jun 2004 10:39:27 +0000 : killes(a)www.drop.org It wouldn't hurt if Drupal had a better documented and possibly extended .htaccess file. Those who whish not to use it should really not care... session.save_handler = user should probably included as well. ------------------------------------------------------------------------ Tue, 08 Jun 2004 12:17:06 +0000 : robertDouglass If you use these settings: php_flag session.use_trans_sid off php_flag session.use_only_cookies on won't it make it so that people with cookies disabled cannot have session state? And if the PHPSESSID is in the URL, isn't that an indication that the browser being used refused to take a cookie? I'd really like clarification on this, if anyone knows the answers. ------------------------------------------------------------------------ Tue, 27 Jul 2004 13:25:46 +0000 : JonBob The original issue is definitely by design, as these URLs need the session ID to preserve the session when running under the given PHP settings. A better-documented .htaccess is a different issue entirely. ------------------------------------------------------------------------ Thu, 19 Aug 2004 18:04:13 +0000 : gtoddv It hasn't been mentioned in this thread or anywhere else that I can find, but this session ID issue breaks validation. I don't know is this will cause accessibility issues too. I have tried the .htaccess fix and that doesn't change anything. ------------------------------------------------------------------------ Sat, 06 Nov 2004 07:17:21 +0000 : wazdog The non-validating problem is another problem with your server setup. PHP can be setup to used encoded &'s or not. Your server isn't if the url isn't validating. You'd have to talk to your server admin to fix that. ------------------------------------------------------------------------ Thu, 30 Dec 2004 20:32:35 +0000 : m_freeman2004 This is what you have to include in the .htaccess file: # Fix for ?PHPSESSID in clean URLs php_value session.use_trans_sid 0 php_value session.use_only_cookies 1 # End of fix ------------------------------------------------------------------------ Wed, 01 Jun 2005 19:07:53 +0000 : dr05 The code in .htaccess file: # Fix for ?PHPSESSID in clean URLs php_value session.use_trans_sid 0 php_value session.use_only_cookies 1 # End of fix don't work! Error: "Internal Server Error!" ------------------------------------------------------------------------ Thu, 14 Jul 2005 15:25:22 +0000 : jasonwhat Anyone else looking into this? Can one get rid of the id added onto the url but still keep the sessions going? ------------------------------------------------------------------------ Mon, 25 Jul 2005 06:16:22 +0000 : Eric Scouten dr05, what version of Apache and what OS are you using? I've been using this same patch with no problems on Mac OS X, Linux, and FreeBSD-based servers using both Apache 1.3.x and 2.0.x. Attached patch will apply these changes to .htaccess. (IMHO, this is useful for the majority of users; those who are smart enough to understand the performance issues can comment out these lines.) ------------------------------------------------------------------------ Mon, 25 Jul 2005 06:57:18 +0000 : clydefrog You forgot the patch, Eric. ------------------------------------------------------------------------ Mon, 25 Jul 2005 08:02:26 +0000 : Eric Scouten Attachment: http://drupal.org/files/issues/htaccess-no-session-ids.patch (383 bytes) D'oh! ------------------------------------------------------------------------ Mon, 25 Jul 2005 08:45:48 +0000 : kbahey There are cases where no parameter will fix this issue. On shared hosting systems where you do not have access to php.ini, and the hosting company has setup things in a way that they cannot be overriden. I found this out the hard way, after lobbying for the settings to be included in the init_set() statements in the settings.php prior to 4.6 being released. They are simply ignored on some hosts. On other hosts, you need to have a php.ini of your own, if suphp or SuExec is being used. In some cases, the only way to make things work is to compile your own PHP as a CGI (detailed writeup) [3]. This can have disadvantages too, such some performance impact, as well as excessive CPU utilization (hosting company may not like it). [3] http://baheyeldin.com/drupal/how-to-get-rid-of-phpsessid-in-drupal-and-othe… ------------------------------------------------------------------------ Mon, 25 Jul 2005 08:49:31 +0000 : kbahey Here is some references: issue 21170 [4], and a forum discussion [5]. [4] http://drupal.org/node/21170 [5] http://drupal.org/node/17947

1 0