August 2005 - Development - lists.drupal.org

[drupal-devel] [feature] create system option to prevent users from changing the theme
by killes 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/26302 Post a follow up: http://drupal.org/project/comments/add/26302 Project: Drupal -Version: 4.6.0 +Version: cvs Component: system.module Category: feature requests Priority: normal Assigned to: Torenware Reported by: Torenware Updated by: killes(a)www.drop.org Status: patch (code needs work) Moving to cvs. I am delighted about this change. This "feature" annoyed me right from when I started to use Drupal... killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Mon, 04 Jul 2005 01:50:45 +0000 : Torenware Attachment: http://drupal.org/files/issues/add-user-themable-option.diff (1.86 KB) >From the forum thread How To Prevent Users From Changing The Theme. I asked: " I'm working on a module that uses organic groups. I want to allow different groups to choose different themes, but I don't want individual users to have that capability. I'm assuming that this is easy to do, but I can't find a setting. Can anybody point me in the right direction? Thanks, Rob " At sepeck's suggestion, I'm submitting a patch to do this. It's against 4.6.0, and modifies theme.inc and system.module. It creates a variable 'configurable_user_themes' which defaults to "enabled" (4.6.0's current behavior), and if activated, makes system.module remove the UI for selected a theme, and also causes theme.inc to ignore any setting for $user->theme if it exists. ------------------------------------------------------------------------ Mon, 04 Jul 2005 01:54:40 +0000 : Torenware Attachment: http://drupal.org/files/issues/add-user-themable-option_0.diff (1.86 KB) Didn't set this to "patch" initially, so I'm including the patch again. Not sure what the procedure is just yet. ------------------------------------------------------------------------ Mon, 04 Jul 2005 05:07:44 +0000 : TDobes -1 -- sorry, but I feel that we should use a different method for this sort of thing. Any theme that is checked in the admin-> themes screen should be selectable by users. Modules should get their list of available themes from list_themes(), which provides a list of all available themes, not just those that are selected for use by users. ------------------------------------------------------------------------ Mon, 04 Jul 2005 09:21:57 +0000 : Bèr Kessels I think we should simply rename the "enabled" into "selecatble". Or any better term. For the only thing tha checkbox does is enable it for users to select. It does not enable or disable the theme at all. ------------------------------------------------------------------------ Mon, 04 Jul 2005 18:56:53 +0000 : Torenware A couple of comments: To TDobbs: for most applications, you're right. But for some applications where it's important to the site that user experience is well tested, letting individual users set the theme is something of a nightmare; a problem with the theme is perceived as a problem with the site. So for /those/ sites (such as the one I'm currently working on), letting the user set the theme was APITA. Still, for a community site, I agree that the current behavior is fine. So I made the current behavior the default. To Bèr Kessels: Let me see if I understand what you mean. Currently, I've coded the UI to say in its English default: User theme settings Configurable Themes: * Disabled * Enabled Enable or disable user-configurable themes. When enabled, users can set their own theme to override the site's default theme. Would you prefer: User theme settings Selectable Themes: * Disabled * Enabled Enable or disable user-selectable themes. When enabled, users can select their own theme to override the site's default theme. I don't really want to lose the "Disable"/"Enable" part, because if you look at the current UI in 4.6, all similar settings are done that way. So using a checkbox would be inconsistent with the rest of the page. How's that? Rob ------------------------------------------------------------------------ Mon, 04 Jul 2005 21:31:14 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/theme.png (17.19 KB) you indeed misunderstood me. We have a "enable theme" checkbox in the theme overview. That checkbos *does not enable anything* it only gives users the opportunity to select that theme. Please se the screeny (sorry, Dutch locale enabled) for what I mean. Th e second comumn. That chackbox. Just investigte its use. You will its complete and utter cruft, that checkbox. Ber ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:20:55 +0000 : Torenware Ber, I have a site that may well use themes set at the group level, so unactivating the theme via admin/theme is not a great solution for me. The problem with your solution is that if a theme is deactivated, it is not available for anyone. I need multiple themes available, but need to make the rather confusing UI that appears in user/n/edit to go away. Your options will not do that. ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:28:27 +0000 : Torenware Ber, /Please se the screeny (sorry, Dutch locale enabled) for what I mean. Th e second comumn. That chackbox. Just investigte its use. You will its complete and utter cruft, that checkbox./ I'm not following you. Could you please explain a bit more? Thanks, Rob ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:37:13 +0000 : TDobes /I have a site that may well use themes set at the group level, so unactivating the theme via admin/theme is not a great solution for me./ Sure it is! Deactivating themes in admin->theme removes them *ONLY* from the list of themes available for users to select. It should not remove them from the list of available themes for modules to use (via. the $custom_theme variable). If themes are disappearing from the modules' lists, these are bugs in the modules and should be reported elsewhere. I was under the impression that you were writing your own module, which is why I suggested you use the list_themes function. This function returns all available themes, not just those that are selected in admin->themes. Ber has mentioned that the term "enabled" is poorly chosen and should be replaced with something else, such as "user-selectable". I agree with him. /The problem with your solution is that if a theme is deactivated, it is not available for anyone./ This is completely false. It is not available to be chosen in the "my account" screen, but it is still very readily available for use by modules through the $custom_theme variable. /I need multiple themes available, but need to make the rather confusing UI that appears in user/n/edit to go away. Your options will not do that./ Yes they do. How are you determining the list of available themes in your module? If the themes are disappearing when you deselect them from admin->themes, then your module is working improperly. ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:59:25 +0000 : Torenware OK, if I'm understanding you, then indeed the UI in admin/themes is bad done enough to fool a native English speaker. What y'all from Europe make of some of the terms, I can't even guess :-) I'll see if the UI disappears if all of the items are "deactivated" makes the UI go away (and doesn't break Organic Groups...). But it sounds like the real "bug" is in the documentation. This string: / Select which themes are available to your users and specify the default theme. To configure site-wide display settings, click the "configure" task above. Alternately, to override these settings in a specific theme, click the "configure" link for the corresponding theme. / needs changing. Perhaps something like "Choose a default theme for your site, and select which themes your users can choose to override the default." For the record: I do not have a clue what "Alternately, to override these settings in a specific theme, click the "configure" link for the corresponding theme.". If someone will tell me what that means, maybe some of us can translate it into English :-) Then someone can translate it into whatever else we need to support. ------------------------------------------------------------------------ Sat, 20 Aug 2005 05:22:53 +0000 : TDobes Please see the patch I've attached to this issue [1], which renames "enabled" to "user-selectable"... this should hopefully clear up a lot of confusion. [1] http://drupal.org/node/29002 ------------------------------------------------------------------------ Sat, 20 Aug 2005 07:52:28 +0000 : robertDouglass I'd like to propose a different solution; create a "can select own theme" permission for users. I agree that there are cases where some people should be able to choose their theme and others shouldn't. Personally, I don't make many sites where you get to "skin" the site just for fun. More likely, I use theme selection for development purposes (I develop the next version of a site's theme and can switch back and forth, and so can the developer, but nobody else). If we had a permission that could be given to roles, then og group administrators could be given this permission, if I'm not mistaken. Would this fit the bill, Torenware? ------------------------------------------------------------------------ Sat, 20 Aug 2005 17:30:29 +0000 : Bèr Kessels personally I am all for removing that option alltogether. "for development reasons" is simply not a reason to leave this in. What about getting rid of this "let users select their alternative theme". And focus more on sections/themeswitchers ? ------------------------------------------------------------------------ Sat, 20 Aug 2005 18:52:03 +0000 : robertDouglass I'm not for removing it. There are a lot of efforts going forward to do things like theme an individual's blog differently (blog_theme module, I think), and this is very interesting, especially if combined with some form of theme editor. The best interface we have for choosing themes is part of the user edit page. Let's not get rid of it. What's wrong with an permission to allow users to choose their own theme? ------------------------------------------------------------------------ Sun, 21 Aug 2005 08:56:32 +0000 : Bèr Kessels There is nothnig wrong witha permission. But with the options in your profile. * Does anyone actually allow his users to choose his or her theme in the profile? I have never come across a drupal site that does this. Never! * As you state, there are loads of much better uses of personal themes, like letting a user choose a theme for his blog. Or a print theme, or a theme for better visibility. Or even a theme special for bots. sections, admin themes, etc. None of these cases benefit from the in-profile theme choice. I think this is some odd *nuke ripoff feature, that is only there, because no-one took the time to remove it. Really, have you ever seen this being used on a site? So to conclude: IMO the in-profile theme choice should go. We should focus on writing or improving modules that do advanced themeswitching. ------------------------------------------------------------------------ Sun, 21 Aug 2005 09:07:02 +0000 : robertDouglass Ok, I agree that the in-profile theme changing stuff is cruft. Better would be a module that lets users do this. It could even show up in the same place, but at least it wouldn't be in core. ------------------------------------------------------------------------ Sun, 21 Aug 2005 09:13:59 +0000 : TDobes In response to Bèr: "* Does anyone actually allow his users to choose his or her theme in the profile? I have never come across a drupal site that does this. Never! " Well, I use the feature. In fact, it was the reason I got interested in the Drupal theming system to begin with. I was extremely frustrated by users' inability to switch between chameleon styles and xtemplate templates in Drupal prior the the last major theming patch. However, I tend to agree with you that this feature could be removed from core. This sort of functionality could be added to the user profile page by a contrib module and implemented by using the $custom_theme variable. ------------------------------------------------------------------------ Sun, 21 Aug 2005 21:37:56 +0000 : Dries Agreed. Let's move this to a contributed module and let's tidy up the theme configuration page (unless I'm mistaken, the enabled-checkboxes could probably be removed?).

1 0

[drupal-devel] [feature] create system option to prevent users from changing the theme
by Dries 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/26302 Post a follow up: http://drupal.org/project/comments/add/26302 Project: Drupal Version: 4.6.0 Component: system.module Category: feature requests Priority: normal Assigned to: Torenware Reported by: Torenware Updated by: Dries Status: patch (code needs work) Agreed. Let's move this to a contributed module and let's tidy up the theme configuration page (unless I'm mistaken, the enabled-checkboxes could probably be removed?). Dries Previous comments: ------------------------------------------------------------------------ Mon, 04 Jul 2005 01:50:45 +0000 : Torenware Attachment: http://drupal.org/files/issues/add-user-themable-option.diff (1.86 KB) >From the forum thread How To Prevent Users From Changing The Theme. I asked: " I'm working on a module that uses organic groups. I want to allow different groups to choose different themes, but I don't want individual users to have that capability. I'm assuming that this is easy to do, but I can't find a setting. Can anybody point me in the right direction? Thanks, Rob " At sepeck's suggestion, I'm submitting a patch to do this. It's against 4.6.0, and modifies theme.inc and system.module. It creates a variable 'configurable_user_themes' which defaults to "enabled" (4.6.0's current behavior), and if activated, makes system.module remove the UI for selected a theme, and also causes theme.inc to ignore any setting for $user->theme if it exists. ------------------------------------------------------------------------ Mon, 04 Jul 2005 01:54:40 +0000 : Torenware Attachment: http://drupal.org/files/issues/add-user-themable-option_0.diff (1.86 KB) Didn't set this to "patch" initially, so I'm including the patch again. Not sure what the procedure is just yet. ------------------------------------------------------------------------ Mon, 04 Jul 2005 05:07:44 +0000 : TDobes -1 -- sorry, but I feel that we should use a different method for this sort of thing. Any theme that is checked in the admin-> themes screen should be selectable by users. Modules should get their list of available themes from list_themes(), which provides a list of all available themes, not just those that are selected for use by users. ------------------------------------------------------------------------ Mon, 04 Jul 2005 09:21:57 +0000 : Bèr Kessels I think we should simply rename the "enabled" into "selecatble". Or any better term. For the only thing tha checkbox does is enable it for users to select. It does not enable or disable the theme at all. ------------------------------------------------------------------------ Mon, 04 Jul 2005 18:56:53 +0000 : Torenware A couple of comments: To TDobbs: for most applications, you're right. But for some applications where it's important to the site that user experience is well tested, letting individual users set the theme is something of a nightmare; a problem with the theme is perceived as a problem with the site. So for /those/ sites (such as the one I'm currently working on), letting the user set the theme was APITA. Still, for a community site, I agree that the current behavior is fine. So I made the current behavior the default. To Bèr Kessels: Let me see if I understand what you mean. Currently, I've coded the UI to say in its English default: User theme settings Configurable Themes: * Disabled * Enabled Enable or disable user-configurable themes. When enabled, users can set their own theme to override the site's default theme. Would you prefer: User theme settings Selectable Themes: * Disabled * Enabled Enable or disable user-selectable themes. When enabled, users can select their own theme to override the site's default theme. I don't really want to lose the "Disable"/"Enable" part, because if you look at the current UI in 4.6, all similar settings are done that way. So using a checkbox would be inconsistent with the rest of the page. How's that? Rob ------------------------------------------------------------------------ Mon, 04 Jul 2005 21:31:14 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/theme.png (17.19 KB) you indeed misunderstood me. We have a "enable theme" checkbox in the theme overview. That checkbos *does not enable anything* it only gives users the opportunity to select that theme. Please se the screeny (sorry, Dutch locale enabled) for what I mean. Th e second comumn. That chackbox. Just investigte its use. You will its complete and utter cruft, that checkbox. Ber ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:20:55 +0000 : Torenware Ber, I have a site that may well use themes set at the group level, so unactivating the theme via admin/theme is not a great solution for me. The problem with your solution is that if a theme is deactivated, it is not available for anyone. I need multiple themes available, but need to make the rather confusing UI that appears in user/n/edit to go away. Your options will not do that. ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:28:27 +0000 : Torenware Ber, /Please se the screeny (sorry, Dutch locale enabled) for what I mean. Th e second comumn. That chackbox. Just investigte its use. You will its complete and utter cruft, that checkbox./ I'm not following you. Could you please explain a bit more? Thanks, Rob ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:37:13 +0000 : TDobes /I have a site that may well use themes set at the group level, so unactivating the theme via admin/theme is not a great solution for me./ Sure it is! Deactivating themes in admin->theme removes them *ONLY* from the list of themes available for users to select. It should not remove them from the list of available themes for modules to use (via. the $custom_theme variable). If themes are disappearing from the modules' lists, these are bugs in the modules and should be reported elsewhere. I was under the impression that you were writing your own module, which is why I suggested you use the list_themes function. This function returns all available themes, not just those that are selected in admin->themes. Ber has mentioned that the term "enabled" is poorly chosen and should be replaced with something else, such as "user-selectable". I agree with him. /The problem with your solution is that if a theme is deactivated, it is not available for anyone./ This is completely false. It is not available to be chosen in the "my account" screen, but it is still very readily available for use by modules through the $custom_theme variable. /I need multiple themes available, but need to make the rather confusing UI that appears in user/n/edit to go away. Your options will not do that./ Yes they do. How are you determining the list of available themes in your module? If the themes are disappearing when you deselect them from admin->themes, then your module is working improperly. ------------------------------------------------------------------------ Mon, 04 Jul 2005 23:59:25 +0000 : Torenware OK, if I'm understanding you, then indeed the UI in admin/themes is bad done enough to fool a native English speaker. What y'all from Europe make of some of the terms, I can't even guess :-) I'll see if the UI disappears if all of the items are "deactivated" makes the UI go away (and doesn't break Organic Groups...). But it sounds like the real "bug" is in the documentation. This string: / Select which themes are available to your users and specify the default theme. To configure site-wide display settings, click the "configure" task above. Alternately, to override these settings in a specific theme, click the "configure" link for the corresponding theme. / needs changing. Perhaps something like "Choose a default theme for your site, and select which themes your users can choose to override the default." For the record: I do not have a clue what "Alternately, to override these settings in a specific theme, click the "configure" link for the corresponding theme.". If someone will tell me what that means, maybe some of us can translate it into English :-) Then someone can translate it into whatever else we need to support. ------------------------------------------------------------------------ Sat, 20 Aug 2005 05:22:53 +0000 : TDobes Please see the patch I've attached to this issue [1], which renames "enabled" to "user-selectable"... this should hopefully clear up a lot of confusion. [1] http://drupal.org/node/29002 ------------------------------------------------------------------------ Sat, 20 Aug 2005 07:52:28 +0000 : robertDouglass I'd like to propose a different solution; create a "can select own theme" permission for users. I agree that there are cases where some people should be able to choose their theme and others shouldn't. Personally, I don't make many sites where you get to "skin" the site just for fun. More likely, I use theme selection for development purposes (I develop the next version of a site's theme and can switch back and forth, and so can the developer, but nobody else). If we had a permission that could be given to roles, then og group administrators could be given this permission, if I'm not mistaken. Would this fit the bill, Torenware? ------------------------------------------------------------------------ Sat, 20 Aug 2005 17:30:29 +0000 : Bèr Kessels personally I am all for removing that option alltogether. "for development reasons" is simply not a reason to leave this in. What about getting rid of this "let users select their alternative theme". And focus more on sections/themeswitchers ? ------------------------------------------------------------------------ Sat, 20 Aug 2005 18:52:03 +0000 : robertDouglass I'm not for removing it. There are a lot of efforts going forward to do things like theme an individual's blog differently (blog_theme module, I think), and this is very interesting, especially if combined with some form of theme editor. The best interface we have for choosing themes is part of the user edit page. Let's not get rid of it. What's wrong with an permission to allow users to choose their own theme? ------------------------------------------------------------------------ Sun, 21 Aug 2005 08:56:32 +0000 : Bèr Kessels There is nothnig wrong witha permission. But with the options in your profile. * Does anyone actually allow his users to choose his or her theme in the profile? I have never come across a drupal site that does this. Never! * As you state, there are loads of much better uses of personal themes, like letting a user choose a theme for his blog. Or a print theme, or a theme for better visibility. Or even a theme special for bots. sections, admin themes, etc. None of these cases benefit from the in-profile theme choice. I think this is some odd *nuke ripoff feature, that is only there, because no-one took the time to remove it. Really, have you ever seen this being used on a site? So to conclude: IMO the in-profile theme choice should go. We should focus on writing or improving modules that do advanced themeswitching. ------------------------------------------------------------------------ Sun, 21 Aug 2005 09:07:02 +0000 : robertDouglass Ok, I agree that the in-profile theme changing stuff is cruft. Better would be a module that lets users do this. It could even show up in the same place, but at least it wouldn't be in core. ------------------------------------------------------------------------ Sun, 21 Aug 2005 09:13:59 +0000 : TDobes In response to Bèr: "* Does anyone actually allow his users to choose his or her theme in the profile? I have never come across a drupal site that does this. Never! " Well, I use the feature. In fact, it was the reason I got interested in the Drupal theming system to begin with. I was extremely frustrated by users' inability to switch between chameleon styles and xtemplate templates in Drupal prior the the last major theming patch. However, I tend to agree with you that this feature could be removed from core. This sort of functionality could be added to the user profile page by a contrib module and implemented by using the $custom_theme variable.

1 0

[drupal-devel] [bug] When I delete a user, any forum in which s/he has commented also disappears.
by Uwe Hermann 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/17428 Post a follow up: http://drupal.org/project/comments/add/17428 Project: Drupal Version: 4.5.0 Component: comment.module Category: bug reports Priority: critical Assigned to: Jill6q Reported by: Jill6q Updated by: Uwe Hermann -Status: active +Status: patch (code needs review) Updating status. Uwe Hermann Previous comments: ------------------------------------------------------------------------ Wed, 16 Feb 2005 17:43:53 +0000 : Jill6q Hi, I'm an administrator, and I've discovered that when I delete a user, drupal deletes a) all the forums that the user has created and b) if the user has made any comments in someone else's forum, that forum gets deleted too. i.e. if Dan has commented in the Italian Food forum (the forum was created by admin), and I delete Dan's account, the Italian Food forum disappears entirely from the "Forums" page. Any help for this? Many thanks! (I love drupal) Jill ------------------------------------------------------------------------ Thu, 21 Apr 2005 12:10:33 +0000 : menesis Attachment: http://drupal.org/files/issues/comment_author_delete.patch (996 bytes) I've run into such problem before, with nodes authored by deleted user which dissapear, see http://drupal.org/node/19055 . I've fixed that for myself by resetting node's author to Anonymous, so that the node remains visible. Neither nodes nor comments aren't deleted, they are still there in database, but queries break and nodes or whole forums are not shown. Same fix could be done to comments. Since comments have author's name as well as uid, changing their uid to 0 still leaves the comment with poster's name, so they look the same, and forums or any other nodes the user commented on don't disappear. This fixes a problem with broken forums, but others don't like such approach because if they delete the user, that's because he abused or spammed the site, so they want to delete his/her nodes/comments as well. You could do that same way as in my patches, changing queries from UPDATE to DELETE.

1 0

[drupal-devel] [bug] Menu cache prohibiting access for users
by Uwe Hermann 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/24034 Post a follow up: http://drupal.org/project/comments/add/24034 Project: Drupal Version: cvs Component: menu system Category: bug reports Priority: critical Assigned to: Anonymous Reported by: nysus Updated by: Uwe Hermann Status: patch (code needs work) Attachment: http://drupal.org/files/issues/user.menu.cache_0.patch (1.5 KB) Rerolled patch for HEAD (untested, though). Uwe Hermann Previous comments: ------------------------------------------------------------------------ Wed, 01 Jun 2005 00:05:09 +0000 : nysus See http://drupal.org/node/24019 for description of the problem. ------------------------------------------------------------------------ Wed, 01 Jun 2005 01:04:21 +0000 : Steven Attachment: http://drupal.org/files/issues/user.menu.cache.patch (1.62 KB) Patch attached. ------------------------------------------------------------------------ Mon, 01 Aug 2005 01:32:36 +0000 : killes(a)www.drop.org Does not apply anymore.

1 0

[drupal-devel] [feature] Increase performance of node_page
by jvandyk 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/29335 Post a follow up: http://drupal.org/project/comments/add/29335 Project: Drupal Version: cvs Component: node.module Category: feature requests Priority: normal Assigned to: jvandyk Reported by: jvandyk Updated by: jvandyk Status: patch (ready to be committed) Attachment: http://drupal.org/files/issues/node_speedyview.patch (1.8 KB) The switch statement on $op in node_pager() currently has to go through feed, add, revisions, rollback-revision, delete-revision and edit cases before hitting the most common case, the view operation. This patch simply moves the location of the view operation to second, after feed, as we want view to be as fast as possible. It also removes the blank line before the delete case for consistency. jvandyk

1 1

[drupal-devel] [bug] Bug with error_level in includes/common.inc?
by Uwe Hermann 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/25084 Post a follow up: http://drupal.org/project/comments/add/25084 Project: Drupal -Version: 4.6.1 +Version: cvs Component: base system Category: bug reports Priority: minor Assigned to: Anonymous Reported by: jasonmcmunn Updated by: Uwe Hermann -Status: active +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/common_12.patch (680 bytes) AFAIK it's not the code that is wrong but the docs. Here's a patch. Someone should review this before committing. Uwe Hermann Previous comments: ------------------------------------------------------------------------ Wed, 15 Jun 2005 17:35:45 +0000 : jasonmcmunn In the following code it says that it will log to the database if it is set to 1, and log to the screen if it is set to 2. Well, as it stands, it logs to the screen if it's one and not two. very easy fix, just change the two 1s to 2s. /** * Log errors as defined by administrator * Error levels: * 1 = Log errors to database. * 2 = Log errors to database and to screen. */ function error_handler($errno, $message, $filename, $line) { if ($errno & (E_ALL ^ E_NOTICE)) { $types = array(1 => 'error', 2 => 'warning', 4 => 'parse error', 8 => 'notice', 16 => 'core error', 32 => 'core warning', 64 => 'compile error', 128 => 'compile warning', 256 => 'user error', 512 => 'user warning', 1024 => 'user notice', 2048 => 'strict warning'); $entry = $types[$errno] .': '. $message .' in '. $filename .' on line '. $line .'.'; if (variable_get('error_level', 1) == 1) { print '<pre>'. $entry .'</pre>'; }

1 0

[drupal-devel] [bug] Teaser always truncated at 600 characters
by killes 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/28211 Post a follow up: http://drupal.org/project/comments/add/28211 Project: Drupal -Version: 4.6.2 +Version: cvs Component: node.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: neale Updated by: killes(a)www.drop.org -Status: active +Status: patch (code needs review) changing version and status. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Thu, 04 Aug 2005 19:18:23 +0000 : neale Attachment: http://drupal.org/files/issues/diff_27 (1.16 KB) The truncation code in node_teaser doesn't make any sense to me: <?php foreach ($breakpoints as $point => $charnum) { if ($length = strpos($body, $point, $size)) { return substr($body, 0, $length + $charnum); } } ?> I don't understand: why is the offset given to strpos the maximum teaser size? This would cause teasers to only be nicely split if they are enough longer than the max. teaser size to have one of the special characters. But this guarantees the teaser will either be abruptly truncated, or over the max. teaser size! In fact, this is what I'm seeing on my installation. Attached is a patch that makes it work the way I think it was intended. At least, it makes more sense to me.

1 0

[drupal-devel] [feature] List of bloggers
by Bèr Kessels 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/17030 Post a follow up: http://drupal.org/project/comments/add/17030 Project: Drupal Version: cvs Component: blog.module Category: feature requests Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels -Status: patch (code needs work) +Status: patch (code needs review) Attachment: http://drupal.org/files/issues/blog_bloggers_list_1.patch (1.75 KB) Bingo! My own patch, brought to you by patchbingo! Bèr Kessels Previous comments: ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:27:27 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.patch (1.66 KB) Small patch to show a list of bloggers. We all should know that blog.module is not meant for personal blogging, but that set aside, we do not have a way to show all bloggers, on a site as a list. This patch ads a few lines that will allow you to show that overview of blogging users. It ads a menu item, disabled by default that shows such a list. ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:31:49 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list.png (4.02 KB) Here is a small screeny that shows what this is about. ------------------------------------------------------------------------ Tue, 08 Feb 2005 23:34:15 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/list_bloggers_2.png (2.25 KB) hmm. error in my png file. Here is a correct one. ------------------------------------------------------------------------ Sat, 19 Feb 2005 20:13:20 +0000 : Emiliano Hi Bèr Kessels! Thanks for the patch! It's really useful! :-) I just noticed what I think is a little mistake in this line: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url('blog/'.$row->uid.'/feed'), TRUE); Which I believe should end like: $items[] = l($row->name, 'blog/'.$row->uid)." ".theme('xml_icon', url*('blog/feed/'.$row->uid)*, TRUE); Ah, and BTW, "db_rewrite_sql" didn't work for me... I just cut it off... ;-) Cheers, Emiliano. ------------------------------------------------------------------------ Thu, 17 Mar 2005 22:17:39 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2.patch (1.81 KB) and here is the actual patch. (i think i really need some script that tells me i did not attach a patch ;) ) ------------------------------------------------------------------------ Thu, 17 Mar 2005 22:19:53 +0000 : Bèr Kessels Attachment: http://drupal.org/files/issues/blog_bloggers_list_2_0.patch (1.71 KB) sigh. something tells me i should stop working.... a silly "F" sneaked into the previous patch. ------------------------------------------------------------------------ Thu, 24 Mar 2005 20:25:01 +0000 : Anonymous I applied the patch, reuploaded the blog.module and then deactivated and reactivated it. I cannot see a difference. How do I access the blog users page? Drupal 4.6rc thanks for the help. ------------------------------------------------------------------------ Thu, 24 Mar 2005 20:53:26 +0000 : Bèr Kessels look in the menu admin. ------------------------------------------------------------------------ Wed, 18 May 2005 13:38:39 +0000 : Bèr Kessels Nearly two months since the patch. If there is no need for this I will mark it won't fix. ------------------------------------------------------------------------ Wed, 18 May 2005 13:52:56 +0000 : tostinni I made a custom block for this, but it still need a little improvment (add "read more" for example). So I don't know if it's usefull but if anyone care : <?php $result = db_query("SELECT u.uid, u.name, COUNT(0) AS num FROM {node} n LEFT JOIN {users} u ON u.uid = n.uid WHERE n.type = 'blog' GROUP BY u.uid, u.name ORDER BY u.name ASC"); while ($blog = db_fetch_object($result)) { $output .= '<li />'.l($blog->name. ' ('.$blog->num.')', 'blog/'.$blog->uid); } return '<ul>'.$output.'</ul>'; ?> ------------------------------------------------------------------------ Wed, 18 May 2005 16:06:36 +0000 : Chris Johnson I think this is a useful feature. I've coded custom blocks in the past to provide it on my sites. ------------------------------------------------------------------------ Sat, 21 May 2005 05:23:11 +0000 : Andrzej7 I was a little afraid (poor PHP) to install the patch (March...), but I have made a block. And it's very nice. One question only. All the bloggers are shown, but the Admin (user No 1) is on the list and he has no blogs. What's that? ------------------------------------------------------------------------ Sun, 22 May 2005 16:24:08 +0000 : Bèr Kessels To avoid confusion: this patch ads no blocks, but shows the list inline: as content! ------------------------------------------------------------------------ Sat, 18 Jun 2005 22:07:42 +0000 : igrcic aaargh.....there is a problem when using PostgreSQL db. After I successfully patch blog.module and enable it in menu, click on it and following sql errors pop up: warning: pg_query(): Query failed: ERROR: function count(integer, character varying) does not exist HINT: No function matches the given name and argument types. You may need to add explicit type casts. in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 45. user error: query: SELECT COUNT(DISTINCT u.uid, u.name) FROM users u LEFT JOIN node n ON n.uid = u.uid WHERE n.type = 'blog' AND n.status =1 ORDER BY n.created DESC in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 62. warning: pg_query(): Query failed: ERROR: for SELECT DISTINCT, ORDER BY expressions must appear in select list in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 45. user error: query: SELECT DISTINCT u.uid, u.name FROM users u LEFT JOIN node n ON n.uid = u.uid WHERE n.type = 'blog' AND n.status = 1 ORDER BY n.created DESC LIMIT 10 OFFSET 0 in /web/www/htdocs/iaeste3/includes/database.pgsql.inc on line 62 For first one its clear, there is no such fucntion in Postgresql, and second one is typical Postgresql/Mysql error, n.created isn't in select syntax. But if we put it in a select distinct syntax , it isn't DISTINCT anymore, so I get lots of lines with user and all of his blogs, with different time of course. So we must modify query a bit: SELECT DISTINCT u.name, u.uid, MAX(n.created) as time FROM users u LEFT JOIN node n ON n.uid = u.uid WHERE n.type = 'blog' AND n.status = 1 GROUP BY u.name,u.uid ORDER BY time DESC It works fine like this :) Didn't look for first one yet... will when I catch some time. Cheers! ------------------------------------------------------------------------ Sat, 18 Jun 2005 22:15:29 +0000 : igrcic Attachment: http://drupal.org/files/issues/blog_bloggers_list_0.patch (1.75 KB) Sorry, here is a patch for a blog_bloggers_list_2_0.patch :) ------------------------------------------------------------------------ Tue, 05 Jul 2005 09:08:19 +0000 : Bèr Kessels That doesz not seem a patch of a patch, but a regular patch. Igrirc, please note that the SQL contains unbracketed tablenames. That is unacceptible. If you don't want to fix it, please report it back here, So I can fix it otherwise :)

1 0

[drupal-devel] [bug] collapsible fieldset icon and ie 5.0
by fago 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/29075 Post a follow up: http://drupal.org/project/comments/add/29075 Project: Drupal Version: 4.6.0 Component: other Category: bug reports Priority: minor Assigned to: fago Reported by: fago Updated by: fago Status: patch (code needs review) Attachment: http://drupal.org/files/issues/arrow-ie5.patch (361 bytes) ie 5.0 displays the menu-collapsed/expanded.png images behind the legend link text. fix attached fago

5 6

[drupal-devel] [bug] Time zone improperly handled in archive.module
by killes 21 Aug '05

21 Aug '05

Issue status update for http://drupal.org/node/8287 Post a follow up: http://drupal.org/project/comments/add/8287 Project: Drupal Version: cvs Component: archive.module Category: bug reports Priority: normal Assigned to: Goba Reported by: Goba Updated by: killes(a)www.drop.org -Status: active +Status: patch (code needs work) Changing status. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ Fri, 04 Jun 2004 11:00:12 +0000 : Goba Attachment: http://drupal.org/files/issues/Drupal-archive-time.patch (706 bytes) The user time zone values are added and substracted from local time values (mktime() and friends), and therefore the resulting datetime values are not right. gmmktime() should be used instead of mktime(), since GMT is what the timezone setting is supposed to be relative to. Here is a patch which fixes part of the problem. It would be nice if someone with understanding of the calendar printout code (or enough time to find out how does it work) would submit a patch against the mktime() issues there. This patch fixes the archive_page time issue. Probably also relevant for HEAD (patch against 4.4.x CVS) ------------------------------------------------------------------------ Fri, 04 Jun 2004 18:08:17 +0000 : Kjartan I would like to see a complete patch that handles everything. For that matter I would love to have the archive module improved in general. ------------------------------------------------------------------------ Tue, 01 Mar 2005 09:29:45 +0000 : Bèr Kessels Setting this to CVS. We discussed removing this module on the Drupal Sprint. Whenever that happens, we can close this. ------------------------------------------------------------------------ Sat, 05 Mar 2005 01:56:55 +0000 : paul(a)murphymaphia.com So the solution to the problem is to just scrap the module? This patch doesn't seem to fix the problem in my case. Is there a newer patch?

1 0