March 2006 - Development - lists.drupal.org

Giving credit for committed patches
by Steve Dondley 03 Mar '06

03 Mar '06

I'm about to talk about a potentially sensitive subject. I will try to approach this delicately by first saying this is not an attach or criticism, just a suggestion for improvement. It is not my intention to start a flame war as has been suggested. So with that out tof the way, I was noticing the other day that Dries gives credit to patch contributors in the cvs log message. I think this is smart. And I think an attempt should be made, where practical, to do it for all patches. First, it helps build the reputation of those who contribute, garnering them the good will of the community, second it strokes their ego. As far as building the reputation of contributors, I think we all recognize that this is an extremely important facet of open source development. For most of us, our reputation within the Drupal community is dependent upon the letters in our respective handles. When I see the letters m-e-r-l-i-n-o-f-c-h-a-o-s I think happy thoughts. He's helped me tremendously and I can him credit because the things he has done for me have come from those mysterious arrangement of letters. And I have done what I can to reward him for his efforts. So I think when we give credit to contributors and build their reputation, it spreads good will. And it puts a human face to the code many labor so hard on. Second, let's just all admit right now we have egos. I'll be the first to say that, yup, I have one. No, I don't work soley for recognition and praise from others. Just the challenge of programming and and building web sites for worthwhile cause provides enough self-fulfillment to sustain me. That said, it sure does feel good when I get some recognition. When my first bug fix patch hit the Drupal core, I feld some accomplishment. And when I saw my name associated with that patch, I was quite proud and got a little high from it. It was the first open source project I was able to contribute to. On the other hand, I also feel a bit sleighted when I contriubute some time or talent to a project (on any endeavor, not just Drupal), and no one takes the the time to say "thanks". That doesn't mean I stop doing the work, but it does mean that I'm less motivated to do something next time. Maybe I'm an anomaly and I'm just a big egotistical asshole. But I suspect I'm just like any other person and simply like getting recognition, no matter how small. So, my suggestion is to simply make more of attempt to give credit to those who contributed their time and talent in the cvs log messages. I think the effort expended to do that is minimal (maybe Dries can better respond to this point) and well worth the effort by fostering more good will and good vibes in the development community.

1 0

critical project module issues: duplicate calls to menu items, and $_POST variables unset
by Nedjo Rogers 03 Mar '06

03 Mar '06

Updating drupal.org to CVS HEAD is being held up in part by two critical bugs in the project module: http://drupal.org/node/50337 version select broken when browsing projects http://drupal.org/node/50786 comment issues broken Both of these bugs cropped up recently after things were working fine, and they seem to reflect the same underlying problem. The menu item functions implementing these functionalities (project_page_overview() and project_comment_page(), respectively) are called twice in the course of the page handling, when presumably they should be called only once. The first time they're called they have access to $_POST variables, but the second time they don't, and so, seemingly, fail for lack of data. Is anyone aware of a recent change to core that might be producing these double calls? Or changes in the handling of $_POST variables so that they are unset? Any ideas would be very welcome!

3 2

beta 5
by Gerhard Killesreiter 03 Mar '06

03 Mar '06

Hi there, I had intended to release a beta 5 this night, but I am simply too exhausted to do so in good conscience (if you think I have one). Therefor all the readers of this list have about 8 hours left to create, review, and test(!) many, many bug-resolving patches which I will then look at before rolling the tarball and I might even apply them! This is the page I will look at: http://drupal.org/project/issues?projects=3060&states=14&categories=bug Cheers, Gerhard

2 2

Help Rick Klau fix Feed Burner
by Nathan Digriz 02 Mar '06

02 Mar '06

This was the ending post here http://drupal.org/node/48829 ""OK, this likely means that we're sending a version of the feed that the Drupal aggregator can't parse properly, which is a simple fix on our end. Can someone who's got info on this shoot me an email at rickk(a)feedburner.comand I'll coordinate with our CTO on a deployment fix for our smartfeed service?"" I am only forwarding this so it does not get missed. I have no idea who the right person is. Thanks for listening

2 4

email when admin approves account: can it get into 4.7?
by Derek Wright 02 Mar '06

02 Mar '06

1 sentance summary: when drupal is configured to require admin approval for user, it should only email the temporary password once the admin has moved the account from blocked to active. http://drupal.org/node/5689 (you can tell from the node id this issue has been around a long time) ;) this is a *major* usability feature for site admins... i'd consider it a "critical" issue, but i don't know if anyone else feels that way. i've got a patch working for this in 4.6 (which is obviously frozen), since that's what i'm using and many other folks want it. if i made time to update the patch to work in 4.7 is there any chance that would make it into 4.7 before the freeze (it's in core -- user.module)? if so, i'll bump this to the top of my drupal-hackery list and get it done ASAP. if it's not going to get into 4.7 no matter how fast i do it, i'll work on fixing it in 4.8... thanks, -derek

7 11

Re: development Digest, Vol 39, Issue 5
by David K Norman 02 Mar '06

02 Mar '06

For admin approving account: http://drupal.org/node/37353#comment-56461 I'm modifying and testing the attachment and I'll commit it to CVS today as contrib module user_status for 4.6. I won't have time to roll it for 4.7, but there sure seems to be enough interest for someone to pick up that FAPI conversion. development-request(a)drupal.org wrote: > Date: Thu, 02 Mar 2006 07:10:49 -0500 > Subject: Re: [development] email when admin approves account: can it > get into 4.7? > > I suspect that it won't - we're working on critical bugfixes > ONLY at the moment, and this is neither a bugfix, nor critical. >

1 0

Which modules should be categorized as developer?
by Kieran Lal 02 Mar '06

02 Mar '06

http://drupal.org/node/50091 Neil Drumm requested that developer be a specific category for modules. If there are some modules that you believe should be tagged developer please respond on the issue and I'll update the spreadsheet. Dries can update http://scratch.drupal.org/project/modules from the spreadsheet. Cheers, Kieran

6 7

javascript in 10 minutes
by Adrian Rossouw 02 Mar '06

02 Mar '06

This helped jog my memory of the little javascript I did several years ago, perhaps it will be of some use to other people who are currently rusty =) http://javascript.infogami.com/Javascript_in_Ten_Minutes -- Adrian Rossouw Drupal developer and Bryght Guy http://drupal.org | http://bryght.com

1 0

Out of Office AutoReply: [feature] Event should use node teaser on calendar view (e.g. event/2006/03/02/week/all/all)
by Steve Parks 02 Mar '06

02 Mar '06

I'm out of the office until Tuesday 7th March, and will have very limited access to emails. I'll get back to you as soon as I can. Thanks Steve

1 0

Out of Office AutoReply: [bug] Reply to non existent comments
by Steve Parks 02 Mar '06

02 Mar '06

I'm out of the office until Tuesday 7th March, and will have very limited access to emails. I'll get back to you as soon as I can. Thanks Steve

1 0