August 2006 - Development - lists.drupal.org

Install profiles should be in their own directories
by Adrian Rossouw 08 Aug '06

08 Aug '06

http://drupal.org/node/77549 I am not going to re-hash everything I said there, but I need to say that install profiles as they are now are not really adequate for many of the things we hope to accomplish with them. I have been building install profiles in one manner of another for 2 years now, and that patch is part of what I found were the base requirements of making install profiles work.

1 0

Strip out theme functions into a .theme file
by Frando (Franz Heinzmann) 07 Aug '06

07 Aug '06

Now that we have modules in their own directories, I think we could move forward to ease pain for designers by stripping out theme functions out of the .module file into a .theme file. We already did the same for installation, and there's currently a patch in the queue to do the same for help files. Why we should move theme_* functions into a <modulename>.theme file: * ease pain for designers. Currently, they have to look through all the module code, that is not interesting for them at all, to find a theme function they want to overwrite. By having them all together in a <modulename>.theme file, it will save a lot of time and effort for them. And IMO we should take a bit more care of them, especially if it does not hurt at all. * Seperation of code and design has always been a main target. So I think it's only logical to stick to this policy here and move the V part of a module into a different file than the C part (according to the MVC pattern) best regards, Frando

12 23

DrupalCON
by Dries Buytaert 07 Aug '06

07 Aug '06

See http://drupal.org/node/77404. :) -- Dries Buytaert :: http://www.buytaert.net/

1 0

Stupid install system question
by Earl Dunovant 06 Aug '06

06 Aug '06

On a clean install, if SCHEMA == 2 are the updates run or just the hook_install() function?

2 1

Administration page patch committed
by Dries Buytaert 06 Aug '06

06 Aug '06

Hello world, I committed Earl's administration page patch! Details at http:// drupal.org/node/72079. Great job, Earl. This is a big change that requires you to update your modules; you'll have to re-categorize your modules' admin pages. Earl promised to provide some guidelines to help you make the right decisions. Keep an eye on the upgrade instructions in the handbook at drupal.org. Chances are that this breaks a number of patches in the patch queue. Please take the time to re-roll them so we can continue to make progress. It's exactly 1 month to the Drupal 4.8/5.0 code freeze. Note that we're well aware that there is room for improvement so feel free to submit patches that build upon Earl's work. It's not perfect, but it is certainly a big step forward. For example, we could use some help making the administration page a tad sexier. Rock on folks! -- Dries Buytaert :: http://www.buytaert.net/

19 34

Release critical bugs for August 06, 2006
by drupal-devel＠drupal.org 06 Aug '06

06 Aug '06

/ bug reports 4.7 Beta/ CVS Errors assigned: msameer age: 19 weeks 2 days url: http://drupal.org/node/55533 / bug reports Adding user to buddy list does not work age: 1 week 4 days url: http://drupal.org/node/75520 / bug reports Localization problem age: 10 weeks 6 days url: http://drupal.org/node/64847 No check for loading chatbox with other name age: 36 weeks 5 days url: http://drupal.org/node/38397 / bug reports update for deprecated settings hook age: 3 weeks 10 hours url: http://drupal.org/node/73917 / bug reports User warning: unknown column age: 6 weeks 3 days url: http://drupal.org/node/70131 event_start not being set age: 10 weeks 2 days url: http://drupal.org/node/65609 Next link will not show for Junes events age: 12 weeks 7 hours url: http://drupal.org/node/63454 Fatal Error After activating "Browse Scheduled Events" in modules age: 13 weeks 2 days url: http://drupal.org/node/61920 Event module preventing me from uploading age: 15 weeks 1 day url: http://drupal.org/node/59775 INSTALL.txt incorrect age: 15 weeks 6 days url: http://drupal.org/node/59019 event calendars off by day/not respecting timezones - fix? age: 18 weeks 5 days url: http://drupal.org/node/56189 Flexinode generates an error age: 19 weeks 4 days url: http://drupal.org/node/55135 Body text missing age: 20 weeks 2 days url: http://drupal.org/node/54383 Calendar subscribing not working age: 20 weeks 4 days url: http://drupal.org/node/54036 Problem Selecting Event by Type age: 21 weeks 4 days url: http://drupal.org/node/52883 Drupal Event age: 32 weeks 4 days url: http://drupal.org/node/41833 Event start and end times not getting saved in database age: 33 weeks 2 days url: http://drupal.org/node/41300 Issues with list view for events age: 34 weeks 6 days url: http://drupal.org/node/39943 Database error keeps popping up age: 35 weeks 4 days url: http://drupal.org/node/39396 Date problem on calendar, off by a day age: 35 weeks 5 days url: http://drupal.org/node/39193 Events module bugs adding and changeing events age: 36 weeks 2 hours url: http://drupal.org/node/39016 gmdate() warnings on windows install age: 1 year 5 weeks url: http://drupal.org/node/26140 / support requests Blank Page After Submit age: 16 weeks 16 hours url: http://drupal.org/node/58918 Can't Administer Event Module age: 30 weeks 2 days url: http://drupal.org/node/43509 displaying event start info in flexinode tabular view? age: 43 weeks 4 days url: http://drupal.org/node/33019 Event block missing content of many fields age: 46 weeks 2 hours url: http://drupal.org/node/31532 / bug reports ArrayMerge Errors with PHP5 age: 23 weeks 1 day url: http://drupal.org/node/51174 / bug reports Embedded G2: blank pages with Gallery Block enabled age: 12 weeks 1 day url: http://drupal.org/node/63326 errors on cron run and in watchdog age: 12 weeks 6 days url: http://drupal.org/node/62335 IE error using embed not error with none-embed... age: 13 weeks 1 day url: http://drupal.org/node/62119 Gallery module render wrong size with 4.7b5 age: 21 weeks 5 days url: http://drupal.org/node/52706 block manage - Block specific settings can save item selected - with drupal 4.7B4 age: 22 weeks 6 days url: http://drupal.org/node/51436 Gallery Module Settings Fatal Error age: 24 weeks 6 days url: http://drupal.org/node/49046 Latest patch hosed my G2 integration and G2 Standalone age: 35 weeks 5 days url: http://drupal.org/node/39168 problem viewing newly added photos in embedded gallery. age: 36 weeks 6 days url: http://drupal.org/node/38352 problem viewing newly added photos in embedded gallery. assigned: trobison age: 36 weeks 6 days url: http://drupal.org/node/38351 Full screen slideshow in Gallery module is not working (erroring out on the wrong URL) age: 1 year 4 weeks url: http://drupal.org/node/26479 / feature requests Unable to initialize embedded Gallery age: 24 weeks 4 days url: http://drupal.org/node/49417 / support requests Gallery Module stopped working age: 34 weeks 5 days url: http://drupal.org/node/40117 import existing gallery2 user account age: 39 weeks 5 days url: http://drupal.org/node/35920 / feature requests po files and other language support age: 27 weeks 4 days url: http://drupal.org/node/46313 / feature requests Goofy Forum UI age: 44 weeks 5 days url: http://drupal.org/node/32294 / bug reports if Clean URLs is Enabled, upload_image in htmlarea not working age: 2 weeks 5 days url: http://drupal.org/node/74119 htmlArea/xinha firefox freezes (multiple textareas) age: 9 weeks 2 days url: http://drupal.org/node/66746 Layout is quirky age: 21 weeks 5 days url: http://drupal.org/node/52741 view source broken in firefox 1.5 age: 27 weeks 4 days url: http://drupal.org/node/46246 Toolbar won't display correct in IE 6 with Pushbutton Theme age: 47 weeks 2 days url: http://drupal.org/node/30696 / support requests Problem with size of button assigned: khayman age: 14 weeks 5 days url: http://drupal.org/node/60255 / bug reports No thumbnails will show.. age: 2 weeks 2 days url: http://drupal.org/node/74770 Preview and thumbnail creation appears to fail when images are larger than a certain size age: 2 weeks 6 days url: http://drupal.org/node/73986 Localization issue for Premiew and Thumbnail links age: 6 weeks 2 days url: http://drupal.org/node/70396 Category module and image_gallery age: 10 weeks 5 days url: http://drupal.org/node/65066 Problem in Image Gallery display especially in Internet Explorer age: 23 weeks 2 days url: http://drupal.org/node/50943 By CHanging the following the error changes assigned: walkah age: 33 weeks 2 days url: http://drupal.org/node/41353 imagemagick.inc file does not contain the function... age: 38 weeks 15 hours url: http://drupal.org/node/37372 Error when Submitting New Image Node age: 38 weeks 15 hours url: http://drupal.org/node/37366 only variables can be passed by reference on line 713 age: 39 weeks 3 days url: http://drupal.org/node/36092 image.module 4.6.0 strange actions age: 43 weeks 2 days url: http://drupal.org/node/33292 File copy failed: source file does not exist error after running update-image.php age: 45 weeks 4 days url: http://drupal.org/node/31816 Path for image folder not inserted correctly when nodetype = image age: 48 weeks 4 days url: http://drupal.org/node/30031 image module patch & image_import module age: 49 weeks 6 days url: http://drupal.org/node/29377 image module fails on dual site configuration age: 1 year 3 weeks url: http://drupal.org/node/26657 Cannot upload .jpgs age: 1 year 22 weeks url: http://drupal.org/node/18076 / feature requests Copying original age: 39 weeks 2 days url: http://drupal.org/node/36321 / support requests showing the galleries separately age: 6 weeks 1 day url: http://drupal.org/node/70499 upload image wont' display, it show a file not found page age: 18 weeks 3 days url: http://drupal.org/node/56491 I need to change the style of displaying each node. Please help. age: 30 weeks 6 days url: http://drupal.org/node/43017 What does update-image.php do exactly? age: 32 weeks 1 day url: http://drupal.org/node/42222 images not showing2 age: 35 weeks 1 day url: http://drupal.org/node/39773 Image Folder Permissions age: 41 weeks 1 day url: http://drupal.org/node/34839 Image Module Permissions age: 1 year 4 weeks url: http://drupal.org/node/26280 / bug reports user lookup on name only assigned: zeroj age: 18 weeks 4 hours url: http://drupal.org/node/56936 Link to mailhandler does not use l() function age: 29 weeks 1 day url: http://drupal.org/node/44599 Listhandler caused error in "comment.module on line 996" ? age: 39 weeks 2 days url: http://drupal.org/node/36244 Listhandler 4.6.0 fails to send emails at all age: 1 year 2 weeks url: http://drupal.org/node/27095 / tasks Correct/Complete Documentation age: 41 weeks 16 hours url: http://drupal.org/node/34909 / support requests Creating a page using mailhandler age: 7 weeks 4 days url: http://drupal.org/node/68947 Mail Body not downloaded age: 30 weeks 3 days url: http://drupal.org/node/43374 / bug reports Update: beta5 and possible problem with php 4 age: 22 weeks 3 days url: http://drupal.org/node/52004 Patch for member.module to bring it up to 4.7 age: 26 weeks 1 day url: http://drupal.org/node/47829 foreach() assigned: neablo age: 31 weeks 5 days url: http://drupal.org/node/42350 / feature requests Enable nodewords for node type? age: 25 weeks 1 day url: http://drupal.org/node/48869 / bug reports nodes are being created with no body age: 34 weeks 3 days url: http://drupal.org/node/40373 missing promote column assigned: Bèr Kessels age: 36 weeks 1 day url: http://drupal.org/node/38836 Naming issues with files and DB tables age: 41 weeks 6 days url: http://drupal.org/node/34298 RSS "no element found at line 1" age: 1 year 5 weeks url: http://drupal.org/node/26185 Outdated help texts age: 2 years 3 days url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 2 years 9 weeks url: http://drupal.org/node/8128 / tasks move XML-parser into an inclde file. age: 1 year 6 weeks url: http://drupal.org/node/25439 / bug reports Content published by scheduler not mailed out age: 8 weeks 5 days url: http://drupal.org/node/67475 Notify not playing well with Organic Groups age: 33 weeks 5 days url: http://drupal.org/node/40967 / feature requests Setting All Users to be Notified Automatically! assigned: BinGoRabbit age: 1 day 11 hours url: http://drupal.org/node/77158 / bug reports Login as an alias gets cached age: 45 weeks 5 days url: http://drupal.org/node/31699 / bug reports Parse Error, unexpected T_STRING age: 1 day 14 hours url: http://drupal.org/node/77137 Malformed PDFs age: 31 weeks 6 days url: http://drupal.org/node/42312 support dynamic content? age: 37 weeks 1 day url: http://drupal.org/node/38181 please explain html2fpdf age: 37 weeks 4 days url: http://drupal.org/node/37748 Management of french charaters age: 38 weeks 6 days url: http://drupal.org/node/36605 / support requests Problem with PDFView age: 28 weeks 5 days url: http://drupal.org/node/45092 / bug reports Folder field defaulting not handled - get error "Field 'folder' doesn't have a default value query" age: 3 days 18 hours url: http://drupal.org/node/76755 Replying to a message from a person who doesn't accept private messages leads to blank screen age: 18 weeks 5 days url: http://drupal.org/node/56136 privatemsg module: - database error - incompatibility with relationship module age: 25 weeks 1 day url: http://drupal.org/node/48866 Reminder email links don't work age: 1 year 6 weeks url: http://drupal.org/node/25677 / bug reports Tagging of Sub-projects. age: 10 weeks 4 days url: http://drupal.org/node/65110 attachements missing after pressing preview age: 15 weeks 6 days url: http://drupal.org/node/59039 Can't attach patch to initial issue post age: 18 weeks 6 days url: http://drupal.org/node/55984 SQL errors on issues and my projects pages age: 32 weeks 2 days url: http://drupal.org/node/42160 Issues from multiple projects listed on a single issue's page age: 36 weeks 3 days url: http://drupal.org/node/38704 Get disconnected from server on attempting to add an issue age: 39 weeks 3 days url: http://drupal.org/node/36124 issue query table: can't select all projects assigned: dww age: 43 weeks 2 days url: http://drupal.org/node/33262 Projects not listed and page not complete age: 1 year 9 weeks url: http://drupal.org/node/23956 / feature requests Need Documentation age: 34 weeks 2 days url: http://drupal.org/node/40392 Allow subscription to individual project issues age: 41 weeks 4 days url: http://drupal.org/node/34496 / support requests Project is unusable (to me) assigned: dww age: 3 weeks 3 days url: http://drupal.org/node/73460 Fatal error: Only variables can be passed by reference age: 20 weeks 4 days url: http://drupal.org/node/53984 Add the project release manually without the scan feature age: 41 weeks 4 days url: http://drupal.org/node/34500 / tasks New method for contributed project releases and versions assigned: dww age: 16 weeks 6 days url: http://drupal.org/node/58066 / bug reports Error with URL to recipe age: 48 weeks 6 days url: http://drupal.org/node/29885 / bug reports Argument #1 is not an array age: 7 weeks 2 days url: http://drupal.org/node/69286 Cron job creates SQL error age: 9 weeks 5 days url: http://drupal.org/node/66202 / bug reports Enable Subscriptions module -> no comments are shown anymore age: 3 weeks 2 days url: http://drupal.org/node/73666 / bug reports Error on Page with Internet Explorer 6 age: 7 weeks 4 days url: http://drupal.org/node/68906 Taxonomy DHTML's cache ignores user privileges age: 11 weeks 1 day url: http://drupal.org/node/64532 taxonomy_dhtml breaks security? age: 31 weeks 3 days url: http://drupal.org/node/42531 Does not work correctly in Internet Explorer age: 43 weeks 1 day url: http://drupal.org/node/33354 javascrip downloads square.gif for every category age: 1 year 24 weeks url: http://drupal.org/node/17366 / feature requests A unique page for each category group? age: 41 weeks 3 days url: http://drupal.org/node/34610 / bug reports Taxonomy links only work for the first line of links assigned: PierreFWalter age: 23 weeks 1 day url: http://drupal.org/node/51149 / support requests Taxonomy has dissapeared age: 43 weeks 4 days url: http://drupal.org/node/33061 / bug reports Sends trackbacks for unpublished nodes assigned: ankur age: 1 year 27 weeks url: http://drupal.org/node/16239 / bug reports Fatal error for Drupal 4.7.0 installed with Fantastico age: 5 weeks 3 days url: http://drupal.org/node/71407 Sometimes when I open the drupal site in My Local machine I am getting the error. age: 21 weeks 6 days url: http://drupal.org/node/52652 Event start/end date section should *not* show first on Submit event page age: 32 weeks 4 days url: http://drupal.org/node/41869 meet age: 33 weeks 4 days url: http://drupal.org/node/40996 / feature requests A better Drupal.org Index (homepage) interface/layout mockup age: 27 weeks 6 days url: http://drupal.org/node/45967 A small but effective improvement to Improvement of admin/user accessability suggestion age: 42 weeks 1 day url: http://drupal.org/node/34073 / support requests block module / side-content module age: 12 weeks 5 days url: http://drupal.org/node/62506 Acess denied to login Newly installed and upgraded site that I need up and running A.S.A.P assigned: Johnny age: 37 weeks 16 hours url: http://drupal.org/node/38227 / bug reports Logging out error age: 18 weeks 2 days url: http://drupal.org/node/56663 / bug reports the wiki module can't work with HTML age: 26 weeks 5 days url: http://drupal.org/node/47124

1 0

RE: [development] Administration page patch committed
by Steven Peck 05 Aug '06

05 Aug '06

Well, for you perhaps. I never liked it. > -----Original Message----- > From: development-bounces(a)drupal.org > [mailto:development-bounces@drupal.org] On Behalf Of Farsheed > Sent: Friday, August 04, 2006 11:56 AM > To: development(a)drupal.org > Subject: Re: [development] Administration page patch committed > > What about using the old CivicSpace administration > theme as a starting point? It would need to be > cleaned up a bit, but it had minimal headers, few > blocks and Chris had a good admin color schema going. > > Farsheed > > > > > --- Moshe Weitzman <weitzman(a)tejasa.com> wrote: > > > Rowan Kerr wrote: > > > I would say the biggest single improvement for any > > dedicated admin theme is removing all the extraneous > > blocks, navigation, etc from the page and only > > providing the common site header (or a minimal > > version of it with logo and site_name), and the > > admin menu links. > > > > > > -Rowan > > > > i agree. i would actually like for theme('page') to > > be enhanced so that any > > page can declare itself as block free. this would > > override settings in block > > admin. the use case is panels.module - > > http://drupal.org/project/panels ... > > there might be other ways to achieve this too. > > > > > __________________________________________________ > Do You Yahoo!? > Tired of spam? Yahoo! Mail has the best spam protection around > http://mail.yahoo.com > >

1 0

The www-subdomain (WAS: Re: Patching settings.php)
by Frederik 'Freso' S. Olesen 04 Aug '06

04 Aug '06

2006/8/4, Khalid B <kb(a)2bits.com>: >On 8/3/06, Jeff Eaton <jeff(a)viapositiva.net> wrote: <zap> >>I, for one, absolutely despise urls that don't have 'www' at the >>beginning -- the http://example.com style. It jst bugs me. I'd loathe >>having drupal default my sites to that style, but explaining the >>subtleties of how to specify your domain name makes things tricky. > >I feel the opposite. The www prefix is redundant ... >But that is a religious argument ... I'd just like to point towards http://no-www.org/ for argumentation against using the www-subdomain. Do any of you have good links to [a] discussion[s] _for_ using the subdomain? (Apart from aesthetics?) -- Frederik 'Freso' S. Olesen <http://freso.dk/>

7 16

Re: [development] Strip out theme functions into a .theme file
by Adam Cooper 04 Aug '06

04 Aug '06

Dries Wrote: >On 03 Aug 2006, at 20:32, Jakub Suchy wrote: >>> Adrian seems to think it is not a performance issue though. >> >> Imagine you have 15 activated modules. Every module has 2 theme >> functions, which makes it 30 fopen() calls for every page load. >> This IS >> performance issue. > >There is lots of subtle trade-offs involved (eg. less PHP parsing, >smaller memory footprint, but more fopen() calls) and it is hard to >predict how these level out. Let's not make claims and just >benchmark it? Would an opcode cache help to negate the fopen() calls? It may be worth benchmarking to see. Adam ----------------------------------------------------------------- This message may contain confidential or privileged information, and is intended only for the addressee or other persons entitled to access the information. If you are not the intended or authorised recipient of this message please notify the sender by return and then delete it from your mailbox. Any dissemination, distribution, copying or use of this communication without prior permission is prohibited. Internet communications are not secure and may be susceptible to data corruption, interception and unauthorised amendment for which Pall Europe Limited does not accept liability. Whilst we have taken all reasonable precautions to ensure that this e-mail and any attachments have been swept for viruses, Pall Europe Limited does not accept liability for losses sustained as a result of software viruses. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Pall Europe Limited unless otherwise specifically stated. Registered Office and Corporate Headquarters: Pall Europe Limited, Europa House, Havant Street, Portsmouth, PO1 -----------------------------------------------------------------

2 1

Split up the cache table
by Gerhard Killesreiter 04 Aug '06

04 Aug '06

Hi there! In my quest to improve caching for Drupal, I've devised a cache that would let us have more than one cache table. The idea came from the observation that some cached items will quickly be invalidated again (page cache) while others will last a while (menu, filter). This is a problem for the mysql query cache, which will then also be invalidated. Also, operations on smaller tables will be faster. The patch can be found here: http://drupal.org/node/72290 I have now run this patch on drupal.org for several hours and here are some results. First, let us look at the cache hits vs cache call ratio as a percentage of the total tries. In our case that is the number of SELECTs minus the number of UPDATEs devided by the SELECTs on a particular cache table: (# selects - # updates) / # selects Explanation: We run a SELECT in every case to determine if there is a cached item, but only the ones which do not trigger a subsequent cache update were successfull. filter: (242318-21780)/242318 = 91% page: (13315-7285)/13315 = 45% menu: (9989-161)/9989 = 98% the rest: (986-488)/986 = 50% So, we have now proof that our page cache isn't working well for a busy site such as drupal.org, but the filter cache seems to work fine while the menu cache is truly excellent. The "rest" are a few feeble attemps on caching in cvs and project module, which apparently don't work too well either. The high part of cache misses for the page cache is probably in part due to the fact that several crawlers are doing their business on drupal.org at all times. These will generate a cached page, but if the page is in fact very uninteresting to humans then the only likely receiver of a cached page is another crawler. And there aren't that many of them that this would happen. I've suggested to make Drupal less attractive for crawlers here: http://drupal.org/node/65017 If we were successful with this, we'd have less pages generated and thus the percentage of successfull cache hits would increase. I have to note that the filter on drupal.org usually only caches the entries for four hours, not 24 h as a stock drupal. This change was made to keep the number of cached items at bay. I did change this to the full 24 hours. This was not intentional as I can not compare my data with the older data I got in all cases. Number of cached items This numbers obviously fluctuates a lot: filter: 132825 (usually about 7000 for the 4h cache) page: 7345 (a very high value, usually between 1000 and 3000) menu: 1040 rest: 79328 (I had forgotten to remove the previous items from the table, there were only 500 relevant items) Speed The individual cached items differ in number and size. Also does the time these queries take. SELECT INSERT UPDATE DELETE filter: 0.002 0.005 0.002 0.087 page: 0.007 0.009 0.003 0.188 menu: 0.011 0.014 0.016 n/a rest: 0.002 0.007 0.004 n/a The page and menu items are the largest, so no surprise that the time is also longest. The number of entries in the table does not seem to matter that much. Total weighted average: SELECT INSERT Now 0.003 0.007 Test 1 0.010 0.011 Test 2 0.007 0.008 There is a marked improvement here. Splitting up the cache apparently has the benefits I tried to achieve: Reduction of query times by having smaller tables and splitting off less-often-changing data into separate tables to allow the query cache to operate more effectively. Considering that the cache_get query is the query which accumulates more time than any other query on drupal.org, I think that we should strongly consider this patch. Cheers, Gerhard

5 11