August 2006 - Development - lists.drupal.org

Patching settings.php
by Jeremy Epstein 04 Aug '06

04 Aug '06

Hi guys, I've noticed that the past 2 commits to settings.php were both made inadvertently, due to someone including a settings.php $db_url change in their patch by mistake. As you can see, both of these commits had to be reverted: http://drupal.org/cvs?file=/sites/default/settings.php Can I request that all of the patch authors among us (including myself) _please_ check your patch files, and that you ensure that there are no custom settings.php $db_url (or other) changes that have slipped into your patch. I think that the primary responsibility for this should lie with patch authors. However, it would be good if the core committers could be on the lookout for accidental settings.php changes in patches as well. If anyone has any tips for excluding settings.php from a patch, that would be greatly appreciated. Personally, I just run "cvs diff -u > foo.patch" from the root Drupal install dir, and then manually edit the file to remove the settings.php cruft. I'm sure there's a better way to do it. ;-) The biggest problem that I have with accidental settings.php changes, is that running "cvs up -dP" after such a change results in CVS complaining about a conflict/merge in settings.php, even though the change was reverted. So let's try and keep _intentional_ settings.php changes to a minimum (which we seem to be doing quite well at), and keep _accidental_ settings.php changes to zero. Thanks, Jaza.

10 16

Re: [development] Administration page patch committed
by Michelle Cox 03 Aug '06

03 Aug '06

Have you guys had a look at the SandsCSS theme? http://drupal.org/node/57629 I'm no CSS expert, so I don't know if it's all that under the hood, but it does make for a prettier Bluemarine. MichelleC On 8/3/2006 1:50:40 PM, Neil Drumm (drumm(a)delocalizedham.com) wrote: > Bluemarine refresh: > 1. Replace the flat Druplicon default icon with the cell-shaded one. > 2. Throw in a tableless layout. > 3. Saturate the light blue colors a bit. > 4. Add whitespace. > 5. Improve the fonts a bit. > 6. Repeat in 1-2 years or as needed.

3 3

integration with bricolage ?
by Alan Dixon 03 Aug '06

03 Aug '06

i'm looking for some opinions, ideas, feedback... I have a client with a bricolage (perl-based cms that spits out static html files for publishing, popular with newsletter, newspaper sites) site, that wants to offer a user comments feature. There was already an attempted integration with vbulletin that didn't work super well, and they liked the other parts of drupal so I was approached to see what kind of drupal integration might work. That was many months ago - at this point I have a working prototype waiting for the client to decide what to do next. I'll describe here my strategy and am looking for general feedback, criticism, other approaches or refinements. If I was starting from scratch, I might use an approach I've seen or heard about that just pumps the bricolage output into node bodies, but this bricolage install has already got a lot of logic about the navigation/theming in it that I thought would lend itself to a less drupal-centric approach. So (omitting the tedious details): 1. I've laid a drupal install over the existing bricolage site's document root. 2. i've created a 'bricolage' module which defines a 'bricolage_render' callback function for the path 'bricolage'. 3. I've created a custom 404 function in the module called bricolage_not_found to handle page not found replies. 4. I've adapted the .htaccess file to have drupal handle .html files. The html that this bricolage install generates includes some php, which was being used to provide the vbulletin interface and that defines the bricolage publication id, as well as whether the article should allow comments. Here's how my module works now: 1. when a bricolage url gets called for the first time (they're always different from regular drupal paths), the bricolage_not_found function is invoked and reads in the corresponding bricolage .html file and generates a new 'bricolage' type node that has an empty body and some extra fields for the url and the bricolage id, and then it also generates a path alias to convert the bricolage url to the drupal path 'bricolage/<bricolage_id>'. (it figures out the bricolage id by doing a drupal_eval on the bricolage output). Then it does a drupal_goto to reload the same url. 2. the second (and all subsequent invocations) of the bricolage url then trigger the bricolage_render callback function. This function looks up the location of the bricolage-generated content (yes, it could try to just get it from the request_uri, but we don't want to rely on that for a few reasons), and then does a drupal_eval to get the output of the page. Then it can selectively invoke whatever other modules it wants (in my case, the comments module), to generate the dynamic content, and sticks it into the output. In other words - it treats the bricolage html pages as templates that drupal outputs as is with some selective mangling (in my case, just comments, but potentially other bits as well, like blocks). Issues: 1. i've chosen to output the content via a callback instead of as a node because I didn't want the overhead and potential mangling of other nodeapi-type modules. It means that these urls are special and don't behave like the other node content on the site - in particular, the drupal search doesn't work. This could be fixed, but my client doesn't need it (yet anyway, they're using google). I did put in a function so that if the corresponding node gets invoked directly with a node/<nid> url, it'll redirect to the bricolage/<bid> url (or rather, it's path equivalent). 2. it's definitely not plug-and-play (yet?) - in my case I needed also to migrate the existing comments into drupal (i did put that in a separate module), and there's probably other code that would need to be written to make this module useable as is with other bricolage sites. Anyone? -- Alan Dixon, Web Developer http://alan.g.dixon.googlepages.com/

1 0

bad registration code in user.module
by Alan Dixon 03 Aug '06

03 Aug '06

a couple of months ago i posted an issue about some core (user.module) code which didn't get much attention (none), presumably because I gave it low priority. Assuming from recent posts that code quality is of higher priority than I thought, and since Jax just posted a patch for my concern, i invite you all to look at: http://drupal.org/node/66945 -- Alan Dixon, Web Developer http://alan.g.dixon.googlepages.com/

1 0

Re: .htaccess patch for 404 of Non-drupal files
by Ken Rickard 03 Aug '06

03 Aug '06

Kahlid- I wrote that page, so I think the answer is a guarded 'yes.' We did find some odd behavior when we turned the patch on, which is noted in the Handbook page: -- WARNING -- There is a known issue that occurs if you block .png files with this method. It affects the system_test() function in system.module, which relies on a phantom .png call to the directory '/system/test/'. ---- There may be other bugs caused by our original patch, so I think more testing (especially on 4.7, since the patch was put in place for 4.6) is definitely needed. To make debugging easier, I have opened http://drupal.org/node/76928 and attached the .htaccess file that we currently use. I also had to modify function system_view_general() in system.module to hard-code clean url settings, since the .htaccess rules broke Drupal's clean_url checker. - Ken Rickard agentrickard Date: Wed, 2 Aug 2006 23:13:38 -0400 From: "Khalid B" <kb(a)2bits.com> Subject: [development] .htaccess patch for 404 of Non-drupal files To: development(a)drupal.org Message-ID: <4a9fdc630608022013k5b15ae14kdf2fc0195911e510(a)mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed It is worth including the change in this page http://drupal.org/node/56773 to the standard .htaccess we distribute? This has two advantages: a) Avoid a Drupal bootstrap for every 404 of these files. b) Send a smaller number of bytes when this happen. I believe the majority of sites would not want Drupal to handle 404 for these files. I can make the patch if it has a chance of getting through.

1 0

Node Rendering patch: benchmarking needed?
by Jeff Eaton 03 Aug '06

03 Aug '06

Work on http://drupal.org/node/74326 (to use FormAPI-style structured arrays to build node bodies) has been going nicely. Things seem to work very well, and the flexibility payoff is big. Right now, though, we need to gather some good numbers on how much the change impacts page rendering times. Several of us have taken a stab at it, but the results are inconclusive -- working on local laptops or busy shared servers where any real impact was lost in the noise of other server load issues. If there are any folks out there with experience benchmarking, any help would be appreciated. --Jeff

1 0

Unmaintained/Abandoned Modules
by Nick Wilson 03 Aug '06

03 Aug '06

Hi everyone, Can somebody tell me what the proceedure is with unmaintained modules? Specifically Im talking about the Invite module -- It *appears* that the author is not contactable and does not look like the module is being maintained. (his last activity on drupal.org was in march) I've been working on the module, and have fixed a number of bugs and made some improvements but don't know how to go about getting them included/reviewed for this module. I would be happy to take over the maintenance, or commit as a new module -- whatever is the norm. thanks -- Nick Wilson http://performancing.com/user/1

5 11

More usability suggestions from Kristjan
by Dries Buytaert 03 Aug '06

03 Aug '06

Hello world, Kristjan (usability expert) provided some additional suggestions for the installer: * http://drupal.org/node/76785 * http://drupal.org/node/75264#comment-120214 * http://drupal.org/node/76591 -- Dries Buytaert :: http://www.buytaert.net/

1 0

social network module - the drupal part of the work
by Novák Áron 03 Aug '06

03 Aug '06

Hi, I've work on the drupal interface of the social network code. The module is in early stage yet, but can be tested and tried out here: http://sna.drupaler.net . The installation and the usage of the module is not trivial yet. The source code and the details are available at the URL too. Thanks for any feedback, Aron Novak

1 0

[neclimdul@gmail.com: Fwd: [development] LinksDB vs. Links]
by Sammy Spets 03 Aug '06

03 Aug '06

Hi all, > * Your SQL queries will not work on PostgreSQL. It needs > db_query('word "%s" word') not db_query("word '%s' word"). For the reference of those that don't know yet, the correct way for both MySQL and PostgreSQL is: db_query("word '%s' word"); Strings in ALL database systems must be encased in single quotes. If you do otherwise you're breaking the SQL standard. Cheers, -- Sammy Spets Synerger Pty Ltd http://www.synerger.com/ * You use double spaces after sentences in _report_submit. * Listen, I know I said you shouldn't use drupal_goto a few bullets ago. That doesn't mean you go and use drupal_set_header with a Location: instead. Man alive. * Oh, and you're passing ; at the end of most of your SQL queries. You don't need to do that either. * You use "'<Root>'" in linksdb_deadlinks, and '<Root>' in linksdb_suggest. Which is it? (For what it's worth, it should be '<'. t('root') .'>', per Drupal core). * To prevent things like "select * from {links_links} where dead=1 order by {links_links}.name", use table abbreviations, like: "select * from {links_links} ll where dead=1 order by _l_l_._n_a_m_e". * if(variable_get('linksdb_show_report',1)==1) - you don't need ==1. * linksdb_deadlinks doesn't translate the report messages. * You use "links/report/$link->id" and then 'links/refer/' . $link->id. Which is it? Concatenation or interpolation? * Oooh, you do know how to predeclare $form = array() in _suggest(). I guess you must have made sloppy mistakes all the other times. Story of your life, eh? * "({name},{url},{description},{active},{category})" - I have no clue what you're even attempting there. Column names aren't prefixed. * Is it site staff or site administrators? You use both. * theme_link() - Gah, you don't use theme('image') here. * Is it "Link" or "link"? Previously you have "Report this link", but then you have "Edit Link". * $cat->shown=99999999;. Right. Heh. * You seem to use the "Report this link as dead" thing a lot. That should be made a function. * # for comments? What is this, Perl? And so on. But I'm getting bored. -- Morbus Iff ( drowning in data, bereft of knowledge. ) Technical: _h_t_t_p_:_/_/_w_w_w_._o_r_e_i_l_l_y_n_e_t_._c_o_m_/_p_u_b_/_a_u_/_7_7_9 Culture: _h_t_t_p_:_/_/_w_w_w_._d_i_s_o_b_e_y_._c_o_m_/ and _h_t_t_p_:_/_/_w_w_w_._g_a_m_e_g_r_e_n_e_._c_o_m_/ icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / _j_a_b_b_e_r_._o_r_g: morbus ----- End forwarded message -----

4 3