October 2007 - Development - lists.drupal.org

hook_schema() now in .install, not .schema
by Barry Jaspan 09 Oct '07

09 Oct '07

Public service announcement: Prior to http://drupal.org/node/150245, hook_schema() was always defined in a module's .schema file. There was never any good reason for it to be there. The bad reason was "to avoid parsing the extra code in .install." However, the results of hook_schema() are cached so the functions only have to be called when modules are enabled/disabled or when CCK type structures change. This is very rare and parsing the .install files only on those occasions is not a performance issue. Now, hook_schema() must be defined in .install. The good reason for this is that it makes much more sense to have the schema definition and the schema update functions in the same place. It will make bugs of the "changed hook_schema() without a hook_update_N() or vice versa" sort less likely. And it is where God intended hook_schema() to be (says the atheist). If this had been an actual emergency, your mail server would already have crashed. Thanks, Barry

6 6

Another notable guy: Desbeers
by Karoly Negyesi 08 Oct '07

08 Oct '07

One of the oldest Drupal users, Nick Berendsen http://drupal.org/user/149 has returned to the project and produces very remarkable patches which reflect a deep understanding of Drupal. Welcome back and thanks!

2 1

strategy for naming module/theme/profile
by Simon Hobbs 08 Oct '07

08 Oct '07

Inspired by Boris Mann, I was going to start adding my company's standard install profile / module / theme in CVS. I've had issues in the past with a theme and module sharing the same name. Is this still an issue? Was this ever a recognised issue? Can I do this in D5 without any repurcussions when it comes to installation? module - "emspace" - support code and snippets for our install profile profile - "emspace" - our default install profile theme - "emspace" - our site's theme including an admin variation. Or to avoid issues described above, should I be doing: "emspace_code" "emspace_profile" "emspace_theme" Any suggestions are welcome. Simon

3 3

new feature: comment settings now per node type
by Chad Phillips -- Apartment Lines 08 Oct '07

08 Oct '07

in order to greatly improve the usability of project module on drupal.org in Drupal 6, we snuck this feature in today... ;) it's a nice new end user feature which also cleans up the UI -- developer impact is minimal, and detailed here: http://drupal.org/node/114774#comment_settings_per_node_type hunmonk

2 1

Views & lots-o-data
by Ryan Courtnage ☠ 08 Oct '07

08 Oct '07

Hi all, I've just written a node module that implements a view. First, I got my simple view to display the node title & body - this works. Next, I add a field that I've exposed from my custom module's table (a "city" field). This is where I run into a problem. My module's node-type has over 88,000 entries. The query that the Views module runs will cause mysql to pin the CPU (I've watched it pin for over 100 minutes before killing the process). What can I do to improve the perfomance (in a big big way)? I'm not a DBA, is there something I should be doing at the DB table level to improve performance? Or perhaps there's a Views option I'm missing? My views implementation follows. I've commented above the $view->field array that causes the problem. Thank you! Ryan irc: Bentley ---- function node_charity_views_tables() { $table = array( 'name' => 'node_charity', 'join' => array( 'left' => array( 'table' => 'node', 'field' => 'nid' ), 'right' => array( 'field' => 'nid' ), ), 'fields' => array( 'address_city' => array( 'name' => t('Charity: City'), 'help' => t('City of Charity'), 'sortable' => FALSE ), ) ); $tables["node_charity"] = $table; return $tables; } function node_charity_views_arguments() { } function node_charity_views_default_views() { $view = new stdClass(); $view->name = 'Charities1'; $view->description = 'CCOs'; $view->access = array ( ); $view->view_args_php = ''; $view->page = TRUE; $view->page_title = 'Charities'; $view->page_header = ''; $view->page_header_format = '1'; $view->page_footer = ''; $view->page_footer_format = '1'; $view->page_empty = ''; $view->page_empty_format = '1'; $view->page_type = 'list'; $view->url = 'charities1'; $view->use_pager = TRUE; $view->nodes_per_page = '50'; $view->sort = array ( ); $view->argument = array ( ); $view->field = array ( array ( 'tablename' => 'node', 'field' => 'title', 'label' => '', 'handler' => 'views_handler_field_nodelink', 'options' => 'link', ), array ( 'tablename' => 'node', 'field' => 'body', 'label' => '', 'handler' => 'views_handler_field_body', ), // the following array causes cpu to pin for hours. array ( 'tablename' => 'node_charity', 'field' => 'address_city', 'label' => '', ), ); $view->filter = array ( array ( 'tablename' => 'node', 'field' => 'type', 'operator' => 'OR', 'options' => '', 'value' => array ( 0 => 'node_charity', ), ), ); $view->exposed_filter = array ( ); $view->requires = array(node, node_charity); $views[$view->name] = $view; return $views; }

2 3

Re: [development] Views & lots-o-data
by andy＠spiders-lair.com 07 Oct '07

07 Oct '07

Doh, I should have read to the bottom to see the view..... you can ignore that last email --Andy

1 0

Re: [development] Views & lots-o-data
by andy＠spiders-lair.com 07 Oct '07

07 Oct '07

Is your "city" field indexed? CREATE INDEX {my_modules_table}_city ON {my_modules_table} (city); regards, --Andy ----- Original Message ---- From: Ryan Courtnage ☠ <ryan(a)courtnage.ca> To: development(a)drupal.org Sent: Sunday, October 7, 2007 9:27:23 PM Subject: [development] Views & lots-o-data Hi all, I've just written a node module that implements a view. First, I got my simple view to display the node title & body - this works. Next, I add a field that I've exposed from my custom module's table (a "city" field). This is where I run into a problem. My module's node-type has over 88,000 entries. The query that the Views module runs will cause mysql to pin the CPU (I've watched it pin for over 100 minutes before killing the process). What can I do to improve the perfomance (in a big big way)? I'm not a DBA, is there something I should be doing at the DB table level to improve performance? Or perhaps there's a Views option I'm missing? My views implementation follows. I've commented above the $view->field array that causes the problem. Thank you! Ryan irc: Bentley ---- function node_charity_views_tables() { $table = array( 'name' => 'node_charity', 'join' => array( 'left' => array( 'table' => 'node', 'field' => 'nid' ), 'right' => array( 'field' => 'nid' ), ), 'fields' => array( 'address_city' => array( 'name' => t('Charity: City'), 'help' => t('City of Charity'), 'sortable' => FALSE ), ) ); $tables["node_charity"] = $table; return $tables; } function node_charity_views_arguments() { } function node_charity_views_default_views() { $view = new stdClass(); $view->name = 'Charities1'; $view->description = 'CCOs'; $view->access = array ( ); $view->view_args_php = ''; $view->page = TRUE; $view->page_title = 'Charities'; $view->page_header = ''; $view->page_header_format = '1'; $view->page_footer = ''; $view->page_footer_format = '1'; $view->page_empty = ''; $view->page_empty_format = '1'; $view->page_type = 'list'; $view->url = 'charities1'; $view->use_pager = TRUE; $view->nodes_per_page = '50'; $view->sort = array ( ); $view->argument = array ( ); $view->field = array ( array ( 'tablename' => 'node', 'field' => 'title', 'label' => '', 'handler' => 'views_handler_field_nodelink', 'options' => 'link', ), array ( 'tablename' => 'node', 'field' => 'body', 'label' => '', 'handler' => 'views_handler_field_body', ), // the following array causes cpu to pin for hours. array ( 'tablename' => 'node_charity', 'field' => 'address_city', 'label' => '', ), ); $view->filter = array ( array ( 'tablename' => 'node', 'field' => 'type', 'operator' => 'OR', 'options' => '', 'value' => array ( 0 => 'node_charity', ), ), ); $view->exposed_filter = array ( ); $view->requires = array(node, node_charity); $views[$view->name] = $view; return $views; }

1 0

Druplicon not in IRC?
by Matthew Farina 07 Oct '07

07 Oct '07

I noticed the Druplicon isn't in the IRC rooms right now. Is something wrong or is there something I didn't know about? Matt

4 3

ie7 login problems?
by Ashraf Amayreh 07 Oct '07

07 Oct '07

Hello all, I have a drupal 5.1 installation and I've been following thread after thread on a very pesky login problem on IE7. Some users get an "invalid login" although they provide correct user names and passwords. This is the only relevant thing about it and it doesn't seem to be answered by anyone. http://drupal.org/node/98108 I'm using linux, no ie7, and this is really a nightmare since I can't even debug it and relying on windows guys but to no avail as it happens with some people and not with others. Cleared caches, done everything I could think of. Any hints?

3 2

view + cck or views + form_alter
by John Barreiros 05 Oct '07

05 Oct '07

Hi All. This particular site I'm building features a layout with a photo in the upper right corner. The client wants to have the ability to specify the image on every single page. I know I know, kind of whacked, but it's what they want. So, first step was to use cck to add a new field to the "page" type. I tried imagefield but didn't like how you couldn't select an existing image. I managed to whip together a new cck field which uses IMCE to select the image (I'll up it to cvs after some more testing and some coworkers give me the thumbs up on its quality). Okay, so that takes care of any pages displaying a single node. How do I handle views? There are a few views and they obviously need to have the image customizable. It'd be nice if when creating a "view" to provide a page, it inherited the cck fields from the "page" type. Could I use form_alter to add the cck field to the views form? Or is there some way when the "view" is being built I can extract the image from the first node and pass it to page.tpl.php? Any help would be appreciated. Thanks in advance. -john

4 9