December 2007 - Development - lists.drupal.org

D6 SAPI: using hook_install to ALTER {tables}
by Augustin (Beginner) 12 Feb '08

12 Feb '08

Hello, I just read through the Schema API documentation: http://drupal.org/node/146843 All the examples of hook_install() assume the module is creating a whole new table. E.g. here http://drupal.org/node/146862 and here: http://api.drupal.org/api/function/hook_install function hook_install() { drupal_install_schema('upload'); } What if a contrib module wants to ALTER an existing table (created by another module)? Q1) Do I still use hook_schema() to define the extra field and call it from hook_install() as in the examples? Q2) Or, do I call db_add_field() from hook_install()? Q3) Is it considered best practice to create your own tables rather than adding fields to existing tables "belonging" to other modules? Blessings, Augustin.

4 4

groking ajax callbacks
by Augustin (Beginner) 23 Jan '08

23 Jan '08

Hello, See my message to the documentation list about where to document everything ajax, ahax, js, and jquery. http://drupal.org/node/121997 Right now, I am trying hard to understand book.js and ... I just don't get it. In book.js, there is an ajax call: $.ajax({ url: Drupal.settings.book.formCallback +'/'+ $('#'+ Drupal.settings.book.formId +' input[name=form_build_id]').val() +'/'+ $('#edit-book-bid').val(), dataType: 'json', success: function(data) { // Insert the new select, and remove the progress bar. $('#edit-book-plid-wrapper').after(data['book']).remove(); } in book_menu(), there is a menu callback, which I guess is the callback used by the js above: $items['book/js/form'] = array( 'page callback' => 'book_form_update', 'access arguments' => array('access content'), 'type' => MENU_CALLBACK, 'file' => 'book.pages.inc', ); But everything javascript and ajax being completely undocumented, I am having a hard time to connect the two together, even by looking at drupal.js, looking at the big documentation block above drupal_add_js() (in common.inc), which I don't understand at all (I told you it was too early to change my handle!!) How does this... $.ajax({ url: Drupal.settings.book.formCallback +'/'+ $('#'+ Drupal.settings.book.formId +' input[name=form_build_id]').val()+'/'+ $('#edit-book-bid').val(), ...lead to the book/js/form callback??? I sense it is connected to Drupal.attachBehaviors (in drupal.js) and Drupal.behaviors.bookSelect (book.js), but I don't know how. As I always do, if you tell me both the answer and where to document this, I'll have a go at starting a documentation. Thanks and blessings, Augustin.

5 7

Updating drupal.org to Drupal 6 release candidate
by Gerhard Killesreiter 05 Jan '08

05 Jan '08

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi there, it is a time honoured tradition that drupal.org is updated to the first release candidate of a new Drupal release as soon as this is available. The first RC of D6 is now available, now when is that update going to happen? The answer is unfortunately: Not very soon. The reason is not the release candidate but the multiple dependencies that drupal.org has. The most well known is probably the project module and it's many friends. However, there are also other dependencies of which I can't find a D6-ready release or some attempt at one (image.module and simplenews for example). Project* has it's own roadmap on the D6 update here: http://groups.drupal.org/node/6180 While I am not entirely happy with the order of the items (I'd obviously prefer to have points 10 and 11 at the top), there is at least something to look at. Also, people who would like to see d.o updated do know how they can help. Unfortunately, there aren't that many people who are eager to help. What I am trying to do is to establish a timeline of when d.o could be updated. So I'd like the maintainers (or other knowledgable parties) to speak up and tell me what their guestimates for updates to D6 are: - - project - - project_issues - - versioncontrol - - views - - image - - image_gallery - - image_attach - - simplenews - - lists - - feature Cheers, Gerhard -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHdpROfg6TFvELooQRAq1UAJ9otQ4pb1veB/DOYFMUnTZjy4tIAgCfWe+w awu0DgZI3+YLejToiw87N6s= =Hexe -----END PGP SIGNATURE-----

10 15

Re: [development] Getting both better internal and external APIs intoDrupal 7
by Michelle Cox 01 Jan '08

01 Jan '08

On 12/30/2007 10:21:32 AM, blogdiva(a)culturekitchen.com wrote: > HOT! > > +1 for including into core : > > CCK > Bio > Panels > > I need more coffee so I can find the notes of a wishlist I have been > compiling for a while. I do know that ICONIZER and BUEditor would be > ideal for those of us who would like Drupal to focus on usability and > better design. I also understand the need to make the default distro > lightweight. For that matter, I still believe there needs to be a > serious push for different "default" distributions --and please, > let's > stop calling those "profiles" because it's confusing with the > term "profile". I've never used iconizer but I really like bueditor. It's easy to use for newbies and yet doesn't get in the way like a true WYSIWYG does. I don't know if the code is core worthy but I think it would be a nice addition if it is. A compromise between those who think Drupal needs a WYSIWYG in core and those who say no way. Of course, it would need to be an optional module, not just hardcoded in. As someone up to her ears in user profiles stuff, I second the changing of install profiles to something else. :) Michelle

2 1

preg_match bug or regex help needed?
by Doug Green 31 Dec '07

31 Dec '07

I'm pretty good with regex, but I'm beating my head against the wall with this one, and wondering if there's a bug in php. Any help is much appreciated. (This is for nicedit.) <?php $text = 'style="font-style: italic; font-weight: bold;"'; $regex = "(\s*([a-z][a-z0-9\-]*)\s*:\s*([a-z][a-z0-9\-]*)\s*;)+"; if (preg_match('/'. $regex .'+/i', $text, $matches)) { print_r($matches); } ?> If the regex is confusing, just think of it simply as ((\w+):(\w+);)+ ... with extra spaces and a definition for words that includes dashes. The regex vars $1 and $2 seem to only put the last matching value in the matches array. Array ( [0] => font-style: italic; font-weight: bold; [1] => font-weight: bold; [2] => font-weight [3] => bold ) I was hoping that it would also write font-style: italic into the matches. Thanks, Doug Green

4 5

Re: [development] Getting both better internal and external APIs intoDrupal 7
by Michelle Cox 31 Dec '07

31 Dec '07

On 12/29/2007 11:46:34 PM, Khalid Baheyeldin (kb(a)2bits.com) wrote: > Users as nodes has 3 modules at least in contrib: > > - bio: the most straight forward of them. > - node profile: a more complex way. > - usernode: the original concept. > > The need to customize how profiles look is the driver here, plus cck and > views. > > Core profile should go away soon, replaced by node + cck. Most of this discussion is over my head but I wanted to comment on this. My upcoming Advanced Profile module uses Panels 2 for displaying the user profile on the view tab of the user page. It currently uses bio but will eventually be able to use bio, node profile, or even the core profile module. I'm designing it so it doesn't care where it gets the profile information from. What would be ideal is to have in core some way of optionally associating a user with a node type as bio does and also include in core a lightweight non-node solution for holding profile data for those who don't want a node for every user. Then people could use Panels 2 (which would be lovely to have in core someday) to display this "user profile object" as well as anything else they want on that page. For now, I'm making this possible in contrib, but having some of it in core would reduce the module dependency for this method. Michelle

5 5

Locked The Thread
by Karoly Negyesi 31 Dec '07

31 Dec '07

So there can be no misunderstanding, this mail is BCC'd to Dub. I also contacted him but I want to be sure. I locked the thread because of repeated pleas to stop and because I and many have been called a psychopant. This is just flaming and not constructive any more.

3 3

Using Admin Theme on Other Pages
by Ben Wheeler 31 Dec '07

31 Dec '07

Hi All, I think this is fairly simple to do, but I couldn't find anything in the forum/handbooks. I have a theme that's very specific and doesn't work well for admin type situations, so I have an admin theme set up. I'd like to use my admin theme on other pages, so in my custom module hook_menu (taking a cue from system.module) i have: function custom_menu($may_cache) { $items = array(); if ($may_cache) { blah blah blah } else { if (arg(0) == 'webfm' OR arg(0) == 'user') { global $custom_theme; $custom_theme = variable_get('admin_theme', '0'); } } return $items; } Which doesn't work at all, although it does set the variable $custom_theme quite nicely. I'm thinking I have to set this at another time, but I don't know how the whole admin theme thing works. Any suggestions? Thanks. -Ben

2 1

Re: [development] Getting both better internal and external APIs intoDrupal 7
by Michelle Cox 30 Dec '07

30 Dec '07

On 12/30/2007 10:46:35 AM, Wim Mostrey (drupal(a)mostrey.be) wrote: > I don't think bio is a good candidate for this, if the plan is to > replace the profile module. Bio does not allow to put fields in the user > registration form, which in my opinion is a required functionality for > core. From my experience node profile does the cleanest of this (to make > it core-worthy the node family dependency would need to be dropped of > course). I have used both nodeprofile and bio and they are both good modules but I think recent changes to bio make it just a bit better. As noted elsewhere, bio now has the ability to put fields on the registration page. Better yet, it has the ability to _selectively_ put them there, not just dump the whole node there. Plus, nodeprofile has two module dependencies. Bio is a lighter solution. I like both modules and nodeprofile is the way to go if you want multiple node profiles for sure. But if anything would be considered for core, I would recommend bio as it is a lot lighter weight. Michelle

1 0

Re: [development] Op-ed: Posting FUD/flame bait to the front page is unproductive, disrespectful, an abuse
by Michelle Cox 30 Dec '07

30 Dec '07

On 12/29/2007 10:58:29 PM, Caleb Gilbert (caleb.gilbert(a)gmail.com) wrote: > ...and is not an appropriate thing to do for people with Drupal.org > frontpage rights. I agree completely. Which is why I demoted it to begin with. For the record, I have always maintained (despite the lies he posts on the thread) that he was in his rights to post the discussion. If he has concerns, he should ask. I don't want anyone to ever be afraid to speak their mind. The _only_ thing I have ever objected to was the promotion to the front page. I see the front page as a "brochure" where you post positive things about Drupal for the benefit of new people. It is _not_ the place for controversial posts that will have new people wondering just what sort of community they are getting into. I was asked by killes a while ago to look after the front page and since then haven't had to do very much. On the whole, the 90ish people with rights to promote do a good job. The only thing I've demoted up to this point is some local group events back when we were first settling on a policy for events on the front page. And I had no backlash from that. This is the first time a maintainer has flamed me for demoting something and then went behind my back and re-promoted it, even knowing that other admins agreed with me and it wasn't a unilateral action on my part. Personally, I don't see this as a breakdown of the system but simply an individual abusing his rights. The frontpage is pretty common sense, IMO. Put up things that will bring people to Drupal and announcements the community needs to know about. It should be a happy place, not a flame fest. Ask yourself, if you were new to Drupal and saw this post, would you turn around and not come back? Common sense is all that's needed. If you are unsure, file an issue or hop on IRC and converse with other admins. I'm even going to go so far and say I feel that promoting your own post is fine if it's something that belongs there. I don't think him promoting his own post was really the problem. It was him promoting his own opinionated, controversial post and then repromoting it after it was discussed and demoted that was the problem. There's a big difference between that and, say, Gábor writing up a release announcement and posting it. So I think promoting your own benign post is fine but, for goodness sake, if it gets demoted for some reason, don't just repromote it without discussing it. Again, it all comes down to common sense. As long as we all use it, the front page will be fine. Ok, off my soapbox. :) Michelle

3 2