- Development - lists.drupal.org

Re: [development] Database queries on drupal.org
by Peter Wolanin 28 Jul '06

28 Jul '06

----- >Date: Fri, 28 Jul 2006 10:49:07 -0500 (CDT) >From: "Larry Garfield" <larry(a)garfieldtech.com> >Subject: Re: [development] Database queries on drupal.org >- Someone needs to get that query out of the forum module's theme >code. :-) In reponse to the above, I was rather astounded to see these SQL queries in the theme function a while back when I was figuring out how to theme the forum pages. I opened an issue, but haven't had any any input. Maybe it needs a better title? Please follow-up there if you're interested. http://drupal.org/node/70578 Right now there is a lot of work done every time a forum page is viewed to generate the links to the previous and next forums. As a start, I'd like to suggest moving to a system more like the book module. The forum table should get two more entries, for the node.nid values for the previous and next node, and I'd add these into the $node object in forum_load(). This would make it easy to generate links to next/prev links without the titles, but getting the titles would still require a query (unless the titles are also duplicated in the forum table). The real trick is to figure out how and how often to update these values. Some schemes order the forum topics by the number of comments.

1 0

Object caching
by Ken Rickard 28 Jul '06

28 Jul '06

This is a fork from the Caching, caching, caching thread. I have opened an issue to start testing the gains for using an object cache on commonly-loaded objects ($user, $node, $block, $profile, $comment, $term) at http://drupal.org/node/74020 The patches apply against HEAD. (Be gentle, they are my first CVS patches.) I'm currently using this approach in 4.6 to run the (very large) SavannahNow.com site and reduce database overhead. I'm currently testing a stripped-down HEAD install on a Mac PowerBook G4, so the testing numbers listed there may be misleading. I toyed with the idea of creating some new functions for cache.inc to make retrieving objects easier, but for the time being am just using cache_set, cache_get, and cache_clear_all. One question: has file-based caching made it into HEAD yet? -- Ken Rickard drupal: agentrickard gmail: agentrickard

18 36

Allow/Disallow path aliasing by settings
by Ken Rickard 28 Jul '06

28 Jul '06

After much discussion on the list, I actually wrote some code that takes a pass at reducing the number of drupal_get_path requests, http://drupal.org/node/75976 I talked some with Moshe on IRC (thanks!) and this patch is not intended to do anything but let developers test whether this approach gives us any real performance gains. In this first pass, all I did was put in the structure that would allow an administrator to remove certain paths from ever being looked up. This approach required a modification of url() and a new function to handle lookup requests. This function is drupal_alias_allowed($path). In the current patch, all paths are still allowed, as the default array is null. To be honest, I tried to do more, but Forms API and admin settings gave me some problems. I'd like to do a textarea for entering 'allowed' paths one per line, but couldn't make the code behave properly. Without an admin, the way to test is to alter the variable_get within drupal_alias_allowed(), I would suggest making that value: array('node', 'user'), which would allow the creation of aliases only for paths the start with 'node' or 'user.' Feedback welcome. - Ken Rickard agentrickard

1 0

displaying phptemplate hooks as HTML to assist theme design
by Farsheed 28 Jul '06

28 Jul '06

Hi, I am interested in developing a diagnostic theme or method to display phptemplate hooks called in a CSS hover over that element. So when you hover over the breadcrumb HTML output on your website it displays: phptemplate: theme_breadcrumb() called in a CSS hover. and that way the designer knows if he/she wants to modify the breadcrumb they will have to look at the $breadcrumb variable or override theme_breadcrumb. It's kind of like how devel.module helps write modules, except for themes. So far the only idea I have is to intercept _phptemplate_callback [1] but wondering if anybody has any better methods. Farsheed [1] http://api.drupal.org/api/4.7/function/_phptemplate_callback __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

Design Flaws in Drupal Caching System
by Alex Markley 26 Jul '06

26 Jul '06

Hey all! I'm sure most of you are busy with other stuff, but I thought I'd make some noise about this issue because it represents a potentially serious design flaw in the caching system. My original, scatter-brained report is here: http://drupal.org/node/75186 I'm not terribly familiar with the caching system as it is, and I know there are other discussions going on about improving it. Thus, I'm not interested in trying to "tell people like it is" or stepping on anybody's toes. I'm just trying to bring up an issue that I know exists and have confirmed to be a problem in 4.7.2. Specifically, while Drupal does a really great job of caching all pages generated by anonymous requests, it does a really, really crappy job of clearing them. Unless I'm mistaken, I don't see any maximum lifetime for cache entries, which I believe to be design flaw number one. Even if that maximum lifetime is over a month, it still protects Drupal-powered sites from serving year-old stale/invalid content to anonymous users. Design flaw number two is that many content updates don't clear any cache entries, resulting in bad/stale content being served to anonymous users: ==> Example: At the moment, admin/node operations immediately result in stale content because they don't trigger any cache deletions. ==> Example: User profile updates immediately result in stale content because they don't trigger any cache deletions. Design flaw number three (my favorite one) has to be the complete and utter lack of an intelligent cache clearing mechanism. For example, why in the name of heaven does node_save do a cache_clear_all(); ?! It should be calling a hook that allows interested modules to clear cache entries that they created! That would prevent good cache entries from being deleted and ensure that old cache entries are deleted on the spot. I guess my beef is that irresponsible modules are failing to clear cache entries when they are rendered invalid, and hacks like calling cache_clear_all(); from node_save() are short-sighted at best. This problem is bad enough to make me seriously consider the sanity of enabling the cache on my site at all, since anonymous users are my primary audience. Feel free to disagree. ttyl --Alex Markley (Malex) http://MalexMedia.Net/

3 2

re: [development] bug in drupal.org search module
by Peter Wolanin 26 Jul '06

26 Jul '06

Yes, this is a known bug- here's the issue and patch to review and test: http://drupal.org/node/67648 >Date: Wed, 26 Jul 2006 10:48:58 +0530 >From: "balachandar muruganantham" <mbchandar(a)gmail.com> > >Hi, > >There is a bug which i found in drupal.org when using search > >steps to follow inorder to simulate the bug >1. go to the url www.drupal.org/taxonomy >2. it will say page not found >3. now in the search text box, if u type any thing, it will not search >anything. same page will come i.e page not found. it is not going to >www.drupal.org/search

1 0

Leave of absence: automember.module
by Kobus Myburgh 26 Jul '06

26 Jul '06

Hi, My situation currently requires me to take a leave of absence from most of my Drupal activities (and most of my hobbies, too) for two months or maybe even more. I have tried to convert automember.module to Drupal 4.7 before I left, but I have not been able to do so successfully - there are still way too many bugs to release. I have had two queries about automember module since I took over from njivy, and no more, so either it is not in widespread use, or people updated it themselves to version 4.7. If this need is more urgent than what I believe it is, I will be willing to hand over to someone who will do the conversion. If the need is not so urgent, and nobody wants to do the conversion, this will have to wait until I get back... Any interested people, please reply to me off-list. Thanks! Kobus

1 0

Re: [development] Design Flaws in Drupal Caching System
by Alex Markley 26 Jul '06

26 Jul '06

> In the upper left is a "What's on now" block. I created this by using in > the block to display the correct info based on current time. But, when I > turn on the cache, whatever show was on at the time the cache was turned > on stays there forever. Well, I think that the current implementation caches entire pages instead of objects within pages. Thus, it sounds like you want to avoid caching altogether. My beef is just that core doesn't have a maximum lifetime for cache items or a method for intelligently expiring cached items when they can programmatically be deemed stale. Even worse, the currently-released code doesn't even play nice with its own delete-everything-when-anything-changes policy, so a newbie admin could end up serving stale content to anonymous users for months at a time. ttyl -- Alex (Malex) Markley http://MalexMedia.Net/ "I may seem like a hard-boiled detective on the outside, but inside, I'm full of... organs." Useless Info: System kernel: Linux 2.6.14-1.1653_FC4 Reliability: 03:30:01 up 5 days, 4:35, 5 users, load average: 0.12, 0.22, 0.38

1 0

bug in drupal.org search module
by balachandar muruganantham 26 Jul '06

26 Jul '06

Hi, There is a bug which i found in drupal.org when using search steps to follow inorder to simulate the bug 1. go to the url www.drupal.org/taxonomy 2. it will say page not found 3. now in the search text box, if u type any thing, it will not search anything. same page will come i.e page not found. it is not going to www.drupal.org/search -- <name> balachandar muruganantham</name> <Yahoo!> mbchandar</Yahoo!> <Hotmail> mbchandar</Hotmail> <blog> http://www.balachandar.net/blog</blog> <web>http://www.balachandar.net</web> <talk> http://www.expertstalk.org</talk> <shop>http://www.chennaishopping.com</shop>

1 0

Re: [development] Have you ever laughed fate in the face?
by Chad Phillips -- Apartment Lines 25 Jul '06

25 Jul '06

On Jul 24, 2006, at 6:00 AM, Gabor Hojtsy wrote: > IMHO what Dries suggested with the status column is simple. status > = 1 is already in queries. status = 0 means unpublished, another > status can mean deleted. No need to modify queries (just review > existing ones for the status queries). once again, let me reiterate that this is an insufficient solution-- it only applies to nodes, and there are other forms of content that need to be addressed--not to mention that afaik node dependent tables don't have a status column, which could also cause problems.

5 4