- Development - lists.drupal.org

Re: [development] Modules page rework
by Adam Cooper 31 Jul '06

31 Jul '06

>On 29 Jul 2006, at 18:00, Moshe Weitzman wrote: >> looks like a big improvement to me. if you are into experimenting, >> i would try this out with just a table and no fieldsets. use >> subtabs for things like 'contrib', 'installed'. the default should >> show lots of modules i would think, like today. > >Here is WordPress' forthcoming plugin manager: > > http://www.brokenkode.com/wp-content/uploads/2006/05/Plugins.jpg > >My first impression is that it a lot easier to the eye than Earl's >proposal. > > - The module names are links that take you to the corresponding >settings page. > - They are not using checkboxes but buttons. I'm in agreement with Dries. It would be nice to look at the approach taken by word press. Your current checkbox metaphor I think would confuse users as it uses a context sensitive approach whereas most users are used to checked = on/yes, not checked = off/no. If inactive modules were on a separate page you may just get away with it (though people would no doubt apply the active modules metaphor to the inactive modules. i.e. check to disable and infact enable.) As it stands having two types of, identical looking, oppositely behaving checkboxes on one page would cause pandemonium. In summary, links to module settings don't hurt, and losing the checkboxes would be a nice experiment. Adam <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML><HEAD> <META content="text/html; charset=windows-1252" http- equiv=Content-Type> <META content="MSHTML 5.00.3700.6699" name=GENERATOR></HEAD> <BODY> <HR> This message may contain confidential or privileged information, and is intended only for the addressee or other persons entitled to access the information. If you are not the intended or authorised recipient of this message please notify the sender by return and then delete it from your mailbox. Any dissemination, distribution, copying or use of this communication without prior permission is prohibited. Internet communications are not secure and may be susceptible to data corruption, interception and unauthorised amendment for which Pall Europe Limited does not accept liability. Whilst we have taken all reasonable precautions to ensure that this e-mail and any attachments have been swept for viruses, Pall Europe Limited does not accept liability for losses sustained as a result of software viruses. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Pall Europe Limited unless otherwise specifically stated. Registered Office and Corporate Headquarters: Pall Europe Limited, Europa House, Havant Street, Portsmouth, PO1 3PD. Registered No 769075, England. <HR> </BODY></HTML>

1 0

the past, present and future of drupal admin
by Kristjan Jansen 30 Jul '06

30 Jul '06

This was meant to be a followup for http://drupal.org/node/72079 but it grew too long and abstract so I brought it over here. I know that long rants are out of vogue nowadays, but I was not able to help it == The purpose of admin pages == Can we sit back for a while and say: what is the reason to have admin pages? what does admins do on those pages mostly? Is it for monitoring how your site is doing? Tinkering settings? Administering content or users? (some answers are here: http://www.surveymonkey.com/DisplaySummary.asp?SID=1425065&U=142506581557) There has been several thinking schools on what should be in main administration page: - administration is mostly about monitoring and then optionally some tinkering. This thinking brought us the chat log as most prominent thing in /administration page. It's questionable whenever the raw chat log really gives you the 'dashboard feel' or you need more structured, more digested information visualization a la http://www.measuremap.com/ or http://heartbeat.skype.com/ (shameless plug ;) - administration is all about (finding and then tinkering) settings and administering content. This is the approach what current http://drupal.org/node/72079 is taking - administration is tuning the settings for backend, content administration might belong to a frontend side (famous "theme for admin" discussions and splitting administration into 2 halves) There are more ideas around though: - administration frontpage is a friendly-tone introductory story with links to most-used admin section and there also some relevant RSS feeds (Wordpress) . It's similar to our no-nodes-yet frontpage + drupal planet - already mentioned dashboard idea combined with a contextual tips that should grab you attention: USERS | there is 21 people applying for an account, waiting COMMENTS | there is 12 comments to be moderated, check also your spamlist etc - add here 37signals "placeholder" idea and your other favorite toolkit's admin pages I have no preference formed, but gut feeling says the "ideal admin page" should contain a smart mixup of these different ideas above == Structuring the admin menu == I have tried to sort the admin items and had a look on various sorting proposal too. There is always a common pattern happening during the process: Some initial, logical task-based clouds are formed: -- Content management -- User management -- Layout / Styles / Look and feel / Site building -- Logs / Statistics (-- Help) Now we are left with 2 tricky groups: -- Site settings / Site configuration / System settings -- Module management This is the point where we hit the head to the wall. - should all settings existing in Drupal belong under "Site settings" or should some of them belong in the logical task clouds named above? Content management has loads of different settings: for nodes, for comments etc. Same goes for user management, there is also config stuff under stats etc. Historically the settings used to be all in a separate section, then there was a big initiative to move task-specific settings (content/user/layout/logs settings) under the specific groups (at the time tabs, subtabs and menus were fleshed out in Dries' experimental site), then over the time these settings creeped back too admin/settings since "nobody could found them" and now the latest proposal moves them back to task clouds. This clearly shows there is no "right" or "wrong" placement really. - Now add not-enabled-by-default and custom modules into the picture and it becomes even more fuzzy. There are dozens of modules what partially belong under several task clouds and partially stand on their own. Just some quick examples (not totally exact) -- spam.module has to do with content (comments) and statistics, e-commerce and civiccrm modules are empires on their own. Nothing really fall simply to our predefined clouds, abstract menu system allows to inject almost anything into menu structure. As it has been said before: Drupal UI is victim of it's own modularity. - Related problem: there are settings where are hard to decide into what task cloud they belong, examples would be RSS, contact form, file upload settings, blogAPI and name-your-favourite-contrib-module. - Another bit about "Module management" -- is it purely meant for turning on and off modules or should there be an access to each modules settings? There was time before the menu system when in module list every module had a "configure/settings" link next to them -- the historical roots of the _settings() hook. Now as every module can populate pages anywhere there is no single entrypoint for module settings any more Whatever smart card sorting we do there is never a point when we could come up with ideal administration menu structure. Sure, it should be done but it fixes a small part of the whole experience. So what does it left us? There are several areas we could work on: 1) comprehensive style guides for developers to find the right menu layout for their contributed modules was already mentioned. Do we need "menu police"? 2) Map out what we have. There is a requirement for a script what generates a full menu tree based on: - default modules - all core modules - all contributed modules (yay) in addition for just pushing out [ul] list, it should also mark tabs and subtabs in order to analyse the situation better 3) Gather existing work. My collected pointers: http://www.surveymonkey.com/DisplaySummary.asp?SID=1425065&U=142506581557 http://www.oscms-summit.org/events/drupal-usability-issues http://www.flossusability.org/wiki.pl?CivicSpaceMenuLearnings Whatever happened to that (Vacouver? Civicspage? Bryght?) card sort thing? 4) sort out the "tabs mess" what have happened. Although it was a hard struggle to get it working, it was obvious from the start that open-endedness of menu tree and strict UI limits of the 2-level tabs can never properly work. Over the time poor tabs got misused and mistreated, the notorious "tabs inside tabs" in content filters and several other places, abusing the "tab title should be a task-specific verb like "list", "configure"" rule. Add primary and secondary links as "tabs" too and it gets even more messy. 5) It's all about _discovery_ of settings, right? How does it work right now? I would imagine couple of ways: -- out-of-the box experience, users rely on logic of predefined menu structure, optionally turn to cross-links or read help (they need to go a separate administer/help page to do it) -- enabling more core modules. How discovering the new menu fresh items work I do not know, possibly exploring the menu tree with "hey, this is new" moments (or relying on browser's not-yet-visited link differentiation). There is also new help sections available in administer/help but there is no direct path between enabling<>help as in reading contributed readme's (see below) -- enabling contributed modules. It's mostly about reading readme.txt/install.txt where is (hopefully) a setup/settings guide with menu paths and there might also be help pages Possible improvements (some of them silly ;) -- improve the module intialization and feature discovery flow: tie closer module listings, enabling modules and related help/usage guide. (do I remember correctly there were once a "help" link on each module in module config screen? I am not saying this is the way to go though) -- there used to be links from module settings pages directly to a help pages, but now those are gone. why? -- for recently enabled modules' menu item add red "new" markings so they stick out while browsing the admin pages. It can be problemsome though: enabling many modules in the same time takes you to go reddie hell. But this is just a suggestion for direction not a concrete proposal -- work on integrating search and admin pages so people can rely on search for navigating administration. Index help texts, have alternative wordings and synonymes and task-centric phrases for menu titles and feed that data into a autosuggest search field a la Spotlight in OSX Preferences panel 6) make module taxonomy http://drupal.org/project/Modules/category work closely together with Drupal administration screen structure - try to sync the structures and labels - give some stucture for module configuration pages?

13 30

Release critical bugs for July 30, 2006
by drupal-devel＠drupal.org 30 Jul '06

30 Jul '06

/ bug reports 4.7 Beta/ CVS Errors assigned: msameer age: 18 weeks 2 days url: http://drupal.org/node/55533 / bug reports Adding user to buddy list does not work age: 4 days 16 hours url: http://drupal.org/node/75520 / bug reports Localization problem age: 9 weeks 6 days url: http://drupal.org/node/64847 No check for loading chatbox with other name age: 35 weeks 5 days url: http://drupal.org/node/38397 / bug reports update for deprecated settings hook age: 2 weeks 10 hours url: http://drupal.org/node/73917 / bug reports User warning: unknown column age: 5 weeks 3 days url: http://drupal.org/node/70131 event_start not being set age: 9 weeks 2 days url: http://drupal.org/node/65609 Next link will not show for Junes events age: 11 weeks 7 hours url: http://drupal.org/node/63454 Fatal Error After activating "Browse Scheduled Events" in modules age: 12 weeks 2 days url: http://drupal.org/node/61920 Event module preventing me from uploading age: 14 weeks 1 day url: http://drupal.org/node/59775 INSTALL.txt incorrect age: 14 weeks 6 days url: http://drupal.org/node/59019 event calendars off by day/not respecting timezones - fix? age: 17 weeks 5 days url: http://drupal.org/node/56189 Flexinode generates an error age: 18 weeks 4 days url: http://drupal.org/node/55135 Body text missing age: 19 weeks 2 days url: http://drupal.org/node/54383 Calendar subscribing not working age: 19 weeks 4 days url: http://drupal.org/node/54036 Problem Selecting Event by Type age: 20 weeks 4 days url: http://drupal.org/node/52883 Drupal Event age: 31 weeks 4 days url: http://drupal.org/node/41833 Event start and end times not getting saved in database age: 32 weeks 2 days url: http://drupal.org/node/41300 Issues with list view for events age: 33 weeks 6 days url: http://drupal.org/node/39943 Database error keeps popping up age: 34 weeks 4 days url: http://drupal.org/node/39396 Date problem on calendar, off by a day age: 34 weeks 5 days url: http://drupal.org/node/39193 Events module bugs adding and changeing events age: 35 weeks 2 hours url: http://drupal.org/node/39016 gmdate() warnings on windows install age: 1 year 4 weeks url: http://drupal.org/node/26140 / feature requests ical subscription capablility assigned: jbird(a)drupal.org age: 1 week 1 day url: http://drupal.org/node/74879 / support requests Blank Page After Submit age: 15 weeks 16 hours url: http://drupal.org/node/58918 Can't Administer Event Module age: 29 weeks 2 days url: http://drupal.org/node/43509 displaying event start info in flexinode tabular view? age: 42 weeks 4 days url: http://drupal.org/node/33019 Event block missing content of many fields age: 45 weeks 2 hours url: http://drupal.org/node/31532 / bug reports ArrayMerge Errors with PHP5 age: 22 weeks 1 day url: http://drupal.org/node/51174 / bug reports Embedded G2: blank pages with Gallery Block enabled age: 11 weeks 1 day url: http://drupal.org/node/63326 errors on cron run and in watchdog age: 11 weeks 6 days url: http://drupal.org/node/62335 IE error using embed not error with none-embed... age: 12 weeks 1 day url: http://drupal.org/node/62119 Gallery module render wrong size with 4.7b5 age: 20 weeks 5 days url: http://drupal.org/node/52706 block manage - Block specific settings can save item selected - with drupal 4.7B4 age: 21 weeks 6 days url: http://drupal.org/node/51436 Gallery Module Settings Fatal Error age: 23 weeks 6 days url: http://drupal.org/node/49046 Latest patch hosed my G2 integration and G2 Standalone age: 34 weeks 5 days url: http://drupal.org/node/39168 problem viewing newly added photos in embedded gallery. age: 35 weeks 6 days url: http://drupal.org/node/38352 problem viewing newly added photos in embedded gallery. assigned: trobison age: 35 weeks 6 days url: http://drupal.org/node/38351 Full screen slideshow in Gallery module is not working (erroring out on the wrong URL) age: 1 year 3 weeks url: http://drupal.org/node/26479 / feature requests Unable to initialize embedded Gallery age: 23 weeks 4 days url: http://drupal.org/node/49417 / support requests Gallery Module stopped working age: 33 weeks 5 days url: http://drupal.org/node/40117 import existing gallery2 user account age: 38 weeks 5 days url: http://drupal.org/node/35920 / feature requests po files and other language support age: 26 weeks 4 days url: http://drupal.org/node/46313 / feature requests Goofy Forum UI age: 43 weeks 5 days url: http://drupal.org/node/32294 / bug reports if Clean URLs is Enabled, upload_image in htmlarea not working age: 1 week 5 days url: http://drupal.org/node/74119 htmlArea/xinha firefox freezes (multiple textareas) age: 8 weeks 2 days url: http://drupal.org/node/66746 Layout is quirky age: 20 weeks 5 days url: http://drupal.org/node/52741 view source broken in firefox 1.5 age: 26 weeks 4 days url: http://drupal.org/node/46246 Toolbar won't display correct in IE 6 with Pushbutton Theme age: 46 weeks 2 days url: http://drupal.org/node/30696 / support requests Problem with size of button assigned: khayman age: 13 weeks 5 days url: http://drupal.org/node/60255 / bug reports No thumbnails will show.. age: 1 week 2 days url: http://drupal.org/node/74770 Preview and thumbnail creation appears to fail when images are larger than a certain size age: 1 week 6 days url: http://drupal.org/node/73986 Localization issue for Premiew and Thumbnail links age: 5 weeks 2 days url: http://drupal.org/node/70396 Category module and image_gallery age: 9 weeks 5 days url: http://drupal.org/node/65066 Problem in Image Gallery display especially in Internet Explorer age: 22 weeks 2 days url: http://drupal.org/node/50943 By CHanging the following the error changes assigned: walkah age: 32 weeks 2 days url: http://drupal.org/node/41353 imagemagick.inc file does not contain the function... age: 37 weeks 15 hours url: http://drupal.org/node/37372 Error when Submitting New Image Node age: 37 weeks 15 hours url: http://drupal.org/node/37366 only variables can be passed by reference on line 713 age: 38 weeks 3 days url: http://drupal.org/node/36092 image.module 4.6.0 strange actions age: 42 weeks 2 days url: http://drupal.org/node/33292 File copy failed: source file does not exist error after running update-image.php age: 44 weeks 4 days url: http://drupal.org/node/31816 Path for image folder not inserted correctly when nodetype = image age: 47 weeks 4 days url: http://drupal.org/node/30031 image module patch & image_import module age: 48 weeks 6 days url: http://drupal.org/node/29377 image module fails on dual site configuration age: 1 year 2 weeks url: http://drupal.org/node/26657 Cannot upload .jpgs age: 1 year 21 weeks url: http://drupal.org/node/18076 / feature requests Copying original age: 38 weeks 2 days url: http://drupal.org/node/36321 / support requests showing the galleries separately age: 5 weeks 1 day url: http://drupal.org/node/70499 upload image wont' display, it show a file not found page age: 17 weeks 3 days url: http://drupal.org/node/56491 I need to change the style of displaying each node. Please help. age: 29 weeks 6 days url: http://drupal.org/node/43017 What does update-image.php do exactly? age: 31 weeks 1 day url: http://drupal.org/node/42222 images not showing2 age: 34 weeks 1 day url: http://drupal.org/node/39773 Image Folder Permissions age: 40 weeks 1 day url: http://drupal.org/node/34839 Image Module Permissions age: 1 year 3 weeks url: http://drupal.org/node/26280 / bug reports user lookup on name only assigned: zeroj age: 17 weeks 4 hours url: http://drupal.org/node/56936 Link to mailhandler does not use l() function age: 28 weeks 1 day url: http://drupal.org/node/44599 Listhandler caused error in "comment.module on line 996" ? age: 38 weeks 2 days url: http://drupal.org/node/36244 Listhandler 4.6.0 fails to send emails at all age: 1 year 1 week url: http://drupal.org/node/27095 / tasks Correct/Complete Documentation age: 40 weeks 16 hours url: http://drupal.org/node/34909 / support requests Creating a page using mailhandler age: 6 weeks 4 days url: http://drupal.org/node/68947 Mail Body not downloaded age: 29 weeks 3 days url: http://drupal.org/node/43374 / bug reports Update: beta5 and possible problem with php 4 age: 21 weeks 3 days url: http://drupal.org/node/52004 Patch for member.module to bring it up to 4.7 age: 25 weeks 1 day url: http://drupal.org/node/47829 foreach() assigned: neablo age: 30 weeks 5 days url: http://drupal.org/node/42350 / feature requests Enable nodewords for node type? age: 24 weeks 1 day url: http://drupal.org/node/48869 / bug reports nodes are being created with no body age: 33 weeks 3 days url: http://drupal.org/node/40373 missing promote column assigned: Bèr Kessels age: 35 weeks 1 day url: http://drupal.org/node/38836 Naming issues with files and DB tables age: 40 weeks 6 days url: http://drupal.org/node/34298 RSS "no element found at line 1" age: 1 year 4 weeks url: http://drupal.org/node/26185 Outdated help texts age: 1 year 51 weeks url: http://drupal.org/node/9692 Import doesn't like XML/RSS feeds with no Title element age: 2 years 8 weeks url: http://drupal.org/node/8128 / tasks move XML-parser into an inclde file. age: 1 year 5 weeks url: http://drupal.org/node/25439 / bug reports Content published by scheduler not mailed out age: 7 weeks 5 days url: http://drupal.org/node/67475 Notify not playing well with Organic Groups age: 32 weeks 5 days url: http://drupal.org/node/40967 / bug reports Login as an alias gets cached age: 44 weeks 5 days url: http://drupal.org/node/31699 / bug reports Malformed PDFs age: 30 weeks 6 days url: http://drupal.org/node/42312 support dynamic content? age: 36 weeks 1 day url: http://drupal.org/node/38181 please explain html2fpdf age: 36 weeks 4 days url: http://drupal.org/node/37748 Management of french charaters age: 37 weeks 6 days url: http://drupal.org/node/36605 / support requests Problem with PDFView age: 27 weeks 5 days url: http://drupal.org/node/45092 / bug reports Replying to a message from a person who doesn't accept private messages leads to blank screen age: 17 weeks 5 days url: http://drupal.org/node/56136 privatemsg module: - database error - incompatibility with relationship module age: 24 weeks 1 day url: http://drupal.org/node/48866 anonymous users can create folders and view all anonymous sent-mail age: 32 weeks 2 days url: http://drupal.org/node/41361 Reminder email links don't work age: 1 year 5 weeks url: http://drupal.org/node/25677 / bug reports "issues" page: search criteria reset when viewing custom search results pages 2-"last" age: 5 weeks 6 days url: http://drupal.org/node/69626 Tagging of Sub-projects. age: 9 weeks 4 days url: http://drupal.org/node/65110 attachements missing after pressing preview age: 14 weeks 6 days url: http://drupal.org/node/59039 upper right search form on issue pages is broken age: 16 weeks 6 days url: http://drupal.org/node/57023 Can't attach patch to initial issue post age: 17 weeks 6 days url: http://drupal.org/node/55984 SQL errors on issues and my projects pages age: 31 weeks 2 days url: http://drupal.org/node/42160 Issues from multiple projects listed on a single issue's page age: 35 weeks 3 days url: http://drupal.org/node/38704 Get disconnected from server on attempting to add an issue age: 38 weeks 3 days url: http://drupal.org/node/36124 issue query table: can't select all projects assigned: dww age: 42 weeks 2 days url: http://drupal.org/node/33262 Projects not listed and page not complete age: 1 year 8 weeks url: http://drupal.org/node/23956 / feature requests Need Documentation age: 33 weeks 2 days url: http://drupal.org/node/40392 Allow subscription to individual project issues age: 40 weeks 4 days url: http://drupal.org/node/34496 / support requests Project is unusable (to me) assigned: dww age: 2 weeks 3 days url: http://drupal.org/node/73460 Fatal error: Only variables can be passed by reference age: 19 weeks 4 days url: http://drupal.org/node/53984 Add the project release manually without the scan feature age: 40 weeks 4 days url: http://drupal.org/node/34500 / tasks New method for contributed project releases and versions age: 15 weeks 6 days url: http://drupal.org/node/58066 / bug reports PHP Fatal error: Call to undefined function: form_textarea() in [drupal root]\modules\recipe\recipe.module on age: 9 weeks 4 days url: http://drupal.org/node/65168 Node not added after filling in ad recipe template age: 14 weeks 3 days url: http://drupal.org/node/59548 Error with URL to recipe age: 47 weeks 6 days url: http://drupal.org/node/29885 / tasks recipe module not security checked age: 19 weeks 2 days url: http://drupal.org/node/54431 / bug reports Argument #1 is not an array age: 6 weeks 2 days url: http://drupal.org/node/69286 Cron job creates SQL error age: 8 weeks 5 days url: http://drupal.org/node/66202 / bug reports Enable Subscriptions module -> no comments are shown anymore age: 2 weeks 2 days url: http://drupal.org/node/73666 / bug reports Error on Page with Internet Explorer 6 age: 6 weeks 4 days url: http://drupal.org/node/68906 Taxonomy DHTML's cache ignores user privileges age: 10 weeks 1 day url: http://drupal.org/node/64532 IE hangs on loading js or when clicking before before page finishes loading age: 18 weeks 1 hour url: http://drupal.org/node/55924 taxonomy_dhtml breaks security? age: 30 weeks 3 days url: http://drupal.org/node/42531 Does not work correctly in Internet Explorer age: 42 weeks 1 day url: http://drupal.org/node/33354 Blocks switch and reset when vocabs are modified age: 1 year 11 weeks url: http://drupal.org/node/22631 javascrip downloads square.gif for every category age: 1 year 23 weeks url: http://drupal.org/node/17366 / feature requests A unique page for each category group? age: 40 weeks 3 days url: http://drupal.org/node/34610 / bug reports Taxonomy links only work for the first line of links assigned: PierreFWalter age: 22 weeks 1 day url: http://drupal.org/node/51149 / support requests Taxonomy has dissapeared age: 42 weeks 4 days url: http://drupal.org/node/33061 / bug reports Sends trackbacks for unpublished nodes assigned: ankur age: 1 year 26 weeks url: http://drupal.org/node/16239 / bug reports Fatal error for Drupal 4.7.0 installed with Fantastico age: 4 weeks 3 days url: http://drupal.org/node/71407 Sometimes when I open the drupal site in My Local machine I am getting the error. age: 20 weeks 6 days url: http://drupal.org/node/52652 Event start/end date section should *not* show first on Submit event page age: 31 weeks 4 days url: http://drupal.org/node/41869 meet age: 32 weeks 4 days url: http://drupal.org/node/40996 / feature requests A better Drupal.org Index (homepage) interface/layout mockup age: 26 weeks 6 days url: http://drupal.org/node/45967 A small but effective improvement to Improvement of admin/user accessability suggestion age: 41 weeks 1 day url: http://drupal.org/node/34073 / support requests block module / side-content module age: 11 weeks 5 days url: http://drupal.org/node/62506 Acess denied to login Newly installed and upgraded site that I need up and running A.S.A.P assigned: Johnny age: 36 weeks 16 hours url: http://drupal.org/node/38227 / bug reports Logging out error age: 17 weeks 2 days url: http://drupal.org/node/56663 / bug reports the wiki module can't work with HTML age: 25 weeks 5 days url: http://drupal.org/node/47124

1 0

Accessing global $user from login_destination
by Timm 29 Jul '06

29 Jul '06

Hi, first post, hope i'm in the right place. I can't find a way to get the current user->uid while inside a function within the login_destination module. $user->uid is always null, logged in/not, no matter who I'm logged in as. In my other code, this type of call works either with user->uid or account->uid. function login_destination_get_destination() { global $user; $username = $user->uid; //$user->uid is always null. Can you tell me what I should be looking for, or why I can't globally call the $user->id? Or is there a separate function that will return the current user->uid? Within the user.module, I was able to call $account->uid, and in some example code posted to the forum about how to use the module it says you can call global $user and pull attributes from there, but it's always null. Any ideas? thanks!

1 0

Re: [development] Database queries on drupal.org
by Ken Rickard 29 Jul '06

29 Jul '06

Larry- I'm not claiming to be an expert, but two approaches that we used in 4.6 on SavannahNow.com can really cut db queries. I have opened issues for both. The first covers path aliasing and allows admins to define the lookup paths that are allowed. In practice, it removes all 'admin' and similar paths from drupal_lookup_path(). http://drupal.org/node/75976 The second is object-caching. The _load functions in Drupal tend to run more often than ideal. Repetitive node_load() calls are lkely due to different modules having to run node_load() to ensure that the node object they need is available, Object caching _might_ help with this. http://drupal.org/node/74020 These are -- I should stress -- both experiments. They need to be tested in large environments (like drupal.org, or scratch.drupal.org) to see if they actually buy us any performance. - Ken Rickard agentrickard Message: 5 > Date: Fri, 28 Jul 2006 10:49:07 -0500 (CDT) > From: "Larry Garfield" <larry(a)garfieldtech.com> > Subject: Re: [development] Database queries on drupal.org > To: development(a)drupal.org > Message-ID: > <1731.70.90.124.113.1154101747.squirrel(a)webmail.garfieldtech.com> > Content-Type: text/plain;charset=iso-8859-1 > > On Fri, July 28, 2006 9:39 am, Gerhard Killesreiter said: > > > I have now stopped the data collecting. > > > >> Here are the first queries by accumulated time. > > > The first column is accumulated time, the second average time/query, the > > third the number of times the query was run, the fourth the function > > which calls the query, the last the query itself: > > > 12585.885 0.01 1322443 cache_get SELECT data, created, > headers, expire > > FROM cache WHERE cid = S > > 7524.278 0.001 6814856 drupal_lookup_path SELECT dst FROM > url_alias > > WHERE src = S > > 6062.889 0.107 56508 theme_forum_topic_navigation SELECT > n.nid, n.title, > > n.sticky, l.comment_count, l.last_comment_timestamp FROM node n INNER > > JOIN node_comment_statistics l ON n.nid = l.nid INNER JOIN term_node r > > ON n.nid = r.nid AND r.tid = D > > 4343.435 0.024 183059 node_load SELECT n.nid, n.vid, > n.type, n.status, > > n.created, n.changed, n.comment, n.promote, n.moderate, n.sticky, > > r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, > > r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users > > u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE > > n.nid = D > > 1837.531 0.04 45429 node_load SELECT n.nid, n.vid, > n.type, n.status, > > n.created, n.changed, n.comment, n.promote, n.moderate, n.sticky, > > r.timestamp AS revision_timestamp, r.title, r.body, r.teaser, r.log, > > r.format, u.uid, u.name, u.picture, u.data FROM node n INNER JOIN users > > u ON u.uid = n.uid INNER JOIN node_revisions r ON r.vid = n.vid WHERE > > n.nid = S > > 1538.485 0.011 143889 cache_set INSERT INTO cache (cid, > data, created, > > expire, headers) VALUES (S) > > > >> Here are the first few queries by average query time, columns as above. > > > 1343.749 3.262 412 pager_query SELECT DISTINCT(n.nid), > n.title, n.type, > > n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, > > l.comment_count FROM node n INNER JOIN users u ON n.uid = u.uid INNER > > JOIN node_comment_statistics l ON n.nid = l.nid WHERE n.status = D > > 1045.001 2.969 352 pager_query SELECT DISTINCT(n.nid), > n.title, n.type, > > n.changed, n.uid, u.name, l.last_comment_timestamp AS last_post, > > l.comment_count FROM node n INNER JOIN node_comment_statistics l ON > > n.nid = l.nid INNER JOIN users u ON n.uid = u.uid LEFT JOIN comments c > > ON n.nid = c.nid AND (c.status = D > > 628.091 1.784 352 pager_query SELECT COUNT(DISTINCT( > n.nid)) FROM node n > > LEFT JOIN comments c ON n.nid = c.nid AND (c.status = D > > 1091.909 1.327 823 pager_query SELECT DISTINCT m.*, r.*, > u.name, u.uid > > FROM cvs_messages m INNER JOIN cvs_repositories r ON m.rid = r.rid INNER > > JOIN users u ON m.uid = u.uid ORDER BY m.created DESC LIMIT D > > 19.668 1.093 18 eval select message, count(message) as > count from > > watchdog where type = S and uid = D > > 147.989 1.08 137 cache_get DELETE FROM cache WHERE > expire != D > > 1.03 1.03 1 pager_query SELECT a.aid, a.timestamp, a.url, > a.uid, u.name > > FROM accesslog a LEFT JOIN users u ON a.uid = u.uid WHERE a.path LIKE S > > ORDER BY a.timestamp DESC LIMIT D > > 10.087 0.56 18 eval select message, count(message) as > count from > > watchdog where type = S and uid != D > > 136.43 0.493 277 pager_query SELECT COUNT(DISTINCT( > n.nid)) FROM node n > > INNER JOIN project_issues p ON p.nid = n.nid INNER JOIN node_revisions r > > ON r.vid = n.vid INNER JOIN users u ON p.assigned = u.uid LEFT JOIN > > project_comments c ON c.nid = p.nid WHERE n.status = D > > 132.688 0.479 277 pager_query SELECT DISTINCT(n.nid) > FROM node n INNER > > JOIN project_issues p ON p.nid = n.nid INNER JOIN node_revisions r ON > > r.vid = n.vid INNER JOIN users u ON p.assigned = u.uid LEFT JOIN > > project_comments c ON c.nid = p.nid WHERE n.status = D > > 1247.877 0.473 2640 do_search CREATE TEMPORARY TABLE > temp_search_sids > > SELECT i.type, i.sid, SUM(i.score * t.count) AS relevance, COUNT(*) AS > > matches FROM search_index i INNER JOIN search_total t ON i.word = t.word > > INNER JOIN node n ON n.nid = i.sid INNER JOIN users u ON n.uid = u.uid > > WHERE n.status = D > > 0.933 0.466 2 aggregator_page_sources SELECT f.fid, f.title, > > f.description, f.image, MAX(i.timestamp) AS last FROM aggregator_feed f > > LEFT JOIN aggregator_item i ON f.fid = i.fid GROUP BY f.fid, f.title, > > f.description, f.image ORDER BY last DESC, f.title > > 0.429 0.429 1 pager_query SELECT q.qid, q.query, q.function, > t.*, > > COUNT(t.qid) AS count, SUM(t.time) AS total_time, AVG(t.time) AS > > average, STDDEV(t.time) AS stddev FROM devel_queries q INNER JOIN > > devel_times t ON q.qid = t.qid GROUP BY t.qid ORDER BY total_time DESC > > LIMIT D > > 9.767 0.425 23 do_search CREATE TEMPORARY TABLE > temp_search_sids SELECT > > i.type, i.sid, SUM(i.score * t.count) AS relevance, COUNT(*) AS matches > > FROM search_index i INNER JOIN search_total t ON i.word = t.word INNER > > JOIN node n ON n.nid = i.sid INNER JOIN term_node tn ON n.nid = tn.nid > > INNER JOIN users u ON n.uid = u.uid WHERE n.status = D > > 6.014 0.401 15 pager_query SELECT uid, access FROM users > WHERE uid > D > > 0.372 0.372 1 pager_query SELECT COUNT(*) FROM accesslog a > LEFT JOIN > > users u ON a.uid = u.uid WHERE a.path LIKE S > > 96.123 0.364 264 forum_get_forums SELECT r.tid, > COUNT(n.nid) AS > > topic_count, SUM(l.comment_count) AS comment_count FROM node n INNER > > JOIN node_comment_statistics l ON n.nid = l.nid INNER JOIN term_node r > > ON n.nid = r.nid WHERE n.status = D > > 42.274 0.282 150 cache_clear_all DELETE FROM cache WHERE > cid = S > > > To my admittedly non-expert eye, this suggests a few (probably obvious, > but I'll say them anyway) observations: > > - The cache system and path alias system are far and away the most > database-intensive systems in Drupal, by over an order of magnitude. In > both cases, though, it's more due to frequency of call than to complexity. > Simply reducing the number of queries should help more than trying to > simplify them. > > - Someone needs to get that query out of the forum module's theme code. > :-) > > - Node loading is also db-intensive (who'd a thunk it, right?) > > - If node_load()'s main query is called that often, I wonder what else > it's doing in the same routine? A given node is loaded by several > queries, which would probably make the function more expensive than it > seems from these logs. > > - Pagers are expensive, which I don't think is much of a surprise. > > - Flushing the cache is non-cheap. I recall a while back someone > mentioning MySQL's "deferred" functionality, which could be useful here. > (If it takes an extra half-second for a cache-flush to commit, that's > probably not a problem for the business logic.) > > I'm sure some other database experts will have more insightful commentary. > :-) > > --Larry Garfield > > > >

1 0

RE: [development] the past, present and future of drupal admin
by Steven Peck 29 Jul '06

29 Jul '06

> -----Original Message----- > From: development-bounces(a)drupal.org > [mailto:development-bounces@drupal.org] On Behalf Of Jeremy Epstein > > Just a quick example from another piece of software (and yes, people > can complain that Microsoft is evil and that it produces buggy > software, but they can't complain that its software is terribly hard > to use). In Windows XP, the 'control panel' groups administrative > tasks logically. There is no 'settings' icon within the Windows > control panel. However, within the 'Display' area, there is a > 'settings' tab (for 'global' settings, such as your screen > resolution), along with 'sets-of-data' things, such as colour schemes > and screen savers. Same with the 'User Accounts' area: the management > of individual user accounts is right in there with the 'general user > settings'. Certainly something to consider. > > Cheers, > Jaza. I feel the need to mention something here. While I realize the example provided is an example and I am the guy that definitly uses MS the example above is not complete as I have a very different experience with it. The Windows XP control panel offers multiple views. A classic and category. These views are can also be controlled by policy settings locally or from a domain level, etc. Frankly, I find the the 'category view to be hard to understand and find things consistently. Part of this is training and experience and part of this is that some of the categorizations do not make sense to me. Also, in your Display example. There exists Video drivers that extend the options available and many times these options are not presented in a manner that makes sense. (nVidia drivers for instance). This gives an effect not unlike some contrib modules. The user accounts button example is also incomplete. If you have a more complex envirnoment, it is not in fact something you use. You use a different tool to manage user accounts in a domain environment including local accounts so never learn about these settings in a domain environment. So, what's my point of dragging in the different and advanced options of this example? (Well, someone used an example from my field. :D ) Well not that, but this .... It really doesn't matter what interface we eventually go with because people are going to have to learn it. That it takes lessons from the current GUI 'norms' (assuming such exist) is good. What does matter is that we decide on rules and guidelines for it. Then we publish those rules and guidelines for contrib. AND we try to be consistent about the logic for placement. Any interface will need to be learned no matter what. As long as we are consistent about it, it will less of a curve. Drupal is still not a 'simple' thing to use and despite the fact that it is getting easier it doesn't mean easy. :D. The Drupal admin interface has been evolving. I think Earl's admin interface patch is a step in the right direction. It's been worked on and gotten a lot of good feedback to refine it. I think that it can be fine-tuned over time from this starting point, but it's pretty darn good now. -sp

2 1

RE: [development] the past, present and future of drupal admin
by Steven Peck 29 Jul '06

29 Jul '06

http://drupal.org/node/63601 <quote> There are two configuration screens that deal with these links: On admin >> settings >> menu you choose which menu is used for the primary links and which for the secondary links. If you have added items to the default "Primary Links" menu and they are not showing up, check to make sure the option on this page hasn't been changed to "No Primary Links". </quote> The verbage is assumed there. Probably could benefit from having words added to effect. Feel free to send them to me offlist and I will edit it. > -----Original Message----- > From: development-bounces(a)drupal.org > [mailto:development-bounces@drupal.org] On Behalf Of Chris Johnson > Sent: Friday, July 28, 2006 6:36 PM > To: development(a)drupal.org > Subject: Re: [development] the past, present and future of > drupal admin > > Neither of which say anything about getting rid of the "Edit > Primary Links" > link, which seems to be somehow tied to the themes, because > deleting the > primary links menu item does not make it go away. > > Steven Peck wrote: > > Handbook > > http://drupal.org/node/63601 > > http://drupal.org/node/59467 > > > >> -----Original Message----- > >> From: development-bounces(a)drupal.org > >> [mailto:development-bounces@drupal.org] On Behalf Of Neil Drumm > >> Sent: Thursday, July 27, 2006 2:28 PM > >> To: development(a)drupal.org > >> Subject: Re: [development] the past, present and future of > >> drupal admin > >> > >> Earl Miles wrote: > >>> Talk about a common question on #drupal-support, too. > 'Edit Primary > >>> Links' takes you to admin/menu but if you want to just get > >> rid of the > >>> link, you actually have to go to admin/settings/menu ... > >> I actually didn't know that setting could be used to get rid of the > >> links until now. I've been deleting the call from themes. > >> > >> -- > >> Neil Drumm > >> http://delocalizedham.com/ > >> > >> > > > > > > >

1 0

RE: [development] the past, present and future of drupal admin
by Steven Peck 29 Jul '06

29 Jul '06

Handbook http://drupal.org/node/63601 http://drupal.org/node/59467 > -----Original Message----- > From: development-bounces(a)drupal.org > [mailto:development-bounces@drupal.org] On Behalf Of Neil Drumm > Sent: Thursday, July 27, 2006 2:28 PM > To: development(a)drupal.org > Subject: Re: [development] the past, present and future of > drupal admin > > Earl Miles wrote: > > Talk about a common question on #drupal-support, too. 'Edit Primary > > Links' takes you to admin/menu but if you want to just get > rid of the > > link, you actually have to go to admin/settings/menu ... > > I actually didn't know that setting could be used to get rid of the > links until now. I've been deleting the call from themes. > > -- > Neil Drumm > http://delocalizedham.com/ > >

2 1

Developing modules for a photo agency
by Hannes Lilljequist 28 Jul '06

28 Jul '06

Hi! (Sorry if this is was already posted - but I don't think it was.) I am (slowly) developing a site for a small independent photo agency. I feel that a lot of the functionality that I need is already in Drupal core and contrib, but there are certain points that I need to address, probably through developing a few new modules. (Theming is obviously an important part of it too, but that's another story.) I have a few ideas on how to implement the functionality that I need and some choices to make, so I'm hoping for some comments and wisdom from the community. Also, if someone else is already doing or has done anything like this, that would be good to know. Hopefully this could turn into a solution that other picture agencies can use, or even better, a set of general modules that can be used in many different contexts. In short, I need too look at: 1) the handling of large image files and the quality of resized images, 2) a specific image search function, and 3) ecommerce integration. To keep this message short I'm saving the details, but I made a post in the forums describing my thoughts so far. If your'e interested or have experience in any of these areas - please take a look! http://drupal.org/node/75282 Thanks! /Hannes - zoo33

3 6

Fwd: [SECURITY] [DSA 1125-1] New drupal packages fix execution of arbitrary web script code
by Bèr Kessels 28 Jul '06

28 Jul '06

Just a FYI. Also to let you people know that 4.5* is not as dead as we might want/think. ---------- Doorgestuurd bericht ---------- Subject: [SECURITY] [DSA 1125-1] New drupal packages fix execution of arbitrary web script code Date: woensdag 26 juli 2006 23:20 From: Moritz Muehlenhoff <jmm(a)debian.org> To: debian-security-announce(a)lists.debian.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 - -------------------------------------------------------------------------- Debian Security Advisory DSA 1125-1 security(a)debian.org http://www.debian.org/security/ Moritz Muehlenhoff July 26th, 2006 http://www.debian.org/security/faq - -------------------------------------------------------------------------- Package : drupal Vulnerability : several Problem-Type : remote Debian-specific: no CVE ID : CVE-2006-2742 CVE-2006-2743 CVE-2006-2831 CVE-2006-2832 CVE-2006-2833 Debian Bug : 368835 Several remote vulnerabilities have been discovered in the Drupal web site platform, which may lead to the execution of arbitrary web script. The Common Vulnerabilities and Exposures project identifies the following problems: CVE-2006-2742 A SQL injection vulnerability has been discovered in the "count" and "from" variables of the database interface. CVE-2006-2743 Multiple file extensions were handled incorrectly if Drupal ran on Apache with mod_mime enabled. CVE-2006-2831 A variation of CVE-2006-2743 was adressed as well. CVE-2006-2832 A Cross-Site-Scripting vulnerability in the upload module has been discovered. CVE-2006-2833 A Cross-Site-Scripting vulnerability in the taxonomy module has been discovered. For the stable distribution (sarge) these problems have been fixed in version 4.5.3-6.1sarge1. For the unstable distribution (sid) these problems have been fixed in version 4.5.8-1.1. We recommend that you upgrade your drupal packages. Upgrade Instructions - -------------------- wget url will fetch the file for you dpkg -i file.deb will install the referenced file. If you are using the apt-get package manager, use the line for sources.list as given below: apt-get update will update the internal database apt-get upgrade will install corrected packages You may use an automated update by adding the resources from the footer to the proper configuration. Debian GNU/Linux 3.1 alias sarge - -------------------------------- Source archives: http://security.debian.org/pool/updates/main/d/drupal/drupal_4.5.3-6.1sarge1 .dsc Size/MD5 checksum: 625 8323ad6164c5beb6e9c7631272fbaee8 http://security.debian.org/pool/updates/main/d/drupal/drupal_4.5.3-6.1sarge1 .diff.gz Size/MD5 checksum: 83802 35863480a9da96adbe6731b014d204c8 http://security.debian.org/pool/updates/main/d/drupal/drupal_4.5.3.orig.tar. gz Size/MD5 checksum: 471540 bf093c4c8aca7bba62833ea1df35702f Architecture independent components: http://security.debian.org/pool/updates/main/d/drupal/drupal_4.5.3-6.1sarge1 _all.deb Size/MD5 checksum: 506884 e4cdba2730662752d8f83fc101ab58a5 These files will probably be moved into the stable distribution on its next update. - ---------------------------------------------------------------------------- ----- For apt-get: deb http://security.debian.org/ stable/updates main For dpkg-ftp: ftp://security.debian.org/debian-security dists/stable/updates/main Mailing list: debian-security-announce(a)lists.debian.org Package info: `apt-cache show <pkg>' and http://packages.debian.org/<pkg> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) iD8DBQFEx9wrXm3vHE4uyloRAsWtAKDoQf4DhL4eqpPLmDuifZ/Rh4h61gCggvrQ zwceOEHQ/r/GyRU2L5X9vd8= =V7nw -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-security-announce-REQUEST(a)lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmaster(a)lists.debian.org ------------------------------------------------------- -- | Bèr Kessels | webschuur.com | Drupal, Joomla and Ruby on Rails web development | | Jabber & Google Talk: ber(a)jabber.webschuur.com | | http://bler.webschuur.com | http://www.webschuur.com |

16 22