- Development - lists.drupal.org

[neclimdul@gmail.com: Fwd: [development] LinksDB vs. Links]
by Sammy Spets 03 Aug '06

03 Aug '06

Hi all, > * Your SQL queries will not work on PostgreSQL. It needs > db_query('word "%s" word') not db_query("word '%s' word"). For the reference of those that don't know yet, the correct way for both MySQL and PostgreSQL is: db_query("word '%s' word"); Strings in ALL database systems must be encased in single quotes. If you do otherwise you're breaking the SQL standard. Cheers, -- Sammy Spets Synerger Pty Ltd http://www.synerger.com/ * You use double spaces after sentences in _report_submit. * Listen, I know I said you shouldn't use drupal_goto a few bullets ago. That doesn't mean you go and use drupal_set_header with a Location: instead. Man alive. * Oh, and you're passing ; at the end of most of your SQL queries. You don't need to do that either. * You use "'<Root>'" in linksdb_deadlinks, and '<Root>' in linksdb_suggest. Which is it? (For what it's worth, it should be '<'. t('root') .'>', per Drupal core). * To prevent things like "select * from {links_links} where dead=1 order by {links_links}.name", use table abbreviations, like: "select * from {links_links} ll where dead=1 order by _l_l_._n_a_m_e". * if(variable_get('linksdb_show_report',1)==1) - you don't need ==1. * linksdb_deadlinks doesn't translate the report messages. * You use "links/report/$link->id" and then 'links/refer/' . $link->id. Which is it? Concatenation or interpolation? * Oooh, you do know how to predeclare $form = array() in _suggest(). I guess you must have made sloppy mistakes all the other times. Story of your life, eh? * "({name},{url},{description},{active},{category})" - I have no clue what you're even attempting there. Column names aren't prefixed. * Is it site staff or site administrators? You use both. * theme_link() - Gah, you don't use theme('image') here. * Is it "Link" or "link"? Previously you have "Report this link", but then you have "Edit Link". * $cat->shown=99999999;. Right. Heh. * You seem to use the "Report this link as dead" thing a lot. That should be made a function. * # for comments? What is this, Perl? And so on. But I'm getting bored. -- Morbus Iff ( drowning in data, bereft of knowledge. ) Technical: _h_t_t_p_:_/_/_w_w_w_._o_r_e_i_l_l_y_n_e_t_._c_o_m_/_p_u_b_/_a_u_/_7_7_9 Culture: _h_t_t_p_:_/_/_w_w_w_._d_i_s_o_b_e_y_._c_o_m_/ and _h_t_t_p_:_/_/_w_w_w_._g_a_m_e_g_r_e_n_e_._c_o_m_/ icq: 2927491 / aim: akaMorbus / yahoo: morbus_iff / _j_a_b_b_e_r_._o_r_g: morbus ----- End forwarded message -----

4 3

Re: [development] .htaccess patch for 404 of Non-drupal files
by Peter Wolanin 03 Aug '06

03 Aug '06

In regard to this: > Khalid B wrote: > > It is worth including the change in this page http://drupal.org/node/56773 > > to the standard .htaccess we distribute? > > I think it's good change, but I'd suggest also adding the extentsion .htm

3 2

.htaccess patch for 404 of Non-drupal files
by Khalid B 03 Aug '06

03 Aug '06

It is worth including the change in this page http://drupal.org/node/56773 to the standard .htaccess we distribute? This has two advantages: a) Avoid a Drupal bootstrap for every 404 of these files. b) Send a smaller number of bytes when this happen. I believe the majority of sites would not want Drupal to handle 404 for these files. I can make the patch if it has a chance of getting through.

4 6

Re: [development] .htaccess patch for 404 of Non-drupal files
by Adam Cooper 03 Aug '06

03 Aug '06

>It is worth including the change in this page http://drupal.org/node/56773 >to the standard .htaccess we distribute? +1 to this. Though it might be worth adding more files to the list. i.e. '.ico' Thanks Adam ----------------------------------------------------------------- This message may contain confidential or privileged information, and is intended only for the addressee or other persons entitled to access the information. If you are not the intended or authorised recipient of this message please notify the sender by return and then delete it from your mailbox. Any dissemination, distribution, copying or use of this communication without prior permission is prohibited. Internet communications are not secure and may be susceptible to data corruption, interception and unauthorised amendment for which Pall Europe Limited does not accept liability. Whilst we have taken all reasonable precautions to ensure that this e-mail and any attachments have been swept for viruses, Pall Europe Limited does not accept liability for losses sustained as a result of software viruses. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Pall Europe Limited unless otherwise specifically stated. Registered Office and Corporate Headquarters: Pall Europe Limited, Europa House, Havant Street, Portsmouth, PO1 -----------------------------------------------------------------

1 0

Drupal Administration survey II -- looking volunteers to do interviews
by Kieran Lal 03 Aug '06

03 Aug '06

Hello, I would like launch a second Drupal Administration Survey this week. Here is the first one: http://www.surveymonkey.com/ DisplaySummary.asp?SID=1425065&U=142506581557 I am looking for some volunteers to help re-design the survey and make sure the questions will lead to effective responses. The survey should help the Drupal development community understand Drupal users and the goal and needs of Drupal administrators. I am asking the Drupal development community to help conduct 10 live interviews to help to refine the survey questions and language A couple of notes about the survey: 1) Surveys are useful but they are not authoritative. They are frequently more useful than any one person's opinion, but not quite absolute truth. 2) Drupal administration involves many activities that are not directly dependent on the Drupal code base, Drupal core features, or the Drupal Administration User Interface. For example, Drupal upgrade documentation, Drupal module categorization, Drupal contributed modules. The survey will run past the Drupal 4.8 code freeze and the results should stand independent of any particular development release or release cycle. 3) The survey will be sent to the major mailing lists, and posted on Drupal.org home page for 45 days (August 5th - September 20th). If you know some user experience professionals who might be able to assist in the design or analysis of the survey and the survey results please contact me. Cheers, Kieran CivicSpace

3 8

PostgreSQL support for 4.8 install system
by Sammy Spets 03 Aug '06

03 Aug '06

Hi everyone, I've added pgsql support in the install system. I've added a few bells and whistles too. Most notably we now have unsigned smallint, int and bigint added in! Those become smalluint, uint and biguint. Check out http://drupal.org/node/76681 for install.pgsql.inc and the patch needed for system.install. I'm in need of testers to ensure the install system operates properly. Cheers, -- Sammy Spets Synerger Pty Ltd http://www.synerger.com/

3 2

LinksDB vs. Links
by Khalid B 02 Aug '06

02 Aug '06

Seems to me like this recent project http://drupal.org/project/linksdb overlaps with this one (which has no 4.7 branch) http://drupal.org/node/24719 Is flibs reading this list?

18 46

views fusions, patch and node relations
by fago 02 Aug '06

02 Aug '06

hi everyone! I'm soc student and I'd love to get some feedback on my work. I'm working on nodeprofiles as soc project and as a generic byproduct I've written the module views_fusion. views_fusion allows one to melt multiple views into one. so you can build fusioned views that display information that is stored in multiple nodes. it uses node relations for joining the appropriate nodes together. So currently the views_fusion module needs the nodefamily module, which I've also built, for getting the node relation information. However in future other node relation modules could also provide their data for views fusion as it is written generic. Nodefamily is just another node relation module, which doesn't provide any interface for end users. It's possible to set custom nid-nid relations through the API or to set relations between content types through the admin interface. In the latter case the module will automatically create nid-nid relations for each nodes of these types that were created by the same author (yeah this is useful for user profiles.. ;) So views fusion uses the data of nodefamily to join the node tables appropriate. Unfortunately I needed to patch the views module to achieve this. Basically this patch creates a possibilty to define a prefix for the tables_aliases that views use in its query. The actual patch can be found at the bottom of this issue I created: http://drupal.org/node/75635 Actually I'd like to get some reviews for this patch, as I'd really like to see it integrated in views, so that views fusion works without patching views. More information about views fusion: http://more.zites.net/soc/views_fusion code: http://cvs.drupal.org/viewcvs/drupal/contributions/modules/nodeprofile/ Thanks.. fago

1 0

Code review for most downloaded modules
by Khalid B 02 Aug '06

02 Aug '06

John may have been half joking, but Morbus really did a good job reviewing the code for LinksDB. Here is an idea, it may not fly because it is "grunt work" and resource intensive, but how about we get a few people to do what Morbus did to the top 10 (or 50 or whatever) downloaded modules? This can be a step towards the top tier/certified/gold modules? On 8/2/06, John VanDyk <jvandyk(a)iastate.edu> wrote: > Wow, Morbus. Will you go through my modules, too, please? >

6 6

Re: [development] LinksDB vs. Links
by Greg Knaddison - GVS 02 Aug '06

02 Aug '06

On 8/2/06, John VanDyk <jvandyk(a)iastate.edu> wrote: > Wow, Morbus. Will you go through my modules, too, please? > I was trying to think what exact set of "buttons" to push to get Morbus to go through ALL of contrib! If we could do a cvs -d:pserver:anonymous:anonymous@cvs.drupal.org:/cvs/drupal-contrib | poke_morbus | awk -f morbus2issue.txt | curl http://drupal.org/node/add/project_issue/$project That would be nice. Greg -- Greg Knaddison | Growing Venture Solutions Denver, CO | http://growingventuresolutions.com Technology Solutions for Communities, Individuals, and Small Businesses

3 2