- Development - lists.drupal.org

[drupal-devel] [bug] unneeded " in query code
by nato 19 Jan '05

19 Jan '05

Project: Drupal Version: cvs Component: statistics.module Category: bug reports Priority: normal Assigned to: nato Reported by: nato Updated by: nato Status: patch Attachment: http://drupal.org/files/issues/statistics.diff (1.07 KB) unneeded " in query code nato -- View: http://drupal.org/node/15825 Edit: http://drupal.org/project/comments/add/15825

2 1

Re: [drupal-devel] Introduction and Questions
by Tim Altman 19 Jan '05

19 Jan '05

On Tue, 18 Jan 2005 20:03:14 -0000, Michael Jervis <mike(a)fuckingbrit.com> wrote: [...] > I have another task in mind, a proper geeklog migration script. I was > thinking a standalone PHP file, rather than a .module, as it would be a > use > once thing. Is there a standard way that has been used in the past for > migration scripts? Or are they all ad-hoc things? I'll probably need to > read > conf.php to get the prefix, which makes me think about slotting into > Drupal. > But I'm not yet familiar enough with the Drupal system to know if I > should/shouldn't etc. I've recently been working on a migration script for Blogger and have written one for MovableType in the past. You can find my current work in my sandbox. There's some information about migrating from Geeklog at http://drupal.org/node/1080, too. If at all possible, we should use the same framework for importation scripts, so it's easy to make a new importer plug-in. That's what I've been trying to do with the Blogger script. I still have to rewrite the MT importer to follow the same framework. I'm quite open to reworking the stuff I've done so far, as I've been making the framework as I've been writing the Blogger plug-in and I haven't done anything like this in the past. -- Tim Altman

1 0

RE: [drupal-devel] Introduction and Questions
by Michael Jervis 19 Jan '05

19 Jan '05

>This is tied to some long standing issues. Basically, need to both add >read/write support for multiple formats, preferably in a Is there something missing here? >Lack of libraries hasn't been the issue, but rather lack of bandwidth >to go through all the related items. Neil Drumm is probably the person >that's actually done the most on this so far (I just bitch and tell >other people how things should be architected, when I'm not >cheerleading). How far have things got with this? Is there code in HEAD working in the direction? Cheers, Mike

1 0

[drupal-devel] Re: ShortStat for Drupal
by K B 19 Jan '05

19 Jan '05

Since I have requested/suggested features relating to statistics before, let me pitch in and add my 2 cents' worth: 1. Drupal will never be able to provide some statistics, for example, bandwidth usage, HTTP response sizes, ..etc. since it does not have access to this feature. This level of detail is at the web server, and not the application (at least in Drupal's case). 2. Drupal can add some of the features in a fairly straightforward fashion, such as: a. Daily/weekly/monthly statistics (number of hits [really page views], which requires no database changes). If someone can suggest a more ANSI way of getting the stats, I can change the patch I did a while back on this. See http://drupal.org/node/15329 b. Web browser statistics (requires that the user agent be stored) c. Extracting search engine keywords can be done (each search engine has a special argument for the keywords, such as q= for google, ...etc. Webalizer configuration file lists them). d. Others. 3. Something like Short Stats is nice to have, for 'at-a-glance' view. However, I prefer the level of detail that specialized modules provide, such as Webalizer.

2 1

Re: [drupal-devel] Introduction and Questions
by Boris Mann 19 Jan '05

19 Jan '05

Welcome, Mike. On Tue, 18 Jan 2005 20:03:14 -0000, Michael Jervis <mike(a)fuckingbrit.com> wrote: > My next project on my personal hit list is to support blogger accounts. > Question: should this go in blogapi.module? I don't really think it > should, > but it did occur to me that perhaps it might. Nope, this is an authentication module. Should be called "bloggerauth" or something like that, I think. > Once I'm done themeing and migrating, I want to look at the aggregator > You can snag the libraries here: > http://www.fuckingbrit.com/downloads/syndication.tgz This is tied to some long standing issues. Basically, need to both add read/write support for multiple formats, preferably in a Lack of libraries hasn't been the issue, but rather lack of bandwidth to go through all the related items. Neil Drumm is probably the person that's actually done the most on this so far (I just bitch and tell other people how things should be architected, when I'm not cheerleading). -- Boris Mann http://www.bryght.com

1 0

[drupal-devel] rel=nofollow
by Todd Grimason 19 Jan '05

19 Jan '05

Haven't seen this mentioned anywhere here yet: http://www.google.com/googleblog/2005/01/preventing-comment-spam.html In short, adding an attribute to an anchor tag: rel="nofollow" will cause participating search engines to not follow/count the link (Google, MSN, and Yahoo! so far). So anywhere there's a link in user-submitted content you'd add this. -- ______________________________ toddgrimason*todd-AT-slack.net

3 2

[drupal-devel] [task] taxonomy: make node type a separatw table
by killes 19 Jan '05

19 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/taxo_4.diff (11.64 KB) Ok, another patch. Upgrade path is tested (We apparently cannot have two updates on the same day). I also removed a bug that would not show you node types if you assigned vocabs to a node type and later disabled the module. You will no longer lose this assignment when editing the vocabulary. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ April 1, 2004 - 00:33 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_0.diff (4.7 KB) I wanted to add caching by a static variable to taxonomy_get_vocabularies(). While I was doing this, I remembered a discussion about putting the node types in their own table and extended the patch to do this. A problem is that all selects on the vocabulary table will no longer contain the node types. Does anybody know of where this might cause problems? taxonomy_get_vocabularies() will also not return the node type if called without parameter. I solved the only problem I found that was caused by this. The patch is incomplete, it does not contain update information and database schemes. It also isn't tested. I'd like to get some feedback on the implementation. ------------------------------------------------------------------------ August 12, 2004 - 16:40 : killes(a)www.drop.org Doesn't apply anymore. ------------------------------------------------------------------------ January 18, 2005 - 21:50 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_1.diff (9.33 KB) I've updated the patch, but the upgrade path is still missing. Related issues: http://drupal.org/node/15690 http://drupal.org/node/6357 http://drupal.org/node/12542 ------------------------------------------------------------------------ January 18, 2005 - 22:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_2.diff (11.11 KB) Removed static caching, addedupgrade path. ------------------------------------------------------------------------ January 18, 2005 - 23:20 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_3.diff (11.09 KB) New version. Removes taxonomy_get_vocab_by_name. Wasn't used. ------------------------------------------------------------------------ January 18, 2005 - 23:23 : tangent Are you sure no modules use get_vocab_by_name? I know that the mailhandler module allows specifying a taxonomy by name instead of by id. ------------------------------------------------------------------------ January 18, 2005 - 23:29 : killes(a)www.drop.org Yes, I am sure. grep is my friend. To be honest: metatags module uses it, but that isn't really maintained. mailhandler lets users add taxo _terms_ by name not vocabs. ------------------------------------------------------------------------ January 18, 2005 - 23:36 : tangent That's true about the terms versus vocalulary. My bad. I guess I'm still getting used to the whole taxonomy system. -- View: http://drupal.org/node/6847 Edit: http://drupal.org/project/comments/add/6847

1 0

[drupal-devel] [task] taxonomy: make node type a separatw table
by tangent 18 Jan '05

18 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: tangent Status: patch That's true about the terms versus vocalulary. My bad. I guess I'm still getting used to the whole taxonomy system. tangent Previous comments: ------------------------------------------------------------------------ March 31, 2004 - 18:33 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_0.diff (4.7 KB) I wanted to add caching by a static variable to taxonomy_get_vocabularies(). While I was doing this, I remembered a discussion about putting the node types in their own table and extended the patch to do this. A problem is that all selects on the vocabulary table will no longer contain the node types. Does anybody know of where this might cause problems? taxonomy_get_vocabularies() will also not return the node type if called without parameter. I solved the only problem I found that was caused by this. The patch is incomplete, it does not contain update information and database schemes. It also isn't tested. I'd like to get some feedback on the implementation. ------------------------------------------------------------------------ August 12, 2004 - 10:40 : killes(a)www.drop.org Doesn't apply anymore. ------------------------------------------------------------------------ January 18, 2005 - 15:50 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_1.diff (9.33 KB) I've updated the patch, but the upgrade path is still missing. Related issues: http://drupal.org/node/15690 http://drupal.org/node/6357 http://drupal.org/node/12542 ------------------------------------------------------------------------ January 18, 2005 - 16:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_2.diff (11.11 KB) Removed static caching, addedupgrade path. ------------------------------------------------------------------------ January 18, 2005 - 17:20 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_3.diff (11.09 KB) New version. Removes taxonomy_get_vocab_by_name. Wasn't used. ------------------------------------------------------------------------ January 18, 2005 - 17:23 : tangent Are you sure no modules use get_vocab_by_name? I know that the mailhandler module allows specifying a taxonomy by name instead of by id. ------------------------------------------------------------------------ January 18, 2005 - 17:29 : killes(a)www.drop.org Yes, I am sure. grep is my friend. To be honest: metatags module uses it, but that isn't really maintained. mailhandler lets users add taxo _terms_ by name not vocabs. -- View: http://drupal.org/node/6847 Edit: http://drupal.org/project/comments/add/6847

1 0

[drupal-devel] [bug] form_hidden and form_submit generate invalid XML
by Steven 18 Jan '05

18 Jan '05

Project: Drupal Version: 4.5.2 Component: base system Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Kjartan Updated by: Steven Status: patch We typically use dashes to separate css id's and classes rather than underscores. Also, the usage of id's is invalid as has been said already. However, I feel that form_hidden and form_submit is not the place to modify this, as wrapping the buttons in a div means that every one of them occupies its own line (and no, setting the div to inline display is not a good work around). This is bad for forms with multiple buttons (like the node submission form). Instead, we should find a solution that still allows for multiple buttons, preferably wrapped inside only one div per button set. Steven Previous comments: ------------------------------------------------------------------------ September 2, 2003 - 11:58 : Kjartan form_submit() and form_hidden() don't wrap their output in a div or similar block element, this creates problems when trying to validate XHTML strict. Wrapping the return in a form_item(0, ....) seems to work fine. ------------------------------------------------------------------------ September 4, 2003 - 20:58 : ax i think it is consensus that form_* functions shouldn't be wrapped into form_item() [1,2]. your problem would be much better fixed by adding an inner <div> to the form() function, ie. function form($form, ...) { // ... return ' <form action=...> <div> $form </div> </form>'; } [1] Re: [drupal-devel] XHTML validity, part II | http://lists.drupal.org/archives/drupal-devel/2003-06/msg00172.html [1] ("PROBLEM 2: common.inc form_* functions") [2] Re: [drupal-devel] form_* functions | http://lists.drupal.org/archives/drupal-devel/2002-10/msg00676.html [2] [1] http://lists.drupal.org/archives/drupal-devel/2003-06/msg00172.html [2] http://lists.drupal.org/archives/drupal-devel/2002-10/msg00676.html ------------------------------------------------------------------------ January 18, 2005 - 18:08 : Zed Pobre Attachment: http://drupal.org/files/issues/common.diff (600 bytes) Attached is a patch to add encapsulation to the form_hidden and form_submit functions in common.inc. ------------------------------------------------------------------------ January 18, 2005 - 18:39 : tangent The previous attached file is not a good solution. The div ID must be unique so a class should be used instead. If you submit a patch, use the unified option. -- View: http://drupal.org/node/2714 Edit: http://drupal.org/project/comments/add/2714

1 0

[drupal-devel] [task] taxonomy: make node type a separatw table
by killes 18 Jan '05

18 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Yes, I am sure. grep is my friend. To be honest: metatags module uses it, but that isn't really maintained. mailhandler lets users add taxo _terms_ by name not vocabs. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ April 1, 2004 - 00:33 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_0.diff (4.7 KB) I wanted to add caching by a static variable to taxonomy_get_vocabularies(). While I was doing this, I remembered a discussion about putting the node types in their own table and extended the patch to do this. A problem is that all selects on the vocabulary table will no longer contain the node types. Does anybody know of where this might cause problems? taxonomy_get_vocabularies() will also not return the node type if called without parameter. I solved the only problem I found that was caused by this. The patch is incomplete, it does not contain update information and database schemes. It also isn't tested. I'd like to get some feedback on the implementation. ------------------------------------------------------------------------ August 12, 2004 - 16:40 : killes(a)www.drop.org Doesn't apply anymore. ------------------------------------------------------------------------ January 18, 2005 - 21:50 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_1.diff (9.33 KB) I've updated the patch, but the upgrade path is still missing. Related issues: http://drupal.org/node/15690 http://drupal.org/node/6357 http://drupal.org/node/12542 ------------------------------------------------------------------------ January 18, 2005 - 22:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_2.diff (11.11 KB) Removed static caching, addedupgrade path. ------------------------------------------------------------------------ January 18, 2005 - 23:20 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_3.diff (11.09 KB) New version. Removes taxonomy_get_vocab_by_name. Wasn't used. ------------------------------------------------------------------------ January 18, 2005 - 23:23 : tangent Are you sure no modules use get_vocab_by_name? I know that the mailhandler module allows specifying a taxonomy by name instead of by id. -- View: http://drupal.org/node/6847 Edit: http://drupal.org/project/comments/add/6847

1 0