- Development - lists.drupal.org

[drupal-devel] Release critical bugs for January 19, 2005
by drupal-devel＠drupal.org 19 Jan '05

19 Jan '05

Bbcode / bug reports email spam filtering does not "see" email addresses when they are NOT preceded by a word age: 3 days 23 hours url: http://drupal.org/node/15654 Chatbox / support requests Cron run kills Chat? age: 6 weeks 1 day url: http://drupal.org/node/14032 Drupal / bug reports updates.inc deleting profile_data when updating age: 3 days 7 hours url: http://drupal.org/node/15686 Change to sesssion.inc violates UID database constraint age: 3 days 17 hours url: http://drupal.org/node/15666 problem with forum.module with postgresql v7.4.1 age: 1 week 2 days url: http://drupal.org/node/15412 forum.module problem with postgresql v7.4.1 age: 1 week 2 days url: http://drupal.org/node/15411 postgresql error age: 1 week 6 days url: http://drupal.org/node/15175 UID 0, anonymous user account deleted age: 6 weeks 3 days url: http://drupal.org/node/13915 Styles broken after multisite patch assigned: TDobes age: 7 weeks 9 hours url: http://drupal.org/node/13738 Entering an empty title broke drupal age: 9 weeks 1 day url: http://drupal.org/node/12974 Argument NOT must be type boolean age: 9 weeks 2 days url: http://drupal.org/node/12950 Need to clear caches after running update.php age: 11 weeks 3 days url: http://drupal.org/node/12350 Private downloads aren't working age: 11 weeks 5 days url: http://drupal.org/node/12267 Comments in approval queue still show up in tracker age: 13 weeks 4 days url: http://drupal.org/node/11647 Drupal / feature requests Xtr3's Feature Requests age: 1 day 7 hours url: http://drupal.org/node/15768 User info exposed to anonymous user age: 7 weeks 4 days url: http://drupal.org/node/13545 Allow named anchors to work without specifying full path to node age: 1 year 8 weeks url: http://drupal.org/node/4213 Drupal / support requests Problem with Forums age: 1 week 4 days url: http://drupal.org/node/15299 /?q=admin/modules doesnt work for me! age: 8 weeks 4 days url: http://drupal.org/node/13193 Drupal / tasks atom.module working version to 4.5.0 assigned: hugoromano age: 11 weeks 3 hours url: http://drupal.org/node/12496 Postgres Compatibility Update assigned: adrian age: 17 weeks 2 days url: http://drupal.org/node/10945 file.inc code review assigned: Stefan age: 39 weeks 2 days url: http://drupal.org/node/7235 Drupal.org maintenance / bug reports Do not use "fixed" as default status for issues on drupal.org! age: 12 weeks 6 days url: http://drupal.org/node/11817 I can not add a release of Chinese Simplified Translation. age: 13 weeks 7 hours url: http://drupal.org/node/11770 Event / bug reports search over fields.inc fields conceptual error age: 11 weeks 5 days url: http://drupal.org/node/12259 fields.inc screws up with multible multiselect fields age: 11 weeks 5 days url: http://drupal.org/node/12257 Still GMT/TZ issues with CVS age: 12 weeks 5 days url: http://drupal.org/node/11870 Time entry is GMT even when site default is not age: 13 weeks 4 days url: http://drupal.org/node/11630 Start Time of Event is NOT Preserved age: 30 weeks 6 days url: http://drupal.org/node/8565 Feature / bug reports Menu item not showing age: 15 weeks 5 days url: http://drupal.org/node/11210 File / bug reports segmentation fault related to filestore age: 1 year 16 weeks url: http://drupal.org/node/3001 Filestore / support requests File store module - Overwriting Filename....Help needed assigned: harishkm age: 42 weeks 8 hours url: http://drupal.org/node/6827 Unserialize error at line 104 age: 48 weeks 5 days url: http://drupal.org/node/5857 Filestore module- sql errors rectified assigned: harishkm age: 50 weeks 13 hours url: http://drupal.org/node/5619 Problems in Filestore2 module assigned: harishkm age: 51 weeks 8 hours url: http://drupal.org/node/5458 Filestore Module Problems unaddressed assigned: harishkm age: 51 weeks 5 days url: http://drupal.org/node/5365 Groups / bug reports Drupal-4.4-rc breaks registration setups and groups.module age: 44 weeks 5 days url: http://drupal.org/node/6392 Image / bug reports Image.Module does not know the correct filename age: 9 weeks 1 day url: http://drupal.org/node/13032 SAFE MODE Restriction in effect... age: 12 weeks 6 days url: http://drupal.org/node/11843 Uploading jpeg makes Imagemagick do high compression age: 14 weeks 3 days url: http://drupal.org/node/11445 Image module failing on Preview because of a blank node id age: 16 weeks 4 days url: http://drupal.org/node/11069 Similar problem with Directory Upload Slow age: 16 weeks 4 days url: http://drupal.org/node/11064 Node Aggregator / bug reports Import doesn't like XML/RSS feeds with no Title element age: 33 weeks 4 days url: http://drupal.org/node/8128 Node Aggregator / feature requests RSS items overwriting edited items age: 31 weeks 4 days url: http://drupal.org/node/8455 Notify / feature requests Notify.module ignores the true submission queue age: 1 year 12 weeks url: http://drupal.org/node/3765 Pdfview / feature requests Internationalization support for PDF assigned: TheLibrarian age: 42 weeks 1 day url: http://drupal.org/node/6795 Project / bug reports "Page Not Found" when trying to view issues or add new release age: 6 weeks 5 days url: http://drupal.org/node/13815 Project pages display only title and description age: 8 weeks 6 days url: http://drupal.org/node/13082 Fatal error: Cannot use string offset as an array in includes/tablesort.inc on line 113 assigned: publian age: 15 weeks 6 days url: http://drupal.org/node/11187 Issued assigned to "unassigned" not being displayed. age: 18 weeks 3 days url: http://drupal.org/node/10744 Can't create new project with issue tracker age: 22 weeks 12 hours url: http://drupal.org/node/10148 Project / support requests Help with everything - nothing seems to work in the latest build age: 8 weeks 2 days url: http://drupal.org/node/13310 TrackBack / bug reports Overly aggressive age: 6 weeks 4 days url: http://drupal.org/node/13865 trackback borks google and every other search engine age: 11 weeks 2 days url: http://drupal.org/node/12388

1 0

[drupal-devel] cvs log messages
by no-reply＠zind.net 19 Jan '05

19 Jan '05

File: /modules/filter.module 1.50 Date: January 19, 2005 - 16:35 User: dries - Patch #15847 by James: added rel="nofollow" support. This is implemented as a filter so it can be enabled/disabled on a per-role basis (eg. some people might want to enable this for anonymous users but not for authenticated users). ---------------------------------------------------------------------- File: /CHANGELOG.txt 1.59 /database/database.mysql 1.166 /database/database.pgsql 1.102 /database/updates.inc 1.81 /modules/taxonomy.module 1.169 Date: January 19, 2005 - 16:22 User: dries - Patch #6847 by Gerhard: replaced vocabulary->nodes by a separate table and tidied up the taxonomy API a bit. This fixes a number of issues. ---------------------------------------------------------------------- File: /modules/wmfilter/wmfilter.sql 1.8 Date: January 19, 2005 - 15:23 User: ahynes1 ---------------------------------------------------------------------- File: /modules/statistics.module 1.182 Date: January 19, 2005 - 12:01 User: unconed - Bad quote ---------------------------------------------------------------------- File: /modules/captcha/captcha.module 1.8 /modules/captcha/README.txt 1.6 Date: January 19, 2005 - 10:25 User: arnabdotorg ---------------------------------------------------------------------- File: /modules/captcha/captcha.module 1.7 Date: January 19, 2005 - 05:31 User: arnabdotorg Fixed bug #15808 ---------------------------------------------------------------------- File: /modules/ecommerce/store/store.module 1.33 Date: January 19, 2005 - 02:49 User: mathias ---------------------------------------------------------------------- File: /modules/ecommerce/store/store.module 1.22.2.9 DRUPAL-4-5 Date: January 19, 2005 - 02:49 User: mathias ---------------------------------------------------------------------- File: /modules/ecommerce/store/store.module 1.32 Date: January 19, 2005 - 02:31 User: mathias * Only display the 'View your order history link' for owner of the transaction. ---------------------------------------------------------------------- File: /modules/ecommerce/store/store.module 1.22.2.8 DRUPAL-4-5 Date: January 19, 2005 - 02:31 User: mathias * Only display the 'View your order history link' for owner of the transaction. ---------------------------------------------------------------------- File: /modules/node.module 1.446 Date: January 19, 2005 - 01:51 User: unconed - Another code style fix. ---------------------------------------------------------------------- File: /modules/comment.module 1.327 /modules/forum.module 1.222 /modules/node.module 1.445 /modules/poll.module 1.154 /modules/statistics.module 1.181 /modules/taxonomy.module 1.168 /modules/tracker.module 1.108 Date: January 19, 2005 - 01:46 User: unconed - Fix tracker pager count query being wrong (it did not return a count but a set, and it counted nodes with more than 1 comment as multiple nodes). - Clean up various SQL queries: removing literally inserted data (db_escape_string is evil!), fixing single "%" which should be "%%", fixing integers being compared as strings. ---------------------------------------------------------------------- File: /translations/it/aggregator-module.po 1.9 Date: January 19, 2005 - 01:17 User: michelef Drupal 4.5.2 translation; ongoing. ---------------------------------------------------------------------- File: /modules/node.module 1.444 /modules/tracker.module 1.107 Date: January 19, 2005 - 01:12 User: unconed - #15500: Fix tracker not showing nodes without comments. - Tiny code style fix ---------------------------------------------------------------------- File: /modules/tracker.module 1.100.2.2 DRUPAL-4-5 Date: January 19, 2005 - 01:10 User: unconed #15500: Fix tracker not showing nodes without comments. ---------------------------------------------------------------------- File: /translations/it/locale-module.po 1.9 Date: January 19, 2005 - 01:00 User: michelef Drupal 4.5.2 translation; ongoing. ---------------------------------------------------------------------- File: /translations/it/node-module.po 1.7 Date: January 19, 2005 - 00:59 User: michelef Drupal 4.5.2 translation; ongoing. ---------------------------------------------------------------------- File: /translations/it/user-module.po 1.11 Date: January 19, 2005 - 00:58 User: michelef Drupal 4.5.2 translation; ongoing. ---------------------------------------------------------------------- File: /translations/it/watchdog-module.po 1.5 Date: January 19, 2005 - 00:53 User: michelef Drupal 4.5.2 translation; complete. ---------------------------------------------------------------------- File: /modules/copyright/copyright.module 1.6 Date: January 19, 2005 - 00:09 User: veridicus Replace check_query with db_escape_string ---------------------------------------------------------------------- File: /modules/copyright/copyright.css 1.2 /modules/copyright/copyright.module 1.5 Date: January 18, 2005 - 23:55 User: veridicus - Edit of node license only allowed by node author or "administer copyright" permission - Moved all display formatting into CSS - Made the CSS styling a little nicer - Load node license info at the point it's required to fix form problems ---------------------------------------------------------------------- File: /modules/autopath/autopath.module 1.1 /modules/autopath/README.txt 1.1 Date: January 18, 2005 - 23:54 User: mikeryan autopath module - automatically generates URL aliases from a node's title ---------------------------------------------------------------------- File: /modules/copyright/CHANGELOG.txt 1.2 Date: January 18, 2005 - 23:53 User: veridicus Listed changes ---------------------------------------------------------------------- File: /modules/copyright/README.txt 1.2 Date: January 18, 2005 - 23:53 User: veridicus Adjusted text and added my name ---------------------------------------------------------------------- File: /modules/contact_dir/README.txt 1.2 Date: January 18, 2005 - 22:21 User: latpro ---------------------------------------------------------------------- File: /modules/contact_dir/contact_dir.mysql.sql 1.1 Date: January 18, 2005 - 22:21 User: latpro ---------------------------------------------------------------------- File: /modules/contact_dir/contact_dir.module 1.1 /modules/contact_dir/fields.inc 1.1 /modules/contact_dir/README.txt 1.1 Date: January 18, 2005 - 21:56 User: latpro ---------------------------------------------------------------------- File: /modules/week/week.module 1.2 Date: January 18, 2005 - 21:55 User: prometheus6 Add that macro tag ---------------------------------------------------------------------- File: /modules/week/week.module 1.1 /modules/week/WEEK.txt 1.1 Date: January 18, 2005 - 21:50 User: prometheus6 Initial version ---------------------------------------------------------------------- File: /modules/taxonomy_block/taxonomy_block.module 1.1.2.3 DRUPAL-4-5 Date: January 18, 2005 - 19:54 User: crunchywelch update node view url syntax to 4.5 ---------------------------------------------------------------------- File: /modules/taxonomy_block/taxonomy_block.module 1.3 Date: January 18, 2005 - 19:49 User: crunchywelch update node view url syntax to 4.5 ---------------------------------------------------------------------- File: /modules/mail_archive/ma_gzip/ma_blogit.module NONE /modules/mail_archive/ma_gzip/README.txt 1.3 Date: January 18, 2005 - 17:19 User: jeremy cleanup CVS accident (restoring README, removing blogit) ---------------------------------------------------------------------- File: /modules/mail_archive/ma_blogit/ma_blogit.module 1.1 /modules/mail_archive/ma_blogit/README.txt 1.1 Date: January 18, 2005 - 17:17 User: jeremy initial commit (user error put this in wrong directory earlier) ----------------------------------------------------------------------

1 0

[drupal-devel] rewrite node queries
by Dries Buytaert 19 Jan '05

19 Jan '05

I just committed chx's node query rewrite patch. If your module queries the node table, you might want to look into issue #14731 (http://drupal.org/node/14731) and update your module accordingly. In short, you should no longer use node_access_join_sql() or node_access_where_sql() but wrap your query in a call to node_rewrite_sql(). I hope chx will update the upgrade-page in the module developers guide. -- Dries Buytaert :: http://www.buytaert.net/

6 8

[drupal-devel] [bug] QUICKFIX: Vocabulary node type checks are bogus
by Goba 19 Jan '05

19 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: bug reports Priority: normal Assigned to: Goba Reported by: Goba Updated by: Goba Status: patch Attachment: http://drupal.org/files/issues/Drupal-fix-vocab-node-types.patch (1.27 KB) The vocabulary node types checks in taxonomy.module are very vulnerable to having node types names as prefixes of other node type names %%%s%% as it is there with %%blog%% will match a lot more, then just this simple node type. I have a special blogmark type for example, which is found for %%blog%%. Since the node types are stored in a comma separated list, the solution is to search for 'blog' or '%%,blog,%%' or 'blog,%%' or '%%,blog', that is matching only for that node type, or matching that node type in a list, or at the beginning of a list, or at the end of a list. It does not look elegant, but this is the solution for the format used. This probably also applies to 4.5.0, the patch is against HEAD. Goba -- View: http://drupal.org/node/15690 Edit: http://drupal.org/project/comments/add/15690

1 2

Re: [drupal-devel] rel=nofollow
by Boris Mann 19 Jan '05

19 Jan '05

On Wed, 19 Jan 2005 17:45:08 +0100, Gerhard Killesreiter <killesreiter(a)physik.uni-freiburg.de> wrote: > If you or anybody else decides to do that, please do it in a way that > can > be bypassed. We once had such a feature and it was most annoying for use > with mailhandler or similar automatic posting. It's in core, it's a filter, and James Walker (yeah, he works with me) coded it. :P -- Boris Mann http://www.bryght.com

1 0

Re: [drupal-devel] rel=nofollow
by Boris Mann 19 Jan '05

19 Jan '05

On Tue, 18 Jan 2005 23:08:06 -0500, Andre Molnar <mcsparkerton(a)yahoo.co.uk> wrote: > Todd Grimason wrote: > > Haven't seen this mentioned anywhere here yet: > > http://www.google.com/googleblog/2005/01/preventing-comment-spam.html > > In short, adding an attribute to an anchor tag: > > rel="nofollow" > > will cause participating search engines to not follow/count the link > > (Google, MSN, and Yahoo! so far). > > So anywhere there's a link in user-submitted content you'd add this. > > Won't stop the spammers - but at least their efforts will be wasted. I'm not sure that there is much point to this...spam.module is MUCH more effective at making this not a problem. And what if you WANT user submitted content to count towards pagerank? Like, say, people in forums constantly pointing to the same RTFM post. Do spammers spam to raise page rank? Or do spammers spam so that other people see/click on their links? *grumble, grumble, grumble* -- Boris Mann http://www.bryght.com

7 6

[drupal-devel] [bug] form_weight should use dleta:15 in book outline admin
by Bèr Kessels 19 Jan '05

19 Jan '05

Project: Drupal Version: cvs Component: book.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Bèr Kessels Updated by: Bèr Kessels Status: patch Attachment: http://drupal.org/files/issues/book_form_weight_delta.patch (1.11 KB) This is a useability improvement *with code* ;) In book-pages node forms we use a delta of fifteen (-15 to +15) but in the book-outline admin we dont dewfine this, resulting in a default delta of ten. This should be consistent and thus both 15. Bèr Kessels -- View: http://drupal.org/node/15843 Edit: http://drupal.org/project/comments/add/15843

1 0

[drupal-devel] settings
by Negyesi Karoly 19 Jan '05

19 Jan '05

Hi, Settings are scattered everywhere. This is extermely confusing the light of the Settings menu item. I'd expect to find every settings under settings. Why Is content settings is reachable under node / settings but not under settings / node ? What's more I'd expect both subtabs (settings, default workflow) from admin/node/configure Same with users, the page admin/user/configure should be also accessible as settings/user. Regards NK

3 6

Re: [drupal-devel] rel=nofollow
by Boris Mann 19 Jan '05

19 Jan '05

On Wed, 19 Jan 2005 10:54:12 +0000, Gabor Hojtsy <gabor(a)hojtsy.hu> wrote: > >> I'm not sure that there is much point to this...spam.module is MUCH > >> more effective at making this not a problem. And what if you WANT user > >> submitted content to count towards pagerank? Like, say, people in > >> forums constantly pointing to the same RTFM post. > > i see a much point. maintaining spam.module is much harder than just > > rewriting some links. the idea is not to rewrite internal links (such > > as your forum example), but rather to rewrite external links. > > For external pages, it is just the same, you might just be happy with > increasing some page's pagerank. On some forums, users tend to suggest > others going to http://www.catb.org/~esr/faqs/smart-questions.html or > the native language translation of that before asking more questions :) > Now it would clearly be positive, if these type of pages pagerank would > raise :) EXACTLY! This is a very big hammer to be raising. I'm not sure what the effects will be (I don't think anyone can, even Google, until it actually starts to effect changes). I *am* interested to flip ahead to the end of this story. May be the single biggest change in Google PR/Internet traffic in history. Chris: in your spam example on SpreadFirefox, wouldn't Jeremy's spam module have unpublished all that content/comments? On my (obviously much smaller) site, I have a big spam problem...so I just turn on comment moderation for anonymous users. Spammers don't get links, but they still spam. Why do people think it will stop because of this? (I'm honestly puzzled by this). In any case...if someone wants to implement, great -- please, just not in core, or allow it to be turned off. -- Boris Mann http://www.bryght.com

2 1

[drupal-devel] [bug] "Add new comment" no longer shows up in $links?
by Junyor 19 Jan '05

19 Jan '05

Project: Drupal Version: 4.5.1 Component: poll.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Morbus Iff Updated by: Junyor -Status: active +Status: patch Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes) The change to theme_node was done as part of http://drupal.org/node/9287. Other than theme_node, poll_view is the only function that calls link_node directly. Attached is a patch to fix the function call in poll_view to send the correct parameters. Junyor Previous comments: ------------------------------------------------------------------------ December 30, 2004 - 15:41 : Morbus Iff I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll block no longer displays the "add new comment" or "# comments" link. This is (was) important to me, as I usually ask for comments whenever someone chooses the negative option. Any idea where and why this went? You can still get to the comment form in a roundabout way ("other polls", choose your poll, whammo), but that's far too many clicks and intellect points. ------------------------------------------------------------------------ January 18, 2005 - 16:50 : rooey I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2 :( There is *some* info on comment issues here: http://drupal.org/node/11366 I didn't find any of them solved this particular issue tho. ------------------------------------------------------------------------ January 18, 2005 - 18:28 : Junyor So, not even the "add new comment" link is showing up? I just loaded the poll module and that shows fine. However, the current comment count doesn't show correctly in the block. This is what I've seen so far: 1) poll_block calls poll_view 2) poll_view calls poll_view_voting, which outputs the poll choices 3) for blocks, poll_view calls link_node, which calls hook_link('node') in each module. For all other poll displays, the theme does the call to link_node (via node_view) I'm guessing poll_view is where the problem is. I'll keep looking at it. ------------------------------------------------------------------------ January 18, 2005 - 18:41 : Junyor Changing the call to link_node on line 438 in poll.module (in poll_view) to: ------------------------------------------------------------------------ January 18, 2005 - 18:51 : Junyor Trying again with correct PHP tags. :) Changing the call to link_node on line 438 in poll.module (in poll_view) to: seems to solve the problem. I'm trying to look now at the history of link_node to see why that fixed it. That's the same parameters that the call in theme_node uses. -- View: http://drupal.org/node/14936 Edit: http://drupal.org/project/comments/add/14936

5 6