- Development - lists.drupal.org

[drupal-devel] [task] taxonomy: make node type a separatw table
by tangent 18 Jan '05

18 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: tangent Status: patch Are you sure no modules use get_vocab_by_name? I know that the mailhandler module allows specifying a taxonomy by name instead of by id. tangent Previous comments: ------------------------------------------------------------------------ March 31, 2004 - 18:33 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_0.diff (4.7 KB) I wanted to add caching by a static variable to taxonomy_get_vocabularies(). While I was doing this, I remembered a discussion about putting the node types in their own table and extended the patch to do this. A problem is that all selects on the vocabulary table will no longer contain the node types. Does anybody know of where this might cause problems? taxonomy_get_vocabularies() will also not return the node type if called without parameter. I solved the only problem I found that was caused by this. The patch is incomplete, it does not contain update information and database schemes. It also isn't tested. I'd like to get some feedback on the implementation. ------------------------------------------------------------------------ August 12, 2004 - 10:40 : killes(a)www.drop.org Doesn't apply anymore. ------------------------------------------------------------------------ January 18, 2005 - 15:50 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_1.diff (9.33 KB) I've updated the patch, but the upgrade path is still missing. Related issues: http://drupal.org/node/15690 http://drupal.org/node/6357 http://drupal.org/node/12542 ------------------------------------------------------------------------ January 18, 2005 - 16:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_2.diff (11.11 KB) Removed static caching, addedupgrade path. ------------------------------------------------------------------------ January 18, 2005 - 17:20 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_3.diff (11.09 KB) New version. Removes taxonomy_get_vocab_by_name. Wasn't used. -- View: http://drupal.org/node/6847 Edit: http://drupal.org/project/comments/add/6847

1 0

[drupal-devel] [task] taxonomy: make node type a separatw table
by killes 18 Jan '05

18 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org Status: patch Attachment: http://drupal.org/files/issues/taxo_3.diff (11.09 KB) New version. Removes taxonomy_get_vocab_by_name. Wasn't used. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ April 1, 2004 - 00:33 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_0.diff (4.7 KB) I wanted to add caching by a static variable to taxonomy_get_vocabularies(). While I was doing this, I remembered a discussion about putting the node types in their own table and extended the patch to do this. A problem is that all selects on the vocabulary table will no longer contain the node types. Does anybody know of where this might cause problems? taxonomy_get_vocabularies() will also not return the node type if called without parameter. I solved the only problem I found that was caused by this. The patch is incomplete, it does not contain update information and database schemes. It also isn't tested. I'd like to get some feedback on the implementation. ------------------------------------------------------------------------ August 12, 2004 - 16:40 : killes(a)www.drop.org Doesn't apply anymore. ------------------------------------------------------------------------ January 18, 2005 - 21:50 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_1.diff (9.33 KB) I've updated the patch, but the upgrade path is still missing. Related issues: http://drupal.org/node/15690 http://drupal.org/node/6357 http://drupal.org/node/12542 ------------------------------------------------------------------------ January 18, 2005 - 22:48 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_2.diff (11.11 KB) Removed static caching, addedupgrade path. -- View: http://drupal.org/node/6847 Edit: http://drupal.org/project/comments/add/6847

1 0

[drupal-devel] [task] taxonomy: make node type a separatw table
by killes 18 Jan '05

18 Jan '05

Project: Drupal Version: cvs Component: taxonomy.module Category: tasks Priority: normal Assigned to: killes(a)www.drop.org Reported by: killes(a)www.drop.org Updated by: killes(a)www.drop.org -Status: active +Status: patch Attachment: http://drupal.org/files/issues/taxo_2.diff (11.11 KB) Removed static caching, addedupgrade path. killes(a)www.drop.org Previous comments: ------------------------------------------------------------------------ April 1, 2004 - 00:33 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_0.diff (4.7 KB) I wanted to add caching by a static variable to taxonomy_get_vocabularies(). While I was doing this, I remembered a discussion about putting the node types in their own table and extended the patch to do this. A problem is that all selects on the vocabulary table will no longer contain the node types. Does anybody know of where this might cause problems? taxonomy_get_vocabularies() will also not return the node type if called without parameter. I solved the only problem I found that was caused by this. The patch is incomplete, it does not contain update information and database schemes. It also isn't tested. I'd like to get some feedback on the implementation. ------------------------------------------------------------------------ August 12, 2004 - 16:40 : killes(a)www.drop.org Doesn't apply anymore. ------------------------------------------------------------------------ January 18, 2005 - 21:50 : killes(a)www.drop.org Attachment: http://drupal.org/files/issues/taxo_1.diff (9.33 KB) I've updated the patch, but the upgrade path is still missing. Related issues: http://drupal.org/node/15690 http://drupal.org/node/6357 http://drupal.org/node/12542 -- View: http://drupal.org/node/6847 Edit: http://drupal.org/project/comments/add/6847

1 0

[drupal-devel] Introduction and Questions
by Michael Jervis 18 Jan '05

18 Jan '05

Hi, I'm new to Drupal. I've been using Geeklog for some time now to run my site, having migrated from PHPNuke. I've had enough of geeklog and am moving on to Drupal for various reasons. I've written plugins for PHPNuke and Geeklog in the past. My geeklog stuff can be found here: http://sourceforge.net/projects/fbglplugins Couple of minor modules, and a fork of the (unmaintained) Journal plugin. I'm a professional web developer, whatever that means these days, but I work in COM/ASP sites since my company doesn't like to train us up to .NET so I hack PHP to keep my geek needs satisfied ;-) As well as writing various windows GUI software and developing the techie side of www.snakenet.com. Anyway, more relevantly, as I'm migrating my site to Drupal, there will be fixes/changes/enhancements I need to run how I like, so I will be contributing in various forms to Drupal. My first effort is a livejournal.module so that Drupal can be up-to-date with it's documents (http://drupal.org/node/15469) providing LiveJournal based authentication. I've read the contributors guide, which states I should "and then notify the contributions manager to request a review of your work before posting". I can't see anything that tells me how to go about this, so I am assuming the method is to post to the list? Should I check into contributions before review to have it somewhere to be reviewed, or post it in some other form somewhere? Or does "before posting" mean before filling in the form to list under modules? I have attached the module in a RAR, I hope this won't cause too much offence, it is less than 1kb. My next project on my personal hit list is to support blogger accounts. Question: should this go in blogapi.module? I don't really think it should, but it did occur to me that perhaps it might. Following that I'll be trying to get my theme working. I have a question here too ;-) If I set the background-image style for my logo to a php file in my theme folder, will the php file execute? I intend to auto-rotate my logo based on date. I'd like to keep the presentation (i.e location of the image) in the style.css, but, I'm not sure if Drupal's path handling stuff will allow that to work. Experimentation is an option, but right now I'm in the middle of other stuff... And, there's more... I have another task in mind, a proper geeklog migration script. I was thinking a standalone PHP file, rather than a .module, as it would be a use once thing. Is there a standard way that has been used in the past for migration scripts? Or are they all ad-hoc things? I'll probably need to read conf.php to get the prefix, which makes me think about slotting into Drupal. But I'm not yet familiar enough with the Drupal system to know if I should/shouldn't etc. Once I'm done themeing and migrating, I want to look at the aggregator and it's support for multiple formats. Plus perhaps Drupal's feed writing support. I have already written a set of OO code using a factory pattern to produce readers and writers for the RSS 0.9x, RDF 1.0, RSS 2.0 and Atom 0.3 formats. These are under the ZLIB license as I wrote them with two ideas, one being to revamp the geeklog system (a tracker issue on their project site) and one being a commercial solution I was working on. I think these could be easily used within aggregator.module to provide seamless reading of any source. They possibly need a tweak to work with Drupal's feed writing (they always write to file, never giving the option to return a feed as a string at the moment). You can snag the libraries here: http://www.fuckingbrit.com/downloads/syndication.tgz I'd be interested in any feedback as to whether or not it's worth me pursuing that line of thought. Geeklog's maintainers are currently ignoring my patch in favour of working on their pet projects... Anyway, Looking forward to any answers from any brave soul who read this far ;-) Mike

1 0

[drupal-devel] Bug#281593: Still problems with BBC?
by Hilko Bengen 18 Jan '05

18 Jan '05

Graeme, could you please try whether you have the same problems with the current version (4.5.2) of Drupal? -Hilko

1 0

[drupal-devel] [bug] "Add new comment" no longer shows up in $links?
by Junyor 18 Jan '05

18 Jan '05

Project: Drupal Version: 4.5.1 Component: poll.module Category: bug reports Priority: normal Assigned to: Junyor Reported by: Morbus Iff Updated by: Junyor Status: patch @moshe: I don't think a patch for HEAD to fix this bug will be needed, as the erroneous function call was removed. Has anyone tested the poll module on HEAD to see if this problem exists there? Junyor Previous comments: ------------------------------------------------------------------------ December 30, 2004 - 15:41 : Morbus Iff I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll block no longer displays the "add new comment" or "# comments" link. This is (was) important to me, as I usually ask for comments whenever someone chooses the negative option. Any idea where and why this went? You can still get to the comment form in a roundabout way ("other polls", choose your poll, whammo), but that's far too many clicks and intellect points. ------------------------------------------------------------------------ January 18, 2005 - 16:50 : rooey I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2 :( There is *some* info on comment issues here: http://drupal.org/node/11366 I didn't find any of them solved this particular issue tho. ------------------------------------------------------------------------ January 18, 2005 - 18:28 : Junyor So, not even the "add new comment" link is showing up? I just loaded the poll module and that shows fine. However, the current comment count doesn't show correctly in the block. This is what I've seen so far: 1) poll_block calls poll_view 2) poll_view calls poll_view_voting, which outputs the poll choices 3) for blocks, poll_view calls link_node, which calls hook_link('node') in each module. For all other poll displays, the theme does the call to link_node (via node_view) I'm guessing poll_view is where the problem is. I'll keep looking at it. ------------------------------------------------------------------------ January 18, 2005 - 18:41 : Junyor Changing the call to link_node on line 438 in poll.module (in poll_view) to: ------------------------------------------------------------------------ January 18, 2005 - 18:51 : Junyor Trying again with correct PHP tags. :) Changing the call to link_node on line 438 in poll.module (in poll_view) to: seems to solve the problem. I'm trying to look now at the history of link_node to see why that fixed it. That's the same parameters that the call in theme_node uses. ------------------------------------------------------------------------ January 18, 2005 - 18:58 : Junyor Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes) The change to theme_node was done as part of http://drupal.org/node/9287. Other than theme_node, poll_view is the only function that calls link_node directly. Attached is a patch to fix the function call in poll_view to send the correct parameters. ------------------------------------------------------------------------ January 18, 2005 - 19:21 : Morbus Iff Confirmed Junyor's patch. Excellent (note: take my confirmation with a grain of salt. One of my previous patches caused a grievous bug for 4.5.2 tracker.module, and I should not be trusted anymore <g>). ------------------------------------------------------------------------ January 18, 2005 - 19:22 : Morbus Iff (His patch is currently in use at gamegrene.com, running 4.5.1). ------------------------------------------------------------------------ January 18, 2005 - 19:23 : Jeremy(a)kerneltrap.org Seems to work like a charm -- thanks. :) ------------------------------------------------------------------------ January 18, 2005 - 19:35 : moshe weitzman please submit a patch for HEAD as well (if needed). link_node() no longer exists so this patch is no help for HEAD ------------------------------------------------------------------------ January 18, 2005 - 19:36 : Junyor Note: The attached patch is a good solution for 4.5.2. For HEAD, all hook_link functions need to have their parameter list updated to make sure they're using $teaser and not $main. Same goes for node_link. Additionally, we should think about adding a theme function to handle hook_block links (if one doesn't already exist). -- View: http://drupal.org/node/14936 Edit: http://drupal.org/project/comments/add/14936

1 0

[drupal-devel] [bug] "Add new comment" no longer shows up in $links?
by Junyor 18 Jan '05

18 Jan '05

Project: Drupal -Version: 4.5.1 +Version: 4.5.2 Component: poll.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Morbus Iff Updated by: Junyor Status: patch Note: The attached patch is a good solution for 4.5.2. For HEAD, all hook_link functions need to have their parameter list updated to make sure they're using $teaser and not $main. Same goes for node_link. Additionally, we should think about adding a theme function to handle hook_block links (if one doesn't already exist). Junyor Previous comments: ------------------------------------------------------------------------ December 30, 2004 - 15:41 : Morbus Iff I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll block no longer displays the "add new comment" or "# comments" link. This is (was) important to me, as I usually ask for comments whenever someone chooses the negative option. Any idea where and why this went? You can still get to the comment form in a roundabout way ("other polls", choose your poll, whammo), but that's far too many clicks and intellect points. ------------------------------------------------------------------------ January 18, 2005 - 16:50 : rooey I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2 :( There is *some* info on comment issues here: http://drupal.org/node/11366 I didn't find any of them solved this particular issue tho. ------------------------------------------------------------------------ January 18, 2005 - 18:28 : Junyor So, not even the "add new comment" link is showing up? I just loaded the poll module and that shows fine. However, the current comment count doesn't show correctly in the block. This is what I've seen so far: 1) poll_block calls poll_view 2) poll_view calls poll_view_voting, which outputs the poll choices 3) for blocks, poll_view calls link_node, which calls hook_link('node') in each module. For all other poll displays, the theme does the call to link_node (via node_view) I'm guessing poll_view is where the problem is. I'll keep looking at it. ------------------------------------------------------------------------ January 18, 2005 - 18:41 : Junyor Changing the call to link_node on line 438 in poll.module (in poll_view) to: ------------------------------------------------------------------------ January 18, 2005 - 18:51 : Junyor Trying again with correct PHP tags. :) Changing the call to link_node on line 438 in poll.module (in poll_view) to: seems to solve the problem. I'm trying to look now at the history of link_node to see why that fixed it. That's the same parameters that the call in theme_node uses. ------------------------------------------------------------------------ January 18, 2005 - 18:58 : Junyor Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes) The change to theme_node was done as part of http://drupal.org/node/9287. Other than theme_node, poll_view is the only function that calls link_node directly. Attached is a patch to fix the function call in poll_view to send the correct parameters. ------------------------------------------------------------------------ January 18, 2005 - 19:21 : Morbus Iff Confirmed Junyor's patch. Excellent (note: take my confirmation with a grain of salt. One of my previous patches caused a grievous bug for 4.5.2 tracker.module, and I should not be trusted anymore <g>). ------------------------------------------------------------------------ January 18, 2005 - 19:22 : Morbus Iff (His patch is currently in use at gamegrene.com, running 4.5.1). ------------------------------------------------------------------------ January 18, 2005 - 19:23 : Jeremy(a)kerneltrap.org Seems to work like a charm -- thanks. :) ------------------------------------------------------------------------ January 18, 2005 - 19:35 : moshe weitzman please submit a patch for HEAD as well (if needed). link_node() no longer exists so this patch is no help for HEAD -- View: http://drupal.org/node/14936 Edit: http://drupal.org/project/comments/add/14936

1 0

[drupal-devel] [bug] "Add new comment" no longer shows up in $links?
by moshe weitzman 18 Jan '05

18 Jan '05

Project: Drupal Version: 4.5.1 Component: poll.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Morbus Iff Updated by: moshe weitzman Status: patch please submit a patch for HEAD as well (if needed). link_node() no longer exists so this patch is no help for HEAD moshe weitzman Previous comments: ------------------------------------------------------------------------ December 30, 2004 - 09:41 : Morbus Iff I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll block no longer displays the "add new comment" or "# comments" link. This is (was) important to me, as I usually ask for comments whenever someone chooses the negative option. Any idea where and why this went? You can still get to the comment form in a roundabout way ("other polls", choose your poll, whammo), but that's far too many clicks and intellect points. ------------------------------------------------------------------------ January 18, 2005 - 10:50 : rooey I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2 :( There is *some* info on comment issues here: http://drupal.org/node/11366 I didn't find any of them solved this particular issue tho. ------------------------------------------------------------------------ January 18, 2005 - 12:28 : Junyor So, not even the "add new comment" link is showing up? I just loaded the poll module and that shows fine. However, the current comment count doesn't show correctly in the block. This is what I've seen so far: 1) poll_block calls poll_view 2) poll_view calls poll_view_voting, which outputs the poll choices 3) for blocks, poll_view calls link_node, which calls hook_link('node') in each module. For all other poll displays, the theme does the call to link_node (via node_view) I'm guessing poll_view is where the problem is. I'll keep looking at it. ------------------------------------------------------------------------ January 18, 2005 - 12:41 : Junyor Changing the call to link_node on line 438 in poll.module (in poll_view) to: ------------------------------------------------------------------------ January 18, 2005 - 12:51 : Junyor Trying again with correct PHP tags. :) Changing the call to link_node on line 438 in poll.module (in poll_view) to: seems to solve the problem. I'm trying to look now at the history of link_node to see why that fixed it. That's the same parameters that the call in theme_node uses. ------------------------------------------------------------------------ January 18, 2005 - 12:58 : Junyor Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes) The change to theme_node was done as part of http://drupal.org/node/9287. Other than theme_node, poll_view is the only function that calls link_node directly. Attached is a patch to fix the function call in poll_view to send the correct parameters. ------------------------------------------------------------------------ January 18, 2005 - 13:21 : Morbus Iff Confirmed Junyor's patch. Excellent (note: take my confirmation with a grain of salt. One of my previous patches caused a grievous bug for 4.5.2 tracker.module, and I should not be trusted anymore <g>). ------------------------------------------------------------------------ January 18, 2005 - 13:22 : Morbus Iff (His patch is currently in use at gamegrene.com, running 4.5.1). ------------------------------------------------------------------------ January 18, 2005 - 13:23 : Jeremy(a)kerneltrap.org Seems to work like a charm -- thanks. :) -- View: http://drupal.org/node/14936 Edit: http://drupal.org/project/comments/add/14936

1 0

[drupal-devel] [bug] "Add new comment" no longer shows up in $links?
by Jeremy 18 Jan '05

18 Jan '05

Project: Drupal Version: 4.5.1 Component: poll.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Morbus Iff Updated by: Jeremy(a)kerneltrap.org Status: patch Seems to work like a charm -- thanks. :) Jeremy(a)kerneltrap.org Previous comments: ------------------------------------------------------------------------ December 30, 2004 - 09:41 : Morbus Iff I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll block no longer displays the "add new comment" or "# comments" link. This is (was) important to me, as I usually ask for comments whenever someone chooses the negative option. Any idea where and why this went? You can still get to the comment form in a roundabout way ("other polls", choose your poll, whammo), but that's far too many clicks and intellect points. ------------------------------------------------------------------------ January 18, 2005 - 10:50 : rooey I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2 :( There is *some* info on comment issues here: http://drupal.org/node/11366 I didn't find any of them solved this particular issue tho. ------------------------------------------------------------------------ January 18, 2005 - 12:28 : Junyor So, not even the "add new comment" link is showing up? I just loaded the poll module and that shows fine. However, the current comment count doesn't show correctly in the block. This is what I've seen so far: 1) poll_block calls poll_view 2) poll_view calls poll_view_voting, which outputs the poll choices 3) for blocks, poll_view calls link_node, which calls hook_link('node') in each module. For all other poll displays, the theme does the call to link_node (via node_view) I'm guessing poll_view is where the problem is. I'll keep looking at it. ------------------------------------------------------------------------ January 18, 2005 - 12:41 : Junyor Changing the call to link_node on line 438 in poll.module (in poll_view) to: ------------------------------------------------------------------------ January 18, 2005 - 12:51 : Junyor Trying again with correct PHP tags. :) Changing the call to link_node on line 438 in poll.module (in poll_view) to: seems to solve the problem. I'm trying to look now at the history of link_node to see why that fixed it. That's the same parameters that the call in theme_node uses. ------------------------------------------------------------------------ January 18, 2005 - 12:58 : Junyor Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes) The change to theme_node was done as part of http://drupal.org/node/9287. Other than theme_node, poll_view is the only function that calls link_node directly. Attached is a patch to fix the function call in poll_view to send the correct parameters. ------------------------------------------------------------------------ January 18, 2005 - 13:21 : Morbus Iff Confirmed Junyor's patch. Excellent (note: take my confirmation with a grain of salt. One of my previous patches caused a grievous bug for 4.5.2 tracker.module, and I should not be trusted anymore <g>). ------------------------------------------------------------------------ January 18, 2005 - 13:22 : Morbus Iff (His patch is currently in use at gamegrene.com, running 4.5.1). -- View: http://drupal.org/node/14936 Edit: http://drupal.org/project/comments/add/14936

1 0

[drupal-devel] [bug] "Add new comment" no longer shows up in $links?
by Morbus Iff 18 Jan '05

18 Jan '05

Project: Drupal Version: 4.5.1 Component: poll.module Category: bug reports Priority: normal Assigned to: Anonymous Reported by: Morbus Iff Updated by: Morbus Iff Status: patch (His patch is currently in use at gamegrene.com, running 4.5.1). Morbus Iff Previous comments: ------------------------------------------------------------------------ December 30, 2004 - 09:41 : Morbus Iff I recently upgraded from 4.4.2 to 4.5.1, and have noticed that the poll block no longer displays the "add new comment" or "# comments" link. This is (was) important to me, as I usually ask for comments whenever someone chooses the negative option. Any idea where and why this went? You can still get to the comment form in a roundabout way ("other polls", choose your poll, whammo), but that's far too many clicks and intellect points. ------------------------------------------------------------------------ January 18, 2005 - 10:50 : rooey I had the same problem going from 4.4 to 4.5 - i still see it in 4.5.2 :( There is *some* info on comment issues here: http://drupal.org/node/11366 I didn't find any of them solved this particular issue tho. ------------------------------------------------------------------------ January 18, 2005 - 12:28 : Junyor So, not even the "add new comment" link is showing up? I just loaded the poll module and that shows fine. However, the current comment count doesn't show correctly in the block. This is what I've seen so far: 1) poll_block calls poll_view 2) poll_view calls poll_view_voting, which outputs the poll choices 3) for blocks, poll_view calls link_node, which calls hook_link('node') in each module. For all other poll displays, the theme does the call to link_node (via node_view) I'm guessing poll_view is where the problem is. I'll keep looking at it. ------------------------------------------------------------------------ January 18, 2005 - 12:41 : Junyor Changing the call to link_node on line 438 in poll.module (in poll_view) to: ------------------------------------------------------------------------ January 18, 2005 - 12:51 : Junyor Trying again with correct PHP tags. :) Changing the call to link_node on line 438 in poll.module (in poll_view) to: seems to solve the problem. I'm trying to look now at the history of link_node to see why that fixed it. That's the same parameters that the call in theme_node uses. ------------------------------------------------------------------------ January 18, 2005 - 12:58 : Junyor Attachment: http://drupal.org/files/issues/junyor.poll.patch (762 bytes) The change to theme_node was done as part of http://drupal.org/node/9287. Other than theme_node, poll_view is the only function that calls link_node directly. Attached is a patch to fix the function call in poll_view to send the correct parameters. ------------------------------------------------------------------------ January 18, 2005 - 13:21 : Morbus Iff Confirmed Junyor's patch. Excellent (note: take my confirmation with a grain of salt. One of my previous patches caused a grievous bug for 4.5.2 tracker.module, and I should not be trusted anymore <g>). -- View: http://drupal.org/node/14936 Edit: http://drupal.org/project/comments/add/14936

1 0